target/rx: Track PSW.U in tb->flags

[PATCH 0/4] target/rx: Track PSW.U in tb->flags

Posted by Richard Henderson 2 years ago

This is a follow up to Kawada-san's patch for the problem
of a missed update to the stack pointer in CLRPSW/SETPSW.
This fixes the problem without movcond by tracking the
current state of PSW.U within the TB.


r~


Richard Henderson (4):
  target/rx: Put tb_flags into DisasContext
  target/rx: Store PSW.U in tb->flags
  target/rx: Move DISAS_UPDATE check for write to PSW
  target/rx: Swap stack pointers on clrpsw/setpsw instruction

 target/rx/cpu.h       |  1 +
 target/rx/translate.c | 67 +++++++++++++++++++++++--------------------
 2 files changed, 37 insertions(+), 31 deletions(-)

-- 
2.25.1

Re: [PATCH 0/4] target/rx: Track PSW.U in tb->flags

Posted by Yoshinori Sato 2 years ago

On Mon, 18 Apr 2022 01:51:26 +0900,
Richard Henderson wrote:
> 
> This is a follow up to Kawada-san's patch for the problem
> of a missed update to the stack pointer in CLRPSW/SETPSW.
> This fixes the problem without movcond by tracking the
> current state of PSW.U within the TB.
> 
> 
> r~
> 
> 
> Richard Henderson (4):
>   target/rx: Put tb_flags into DisasContext
>   target/rx: Store PSW.U in tb->flags
>   target/rx: Move DISAS_UPDATE check for write to PSW
>   target/rx: Swap stack pointers on clrpsw/setpsw instruction
> 
>  target/rx/cpu.h       |  1 +
>  target/rx/translate.c | 67 +++++++++++++++++++++++--------------------
>  2 files changed, 37 insertions(+), 31 deletions(-)
> 
> -- 
> 2.25.1
> 

Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp>

-- 
Yosinori Sato

Re: [PATCH 0/4] target/rx: Track PSW.U in tb->flags

Posted by Richard Henderson 2 years ago

On 4/19/22 00:40, Yoshinori Sato wrote:
> On Mon, 18 Apr 2022 01:51:26 +0900,
> Richard Henderson wrote:
>>
>> This is a follow up to Kawada-san's patch for the problem
>> of a missed update to the stack pointer in CLRPSW/SETPSW.
>> This fixes the problem without movcond by tracking the
>> current state of PSW.U within the TB.
>>
>>
>> r~
>>
>>
>> Richard Henderson (4):
>>    target/rx: Put tb_flags into DisasContext
>>    target/rx: Store PSW.U in tb->flags
>>    target/rx: Move DISAS_UPDATE check for write to PSW
>>    target/rx: Swap stack pointers on clrpsw/setpsw instruction
>>
>>   target/rx/cpu.h       |  1 +
>>   target/rx/translate.c | 67 +++++++++++++++++++++++--------------------
>>   2 files changed, 37 insertions(+), 31 deletions(-)
>>
>> -- 
>> 2.25.1
>>
> 
> Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp>
> 

Queued to target-rx-next.

r~