[PATCH v4 0/4] dump: add 32-bit guest Windows support

Viktor Prutyanov posted 4 patches 2 years ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220406171558.199263-1-viktor.prutyanov@redhat.com
Maintainers: Viktor Prutyanov <viktor.prutyanov@phystech.edu>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>
contrib/elf2dmp/main.c       |   6 +-
dump/win_dump.c              | 299 ++++++++++++++++++++++-------------
hmp-commands.hx              |   2 +-
include/qemu/win_dump_defs.h | 115 +++++++++++++-
4 files changed, 306 insertions(+), 116 deletions(-)
[PATCH v4 0/4] dump: add 32-bit guest Windows support
Posted by Viktor Prutyanov 2 years ago
From: Viktor Prutyanov <viktor@daynix.com>

Since 32-bit versions of Windows still exist, there is a need to take
live and crash dumps of such guests along with 64-bit guests. So, add
an ability for 'dump-guest-memory -w' to take dumps from 32-bit guest.
When running the command QEMU consumes 32-bit Complete Memory Dump
header passed by guest driver through vmcoreinfo device as it was
previously done for 64-bit headers. 32-bit vmcoreinfo guest driver in
upstream virtio-win can fill such a header.

Changes in v4:
    - dump-guest-memory command help message is updated
Changes in v3:
    - some WIN_DUMP_* macros are replaced by similar functions where it
      is possible
Changes in v2:
    - no change in logic, just split patches
    - first introduce WIN_DUMP_* macros for x64 in a separate patch
    - rename WinContext to WinContext64 in a separate patch

Viktor Prutyanov (4):
  include/qemu: rename Windows context definitions to expose bitness
  dump/win_dump: add helper macros for Windows dump header access
  include/qemu: add 32-bit Windows dump structures
  dump/win_dump: add 32-bit guest Windows support

 contrib/elf2dmp/main.c       |   6 +-
 dump/win_dump.c              | 299 ++++++++++++++++++++++-------------
 hmp-commands.hx              |   2 +-
 include/qemu/win_dump_defs.h | 115 +++++++++++++-
 4 files changed, 306 insertions(+), 116 deletions(-)

-- 
2.35.1
Re: [PATCH v4 0/4] dump: add 32-bit guest Windows support
Posted by Viktor Prutyanov 2 years ago
ping

On Wed,  6 Apr 2022 20:15:54 +0300
Viktor Prutyanov <viktor.prutyanov@redhat.com> wrote:

> From: Viktor Prutyanov <viktor@daynix.com>
> 
> Since 32-bit versions of Windows still exist, there is a need to take
> live and crash dumps of such guests along with 64-bit guests. So, add
> an ability for 'dump-guest-memory -w' to take dumps from 32-bit guest.
> When running the command QEMU consumes 32-bit Complete Memory Dump
> header passed by guest driver through vmcoreinfo device as it was
> previously done for 64-bit headers. 32-bit vmcoreinfo guest driver in
> upstream virtio-win can fill such a header.
> 
> Changes in v4:
>     - dump-guest-memory command help message is updated
> Changes in v3:
>     - some WIN_DUMP_* macros are replaced by similar functions where
> it is possible
> Changes in v2:
>     - no change in logic, just split patches
>     - first introduce WIN_DUMP_* macros for x64 in a separate patch
>     - rename WinContext to WinContext64 in a separate patch
> 
> Viktor Prutyanov (4):
>   include/qemu: rename Windows context definitions to expose bitness
>   dump/win_dump: add helper macros for Windows dump header access
>   include/qemu: add 32-bit Windows dump structures
>   dump/win_dump: add 32-bit guest Windows support
> 
>  contrib/elf2dmp/main.c       |   6 +-
>  dump/win_dump.c              | 299
> ++++++++++++++++++++++------------- hmp-commands.hx              |
> 2 +- include/qemu/win_dump_defs.h | 115 +++++++++++++-
>  4 files changed, 306 insertions(+), 116 deletions(-)
> 

-- 
Sincerely,
Viktor Prutyanov