[v2] COLO net and runstate bugfix/optimization

[PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition support form COLO to PRELAUNCH

Posted by Zhang Chen 3 years, 10 months ago

If the checkpoint occurs when the guest finishes restarting
but has not started running, the runstate_set() may reject
the transition from COLO to PRELAUNCH with the crash log:

{"timestamp": {"seconds": 1593484591, "microseconds": 26605},\
"event": "RESET", "data": {"guest": true, "reason": "guest-reset"}}
qemu-system-x86_64: invalid runstate transition: 'colo' -> 'prelaunch'

Long-term testing says that it's pretty safe.

Signed-off-by: Like Xu <like.xu@linux.intel.com>
Signed-off-by: Zhang Chen <chen.zhang@intel.com>
---
 softmmu/runstate.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/softmmu/runstate.c b/softmmu/runstate.c
index e0d869b21a..c021c56338 100644
--- a/softmmu/runstate.c
+++ b/softmmu/runstate.c
@@ -127,6 +127,7 @@ static const RunStateTransition runstate_transitions_def[] = {
     { RUN_STATE_RESTORE_VM, RUN_STATE_PRELAUNCH },
 
     { RUN_STATE_COLO, RUN_STATE_RUNNING },
+    { RUN_STATE_COLO, RUN_STATE_PRELAUNCH },
     { RUN_STATE_COLO, RUN_STATE_SHUTDOWN},
 
     { RUN_STATE_RUNNING, RUN_STATE_DEBUG },
-- 
2.25.1

Re: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition support form COLO to PRELAUNCH

Posted by Jason Wang 3 years, 9 months ago

On Fri, Apr 1, 2022 at 11:59 AM Zhang Chen <chen.zhang@intel.com> wrote:
>
> If the checkpoint occurs when the guest finishes restarting
> but has not started running, the runstate_set() may reject
> the transition from COLO to PRELAUNCH with the crash log:
>
> {"timestamp": {"seconds": 1593484591, "microseconds": 26605},\
> "event": "RESET", "data": {"guest": true, "reason": "guest-reset"}}
> qemu-system-x86_64: invalid runstate transition: 'colo' -> 'prelaunch'
>
> Long-term testing says that it's pretty safe.
>
> Signed-off-by: Like Xu <like.xu@linux.intel.com>
> Signed-off-by: Zhang Chen <chen.zhang@intel.com>

I'd expect this to get ack from the relevant maintainers.

Thanks

> ---
>  softmmu/runstate.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/softmmu/runstate.c b/softmmu/runstate.c
> index e0d869b21a..c021c56338 100644
> --- a/softmmu/runstate.c
> +++ b/softmmu/runstate.c
> @@ -127,6 +127,7 @@ static const RunStateTransition runstate_transitions_def[] = {
>      { RUN_STATE_RESTORE_VM, RUN_STATE_PRELAUNCH },
>
>      { RUN_STATE_COLO, RUN_STATE_RUNNING },
> +    { RUN_STATE_COLO, RUN_STATE_PRELAUNCH },
>      { RUN_STATE_COLO, RUN_STATE_SHUTDOWN},
>
>      { RUN_STATE_RUNNING, RUN_STATE_DEBUG },
> --
> 2.25.1
>

RE: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition support form COLO to PRELAUNCH

Posted by Zhang, Chen 3 years, 9 months ago


> -----Original Message-----
> From: Jason Wang <jasowang@redhat.com>
> Sent: Wednesday, April 27, 2022 4:57 PM
> To: Zhang, Chen <chen.zhang@intel.com>
> Cc: Li Zhijian <lizhijian@cn.fujitsu.com>; qemu-dev <qemu-
> devel@nongnu.org>; Like Xu <like.xu@linux.intel.com>
> Subject: Re: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition
> support form COLO to PRELAUNCH
> 
> On Fri, Apr 1, 2022 at 11:59 AM Zhang Chen <chen.zhang@intel.com> wrote:
> >
> > If the checkpoint occurs when the guest finishes restarting but has
> > not started running, the runstate_set() may reject the transition from
> > COLO to PRELAUNCH with the crash log:
> >
> > {"timestamp": {"seconds": 1593484591, "microseconds": 26605},\
> > "event": "RESET", "data": {"guest": true, "reason": "guest-reset"}}
> > qemu-system-x86_64: invalid runstate transition: 'colo' -> 'prelaunch'
> >
> > Long-term testing says that it's pretty safe.
> >
> > Signed-off-by: Like Xu <like.xu@linux.intel.com>
> > Signed-off-by: Zhang Chen <chen.zhang@intel.com>
> 
> I'd expect this to get ack from the relevant maintainers.
> 

The scripts/get_maintainer.pl can't find relevant maintainers for this patch.
Maybe Paolo have time to cover this simple patch related to runstate? 

Thanks
Chen

> Thanks
> 
> > ---
> >  softmmu/runstate.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/softmmu/runstate.c b/softmmu/runstate.c index
> > e0d869b21a..c021c56338 100644
> > --- a/softmmu/runstate.c
> > +++ b/softmmu/runstate.c
> > @@ -127,6 +127,7 @@ static const RunStateTransition
> runstate_transitions_def[] = {
> >      { RUN_STATE_RESTORE_VM, RUN_STATE_PRELAUNCH },
> >
> >      { RUN_STATE_COLO, RUN_STATE_RUNNING },
> > +    { RUN_STATE_COLO, RUN_STATE_PRELAUNCH },
> >      { RUN_STATE_COLO, RUN_STATE_SHUTDOWN},
> >
> >      { RUN_STATE_RUNNING, RUN_STATE_DEBUG },
> > --
> > 2.25.1
> >

RE: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition support form COLO to PRELAUNCH

Posted by Zhang, Chen 3 years, 9 months ago


> -----Original Message-----
> From: Zhang, Chen
> Sent: Wednesday, April 27, 2022 5:26 PM
> To: Jason Wang <jasowang@redhat.com>; Paolo Bonzini
> <pbonzini@redhat.com>
> Cc: Li Zhijian <lizhijian@cn.fujitsu.com>; qemu-dev <qemu-
> devel@nongnu.org>; Like Xu <like.xu@linux.intel.com>
> Subject: RE: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition
> support form COLO to PRELAUNCH
> 
> 
> 
> > -----Original Message-----
> > From: Jason Wang <jasowang@redhat.com>
> > Sent: Wednesday, April 27, 2022 4:57 PM
> > To: Zhang, Chen <chen.zhang@intel.com>
> > Cc: Li Zhijian <lizhijian@cn.fujitsu.com>; qemu-dev <qemu-
> > devel@nongnu.org>; Like Xu <like.xu@linux.intel.com>
> > Subject: Re: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition
> > support form COLO to PRELAUNCH
> >
> > On Fri, Apr 1, 2022 at 11:59 AM Zhang Chen <chen.zhang@intel.com> wrote:
> > >
> > > If the checkpoint occurs when the guest finishes restarting but has
> > > not started running, the runstate_set() may reject the transition
> > > from COLO to PRELAUNCH with the crash log:
> > >
> > > {"timestamp": {"seconds": 1593484591, "microseconds": 26605},\
> > > "event": "RESET", "data": {"guest": true, "reason": "guest-reset"}}
> > > qemu-system-x86_64: invalid runstate transition: 'colo' -> 'prelaunch'
> > >
> > > Long-term testing says that it's pretty safe.
> > >
> > > Signed-off-by: Like Xu <like.xu@linux.intel.com>
> > > Signed-off-by: Zhang Chen <chen.zhang@intel.com>
> >
> > I'd expect this to get ack from the relevant maintainers.
> >
> 
> The scripts/get_maintainer.pl can't find relevant maintainers for this patch.
> Maybe Paolo have time to cover this simple patch related to runstate?

No news for a while, any comments for unmaintained files changes ?
Ping...

Thanks
Chen

> 
> Thanks
> Chen
> 
> > Thanks
> >
> > > ---
> > >  softmmu/runstate.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/softmmu/runstate.c b/softmmu/runstate.c index
> > > e0d869b21a..c021c56338 100644
> > > --- a/softmmu/runstate.c
> > > +++ b/softmmu/runstate.c
> > > @@ -127,6 +127,7 @@ static const RunStateTransition
> > runstate_transitions_def[] = {
> > >      { RUN_STATE_RESTORE_VM, RUN_STATE_PRELAUNCH },
> > >
> > >      { RUN_STATE_COLO, RUN_STATE_RUNNING },
> > > +    { RUN_STATE_COLO, RUN_STATE_PRELAUNCH },
> > >      { RUN_STATE_COLO, RUN_STATE_SHUTDOWN},
> > >
> > >      { RUN_STATE_RUNNING, RUN_STATE_DEBUG },
> > > --
> > > 2.25.1
> > >

Re: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition support form COLO to PRELAUNCH

Posted by Jason Wang 3 years, 9 months ago

On Sat, May 7, 2022 at 10:03 AM Zhang, Chen <chen.zhang@intel.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Zhang, Chen
> > Sent: Wednesday, April 27, 2022 5:26 PM
> > To: Jason Wang <jasowang@redhat.com>; Paolo Bonzini
> > <pbonzini@redhat.com>
> > Cc: Li Zhijian <lizhijian@cn.fujitsu.com>; qemu-dev <qemu-
> > devel@nongnu.org>; Like Xu <like.xu@linux.intel.com>
> > Subject: RE: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition
> > support form COLO to PRELAUNCH
> >
> >
> >
> > > -----Original Message-----
> > > From: Jason Wang <jasowang@redhat.com>
> > > Sent: Wednesday, April 27, 2022 4:57 PM
> > > To: Zhang, Chen <chen.zhang@intel.com>
> > > Cc: Li Zhijian <lizhijian@cn.fujitsu.com>; qemu-dev <qemu-
> > > devel@nongnu.org>; Like Xu <like.xu@linux.intel.com>
> > > Subject: Re: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition
> > > support form COLO to PRELAUNCH
> > >
> > > On Fri, Apr 1, 2022 at 11:59 AM Zhang Chen <chen.zhang@intel.com> wrote:
> > > >
> > > > If the checkpoint occurs when the guest finishes restarting but has
> > > > not started running, the runstate_set() may reject the transition
> > > > from COLO to PRELAUNCH with the crash log:
> > > >
> > > > {"timestamp": {"seconds": 1593484591, "microseconds": 26605},\
> > > > "event": "RESET", "data": {"guest": true, "reason": "guest-reset"}}
> > > > qemu-system-x86_64: invalid runstate transition: 'colo' -> 'prelaunch'
> > > >
> > > > Long-term testing says that it's pretty safe.
> > > >
> > > > Signed-off-by: Like Xu <like.xu@linux.intel.com>
> > > > Signed-off-by: Zhang Chen <chen.zhang@intel.com>
> > >
> > > I'd expect this to get ack from the relevant maintainers.
> > >
> >
> > The scripts/get_maintainer.pl can't find relevant maintainers for this patch.
> > Maybe Paolo have time to cover this simple patch related to runstate?
>
> No news for a while, any comments for unmaintained files changes ?
> Ping...

Adding David and Juan.

Thanks

>
> Thanks
> Chen
>
> >
> > Thanks
> > Chen
> >
> > > Thanks
> > >
> > > > ---
> > > >  softmmu/runstate.c | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/softmmu/runstate.c b/softmmu/runstate.c index
> > > > e0d869b21a..c021c56338 100644
> > > > --- a/softmmu/runstate.c
> > > > +++ b/softmmu/runstate.c
> > > > @@ -127,6 +127,7 @@ static const RunStateTransition
> > > runstate_transitions_def[] = {
> > > >      { RUN_STATE_RESTORE_VM, RUN_STATE_PRELAUNCH },
> > > >
> > > >      { RUN_STATE_COLO, RUN_STATE_RUNNING },
> > > > +    { RUN_STATE_COLO, RUN_STATE_PRELAUNCH },
> > > >      { RUN_STATE_COLO, RUN_STATE_SHUTDOWN},
> > > >
> > > >      { RUN_STATE_RUNNING, RUN_STATE_DEBUG },
> > > > --
> > > > 2.25.1
> > > >
>

Re: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition support form COLO to PRELAUNCH

Posted by Dr. David Alan Gilbert 3 years, 8 months ago

* Jason Wang (jasowang@redhat.com) wrote:
> On Sat, May 7, 2022 at 10:03 AM Zhang, Chen <chen.zhang@intel.com> wrote:
> >
> >
> >
> > > -----Original Message-----
> > > From: Zhang, Chen
> > > Sent: Wednesday, April 27, 2022 5:26 PM
> > > To: Jason Wang <jasowang@redhat.com>; Paolo Bonzini
> > > <pbonzini@redhat.com>
> > > Cc: Li Zhijian <lizhijian@cn.fujitsu.com>; qemu-dev <qemu-
> > > devel@nongnu.org>; Like Xu <like.xu@linux.intel.com>
> > > Subject: RE: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition
> > > support form COLO to PRELAUNCH
> > >
> > >
> > >
> > > > -----Original Message-----
> > > > From: Jason Wang <jasowang@redhat.com>
> > > > Sent: Wednesday, April 27, 2022 4:57 PM
> > > > To: Zhang, Chen <chen.zhang@intel.com>
> > > > Cc: Li Zhijian <lizhijian@cn.fujitsu.com>; qemu-dev <qemu-
> > > > devel@nongnu.org>; Like Xu <like.xu@linux.intel.com>
> > > > Subject: Re: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition
> > > > support form COLO to PRELAUNCH
> > > >
> > > > On Fri, Apr 1, 2022 at 11:59 AM Zhang Chen <chen.zhang@intel.com> wrote:
> > > > >
> > > > > If the checkpoint occurs when the guest finishes restarting but has
> > > > > not started running, the runstate_set() may reject the transition
> > > > > from COLO to PRELAUNCH with the crash log:
> > > > >
> > > > > {"timestamp": {"seconds": 1593484591, "microseconds": 26605},\
> > > > > "event": "RESET", "data": {"guest": true, "reason": "guest-reset"}}
> > > > > qemu-system-x86_64: invalid runstate transition: 'colo' -> 'prelaunch'
> > > > >
> > > > > Long-term testing says that it's pretty safe.
> > > > >
> > > > > Signed-off-by: Like Xu <like.xu@linux.intel.com>
> > > > > Signed-off-by: Zhang Chen <chen.zhang@intel.com>
> > > >
> > > > I'd expect this to get ack from the relevant maintainers.
> > > >
> > >
> > > The scripts/get_maintainer.pl can't find relevant maintainers for this patch.
> > > Maybe Paolo have time to cover this simple patch related to runstate?
> >
> > No news for a while, any comments for unmaintained files changes ?
> > Ping...
> 
> Adding David and Juan.

This looks OK to me;

Acked-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

it should be fine to merge it along with the pull that takes the other
patches.

Dave

> Thanks
> 
> >
> > Thanks
> > Chen
> >
> > >
> > > Thanks
> > > Chen
> > >
> > > > Thanks
> > > >
> > > > > ---
> > > > >  softmmu/runstate.c | 1 +
> > > > >  1 file changed, 1 insertion(+)
> > > > >
> > > > > diff --git a/softmmu/runstate.c b/softmmu/runstate.c index
> > > > > e0d869b21a..c021c56338 100644
> > > > > --- a/softmmu/runstate.c
> > > > > +++ b/softmmu/runstate.c
> > > > > @@ -127,6 +127,7 @@ static const RunStateTransition
> > > > runstate_transitions_def[] = {
> > > > >      { RUN_STATE_RESTORE_VM, RUN_STATE_PRELAUNCH },
> > > > >
> > > > >      { RUN_STATE_COLO, RUN_STATE_RUNNING },
> > > > > +    { RUN_STATE_COLO, RUN_STATE_PRELAUNCH },
> > > > >      { RUN_STATE_COLO, RUN_STATE_SHUTDOWN},
> > > > >
> > > > >      { RUN_STATE_RUNNING, RUN_STATE_DEBUG },
> > > > > --
> > > > > 2.25.1
> > > > >
> >
> 
-- 
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK

Re: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition support form COLO to PRELAUNCH

Posted by Jason Wang 3 years, 8 months ago

On Wed, May 18, 2022 at 9:09 PM Dr. David Alan Gilbert
<dgilbert@redhat.com> wrote:
>
> * Jason Wang (jasowang@redhat.com) wrote:
> > On Sat, May 7, 2022 at 10:03 AM Zhang, Chen <chen.zhang@intel.com> wrote:
> > >
> > >
> > >
> > > > -----Original Message-----
> > > > From: Zhang, Chen
> > > > Sent: Wednesday, April 27, 2022 5:26 PM
> > > > To: Jason Wang <jasowang@redhat.com>; Paolo Bonzini
> > > > <pbonzini@redhat.com>
> > > > Cc: Li Zhijian <lizhijian@cn.fujitsu.com>; qemu-dev <qemu-
> > > > devel@nongnu.org>; Like Xu <like.xu@linux.intel.com>
> > > > Subject: RE: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition
> > > > support form COLO to PRELAUNCH
> > > >
> > > >
> > > >
> > > > > -----Original Message-----
> > > > > From: Jason Wang <jasowang@redhat.com>
> > > > > Sent: Wednesday, April 27, 2022 4:57 PM
> > > > > To: Zhang, Chen <chen.zhang@intel.com>
> > > > > Cc: Li Zhijian <lizhijian@cn.fujitsu.com>; qemu-dev <qemu-
> > > > > devel@nongnu.org>; Like Xu <like.xu@linux.intel.com>
> > > > > Subject: Re: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition
> > > > > support form COLO to PRELAUNCH
> > > > >
> > > > > On Fri, Apr 1, 2022 at 11:59 AM Zhang Chen <chen.zhang@intel.com> wrote:
> > > > > >
> > > > > > If the checkpoint occurs when the guest finishes restarting but has
> > > > > > not started running, the runstate_set() may reject the transition
> > > > > > from COLO to PRELAUNCH with the crash log:
> > > > > >
> > > > > > {"timestamp": {"seconds": 1593484591, "microseconds": 26605},\
> > > > > > "event": "RESET", "data": {"guest": true, "reason": "guest-reset"}}
> > > > > > qemu-system-x86_64: invalid runstate transition: 'colo' -> 'prelaunch'
> > > > > >
> > > > > > Long-term testing says that it's pretty safe.
> > > > > >
> > > > > > Signed-off-by: Like Xu <like.xu@linux.intel.com>
> > > > > > Signed-off-by: Zhang Chen <chen.zhang@intel.com>
> > > > >
> > > > > I'd expect this to get ack from the relevant maintainers.
> > > > >
> > > >
> > > > The scripts/get_maintainer.pl can't find relevant maintainers for this patch.
> > > > Maybe Paolo have time to cover this simple patch related to runstate?
> > >
> > > No news for a while, any comments for unmaintained files changes ?
> > > Ping...
> >
> > Adding David and Juan.
>
> This looks OK to me;
>
> Acked-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

Great.

>
> it should be fine to merge it along with the pull that takes the other
> patches.

Yes, I've queued this series.

Thanks

>
> Dave
>
> > Thanks
> >
> > >
> > > Thanks
> > > Chen
> > >
> > > >
> > > > Thanks
> > > > Chen
> > > >
> > > > > Thanks
> > > > >
> > > > > > ---
> > > > > >  softmmu/runstate.c | 1 +
> > > > > >  1 file changed, 1 insertion(+)
> > > > > >
> > > > > > diff --git a/softmmu/runstate.c b/softmmu/runstate.c index
> > > > > > e0d869b21a..c021c56338 100644
> > > > > > --- a/softmmu/runstate.c
> > > > > > +++ b/softmmu/runstate.c
> > > > > > @@ -127,6 +127,7 @@ static const RunStateTransition
> > > > > runstate_transitions_def[] = {
> > > > > >      { RUN_STATE_RESTORE_VM, RUN_STATE_PRELAUNCH },
> > > > > >
> > > > > >      { RUN_STATE_COLO, RUN_STATE_RUNNING },
> > > > > > +    { RUN_STATE_COLO, RUN_STATE_PRELAUNCH },
> > > > > >      { RUN_STATE_COLO, RUN_STATE_SHUTDOWN},
> > > > > >
> > > > > >      { RUN_STATE_RUNNING, RUN_STATE_DEBUG },
> > > > > > --
> > > > > > 2.25.1
> > > > > >
> > >
> >
> --
> Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
>

RE: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition support form COLO to PRELAUNCH

Posted by Zhang, Chen 3 years, 7 months ago

> > > > > > On Fri, Apr 1, 2022 at 11:59 AM Zhang Chen <chen.zhang@intel.com>
> wrote:
> > > > > > >
> > > > > > > If the checkpoint occurs when the guest finishes restarting
> > > > > > > but has not started running, the runstate_set() may reject
> > > > > > > the transition from COLO to PRELAUNCH with the crash log:
> > > > > > >
> > > > > > > {"timestamp": {"seconds": 1593484591, "microseconds":
> > > > > > > 26605},\
> > > > > > > "event": "RESET", "data": {"guest": true, "reason":
> > > > > > > "guest-reset"}}
> > > > > > > qemu-system-x86_64: invalid runstate transition: 'colo' ->
> 'prelaunch'
> > > > > > >
> > > > > > > Long-term testing says that it's pretty safe.
> > > > > > >
> > > > > > > Signed-off-by: Like Xu <like.xu@linux.intel.com>
> > > > > > > Signed-off-by: Zhang Chen <chen.zhang@intel.com>
> > > > > >
> > > > > > I'd expect this to get ack from the relevant maintainers.
> > > > > >
> > > > >
> > > > > The scripts/get_maintainer.pl can't find relevant maintainers for this
> patch.
> > > > > Maybe Paolo have time to cover this simple patch related to runstate?
> > > >
> > > > No news for a while, any comments for unmaintained files changes ?
> > > > Ping...
> > >
> > > Adding David and Juan.
> >
> > This looks OK to me;
> >
> > Acked-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> 
> Great.
> 
> >
> > it should be fine to merge it along with the pull that takes the other
> > patches.
> 
> Yes, I've queued this series.

Hi Jason,  did this series get lost in the net queue branch?

Thanks
Chen

> 
> Thanks
> 
> >
> > Dave
> >
> > > Thanks
> > >
> > > >
> >

Re: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition support form COLO to PRELAUNCH

Posted by Jason Wang 3 years, 7 months ago

On Wed, Jul 6, 2022 at 1:02 PM Zhang, Chen <chen.zhang@intel.com> wrote:
>
> > > > > > > On Fri, Apr 1, 2022 at 11:59 AM Zhang Chen <chen.zhang@intel.com>
> > wrote:
> > > > > > > >
> > > > > > > > If the checkpoint occurs when the guest finishes restarting
> > > > > > > > but has not started running, the runstate_set() may reject
> > > > > > > > the transition from COLO to PRELAUNCH with the crash log:
> > > > > > > >
> > > > > > > > {"timestamp": {"seconds": 1593484591, "microseconds":
> > > > > > > > 26605},\
> > > > > > > > "event": "RESET", "data": {"guest": true, "reason":
> > > > > > > > "guest-reset"}}
> > > > > > > > qemu-system-x86_64: invalid runstate transition: 'colo' ->
> > 'prelaunch'
> > > > > > > >
> > > > > > > > Long-term testing says that it's pretty safe.
> > > > > > > >
> > > > > > > > Signed-off-by: Like Xu <like.xu@linux.intel.com>
> > > > > > > > Signed-off-by: Zhang Chen <chen.zhang@intel.com>
> > > > > > >
> > > > > > > I'd expect this to get ack from the relevant maintainers.
> > > > > > >
> > > > > >
> > > > > > The scripts/get_maintainer.pl can't find relevant maintainers for this
> > patch.
> > > > > > Maybe Paolo have time to cover this simple patch related to runstate?
> > > > >
> > > > > No news for a while, any comments for unmaintained files changes ?
> > > > > Ping...
> > > >
> > > > Adding David and Juan.
> > >
> > > This looks OK to me;
> > >
> > > Acked-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> >
> > Great.
> >
> > >
> > > it should be fine to merge it along with the pull that takes the other
> > > patches.
> >
> > Yes, I've queued this series.
>
> Hi Jason,  did this series get lost in the net queue branch?

Unfortunately, yes.

It will be included in the net pull request.

Sorry.

>
> Thanks
> Chen
>
> >
> > Thanks
> >
> > >
> > > Dave
> > >
> > > > Thanks
> > > >
> > > > >
> > >
>