[v5] Transactional block-graph modifying API

[PATCH v5 05/45] tests-bdrv-drain: bdrv_replace_test driver: declare supports_backing

Vladimir Sementsov-Ogievskiy posted 45 patches 3 years, 8 months ago

Diff against v4
Download mbox

Maintainers: Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>, Ari Sundholm <ari@tuxera.com>, Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>, Paolo Bonzini <pbonzini@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, John Snow <jsnow@redhat.com>, Vladimir Sementsov-Ogievskiy <v.sementsov-og@mail.ru>, "Denis V. Lunev" <den@openvz.org>, Wen Congyang <wencongyang2@huawei.com>, Xie Changlong <xiechanglong.d@gmail.com>, Stefan Weil <sw@weilnetz.de>, Jeff Cody <codyprime@gmail.com>, Fam Zheng <fam@euphon.net>, Markus Armbruster <armbru@redhat.com>, Eric Blake <eblake@redhat.com>

Expand all Fold all

[PATCH v5 05/45] tests-bdrv-drain: bdrv_replace_test driver: declare supports_backing

Posted by Vladimir Sementsov-Ogievskiy 3 years, 8 months ago

We do add COW child to the node.  In future we are going to forbid
adding COW child to the node that doesn't support backing. So, fix it
here now.

Don't worry about setting bs->backing itself: it further commit we'll
update the block-layer to automatically set/unset this field in generic
code.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@openvz.org>
---
 tests/unit/test-bdrv-drain.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/unit/test-bdrv-drain.c b/tests/unit/test-bdrv-drain.c
index 36be84ae55..23d425a494 100644
--- a/tests/unit/test-bdrv-drain.c
+++ b/tests/unit/test-bdrv-drain.c
@@ -1948,6 +1948,7 @@ static void coroutine_fn bdrv_replace_test_co_drain_end(BlockDriverState *bs)
 static BlockDriver bdrv_replace_test = {
     .format_name            = "replace_test",
     .instance_size          = sizeof(BDRVReplaceTestState),
+    .supports_backing       = true,
 
     .bdrv_close             = bdrv_replace_test_close,
     .bdrv_co_preadv         = bdrv_replace_test_co_preadv,
-- 
2.35.1

Re: [PATCH v5 05/45] tests-bdrv-drain: bdrv_replace_test driver: declare supports_backing

Posted by Hanna Reitz 3 years, 6 months ago

On 30.03.22 23:28, Vladimir Sementsov-Ogievskiy wrote:
> We do add COW child to the node.  In future we are going to forbid
> adding COW child to the node that doesn't support backing. So, fix it
> here now.
>
> Don't worry about setting bs->backing itself: it further commit we'll

s/it/in/

> update the block-layer to automatically set/unset this field in generic
> code.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@openvz.org>
> ---
>   tests/unit/test-bdrv-drain.c | 1 +
>   1 file changed, 1 insertion(+)

Reviewed-by: Hanna Reitz <hreitz@redhat.com>