[v5] Transactional block-graph modifying API

[PATCH v5 03/45] block/blklogwrites: don't care to remove bs->file child on failure

Vladimir Sementsov-Ogievskiy posted 45 patches 3 years, 8 months ago

Diff against v4
Download mbox

Maintainers: Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>, Ari Sundholm <ari@tuxera.com>, Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>, Paolo Bonzini <pbonzini@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, John Snow <jsnow@redhat.com>, Vladimir Sementsov-Ogievskiy <v.sementsov-og@mail.ru>, "Denis V. Lunev" <den@openvz.org>, Wen Congyang <wencongyang2@huawei.com>, Xie Changlong <xiechanglong.d@gmail.com>, Stefan Weil <sw@weilnetz.de>, Jeff Cody <codyprime@gmail.com>, Fam Zheng <fam@euphon.net>, Markus Armbruster <armbru@redhat.com>, Eric Blake <eblake@redhat.com>

Expand all Fold all

[PATCH v5 03/45] block/blklogwrites: don't care to remove bs->file child on failure

Posted by Vladimir Sementsov-Ogievskiy 3 years, 8 months ago

We don't need to remove bs->file, generic layer takes care of it. No
other driver cares to remove bs->file on failure by hand.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@openvz.org>
---
 block/blklogwrites.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/block/blklogwrites.c b/block/blklogwrites.c
index f66a617eb3..7d25df97cc 100644
--- a/block/blklogwrites.c
+++ b/block/blklogwrites.c
@@ -254,10 +254,6 @@ fail_log:
         s->log_file = NULL;
     }
 fail:
-    if (ret < 0) {
-        bdrv_unref_child(bs, bs->file);
-        bs->file = NULL;
-    }
     qemu_opts_del(opts);
     return ret;
 }
-- 
2.35.1

Re: [PATCH v5 03/45] block/blklogwrites: don't care to remove bs->file child on failure

Posted by Hanna Reitz 3 years, 6 months ago

On 30.03.22 23:28, Vladimir Sementsov-Ogievskiy wrote:
> We don't need to remove bs->file, generic layer takes care of it. No
> other driver cares to remove bs->file on failure by hand.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@openvz.org>
> ---
>   block/blklogwrites.c | 4 ----
>   1 file changed, 4 deletions(-)

Reviewed-by: Hanna Reitz <hreitz@redhat.com>