[v5] Transactional block-graph modifying API

[PATCH v5 20/45] block: make permission update functions public

Vladimir Sementsov-Ogievskiy posted 45 patches 3 years, 8 months ago

Diff against v4
Download mbox

Maintainers: Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>, Ari Sundholm <ari@tuxera.com>, Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>, Paolo Bonzini <pbonzini@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, John Snow <jsnow@redhat.com>, Vladimir Sementsov-Ogievskiy <v.sementsov-og@mail.ru>, "Denis V. Lunev" <den@openvz.org>, Wen Congyang <wencongyang2@huawei.com>, Xie Changlong <xiechanglong.d@gmail.com>, Stefan Weil <sw@weilnetz.de>, Jeff Cody <codyprime@gmail.com>, Fam Zheng <fam@euphon.net>, Markus Armbruster <armbru@redhat.com>, Eric Blake <eblake@redhat.com>

Expand all Fold all

[PATCH v5 20/45] block: make permission update functions public

Posted by Vladimir Sementsov-Ogievskiy 3 years, 8 months ago

We'll need them in further commits in blockdev.c for new transaction
block-graph modifying API.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@openvz.org>
---
 block.c                            | 7 +++----
 include/block/block-global-state.h | 4 ++++
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/block.c b/block.c
index 9009f73534..be19964f89 100644
--- a/block.c
+++ b/block.c
@@ -2519,8 +2519,8 @@ static int bdrv_do_refresh_perms(GSList *list, BlockReopenQueue *q,
  * topologically sorted. It's not a problem if some node occurs in the @list
  * several times.
  */
-static int bdrv_list_refresh_perms(GSList *list, BlockReopenQueue *q,
-                                   Transaction *tran, Error **errp)
+int bdrv_list_refresh_perms(GSList *list, BlockReopenQueue *q,
+                            Transaction *tran, Error **errp)
 {
     g_autoptr(GHashTable) found = g_hash_table_new(NULL, NULL);
     g_autoptr(GSList) refresh_list = NULL;
@@ -2580,8 +2580,7 @@ char *bdrv_perm_names(uint64_t perm)
 
 
 /* @tran is allowed to be NULL. In this case no rollback is possible */
-static int bdrv_refresh_perms(BlockDriverState *bs, Transaction *tran,
-                              Error **errp)
+int bdrv_refresh_perms(BlockDriverState *bs, Transaction *tran, Error **errp)
 {
     int ret;
     Transaction *local_tran = NULL;
diff --git a/include/block/block-global-state.h b/include/block/block-global-state.h
index 600afcf5bd..c307b48b2a 100644
--- a/include/block/block-global-state.h
+++ b/include/block/block-global-state.h
@@ -253,4 +253,8 @@ void bdrv_unregister_buf(BlockDriverState *bs, void *host);
 
 void bdrv_cancel_in_flight(BlockDriverState *bs);
 
+int bdrv_list_refresh_perms(GSList *list, BlockReopenQueue *q,
+                            Transaction *tran, Error **errp);
+int bdrv_refresh_perms(BlockDriverState *bs, Transaction *tran, Error **errp);
+
 #endif /* BLOCK_GLOBAL_STATE_H */
-- 
2.35.1

Re: [PATCH v5 20/45] block: make permission update functions public

Posted by Hanna Reitz 3 years, 6 months ago

On 30.03.22 23:28, Vladimir Sementsov-Ogievskiy wrote:
> We'll need them in further commits in blockdev.c for new transaction
> block-graph modifying API.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@openvz.org>
> ---
>   block.c                            | 7 +++----
>   include/block/block-global-state.h | 4 ++++
>   2 files changed, 7 insertions(+), 4 deletions(-)

Reviewed-by: Hanna Reitz <hreitz@redhat.com>