[v2] Python: Remove synchronous QMP library

[PATCH v2 9/9] python/qmp: remove pylint workaround from legacy.py

Posted by John Snow 3 years, 10 months ago

Pylint upgraded recently (2.13.z) and having a pylint: disable comment
in the middle of an argument field causes it some grief (It appears to
stop parsing when it encounters it, causing some syntax problems). Since
the duplicate line threshold was bumped up in 22305c2a081b, we don't
need this workaround anymore. Drop it.

Signed-off-by: John Snow <jsnow@redhat.com>
---
 python/qemu/qmp/legacy.py | 2 --
 1 file changed, 2 deletions(-)

diff --git a/python/qemu/qmp/legacy.py b/python/qemu/qmp/legacy.py
index a8629b44dff..03b5574618f 100644
--- a/python/qemu/qmp/legacy.py
+++ b/python/qemu/qmp/legacy.py
@@ -106,8 +106,6 @@ def __enter__(self: _T) -> _T:
         return self
 
     def __exit__(self,
-                 # pylint: disable=duplicate-code
-                 # see https://github.com/PyCQA/pylint/issues/3619
                  exc_type: Optional[Type[BaseException]],
                  exc_val: Optional[BaseException],
                  exc_tb: Optional[TracebackType]) -> None:
-- 
2.34.1

Re: [PATCH v2 9/9] python/qmp: remove pylint workaround from legacy.py

Posted by Vladimir Sementsov-Ogievskiy 3 years, 10 months ago

30.03.2022 20:28, John Snow wrote:
> Pylint upgraded recently (2.13.z) and having a pylint: disable comment
> in the middle of an argument field causes it some grief (It appears to
> stop parsing when it encounters it, causing some syntax problems). Since
> the duplicate line threshold was bumped up in 22305c2a081b, we don't
> need this workaround anymore. Drop it.
> 
> Signed-off-by: John Snow<jsnow@redhat.com>

Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@openvz.org>

-- 
Best regards,
Vladimir