[v1] tests/docker and tests/tcg cleanup and diet

[PATCH 01/15] tests/docker: remove dead code

Posted by Paolo Bonzini 3 years, 8 months ago

debian-powerpc-user-cross was the only linux-user powered cross builder
and it was removed in commit 80394ccf21 ("tests/docker: remove
debian-powerpc-user-cross", 2019-09-26). Remove all the infrastructure
around it since it is now unused.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 tests/docker/Makefile.include | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
index e495b163a0..a6a5a20949 100644
--- a/tests/docker/Makefile.include
+++ b/tests/docker/Makefile.include
@@ -229,12 +229,6 @@ DOCKER_PARTIAL_IMAGES += debian-tricore-cross
 DOCKER_PARTIAL_IMAGES += debian-xtensa-cross
 DOCKER_PARTIAL_IMAGES += fedora-cris-cross
 
-# Rules for building linux-user powered images
-#
-# These are slower than using native cross compiler setups but can
-# work around issues with poorly working multi-arch systems and broken
-# packages.
-
 # Expand all the pre-requistes for each docker image and test combination
 $(foreach i,$(filter-out $(DOCKER_PARTIAL_IMAGES) $(DOCKER_VIRTUAL_IMAGES),$(DOCKER_IMAGES)), \
 	$(foreach t,$(DOCKER_TESTS), \
@@ -266,11 +260,6 @@ docker:
 	@echo
 	@echo 'Available container images:'
 	@echo '    $(DOCKER_IMAGES)'
-ifneq ($(DOCKER_USER_IMAGES),)
-	@echo
-	@echo 'Available linux-user images (docker-binfmt-image-debian-%):'
-	@echo '    $(DOCKER_USER_IMAGES)'
-endif
 	@echo
 	@echo 'Available tests:'
 	@echo '    $(DOCKER_TESTS)'
-- 
2.31.1

Re: [PATCH 01/15] tests/docker: remove dead code

Posted by Alex Bennée 3 years, 8 months ago

Paolo Bonzini <pbonzini@redhat.com> writes:

> debian-powerpc-user-cross was the only linux-user powered cross builder
> and it was removed in commit 80394ccf21 ("tests/docker: remove
> debian-powerpc-user-cross", 2019-09-26). Remove all the infrastructure
> around it since it is now unused.

It doesn't remove it all - we still have the
docker-binfmt-image-debian-% rule (which I'd like to keep). Anyway:

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée

Re: [PATCH 01/15] tests/docker: remove dead code

Posted by Paolo Bonzini 3 years, 8 months ago

On 3/28/22 18:18, Alex Bennée wrote:
> 
>> debian-powerpc-user-cross was the only linux-user powered cross builder
>> and it was removed in commit 80394ccf21 ("tests/docker: remove
>> debian-powerpc-user-cross", 2019-09-26). Remove all the infrastructure
>> around it since it is now unused.
> It doesn't remove it all - we still have the
> docker-binfmt-image-debian-% rule (which I'd like to keep). Anyway:
> 
> Reviewed-by: Alex Bennée<alex.bennee@linaro.org>

Yeah, I wasn't sure about that one.

Paolo