[v1] tests/tcg/xtensa: allow testing big-endian cores

[PATCH] tests/tcg/xtensa: allow testing big-endian cores

Max Filippov posted 1 patch 2 years, 1 month ago

Diff against v1 v1
Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220325182352.113975-1-jcmvbkbc@gmail.com

Test checkpatch passed

Maintainers: Max Filippov <jcmvbkbc@gmail.com>

There is a newer version of this series

MAINTAINERS                                | 1 +
tests/tcg/xtensa/Makefile.softmmu-target   | 4 ++--
tests/tcg/xtensaeb/Makefile.softmmu-target | 5 +++++
3 files changed, 8 insertions(+), 2 deletions(-)
create mode 100644 tests/tcg/xtensaeb/Makefile.softmmu-target

Expand all Fold all

[PATCH] tests/tcg/xtensa: allow testing big-endian cores

Posted by Max Filippov 2 years, 1 month ago

Don't disable all big-endian tests, instead check whether $(CORE) is
supported by the configured $(QEMU) and enable tests if it is.

Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
---
 MAINTAINERS                                | 1 +
 tests/tcg/xtensa/Makefile.softmmu-target   | 4 ++--
 tests/tcg/xtensaeb/Makefile.softmmu-target | 5 +++++
 3 files changed, 8 insertions(+), 2 deletions(-)
 create mode 100644 tests/tcg/xtensaeb/Makefile.softmmu-target

diff --git a/MAINTAINERS b/MAINTAINERS
index 9aed5f3e04e4..e16585b073a3 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -347,6 +347,7 @@ S: Maintained
 F: target/xtensa/
 F: hw/xtensa/
 F: tests/tcg/xtensa/
+F: tests/tcg/xtensaeb/
 F: disas/xtensa.c
 F: include/hw/xtensa/xtensa-isa.h
 F: configs/devices/xtensa*/default.mak
diff --git a/tests/tcg/xtensa/Makefile.softmmu-target b/tests/tcg/xtensa/Makefile.softmmu-target
index 9530cac2ad95..f1cf2a6496d2 100644
--- a/tests/tcg/xtensa/Makefile.softmmu-target
+++ b/tests/tcg/xtensa/Makefile.softmmu-target
@@ -2,7 +2,8 @@
 # Xtensa softmmu tests
 #
 
-ifneq ($(TARGET_WORDS_BIGENDIAN),y)
+CORE=dc232b
+ifneq ($(shell $(QEMU) -cpu help | grep -w $(CORE)),)
 
 XTENSA_SRC = $(SRC_PATH)/tests/tcg/xtensa
 XTENSA_ALL = $(filter-out $(XTENSA_SRC)/linker.ld.S,$(wildcard $(XTENSA_SRC)/*.S))
@@ -15,7 +16,6 @@ XTENSA_USABLE_TESTS = $(filter-out $(XTENSA_BROKEN_TESTS), $(XTENSA_TESTS))
 TESTS += $(XTENSA_USABLE_TESTS)
 VPATH += $(XTENSA_SRC)
 
-CORE=dc232b
 QEMU_OPTS+=-M sim -cpu $(CORE) -nographic -semihosting -icount 6 $(EXTFLAGS) -kernel
 
 INCLUDE_DIRS = $(SRC_PATH)/target/xtensa/core-$(CORE)
diff --git a/tests/tcg/xtensaeb/Makefile.softmmu-target b/tests/tcg/xtensaeb/Makefile.softmmu-target
new file mode 100644
index 000000000000..4204a96d53c0
--- /dev/null
+++ b/tests/tcg/xtensaeb/Makefile.softmmu-target
@@ -0,0 +1,5 @@
+#
+# Xtensa softmmu tests
+#
+
+include $(SRC_PATH)/tests/tcg/xtensa/Makefile.softmmu-target
-- 
2.30.2

Re: [PATCH] tests/tcg/xtensa: allow testing big-endian cores

Posted by Philippe Mathieu-Daudé 2 years, 1 month ago

On 25/3/22 19:23, Max Filippov wrote:
> Don't disable all big-endian tests, instead check whether $(CORE) is
> supported by the configured $(QEMU) and enable tests if it is.
> 
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
> ---
>   MAINTAINERS                                | 1 +
>   tests/tcg/xtensa/Makefile.softmmu-target   | 4 ++--
>   tests/tcg/xtensaeb/Makefile.softmmu-target | 5 +++++
>   3 files changed, 8 insertions(+), 2 deletions(-)
>   create mode 100644 tests/tcg/xtensaeb/Makefile.softmmu-target

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>