target/i386: Some mmx/sse instructions don't require

[PATCH 0/2] target/i386: Some mmx/sse instructions don't require

Wei Li posted 2 patches 2 years, 1 month ago

Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220325145007.448948-1-lw945lw945@yahoo.com

Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Eduardo Habkost <eduardo@habkost.net>

target/i386/tcg/translate.c | 45 +++++++++++++++++--------------------
1 file changed, 21 insertions(+), 24 deletions(-)

Expand all Fold all

[PATCH 0/2] target/i386: Some mmx/sse instructions don't require

Posted by Wei Li 2 years, 1 month ago

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/427

All instructions decoded by 'gen_see' is assumed to require CRO.TS=0. But
according to SDM, CRC32 doesn't require it. In fact, EMMS, FMMS and some
mmx/sse instructions(0F38F[0-F], 0F3AF[0-F]) don't require it.

To solve the problem, first to move EMMS and FMMS out of gen_sse. Then
instructions in 'gen_sse' require it only when modrm & 0xF0 is false.

Wei Li (2):
  Move EMMS and FEMMS instructions out of gen_sse
  Some mmx/sse instructions in 'gen_sse' don't require CRO.TS=0

 target/i386/tcg/translate.c | 45 +++++++++++++++++--------------------
 1 file changed, 21 insertions(+), 24 deletions(-)

-- 
2.30.2

Re: [PATCH 0/2] target/i386: Some mmx/sse instructions don't require

Posted by Wei Li 2 years, 1 month ago

Ping......

And the title is target/i386: Some mmx/sse instructions don't require
CR0.TS=0

On Fri, Mar 25, 2022 at 10:55 PM Wei Li <lw945lw945@yahoo.com> wrote:

> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/427
>
> All instructions decoded by 'gen_see' is assumed to require CRO.TS=0. But
> according to SDM, CRC32 doesn't require it. In fact, EMMS, FMMS and some
> mmx/sse instructions(0F38F[0-F], 0F3AF[0-F]) don't require it.
>
> To solve the problem, first to move EMMS and FMMS out of gen_sse. Then
> instructions in 'gen_sse' require it only when modrm & 0xF0 is false.
>
> Wei Li (2):
>   Move EMMS and FEMMS instructions out of gen_sse
>   Some mmx/sse instructions in 'gen_sse' don't require CRO.TS=0
>
>  target/i386/tcg/translate.c | 45 +++++++++++++++++--------------------
>  1 file changed, 21 insertions(+), 24 deletions(-)
>
> --
> 2.30.2
>
>
>
Thanks.
--
Wei Li