[PATCH] configure: remove dead int128 test

Paolo Bonzini posted 1 patch 2 years, 1 month ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220323115021.24763-1-pbonzini@redhat.com
configure | 18 ------------------
1 file changed, 18 deletions(-)
[PATCH] configure: remove dead int128 test
Posted by Paolo Bonzini 2 years, 1 month ago
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 configure | 18 ------------------
 1 file changed, 18 deletions(-)

diff --git a/configure b/configure
index 6d9cb23ac5..7c08c18358 100755
--- a/configure
+++ b/configure
@@ -2463,24 +2463,6 @@ else # "$safe_stack" = ""
 fi
 fi
 
-########################################
-# check if __[u]int128_t is usable.
-
-int128=no
-cat > $TMPC << EOF
-__int128_t a;
-__uint128_t b;
-int main (void) {
-  a = a + b;
-  b = a * b;
-  a = a * a;
-  return 0;
-}
-EOF
-if compile_prog "" "" ; then
-    int128=yes
-fi
-
 ########################################
 # check if ccache is interfering with
 # semantic analysis of macros
-- 
2.35.1
Re: [PATCH] configure: remove dead int128 test
Posted by Thomas Huth 2 years, 1 month ago
On 23/03/2022 12.50, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   configure | 18 ------------------
>   1 file changed, 18 deletions(-)
> 
> diff --git a/configure b/configure
> index 6d9cb23ac5..7c08c18358 100755
> --- a/configure
> +++ b/configure
> @@ -2463,24 +2463,6 @@ else # "$safe_stack" = ""
>   fi
>   fi
>   
> -########################################
> -# check if __[u]int128_t is usable.
> -
> -int128=no
> -cat > $TMPC << EOF
> -__int128_t a;
> -__uint128_t b;
> -int main (void) {
> -  a = a + b;
> -  b = a * b;
> -  a = a * a;
> -  return 0;
> -}
> -EOF
> -if compile_prog "" "" ; then
> -    int128=yes
> -fi
> -
>   ########################################
>   # check if ccache is interfering with
>   # semantic analysis of macros

Fixes: 848126d11e ("meson: move int128 checks from configure")

Reviewed-by: Thomas Huth <thuth@redhat.com>
Re: [PATCH] configure: remove dead int128 test
Posted by Marc-André Lureau 2 years, 1 month ago
On Wed, Mar 23, 2022 at 3:50 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

> ---
>  configure | 18 ------------------
>  1 file changed, 18 deletions(-)
>
> diff --git a/configure b/configure
> index 6d9cb23ac5..7c08c18358 100755
> --- a/configure
> +++ b/configure
> @@ -2463,24 +2463,6 @@ else # "$safe_stack" = ""
>  fi
>  fi
>
> -########################################
> -# check if __[u]int128_t is usable.
> -
> -int128=no
> -cat > $TMPC << EOF
> -__int128_t a;
> -__uint128_t b;
> -int main (void) {
> -  a = a + b;
> -  b = a * b;
> -  a = a * a;
> -  return 0;
> -}
> -EOF
> -if compile_prog "" "" ; then
> -    int128=yes
> -fi
> -
>  ########################################
>  # check if ccache is interfering with
>  # semantic analysis of macros
> --
> 2.35.1
>