target/avr/cpu.h | 2 -- target/avr/cpu.c | 1 - target/avr/helper.c | 6 ------ 3 files changed, 9 deletions(-)
CPUClass::memory_rw_debug() holds a callback for GDB memory access.
If not provided, cpu_memory_rw_debug() is used by the GDB stub.
Drop avr_cpu_memory_rw_debug() which does nothing special.
Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---
target/avr/cpu.h | 2 --
target/avr/cpu.c | 1 -
target/avr/helper.c | 6 ------
3 files changed, 9 deletions(-)
diff --git a/target/avr/cpu.h b/target/avr/cpu.h
index 55497f851d..44c2b08bd7 100644
--- a/target/avr/cpu.h
+++ b/target/avr/cpu.h
@@ -184,8 +184,6 @@ void avr_cpu_tcg_init(void);
void avr_cpu_list(void);
int cpu_avr_exec(CPUState *cpu);
-int avr_cpu_memory_rw_debug(CPUState *cs, vaddr address, uint8_t *buf,
- int len, bool is_write);
enum {
TB_FLAGS_FULL_ACCESS = 1,
diff --git a/target/avr/cpu.c b/target/avr/cpu.c
index 5d70e34dd5..05b992ff73 100644
--- a/target/avr/cpu.c
+++ b/target/avr/cpu.c
@@ -214,7 +214,6 @@ static void avr_cpu_class_init(ObjectClass *oc, void *data)
cc->has_work = avr_cpu_has_work;
cc->dump_state = avr_cpu_dump_state;
cc->set_pc = avr_cpu_set_pc;
- cc->memory_rw_debug = avr_cpu_memory_rw_debug;
dc->vmsd = &vms_avr_cpu;
cc->sysemu_ops = &avr_sysemu_ops;
cc->disas_set_info = avr_cpu_disas_set_info;
diff --git a/target/avr/helper.c b/target/avr/helper.c
index c27f702901..db76452f9a 100644
--- a/target/avr/helper.c
+++ b/target/avr/helper.c
@@ -93,12 +93,6 @@ void avr_cpu_do_interrupt(CPUState *cs)
cs->exception_index = -1;
}
-int avr_cpu_memory_rw_debug(CPUState *cs, vaddr addr, uint8_t *buf,
- int len, bool is_write)
-{
- return cpu_memory_rw_debug(cs, addr, buf, len, is_write);
-}
-
hwaddr avr_cpu_get_phys_page_debug(CPUState *cs, vaddr addr)
{
return addr; /* I assume 1:1 address correspondence */
--
2.25.1
On 3/22/22 02:50, Bin Meng wrote: > CPUClass::memory_rw_debug() holds a callback for GDB memory access. > If not provided, cpu_memory_rw_debug() is used by the GDB stub. > Drop avr_cpu_memory_rw_debug() which does nothing special. > > Signed-off-by: Bin Meng <bmeng.cn@gmail.com> Queued to tcg-next, for lack of anything better. r~
On Mon, Jun 20, 2022 at 10:01 PM Richard Henderson <richard.henderson@linaro.org> wrote: > On 3/22/22 02:50, Bin Meng wrote: > > CPUClass::memory_rw_debug() holds a callback for GDB memory access. > > If not provided, cpu_memory_rw_debug() is used by the GDB stub. > > Drop avr_cpu_memory_rw_debug() which does nothing special. > > > > Signed-off-by: Bin Meng <bmeng.cn@gmail.com> > > Queued to tcg-next, for lack of anything better. Thank you!
On 22/3/22 10:50, Bin Meng wrote: > CPUClass::memory_rw_debug() holds a callback for GDB memory access. > If not provided, cpu_memory_rw_debug() is used by the GDB stub. > Drop avr_cpu_memory_rw_debug() which does nothing special. > > Signed-off-by: Bin Meng <bmeng.cn@gmail.com> > --- > > target/avr/cpu.h | 2 -- > target/avr/cpu.c | 1 - > target/avr/helper.c | 6 ------ > 3 files changed, 9 deletions(-) Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
© 2016 - 2024 Red Hat, Inc.