[v3] Create menus in iothread

[PATCH v3 0/2] Create menus in iothread

Akihiko Odaki posted 2 patches 2 years, 1 month ago

Diff against v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220321041043.24112-1-akihiko.odaki@gmail.com

Test checkpatch passed

Maintainers: Peter Maydell <peter.maydell@linaro.org>, "Philippe Mathieu-Daudé" <f4bug@amsat.org>, Akihiko Odaki <akihiko.odaki@gmail.com>, Gerd Hoffmann <kraxel@redhat.com>

ui/cocoa.m | 209 +++++++++++++++++++++++++----------------------------
1 file changed, 98 insertions(+), 111 deletions(-)

Expand all Fold all

[PATCH v3 0/2] Create menus in iothread

Posted by Akihiko Odaki 2 years, 1 month ago

Commit 0439c5a4623d674efa0c72abd62ca6e98bb7cf87 introduced an
assertion that blk_all_next is called in the main thread. The function
is called in the following chain:
- blk_all_next
- qmp_query_block
- addRemovableDevicesMenuItems
- main

This change moves the menu creation to the iothread. This also changes
the menu creation procedure to construct the entire menu tree before
setting to NSApp, which is necessary because a menu set once cannot be
modified if NSApp is already running.

v2: Separate a change moving create_initial_menus (Peter Maydell)

v3: Rebased to commit 2058fdbe81e2985c226a026851dd26b146d3395c

Akihiko Odaki (2):
  ui/cocoa: Move create_initial_menus
  ui/cocoa: Create menus in iothread

 ui/cocoa.m | 209 +++++++++++++++++++++++++----------------------------
 1 file changed, 98 insertions(+), 111 deletions(-)

-- 
2.32.0 (Apple Git-132)