[PATCH v7 00/12] hw/nvme: SR-IOV with Virtualization Enhancements

Lukasz Maniak posted 12 patches 2 years, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220318191819.1711831-1-lukasz.maniak@linux.intel.com
Test checkpatch passed
Maintainers: "Michael S. Tsirkin" <mst@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Ani Sinha <ani@anisinha.ca>, Keith Busch <kbusch@kernel.org>, Klaus Jensen <its@irrelevant.dk>, Stefan Hajnoczi <stefanha@redhat.com>, Fam Zheng <fam@euphon.net>, "Philippe Mathieu-Daudé" <f4bug@amsat.org>, Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
There is a newer version of this series
docs/system/devices/nvme.rst |  82 +++++
hw/acpi/pcihp.c              |   6 +-
hw/nvme/ctrl.c               | 673 ++++++++++++++++++++++++++++++++---
hw/nvme/ns.c                 |   2 +-
hw/nvme/nvme.h               |  55 ++-
hw/nvme/subsys.c             |  75 +++-
hw/nvme/trace-events         |   6 +
include/block/nvme.h         |  65 ++++
include/hw/pci/pci_ids.h     |   1 +
9 files changed, 909 insertions(+), 56 deletions(-)
[PATCH v7 00/12] hw/nvme: SR-IOV with Virtualization Enhancements
Posted by Lukasz Maniak 2 years, 1 month ago
Resubmitting v6 as v7 since Patchew got lost with my sophisticated CC of
all maintainers just for the cover letter.

Changes since v5:
- Fixed PCI hotplug issue related to deleting VF twice
- Corrected error messages for SR-IOV parameters
- Rebased on master, patches for PCI got pulled into the tree
- Added Reviewed-by labels

Lukasz Maniak (4):
  hw/nvme: Add support for SR-IOV
  hw/nvme: Add support for Primary Controller Capabilities
  hw/nvme: Add support for Secondary Controller List
  docs: Add documentation for SR-IOV and Virtualization Enhancements

Łukasz Gieryk (8):
  hw/nvme: Implement the Function Level Reset
  hw/nvme: Make max_ioqpairs and msix_qsize configurable in runtime
  hw/nvme: Remove reg_size variable and update BAR0 size calculation
  hw/nvme: Calculate BAR attributes in a function
  hw/nvme: Initialize capability structures for primary/secondary
    controllers
  hw/nvme: Add support for the Virtualization Management command
  hw/nvme: Update the initalization place for the AER queue
  hw/acpi: Make the PCI hot-plug aware of SR-IOV

 docs/system/devices/nvme.rst |  82 +++++
 hw/acpi/pcihp.c              |   6 +-
 hw/nvme/ctrl.c               | 673 ++++++++++++++++++++++++++++++++---
 hw/nvme/ns.c                 |   2 +-
 hw/nvme/nvme.h               |  55 ++-
 hw/nvme/subsys.c             |  75 +++-
 hw/nvme/trace-events         |   6 +
 include/block/nvme.h         |  65 ++++
 include/hw/pci/pci_ids.h     |   1 +
 9 files changed, 909 insertions(+), 56 deletions(-)

-- 
2.25.1


Re: [PATCH v7 00/12] hw/nvme: SR-IOV with Virtualization Enhancements
Posted by Michael S. Tsirkin 2 years ago
On Fri, Mar 18, 2022 at 08:18:07PM +0100, Lukasz Maniak wrote:
> Resubmitting v6 as v7 since Patchew got lost with my sophisticated CC of
> all maintainers just for the cover letter.
> 
> Changes since v5:
> - Fixed PCI hotplug issue related to deleting VF twice
> - Corrected error messages for SR-IOV parameters
> - Rebased on master, patches for PCI got pulled into the tree
> - Added Reviewed-by labels
> 
> Lukasz Maniak (4):
>   hw/nvme: Add support for SR-IOV
>   hw/nvme: Add support for Primary Controller Capabilities
>   hw/nvme: Add support for Secondary Controller List
>   docs: Add documentation for SR-IOV and Virtualization Enhancements
> 
> Łukasz Gieryk (8):
>   hw/nvme: Implement the Function Level Reset
>   hw/nvme: Make max_ioqpairs and msix_qsize configurable in runtime
>   hw/nvme: Remove reg_size variable and update BAR0 size calculation
>   hw/nvme: Calculate BAR attributes in a function
>   hw/nvme: Initialize capability structures for primary/secondary
>     controllers
>   hw/nvme: Add support for the Virtualization Management command
>   hw/nvme: Update the initalization place for the AER queue
>   hw/acpi: Make the PCI hot-plug aware of SR-IOV

the right people to review and merge this would be storage/nvme
maintainers.
I did take a quick look though.

Acked-by: Michael S. Tsirkin <mst@redhat.com>



>  docs/system/devices/nvme.rst |  82 +++++
>  hw/acpi/pcihp.c              |   6 +-
>  hw/nvme/ctrl.c               | 673 ++++++++++++++++++++++++++++++++---
>  hw/nvme/ns.c                 |   2 +-
>  hw/nvme/nvme.h               |  55 ++-
>  hw/nvme/subsys.c             |  75 +++-
>  hw/nvme/trace-events         |   6 +
>  include/block/nvme.h         |  65 ++++
>  include/hw/pci/pci_ids.h     |   1 +
>  9 files changed, 909 insertions(+), 56 deletions(-)
> 
> -- 
> 2.25.1


Re: [PATCH v7 00/12] hw/nvme: SR-IOV with Virtualization Enhancements
Posted by Klaus Jensen 2 years ago
On Apr 20 08:02, Michael S. Tsirkin wrote:
> On Fri, Mar 18, 2022 at 08:18:07PM +0100, Lukasz Maniak wrote:
> > Resubmitting v6 as v7 since Patchew got lost with my sophisticated CC of
> > all maintainers just for the cover letter.
> > 
> > Changes since v5:
> > - Fixed PCI hotplug issue related to deleting VF twice
> > - Corrected error messages for SR-IOV parameters
> > - Rebased on master, patches for PCI got pulled into the tree
> > - Added Reviewed-by labels
> > 
> > Lukasz Maniak (4):
> >   hw/nvme: Add support for SR-IOV
> >   hw/nvme: Add support for Primary Controller Capabilities
> >   hw/nvme: Add support for Secondary Controller List
> >   docs: Add documentation for SR-IOV and Virtualization Enhancements
> > 
> > Łukasz Gieryk (8):
> >   hw/nvme: Implement the Function Level Reset
> >   hw/nvme: Make max_ioqpairs and msix_qsize configurable in runtime
> >   hw/nvme: Remove reg_size variable and update BAR0 size calculation
> >   hw/nvme: Calculate BAR attributes in a function
> >   hw/nvme: Initialize capability structures for primary/secondary
> >     controllers
> >   hw/nvme: Add support for the Virtualization Management command
> >   hw/nvme: Update the initalization place for the AER queue
> >   hw/acpi: Make the PCI hot-plug aware of SR-IOV
> 
> the right people to review and merge this would be storage/nvme
> maintainers.
> I did take a quick look though.
> 
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
> 

Was waiting for a review on the acpi stuff. Thanks! :)
Re: [PATCH v7 00/12] hw/nvme: SR-IOV with Virtualization Enhancements
Posted by Lukasz Maniak 2 years ago
On Wed, Apr 20, 2022 at 02:12:58PM +0200, Klaus Jensen wrote:
> On Apr 20 08:02, Michael S. Tsirkin wrote:
> > On Fri, Mar 18, 2022 at 08:18:07PM +0100, Lukasz Maniak wrote:
> > > Resubmitting v6 as v7 since Patchew got lost with my sophisticated CC of
> > > all maintainers just for the cover letter.
> > > 
> > > Changes since v5:
> > > - Fixed PCI hotplug issue related to deleting VF twice
> > > - Corrected error messages for SR-IOV parameters
> > > - Rebased on master, patches for PCI got pulled into the tree
> > > - Added Reviewed-by labels
> > > 
> > > Lukasz Maniak (4):
> > >   hw/nvme: Add support for SR-IOV
> > >   hw/nvme: Add support for Primary Controller Capabilities
> > >   hw/nvme: Add support for Secondary Controller List
> > >   docs: Add documentation for SR-IOV and Virtualization Enhancements
> > > 
> > > Łukasz Gieryk (8):
> > >   hw/nvme: Implement the Function Level Reset
> > >   hw/nvme: Make max_ioqpairs and msix_qsize configurable in runtime
> > >   hw/nvme: Remove reg_size variable and update BAR0 size calculation
> > >   hw/nvme: Calculate BAR attributes in a function
> > >   hw/nvme: Initialize capability structures for primary/secondary
> > >     controllers
> > >   hw/nvme: Add support for the Virtualization Management command
> > >   hw/nvme: Update the initalization place for the AER queue
> > >   hw/acpi: Make the PCI hot-plug aware of SR-IOV
> > 
> > the right people to review and merge this would be storage/nvme
> > maintainers.
> > I did take a quick look though.
> > 
> > Acked-by: Michael S. Tsirkin <mst@redhat.com>
> > 
> 
> Was waiting for a review on the acpi stuff. Thanks! :)

Thank you for checking and acking Michael :)

Klaus, looking through the list of patches, we are still missing reviews
for numbers 03, 08 and 09.
Do you want me to update to v8 or wait for a review first?

Thanks,
Lukasz

Re: [PATCH v7 00/12] hw/nvme: SR-IOV with Virtualization Enhancements
Posted by Klaus Jensen 2 years ago
On Mar 18 20:18, Lukasz Maniak wrote:
> Resubmitting v6 as v7 since Patchew got lost with my sophisticated CC of
> all maintainers just for the cover letter.
> 
> Changes since v5:
> - Fixed PCI hotplug issue related to deleting VF twice
> - Corrected error messages for SR-IOV parameters
> - Rebased on master, patches for PCI got pulled into the tree
> - Added Reviewed-by labels
> 
> Lukasz Maniak (4):
>   hw/nvme: Add support for SR-IOV
>   hw/nvme: Add support for Primary Controller Capabilities
>   hw/nvme: Add support for Secondary Controller List
>   docs: Add documentation for SR-IOV and Virtualization Enhancements
> 
> Łukasz Gieryk (8):
>   hw/nvme: Implement the Function Level Reset
>   hw/nvme: Make max_ioqpairs and msix_qsize configurable in runtime
>   hw/nvme: Remove reg_size variable and update BAR0 size calculation
>   hw/nvme: Calculate BAR attributes in a function
>   hw/nvme: Initialize capability structures for primary/secondary
>     controllers
>   hw/nvme: Add support for the Virtualization Management command
>   hw/nvme: Update the initalization place for the AER queue
>   hw/acpi: Make the PCI hot-plug aware of SR-IOV
> 
>  docs/system/devices/nvme.rst |  82 +++++
>  hw/acpi/pcihp.c              |   6 +-
>  hw/nvme/ctrl.c               | 673 ++++++++++++++++++++++++++++++++---
>  hw/nvme/ns.c                 |   2 +-
>  hw/nvme/nvme.h               |  55 ++-
>  hw/nvme/subsys.c             |  75 +++-
>  hw/nvme/trace-events         |   6 +
>  include/block/nvme.h         |  65 ++++
>  include/hw/pci/pci_ids.h     |   1 +
>  9 files changed, 909 insertions(+), 56 deletions(-)
> 

Series (hw/nvme parts) looks good.

Reviewed-by: Klaus Jensen <k.jensen@samsung.com>