[PATCH] docs/devel: Fix broken internal link to mailing lists

Kashyap Chamarthy posted 1 patch 2 years, 1 month ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220315155426.659426-1-kchamart@redhat.com
docs/devel/submitting-a-patch.rst | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
[PATCH] docs/devel: Fix broken internal link to mailing lists
Posted by Kashyap Chamarthy 2 years, 1 month ago
Missed this during the initial conversion.

Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com>
---
This patch should be merged on top of this[1].  Otherwise Sphinx will
complain (correctly so).

[1] https://lists.nongnu.org/archive/html/qemu-devel/2022-03/msg03488.html
    -- docs: rSTify MailingLists wiki; move it to QEMU Git

Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com>
---
 docs/devel/submitting-a-patch.rst | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/docs/devel/submitting-a-patch.rst b/docs/devel/submitting-a-patch.rst
index e51259eb9c..3632b74585 100644
--- a/docs/devel/submitting-a-patch.rst
+++ b/docs/devel/submitting-a-patch.rst
@@ -18,13 +18,13 @@ one-shot fix, the bare minimum we ask is that:
    <http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches?id=f6f94e2ab1b33f0082ac22d71f66385a60d8157f#n297>`__
    policy.) ``git commit -s`` or ``git format-patch -s`` will add one.
 -  All contributions to QEMU must be **sent as patches** to the
-   qemu-devel `mailing list <MailingLists>`__. Patch contributions
-   should not be posted on the bug tracker, posted on forums, or
-   externally hosted and linked to. (We have other mailing lists too,
-   but all patches must go to qemu-devel, possibly with a Cc: to another
-   list.) ``git send-email`` (`step-by-step setup
-   guide <https://git-send-email.io/>`__ and `hints and
-   tips <https://elixir.bootlin.com/linux/latest/source/Documentation/process/email-clients.rst>`__)
+   qemu-devel mailing list (refer to :ref:`mailing-lists`). Patch
+   contributions should not be posted on the bug tracker, posted on
+   forums, or externally hosted and linked to. (We have other mailing
+   lists too, but all patches must go to qemu-devel, possibly with a Cc:
+   to another list.) ``git send-email`` (`step-by-step setup guide
+   <https://git-send-email.io/>`__ and `hints and tips
+   <https://elixir.bootlin.com/linux/latest/source/Documentation/process/email-clients.rst>`__)
    works best for delivering the patch without mangling it, but
    attachments can be used as a last resort on a first-time submission.
 -  You must read replies to your message, and be willing to act on them.
-- 
2.33.1
Re: [PATCH] docs/devel: Fix broken internal link to mailing lists
Posted by Thomas Huth 1 year, 11 months ago
On 15/03/2022 16.54, Kashyap Chamarthy wrote:
> Missed this during the initial conversion.
> 
> Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com>
> ---
> This patch should be merged on top of this[1].  Otherwise Sphinx will
> complain (correctly so).
> 
> [1] https://lists.nongnu.org/archive/html/qemu-devel/2022-03/msg03488.html
>      -- docs: rSTify MailingLists wiki; move it to QEMU Git
> 
> Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com>
> ---
>   docs/devel/submitting-a-patch.rst | 14 +++++++-------
>   1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/docs/devel/submitting-a-patch.rst b/docs/devel/submitting-a-patch.rst
> index e51259eb9c..3632b74585 100644
> --- a/docs/devel/submitting-a-patch.rst
> +++ b/docs/devel/submitting-a-patch.rst
> @@ -18,13 +18,13 @@ one-shot fix, the bare minimum we ask is that:
>      <http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches?id=f6f94e2ab1b33f0082ac22d71f66385a60d8157f#n297>`__
>      policy.) ``git commit -s`` or ``git format-patch -s`` will add one.
>   -  All contributions to QEMU must be **sent as patches** to the
> -   qemu-devel `mailing list <MailingLists>`__. Patch contributions

  Hi Kashyap!

This still seems to be broken - did you ever respin the other patches? (I 
was not able to spot a v3 of the series...?)

  Thomas
Re: [PATCH] docs/devel: Fix broken internal link to mailing lists
Posted by Kashyap Chamarthy 1 year, 11 months ago
On Wed, May 18, 2022 at 09:04:35AM +0200, Thomas Huth wrote:
> On 15/03/2022 16.54, Kashyap Chamarthy wrote:
> > Missed this during the initial conversion.
> > 
> > Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com>
> > ---
> > This patch should be merged on top of this[1].  Otherwise Sphinx will
> > complain (correctly so).
> > 
> > [1] https://lists.nongnu.org/archive/html/qemu-devel/2022-03/msg03488.html
> >      -- docs: rSTify MailingLists wiki; move it to QEMU Git
> > 
> > Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com>
> > ---
> >   docs/devel/submitting-a-patch.rst | 14 +++++++-------
> >   1 file changed, 7 insertions(+), 7 deletions(-)
> > 
> > diff --git a/docs/devel/submitting-a-patch.rst b/docs/devel/submitting-a-patch.rst
> > index e51259eb9c..3632b74585 100644
> > --- a/docs/devel/submitting-a-patch.rst
> > +++ b/docs/devel/submitting-a-patch.rst
> > @@ -18,13 +18,13 @@ one-shot fix, the bare minimum we ask is that:
> >      <http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches?id=f6f94e2ab1b33f0082ac22d71f66385a60d8157f#n297>`__
> >      policy.) ``git commit -s`` or ``git format-patch -s`` will add one.
> >   -  All contributions to QEMU must be **sent as patches** to the
> > -   qemu-devel `mailing list <MailingLists>`__. Patch contributions
> 
>  Hi Kashyap!

Hiya,

> This still seems to be broken - did you ever respin the other patches? (I
> was not able to spot a v3 of the series...?)

I have not respun yet, afraid.  Let's see what is pending:

  - Looking at my TODO notes, in v3, I just to need to add another
    docs/about/contacting-the-project.rst as per Peter's feedback here:

        https://lists.nongnu.org/archive/html/qemu-devel/2022-03/msg05178.html

  - Also, I haven't seen any comments on this one in v2:

        https://lists.nongnu.org/archive/html/qemu-devel/2022-03/msg03489.html
        [PATCH v2 3/3] docs: rSTify GettingStartedDevelopers wiki; move
        it to QEMU Git

    I'm assuming it is fine.

I'll send out a v3 this week.  Thanks for the reminder!  

-- 
/kashyap