[PATCH v1 8/8] gitlab: include new aarch32 job in custom-runners

Alex Bennée posted 8 patches 3 years, 11 months ago
Maintainers: "Alex Bennée" <alex.bennee@linaro.org>, "Philippe Mathieu-Daudé" <f4bug@amsat.org>, Thomas Huth <thuth@redhat.com>, Wainer dos Santos Moschetta <wainersm@redhat.com>, Beraldo Leal <bleal@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Eduardo Habkost <eduardo@habkost.net>, Cleber Rosa <crosa@redhat.com>, David Hildenbrand <david@redhat.com>
[PATCH v1 8/8] gitlab: include new aarch32 job in custom-runners
Posted by Alex Bennée 3 years, 11 months ago
Without linking it in it won't be presented on the UI.

Fixes: cc44a16002 ("gitlab: add a new aarch32 custom runner definition")
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 .gitlab-ci.d/custom-runners.yml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.gitlab-ci.d/custom-runners.yml b/.gitlab-ci.d/custom-runners.yml
index 3e76a2034a..15aaccc481 100644
--- a/.gitlab-ci.d/custom-runners.yml
+++ b/.gitlab-ci.d/custom-runners.yml
@@ -16,4 +16,5 @@ variables:
 include:
   - local: '/.gitlab-ci.d/custom-runners/ubuntu-20.04-s390x.yml'
   - local: '/.gitlab-ci.d/custom-runners/ubuntu-20.04-aarch64.yml'
+  - local: '/.gitlab-ci.d/custom-runners/ubuntu-20.04-aarch32.yml'
   - local: '/.gitlab-ci.d/custom-runners/centos-stream-8-x86_64.yml'
-- 
2.30.2


Re: [PATCH v1 8/8] gitlab: include new aarch32 job in custom-runners
Posted by Alex Bennée 3 years, 11 months ago
And of course after sending I immediately see the aarch32 job is misnamed.
Will send a v2 follow-up individually

On Tue, 15 Mar 2022 at 12:12, Alex Bennée <alex.bennee@linaro.org> wrote:

> Without linking it in it won't be presented on the UI.
>
> Fixes: cc44a16002 ("gitlab: add a new aarch32 custom runner definition")
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  .gitlab-ci.d/custom-runners.yml | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/.gitlab-ci.d/custom-runners.yml
> b/.gitlab-ci.d/custom-runners.yml
> index 3e76a2034a..15aaccc481 100644
> --- a/.gitlab-ci.d/custom-runners.yml
> +++ b/.gitlab-ci.d/custom-runners.yml
> @@ -16,4 +16,5 @@ variables:
>  include:
>    - local: '/.gitlab-ci.d/custom-runners/ubuntu-20.04-s390x.yml'
>    - local: '/.gitlab-ci.d/custom-runners/ubuntu-20.04-aarch64.yml'
> +  - local: '/.gitlab-ci.d/custom-runners/ubuntu-20.04-aarch32.yml'
>    - local: '/.gitlab-ci.d/custom-runners/centos-stream-8-x86_64.yml'
> --
> 2.30.2
>
>

-- 
Alex Bennée
KVM/QEMU Hacker for Linaro
[PATCH v2] gitlab: include new aarch32 job in custom-runners
Posted by Alex Bennée 3 years, 11 months ago
Without linking it in it won't be presented on the UI. Also while
doing that fix the misnamed job from 20.40 to 20.04.

Fixes: cc44a16002 ("gitlab: add a new aarch32 custom runner definition")
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

---
v2
  - argggggg!!!!!
---
 .gitlab-ci.d/custom-runners.yml                                  | 1 +
 .../{ubuntu-20.40-aarch32.yml => ubuntu-20.04-aarch32.yml}       | 0
 2 files changed, 1 insertion(+)
 rename .gitlab-ci.d/custom-runners/{ubuntu-20.40-aarch32.yml => ubuntu-20.04-aarch32.yml} (100%)

diff --git a/.gitlab-ci.d/custom-runners.yml b/.gitlab-ci.d/custom-runners.yml
index 3e76a2034a..15aaccc481 100644
--- a/.gitlab-ci.d/custom-runners.yml
+++ b/.gitlab-ci.d/custom-runners.yml
@@ -16,4 +16,5 @@ variables:
 include:
   - local: '/.gitlab-ci.d/custom-runners/ubuntu-20.04-s390x.yml'
   - local: '/.gitlab-ci.d/custom-runners/ubuntu-20.04-aarch64.yml'
+  - local: '/.gitlab-ci.d/custom-runners/ubuntu-20.04-aarch32.yml'
   - local: '/.gitlab-ci.d/custom-runners/centos-stream-8-x86_64.yml'
diff --git a/.gitlab-ci.d/custom-runners/ubuntu-20.40-aarch32.yml b/.gitlab-ci.d/custom-runners/ubuntu-20.04-aarch32.yml
similarity index 100%
rename from .gitlab-ci.d/custom-runners/ubuntu-20.40-aarch32.yml
rename to .gitlab-ci.d/custom-runners/ubuntu-20.04-aarch32.yml
-- 
2.30.2


Re: [PATCH v2] gitlab: include new aarch32 job in custom-runners
Posted by Richard Henderson 3 years, 11 months ago
On 3/15/22 05:19, Alex Bennée wrote:
> Without linking it in it won't be presented on the UI. Also while
> doing that fix the misnamed job from 20.40 to 20.04.
> 
> Fixes: cc44a16002 ("gitlab: add a new aarch32 custom runner definition")
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~

Re: [PATCH v2] gitlab: include new aarch32 job in custom-runners
Posted by Philippe Mathieu-Daudé 3 years, 11 months ago
On 15/3/22 13:19, Alex Bennée wrote:
> Without linking it in it won't be presented on the UI. Also while
> doing that fix the misnamed job from 20.40 to 20.04.
> 
> Fixes: cc44a16002 ("gitlab: add a new aarch32 custom runner definition")
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> 
> ---
> v2
>    - argggggg!!!!!
> ---
>   .gitlab-ci.d/custom-runners.yml                                  | 1 +
>   .../{ubuntu-20.40-aarch32.yml => ubuntu-20.04-aarch32.yml}       | 0
>   2 files changed, 1 insertion(+)
>   rename .gitlab-ci.d/custom-runners/{ubuntu-20.40-aarch32.yml => ubuntu-20.04-aarch32.yml} (100%)
> 
> diff --git a/.gitlab-ci.d/custom-runners.yml b/.gitlab-ci.d/custom-runners.yml
> index 3e76a2034a..15aaccc481 100644
> --- a/.gitlab-ci.d/custom-runners.yml
> +++ b/.gitlab-ci.d/custom-runners.yml
> @@ -16,4 +16,5 @@ variables:
>   include:
>     - local: '/.gitlab-ci.d/custom-runners/ubuntu-20.04-s390x.yml'
>     - local: '/.gitlab-ci.d/custom-runners/ubuntu-20.04-aarch64.yml'
> +  - local: '/.gitlab-ci.d/custom-runners/ubuntu-20.04-aarch32.yml'
>     - local: '/.gitlab-ci.d/custom-runners/centos-stream-8-x86_64.yml'
> diff --git a/.gitlab-ci.d/custom-runners/ubuntu-20.40-aarch32.yml b/.gitlab-ci.d/custom-runners/ubuntu-20.04-aarch32.yml
> similarity index 100%
> rename from .gitlab-ci.d/custom-runners/ubuntu-20.40-aarch32.yml
> rename to .gitlab-ci.d/custom-runners/ubuntu-20.04-aarch32.ym
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>