[v4] target/riscv: Initial support for the Sdtrig extension via M-mode CSRs

[PATCH v4 0/7] target/riscv: Initial support for the Sdtrig extension via M-mode CSRs

Bin Meng posted 7 patches 2 years, 1 month ago

Diff against v5
Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220315065529.62198-1-bmeng.cn@gmail.com

Maintainers: Richard Henderson <richard.henderson@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, Palmer Dabbelt <palmer@dabbelt.com>, Alistair Francis <alistair.francis@wdc.com>, Bin Meng <bin.meng@windriver.com>

There is a newer version of this series

include/hw/core/tcg-cpu-ops.h |   1 +
target/riscv/cpu.h            |   9 +-
target/riscv/debug.h          | 114 +++++++++
target/riscv/cpu.c            |  12 +
target/riscv/csr.c            |  57 +++++
target/riscv/debug.c          | 441 ++++++++++++++++++++++++++++++++++
target/riscv/machine.c        |  32 +++
target/riscv/meson.build      |   1 +
8 files changed, 666 insertions(+), 1 deletion(-)
create mode 100644 target/riscv/debug.h
create mode 100644 target/riscv/debug.c

Expand all Fold all

[PATCH v4 0/7] target/riscv: Initial support for the Sdtrig extension via M-mode CSRs

Posted by Bin Meng 2 years, 1 month ago

This adds initial support for the Sdtrig extension via the Trigger Module,
as defined in the RISC-V Debug Specification [1].

Only "Address / Data Match" trigger (type 2) is implemented as of now,
which is mainly used for hardware breakpoint and watchpoint. The number
of type 2 triggers implemented is 2, which is the number that we can
find in the SiFive U54/U74 cores.

[1] https://github.com/riscv/riscv-debug-spec/raw/master/riscv-debug-stable.pdf

Changes in v4:
- mention Sdtrig extension in the commit
- rename 'struct trigger_type2_t' to 'type2_trigger_t'
- move riscv_trigger_init() call to riscv_cpu_reset()

Changes in v3:
- drop riscv_trigger_init(), which will be moved to patch #5
- add riscv_trigger_init(), moved from patch #1 to this patch
- enable debug feature by default for all CPUs

Changes in v2:
- new patch: add debug state description
- use 0 instead of GETPC()
- change the config option to 'disabled' by default

Bin Meng (7):
  target/riscv: Add initial support for the Sdtrig extension
  target/riscv: machine: Add debug state description
  target/riscv: debug: Implement debug related TCGCPUOps
  target/riscv: cpu: Add a config option for native debug
  target/riscv: csr: Hook debug CSR read/write
  target/riscv: cpu: Enable native debug feature
  hw/core: tcg-cpu-ops.h: Update comments of debug_check_watchpoint()

 include/hw/core/tcg-cpu-ops.h |   1 +
 target/riscv/cpu.h            |   9 +-
 target/riscv/debug.h          | 114 +++++++++
 target/riscv/cpu.c            |  12 +
 target/riscv/csr.c            |  57 +++++
 target/riscv/debug.c          | 441 ++++++++++++++++++++++++++++++++++
 target/riscv/machine.c        |  32 +++
 target/riscv/meson.build      |   1 +
 8 files changed, 666 insertions(+), 1 deletion(-)
 create mode 100644 target/riscv/debug.h
 create mode 100644 target/riscv/debug.c

-- 
2.25.1

Re: [PATCH v4 0/7] target/riscv: Initial support for the Sdtrig extension via M-mode CSRs

Posted by Alistair Francis 2 years, 1 month ago

On Tue, Mar 15, 2022 at 5:17 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
>
> This adds initial support for the Sdtrig extension via the Trigger Module,
> as defined in the RISC-V Debug Specification [1].
>
> Only "Address / Data Match" trigger (type 2) is implemented as of now,
> which is mainly used for hardware breakpoint and watchpoint. The number
> of type 2 triggers implemented is 2, which is the number that we can
> find in the SiFive U54/U74 cores.
>
> [1] https://github.com/riscv/riscv-debug-spec/raw/master/riscv-debug-stable.pdf
>
> Changes in v4:
> - mention Sdtrig extension in the commit
> - rename 'struct trigger_type2_t' to 'type2_trigger_t'
> - move riscv_trigger_init() call to riscv_cpu_reset()
>
> Changes in v3:
> - drop riscv_trigger_init(), which will be moved to patch #5
> - add riscv_trigger_init(), moved from patch #1 to this patch
> - enable debug feature by default for all CPUs
>
> Changes in v2:
> - new patch: add debug state description
> - use 0 instead of GETPC()
> - change the config option to 'disabled' by default
>
> Bin Meng (7):
>   target/riscv: Add initial support for the Sdtrig extension
>   target/riscv: machine: Add debug state description
>   target/riscv: debug: Implement debug related TCGCPUOps
>   target/riscv: cpu: Add a config option for native debug
>   target/riscv: csr: Hook debug CSR read/write
>   target/riscv: cpu: Enable native debug feature
>   hw/core: tcg-cpu-ops.h: Update comments of debug_check_watchpoint()

Thanks!

Applied to riscv-to-apply.next

Alistair

>
>  include/hw/core/tcg-cpu-ops.h |   1 +
>  target/riscv/cpu.h            |   9 +-
>  target/riscv/debug.h          | 114 +++++++++
>  target/riscv/cpu.c            |  12 +
>  target/riscv/csr.c            |  57 +++++
>  target/riscv/debug.c          | 441 ++++++++++++++++++++++++++++++++++
>  target/riscv/machine.c        |  32 +++
>  target/riscv/meson.build      |   1 +
>  8 files changed, 666 insertions(+), 1 deletion(-)
>  create mode 100644 target/riscv/debug.h
>  create mode 100644 target/riscv/debug.c
>
> --
> 2.25.1
>
>