block/vmdk: Fix reopening bs->file

[PATCH for-7.0 0/2] block/vmdk: Fix reopening bs->file

Hanna Reitz posted 2 patches 2 years, 1 month ago

Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220314162719.65384-1-hreitz@redhat.com

Maintainers: Fam Zheng <fam@euphon.net>, Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>

block/vmdk.c                             | 56 ++++++++++++++-
tests/qemu-iotests/tests/reopen-file     | 88 ++++++++++++++++++++++++
tests/qemu-iotests/tests/reopen-file.out |  5 ++
3 files changed, 148 insertions(+), 1 deletion(-)
create mode 100755 tests/qemu-iotests/tests/reopen-file
create mode 100644 tests/qemu-iotests/tests/reopen-file.out

Expand all Fold all

[PATCH for-7.0 0/2] block/vmdk: Fix reopening bs->file

Posted by Hanna Reitz 2 years, 1 month ago

Hi,

A couple of months ago I noticed that changing a vmdk node’s file child
through blockdev-reopen would crash qemu.  I started writing a fix at
some point, got distracted, but now here it is.


Hanna Reitz (2):
  block/vmdk: Fix reopening bs->file
  iotests/reopen-file: Test reopening file child

 block/vmdk.c                             | 56 ++++++++++++++-
 tests/qemu-iotests/tests/reopen-file     | 88 ++++++++++++++++++++++++
 tests/qemu-iotests/tests/reopen-file.out |  5 ++
 3 files changed, 148 insertions(+), 1 deletion(-)
 create mode 100755 tests/qemu-iotests/tests/reopen-file
 create mode 100644 tests/qemu-iotests/tests/reopen-file.out

-- 
2.35.1

Re: [PATCH for-7.0 0/2] block/vmdk: Fix reopening bs->file

Posted by Kevin Wolf 2 years ago

Am 14.03.2022 um 17:27 hat Hanna Reitz geschrieben:
> Hi,
> 
> A couple of months ago I noticed that changing a vmdk node’s file child
> through blockdev-reopen would crash qemu.  I started writing a fix at
> some point, got distracted, but now here it is.

Thanks, fixed up a merge conflict with 2882ccf86a9 in the test case and
applied to the block branch.

Kevin