[PULL 00/12] dbus console fixes

marcandre.lureau@redhat.com posted 12 patches 3 years, 11 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220314125940.1866728-1-marcandre.lureau@redhat.com
Maintainers: Gerd Hoffmann <kraxel@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>
There is a newer version of this series
include/ui/console.h |  19 +++++---
ui/dbus.h            |   3 ++
ui/console.c         | 102 ++++++++++++++++++++++++++-----------------
ui/dbus-console.c    |  27 ++++++------
ui/dbus-listener.c   |  48 +++++++++-----------
ui/dbus.c            |  35 ++++++++++++++-
ui/egl-headless.c    |  17 +++++++-
ui/gtk.c             |  18 +++++++-
ui/sdl2.c            |   9 +++-
ui/shader.c          |   9 +++-
ui/spice-display.c   |   9 +++-
11 files changed, 200 insertions(+), 96 deletions(-)
[PULL 00/12] dbus console fixes
Posted by marcandre.lureau@redhat.com 3 years, 11 months ago
From: Marc-André Lureau <marcandre.lureau@redhat.com>

The following changes since commit 1416688c53be6535be755b44c15fb2eb9defd20f:

  Merge remote-tracking branch 'remotes/mcayland/tags/q800-updates-for-7.0-20220309' into staging (2022-03-10 13:16:37 +0000)

are available in the Git repository at:

  git@gitlab.com:marcandre.lureau/qemu.git tags/dbus-pull-request

for you to fetch changes up to c923967ca32600aa4e8ab817565ebf5415b4e195:

  ui/console: call gfx_switch() even if the current scanout is GL (2022-03-14 15:16:29 +0400)

----------------------------------------------------------------
GL & D-Bus display related fixes

Hi,

Here are pending fixes related to D-Bus and GL, most of them reported thanks to
Akihiko Odaki.

----------------------------------------------------------------

Marc-André Lureau (12):
  ui/console: move check for compatible GL context
  ui/console: move dcl compatiblity check to a callback
  ui/console: egl-headless is compatible with non-gl listeners
  ui/dbus: associate the DBusDisplayConsole listener with the given
    console
  ui/console: move console compatibility check to dcl_display_console()
  ui/shader: fix potential leak of shader on error
  ui/shader: free associated programs
  ui/console: add a dpy_gfx_switch callback helper
  ui/console: optionally update after gfx switch
  ui/dbus: fix texture sharing
  ui/dbus: do not send 2d scanout until gfx_update
  ui/console: call gfx_switch() even if the current scanout is GL

 include/ui/console.h |  19 +++++---
 ui/dbus.h            |   3 ++
 ui/console.c         | 102 ++++++++++++++++++++++++++-----------------
 ui/dbus-console.c    |  27 ++++++------
 ui/dbus-listener.c   |  48 +++++++++-----------
 ui/dbus.c            |  35 ++++++++++++++-
 ui/egl-headless.c    |  17 +++++++-
 ui/gtk.c             |  18 +++++++-
 ui/sdl2.c            |   9 +++-
 ui/shader.c          |   9 +++-
 ui/spice-display.c   |   9 +++-
 11 files changed, 200 insertions(+), 96 deletions(-)

-- 
2.35.1.273.ge6ebfd0e8cbb

Re: [PULL 00/12] dbus console fixes
Posted by Peter Maydell 3 years, 11 months ago
On Mon, 14 Mar 2022 at 12:59, <marcandre.lureau@redhat.com> wrote:
>
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> The following changes since commit 1416688c53be6535be755b44c15fb2eb9defd20f:
>
>   Merge remote-tracking branch 'remotes/mcayland/tags/q800-updates-for-7.0-20220309' into staging (2022-03-10 13:16:37 +0000)
>
> are available in the Git repository at:
>
>   git@gitlab.com:marcandre.lureau/qemu.git tags/dbus-pull-request
>
> for you to fetch changes up to c923967ca32600aa4e8ab817565ebf5415b4e195:
>
>   ui/console: call gfx_switch() even if the current scanout is GL (2022-03-14 15:16:29 +0400)
>
> ----------------------------------------------------------------
> GL & D-Bus display related fixes
>
> Hi,
>
> Here are pending fixes related to D-Bus and GL, most of them reported thanks to
> Akihiko Odaki.
>
> ----------------------------------------------------------------

This causes failures on the CI jobs that run check-acceptance, eg:

https://gitlab.com/qemu-project/qemu/-/jobs/2200046502
https://gitlab.com/qemu-project/qemu/-/jobs/2200046505
https://gitlab.com/qemu-project/qemu/-/jobs/2200046522

on the same pair of tests each time:

(171/183) tests/avocado/vnc.py:Vnc.test_change_password_requires_a_password:
ERROR: ConnectError: Failed to establish session: EOFError\n Exit
code: -11\n Command: ./qemu-system-x86_64 -display none -vga none
-chardev socket,id=mon,path=/var/tmp/avo_qemu_sock_fuvyei1z/qemu-1849-7fcdc8bae828-monitor.sock
-mon chardev=mon,mode=control -nodef... (0.48 s)
(172/183) tests/avocado/vnc.py:Vnc.test_change_password: ERROR:
ConnectError: Failed to establish session: EOFError\n Exit code: -11\n
Command: ./qemu-system-x86_64 -display none -vga none -chardev
socket,id=mon,path=/var/tmp/avo_qemu_sock_vk5oz22m/qemu-1855-7fcdc8babba8-monitor.sock
-mon chardev=mon,mode=control -nodef... (0.16 s)

thanks
-- PMM