ppc/xive2: Make type Xive2EndSource not user creatable

[PATCH] ppc/xive2: Make type Xive2EndSource not user creatable

Posted by Cédric Le Goater 3 years, 11 months ago

Xive2EndSource objects can only be instantiated through a Xive2Router
(PnvXive2).

Suggested-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 hw/intc/xive2.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/intc/xive2.c b/hw/intc/xive2.c
index b6452f14784b..3aff42a69ef5 100644
--- a/hw/intc/xive2.c
+++ b/hw/intc/xive2.c
@@ -1000,6 +1000,7 @@ static void xive2_end_source_class_init(ObjectClass *klass, void *data)
     dc->desc    = "XIVE END Source";
     device_class_set_props(dc, xive2_end_source_properties);
     dc->realize = xive2_end_source_realize;
+    dc->user_creatable = false;
 }
 
 static const TypeInfo xive2_end_source_info = {
-- 
2.34.1

Re: [PATCH] ppc/xive2: Make type Xive2EndSource not user creatable

Posted by Thomas Huth 3 years, 11 months ago

On 11/03/2022 08.43, Cédric Le Goater wrote:
> Xive2EndSource objects can only be instantiated through a Xive2Router
> (PnvXive2).
> 
> Suggested-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
>   hw/intc/xive2.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/hw/intc/xive2.c b/hw/intc/xive2.c
> index b6452f14784b..3aff42a69ef5 100644
> --- a/hw/intc/xive2.c
> +++ b/hw/intc/xive2.c
> @@ -1000,6 +1000,7 @@ static void xive2_end_source_class_init(ObjectClass *klass, void *data)
>       dc->desc    = "XIVE END Source";
>       device_class_set_props(dc, xive2_end_source_properties);
>       dc->realize = xive2_end_source_realize;
> +    dc->user_creatable = false;
>   }

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [PATCH] ppc/xive2: Make type Xive2EndSource not user creatable

Posted by Cédric Le Goater 3 years, 11 months ago

On 3/11/22 08:45, Thomas Huth wrote:
> On 11/03/2022 08.43, Cédric Le Goater wrote:
>> Xive2EndSource objects can only be instantiated through a Xive2Router
>> (PnvXive2).
>>
>> Suggested-by: Thomas Huth <thuth@redhat.com>
>> Signed-off-by: Cédric Le Goater <clg@kaod.org>
>> ---
>>   hw/intc/xive2.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/intc/xive2.c b/hw/intc/xive2.c
>> index b6452f14784b..3aff42a69ef5 100644
>> --- a/hw/intc/xive2.c
>> +++ b/hw/intc/xive2.c
>> @@ -1000,6 +1000,7 @@ static void xive2_end_source_class_init(ObjectClass *klass, void *data)
>>       dc->desc    = "XIVE END Source";
>>       device_class_set_props(dc, xive2_end_source_properties);
>>       dc->realize = xive2_end_source_realize;
>> +    dc->user_creatable = false;
>>   }
> 
> Reviewed-by: Thomas Huth <thuth@redhat.com>

And,

Fixes: f8a233dedf25 ("ppc/xive2: Introduce a XIVE2 core framework")

Thanks,

C.

Re: [PATCH] ppc/xive2: Make type Xive2EndSource not user creatable

Posted by Philippe Mathieu-Daudé 3 years, 11 months ago

On 11/3/22 08:43, Cédric Le Goater wrote:
> Xive2EndSource objects can only be instantiated through a Xive2Router
> (PnvXive2).
> 
> Suggested-by: Thomas Huth <thuth@redhat.com>

Reported-by?

> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
>   hw/intc/xive2.c | 1 +
>   1 file changed, 1 insertion(+)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Re: [PATCH] ppc/xive2: Make type Xive2EndSource not user creatable

Posted by Cédric Le Goater 3 years, 11 months ago

On 3/11/22 08:43, Cédric Le Goater wrote:
> Xive2EndSource objects can only be instantiated through a Xive2Router
> (PnvXive2).
> 
> Suggested-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
>   hw/intc/xive2.c | 1 +
>   1 file changed, 1 insertion(+)


Queued for 7.0

Thanks,

C.