linux-user: Fix missing space in error message

[PATCH] linux-user: Fix missing space in error message

Posted by Patrick Venture 3 years, 11 months ago

From: Fergus Henderson <fergus@google.com>

Signed-off-by: Fergus Henderson <fergus@google.com>
Signed-off-by: Patrick Venture <venture@google.com>
---
 linux-user/elfload.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index 9628a38361..c45da4d633 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -2504,7 +2504,7 @@ static void pgb_reserved_va(const char *image_name, abi_ulong guest_loaddr,
     addr = mmap(test, reserved_va, PROT_NONE, flags, -1, 0);
     if (addr == MAP_FAILED || addr != test) {
         error_report("Unable to reserve 0x%lx bytes of virtual address "
-                     "space at %p (%s) for use as guest address space (check your"
+                     "space at %p (%s) for use as guest address space (check your "
                      "virtual memory ulimit setting, min_mmap_addr or reserve less "
                      "using -R option)", reserved_va, test, strerror(errno));
         exit(EXIT_FAILURE);
-- 
2.35.1.723.g4982287a31-goog

Re: [PATCH] linux-user: Fix missing space in error message

Posted by Peter Maydell 3 years, 11 months ago

On Thu, 10 Mar 2022 at 19:29, Patrick Venture <venture@google.com> wrote:
>
> From: Fergus Henderson <fergus@google.com>
>
> Signed-off-by: Fergus Henderson <fergus@google.com>
> Signed-off-by: Patrick Venture <venture@google.com>
> ---
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM

Re: [PATCH-for-7.0] linux-user: Fix missing space in error message

Posted by Philippe Mathieu-Daudé 3 years, 11 months ago

On 10/3/22 20:21, Patrick Venture wrote:
> From: Fergus Henderson <fergus@google.com>
> 
> Signed-off-by: Fergus Henderson <fergus@google.com>
> Signed-off-by: Patrick Venture <venture@google.com>
> ---
>   linux-user/elfload.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/linux-user/elfload.c b/linux-user/elfload.c
> index 9628a38361..c45da4d633 100644
> --- a/linux-user/elfload.c
> +++ b/linux-user/elfload.c
> @@ -2504,7 +2504,7 @@ static void pgb_reserved_va(const char *image_name, abi_ulong guest_loaddr,
>       addr = mmap(test, reserved_va, PROT_NONE, flags, -1, 0);
>       if (addr == MAP_FAILED || addr != test) {
>           error_report("Unable to reserve 0x%lx bytes of virtual address "
> -                     "space at %p (%s) for use as guest address space (check your"
> +                     "space at %p (%s) for use as guest address space (check your "
>                        "virtual memory ulimit setting, min_mmap_addr or reserve less "
>                        "using -R option)", reserved_va, test, strerror(errno));
>           exit(EXIT_FAILURE);

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Re: [PATCH] linux-user: Fix missing space in error message

Posted by Laurent Vivier 3 years, 10 months ago

Le 10/03/2022 à 20:21, Patrick Venture a écrit :
> From: Fergus Henderson <fergus@google.com>
> 
> Signed-off-by: Fergus Henderson <fergus@google.com>
> Signed-off-by: Patrick Venture <venture@google.com>
> ---
>   linux-user/elfload.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/linux-user/elfload.c b/linux-user/elfload.c
> index 9628a38361..c45da4d633 100644
> --- a/linux-user/elfload.c
> +++ b/linux-user/elfload.c
> @@ -2504,7 +2504,7 @@ static void pgb_reserved_va(const char *image_name, abi_ulong guest_loaddr,
>       addr = mmap(test, reserved_va, PROT_NONE, flags, -1, 0);
>       if (addr == MAP_FAILED || addr != test) {
>           error_report("Unable to reserve 0x%lx bytes of virtual address "
> -                     "space at %p (%s) for use as guest address space (check your"
> +                     "space at %p (%s) for use as guest address space (check your "
>                        "virtual memory ulimit setting, min_mmap_addr or reserve less "
>                        "using -R option)", reserved_va, test, strerror(errno));
>           exit(EXIT_FAILURE);


Applied to my linux-user-for-7.0 branch.

Thanks,
Laurent