1. Patchew
  2. QEMU
  3. View series

[PULL 00/12] Hexagon (target/hexagon) queue

Taylor Simpson posted 12 patches 2 years, 1 month ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220308215435.21806-1-tsimpson@quicinc.com
Maintainers: Taylor Simpson <tsimpson@quicinc.com>
There is a newer version of this series
target/hexagon/fma_emu.h          |    6 +-
target/hexagon/macros.h           |    4 +-
target/hexagon/mmvec/macros.h     |    6 +-
target/hexagon/arch.c             |    6 +-
target/hexagon/genptr.c           |   14 +-
target/hexagon/op_helper.c        |   28 +-
tests/tcg/hexagon/circ.c          |    5 +-
tests/tcg/hexagon/fpstuff.c       |  123 +++-
tests/tcg/hexagon/hvx_misc.c      |   71 ++-
tests/tcg/hexagon/overflow.c      |   61 +-
tests/tcg/hexagon/preg_alias.c    |   84 ++-
tests/tcg/hexagon/usr.c           | 1141 +++++++++++++++++++++++++++++++++++++
tests/tcg/hexagon/Makefile.target |    8 +-
13 files changed, 1474 insertions(+), 83 deletions(-)
create mode 100644 tests/tcg/hexagon/usr.c
[PULL 00/12] Hexagon (target/hexagon) queue
Posted by Taylor Simpson 2 years, 1 month ago 
The following changes since commit 33d102e92e41a65c817d85ff8bfd5ffa2c16b1d3:

  Merge remote-tracking branch 'remotes/kraxel/tags/seabios-20220307-pull-request' into staging (2022-03-08 12:40:58 +0000)

are available in the Git repository at:

  https://github.com/quic/qemu tags/pull-hex-20220308

for you to fetch changes up to ebbf0ee1335548fe9b42fcd1ff031aea2d27cc1a:

  target/hexagon: remove unused variable (2022-03-08 13:27:00 -0800)

----------------------------------------------------------------
Hexagon bug fixes and additional tests

Also includes a patch from Zongyuan Li <zongyuan.li@smartx.com>
to remove an unused variable

----------------------------------------------------------------
Michael Lambert (1):
      Hexagon (target/hexagon) fix bug in circular addressing

Taylor Simpson (10):
      Hexagon HVX (target/hexagon) fix bug in HVX saturate instructions
      Hexagon (target/hexagon) properly set FPINVF bit in sfcmp.uo and dfcmp.uo
      Hexagon (target/hexagon) properly handle denorm in arch_sf_recip_common
      Hexagon (target/hexagon) properly handle NaN in dfmin/dfmax/sfmin/sfmax
      Hexagon (tests/tcg/hexagon) test instructions that might set bits in USR
      Hexagon (tests/tcg/hexagon) add floating point instructions to usr.c
      Hexagon (tests/tcg/hexagon) update overflow test
      Hexagon (tests/tcg/hexagon) fix inline asm in preg_alias.c
      Hexagon (target/hexagon) fix bug in conv_df2uw_chop
      Hexagon (target/hexagon) assignment to c4 should wait until packet commit

Zongyuan Li (1):
      target/hexagon: remove unused variable

 target/hexagon/fma_emu.h          |    6 +-
 target/hexagon/macros.h           |    4 +-
 target/hexagon/mmvec/macros.h     |    6 +-
 target/hexagon/arch.c             |    6 +-
 target/hexagon/genptr.c           |   14 +-
 target/hexagon/op_helper.c        |   28 +-
 tests/tcg/hexagon/circ.c          |    5 +-
 tests/tcg/hexagon/fpstuff.c       |  123 +++-
 tests/tcg/hexagon/hvx_misc.c      |   71 ++-
 tests/tcg/hexagon/overflow.c      |   61 +-
 tests/tcg/hexagon/preg_alias.c    |   84 ++-
 tests/tcg/hexagon/usr.c           | 1141 +++++++++++++++++++++++++++++++++++++
 tests/tcg/hexagon/Makefile.target |    8 +-
 13 files changed, 1474 insertions(+), 83 deletions(-)
 create mode 100644 tests/tcg/hexagon/usr.c
Re: [PULL 00/12] Hexagon (target/hexagon) queue
Posted by Peter Maydell 2 years, 1 month ago 
On Tue, 8 Mar 2022 at 21:55, Taylor Simpson <tsimpson@quicinc.com> wrote:
>
> The following changes since commit 33d102e92e41a65c817d85ff8bfd5ffa2c16b1d3:
>
>   Merge remote-tracking branch 'remotes/kraxel/tags/seabios-20220307-pull-request' into staging (2022-03-08 12:40:58 +0000)
>
> are available in the Git repository at:
>
>   https://github.com/quic/qemu tags/pull-hex-20220308
>
> for you to fetch changes up to ebbf0ee1335548fe9b42fcd1ff031aea2d27cc1a:
>
>   target/hexagon: remove unused variable (2022-03-08 13:27:00 -0800)
>
> ----------------------------------------------------------------
> Hexagon bug fixes and additional tests
>
> Also includes a patch from Zongyuan Li <zongyuan.li@smartx.com>
> to remove an unused variable
>

This fails the build-user-hexagon CI job:
https://gitlab.com/qemu-project/qemu/-/jobs/2187325916

BUILD hexagon-linux-user guest-tests with hexagon-unknown-linux-musl-clang
/builds/qemu-project/qemu/tests/tcg/hexagon/preg_alias.c:68:9: error:
unknown register name 'c4' in asm
: "c4", "p0", "p1", "p2", "p3");
^
/builds/qemu-project/qemu/tests/tcg/hexagon/preg_alias.c:95:10: error:
unknown register name 'c4' in asm
: "c4", "c5", "p0", "p1", "p2", "p3");
^
/builds/qemu-project/qemu/tests/tcg/hexagon/preg_alias.c:120:12:
error: unknown register name 'c4' in asm
: "c4", "p0", "p1", "p2", "p3");
^
/builds/qemu-project/qemu/tests/tcg/hexagon/preg_alias.c:132:12:
error: unknown register name 'c4' in asm
: "c4", "p0", "p1", "p2", "p3", "memory");
^
4 errors generated.
make[2]: *** [../Makefile.target:108: preg_alias] Error 1

-- PMM
RE: [PULL 00/12] Hexagon (target/hexagon) queue
Posted by Taylor Simpson 2 years, 1 month ago 
My apologies.  I'll investigate the mismatch between the toolchain I'm using and the one CI is using.



> -----Original Message-----
> From: Peter Maydell <peter.maydell@linaro.org>
> Sent: Thursday, March 10, 2022 7:16 AM
> To: Taylor Simpson <tsimpson@quicinc.com>
> Cc: qemu-devel@nongnu.org; richard.henderson@linaro.org;
> f4bug@amsat.org; zongyuan.li@smartx.com
> Subject: Re: [PULL 00/12] Hexagon (target/hexagon) queue
> 
> WARNING: This email originated from outside of Qualcomm. Please be wary
> of any links or attachments, and do not enable macros.
> 
> On Tue, 8 Mar 2022 at 21:55, Taylor Simpson <tsimpson@quicinc.com> wrote:
> >
> > The following changes since commit
> 33d102e92e41a65c817d85ff8bfd5ffa2c16b1d3:
> >
> >   Merge remote-tracking branch
> > 'remotes/kraxel/tags/seabios-20220307-pull-request' into staging
> > (2022-03-08 12:40:58 +0000)
> >
> > are available in the Git repository at:
> >
> >   https://github.com/quic/qemu tags/pull-hex-20220308
> >
> > for you to fetch changes up to
> ebbf0ee1335548fe9b42fcd1ff031aea2d27cc1a:
> >
> >   target/hexagon: remove unused variable (2022-03-08 13:27:00 -0800)
> >
> > ----------------------------------------------------------------
> > Hexagon bug fixes and additional tests
> >
> > Also includes a patch from Zongyuan Li <zongyuan.li@smartx.com> to
> > remove an unused variable
> >
> 
> This fails the build-user-hexagon CI job:
> https://gitlab.com/qemu-project/qemu/-/jobs/2187325916
> 
> BUILD hexagon-linux-user guest-tests with hexagon-unknown-linux-musl-
> clang
> /builds/qemu-project/qemu/tests/tcg/hexagon/preg_alias.c:68:9: error:
> unknown register name 'c4' in asm
> : "c4", "p0", "p1", "p2", "p3");
> ^
> /builds/qemu-project/qemu/tests/tcg/hexagon/preg_alias.c:95:10: error:
> unknown register name 'c4' in asm
> : "c4", "c5", "p0", "p1", "p2", "p3");
> ^
> /builds/qemu-project/qemu/tests/tcg/hexagon/preg_alias.c:120:12:
> error: unknown register name 'c4' in asm
> : "c4", "p0", "p1", "p2", "p3");
> ^
> /builds/qemu-project/qemu/tests/tcg/hexagon/preg_alias.c:132:12:
> error: unknown register name 'c4' in asm
> : "c4", "p0", "p1", "p2", "p3", "memory"); ^
> 4 errors generated.
> make[2]: *** [../Makefile.target:108: preg_alias] Error 1
> 
> -- PMM
Re: [PULL 00/12] Hexagon (target/hexagon) queue
Posted by Alex Bennée 2 years, 1 month ago 
Taylor Simpson <tsimpson@quicinc.com> writes:

> My apologies.  I'll investigate the mismatch between the toolchain I'm
> using and the one CI is using.

I don't recall seeing a new binary docker since the previous one had ABI
issues with signal handling.

-- 
Alex Bennée

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.