Series comparison

-[PULL 00/18] target-arm queue
+[Qemu-devel] [PULL v2 00/25] target-arm queue
-Last lot of target-arm stuff: cleanups, bug fixes; nothing major here.
+Dropped the tmp421 patch and the following patch that
 depended on it; no other changes.
+thanks
 -- PMM
-The following changes since commit 9d662a6b22a0838a85c5432385f35db2488a33a5:
+The following changes since commit 43771d5d92312504305c19abe29ec5bfabd55f01:
-  Merge remote-tracking branch 'remotes/legoater/tags/pull-ppc-20220305' into staging (2022-03-05 18:03:15 +0000)
+  Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2017-05-31' into staging (2017-06-01 16:39:16 +0100)
-are available in the Git repository at:
+are available in the git repository at:
-  https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20220307
+  git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20170602
-for you to fetch changes up to 0942820408dc788560f6968e9b5f011803b846c2:
+for you to fetch changes up to c7637c04be257968e6df30de961a6a23a0ac3dd8:
-  hw/arm/virt: Disable LPA2 for -machine virt-6.2 (2022-03-07 14:32:21 +0000)
+  hw/arm/virt: fdt: generate distance-map when needed (2017-06-02 11:51:49 +0100)
 ----------------------------------------------------------------
 target-arm queue:
- * cleanups of qemu_oom_check() and qemu_memalign()
+ * virt: numa: provide ACPI distance info when needed
- * target/arm/translate-neon: UNDEF if VLD1/VST1 stride bits are non-zero
+ * aspeed: fix i2c controller bugs
- * target/arm/translate-neon: Simplify align field check for VLD3
+ * M profile: support MPU
- * GICv3 ITS: add more trace events
+ * gicv3: fix mishandling of BPR1, VBPR1
- * GICv3 ITS: implement 8-byte accesses properly
+ * load_uboot_image: don't assume a full header read
- * GICv3: fix minor issues with some trace/log messages
+ * libvixl: Correct build failures on NetBSD
  * ui/cocoa: Use the standard about panel
  * target/arm: Provide cpu property for controling FEAT_LPA2
  * hw/arm/virt: Disable LPA2 for -machine virt-6.2
 ----------------------------------------------------------------
-Akihiko Odaki (1):
+Andrew Jones (3):
-      ui/cocoa: Use the standard about panel
+      load_uboot_image: don't assume a full header read
       hw/arm/virt-acpi-build: build SLIT when needed
       hw/arm/virt: fdt: generate distance-map when needed
-Peter Maydell (15):
+Cédric Le Goater (4):
-      util: Make qemu_oom_check() a static function
+      aspeed/i2c: improve command handling
-      util: Unify implementations of qemu_memalign()
+      aspeed/i2c: handle LAST command under the RX command
-      util: Return valid allocation for qemu_try_memalign() with zero size
+      aspeed/i2c: introduce a state machine
-      meson.build: Don't misdetect posix_memalign() on Windows
+      aspeed: add some I2C devices to the Aspeed machines
       util: Share qemu_try_memalign() implementation between POSIX and Windows
       util: Use meson checks for valloc() and memalign() presence
       util: Put qemu_vfree() in memalign.c
       osdep: Move memalign-related functions to their own header
       target/arm/translate-neon: UNDEF if VLD1/VST1 stride bits are non-zero
       target/arm/translate-neon: Simplify align field check for VLD3
       hw/intc/arm_gicv3_its: Add trace events for commands
       hw/intc/arm_gicv3_its: Add trace events for table reads and writes
       hw/intc/arm_gicv3: Specify valid and impl in MemoryRegionOps
       hw/intc/arm_gicv3: Fix missing spaces in error log messages
       hw/intc/arm_gicv3_cpuif: Fix register names in ICV_HPPIR read trace event
-Richard Henderson (2):
+Kamil Rytarowski (1):
-      target/arm: Provide cpu property for controling FEAT_LPA2
+      libvixl: Correct build failures on NetBSD
       hw/arm/virt: Disable LPA2 for -machine virt-6.2
- meson.build                    |   7 ++-
+Michael Davidsaver (4):
- include/hw/arm/virt.h          |   1 +
+      armv7m: Improve "-d mmu" tracing for PMSAv7 MPU
- include/qemu-common.h          |   2 -
+      armv7m: Implement M profile default memory map
- include/qemu/memalign.h        |  61 ++++++++++++++++++++++
+      armv7m: Classify faults as MemManage or BusFault
- include/qemu/osdep.h           |  18 -------
+      arm: add MPU support to M profile CPUs
- target/arm/cpu.h               |   5 +-
- block/blkverify.c              |   1 +
+Peter Maydell (12):
- block/block-copy.c             |   1 +
+      hw/intc/arm_gicv3_cpuif: Fix reset value for VMCR_EL2.VBPR1
- block/commit.c                 |   1 +
+      hw/intc/arm_gicv3_cpuif: Don't let BPR be set below its minimum
- block/crypto.c                 |   1 +
+      hw/intc/arm_gicv3_cpuif: Fix priority masking for NS BPR1
- block/dmg.c                    |   1 +
+      arm: Use the mmu_idx we're passed in arm_cpu_do_unaligned_access()
- block/export/fuse.c            |   1 +
+      arm: Add support for M profile CPUs having different MMU index semantics
- block/file-posix.c             |   1 +
+      arm: Use different ARMMMUIdx values for M profile
- block/io.c                     |   1 +
+      arm: Clean up handling of no-MPU PMSA CPUs
- block/mirror.c                 |   1 +
+      arm: Don't clear ARM_FEATURE_PMSA for no-mpu configs
- block/nvme.c                   |   1 +
+      arm: Don't let no-MPU PMSA cores write to SCTLR.M
- block/parallels-ext.c          |   1 +
+      arm: Remove unnecessary check on cpu->pmsav7_dregion
- block/parallels.c              |   1 +
+      arm: All M profile cores are PMSA
- block/qcow.c                   |   1 +
+      arm: Implement HFNMIENA support for M profile MPU
- block/qcow2-cache.c            |   1 +
- block/qcow2-cluster.c          |   1 +
+Wei Huang (1):
- block/qcow2-refcount.c         |   1 +
+      target/arm: clear PMUVER field of AA64DFR0 when vPMU=off
- block/qcow2-snapshot.c         |   1 +
- block/qcow2.c                  |   1 +
+ disas/libvixl/Makefile.objs |   3 +
- block/qed-l2-cache.c           |   1 +
+ target/arm/cpu.h            | 118 ++++++++++++++--
- block/qed-table.c              |   1 +
+ target/arm/translate.h      |   2 +-
- block/qed.c                    |   1 +
+ hw/arm/aspeed.c             |  27 ++++
- block/quorum.c                 |   1 +
+ hw/arm/virt-acpi-build.c    |   4 +
- block/raw-format.c             |   1 +
+ hw/arm/virt.c               |  21 +++
- block/vdi.c                    |   1 +
+ hw/core/loader.c            |   3 +-
- block/vhdx-log.c               |   1 +
+ hw/i2c/aspeed_i2c.c         |  65 +++++++--
- block/vhdx.c                   |   1 +
+ hw/intc/arm_gicv3_cpuif.c   |  50 ++++++-
- block/vmdk.c                   |   1 +
+ hw/intc/armv7m_nvic.c       | 104 ++++++++++++++
- block/vpc.c                    |   1 +
+ target/arm/cpu.c            |  28 +++-
- block/win32-aio.c              |   1 +
+ target/arm/helper.c         | 338 ++++++++++++++++++++++++++++++--------------
- hw/arm/virt.c                  |   7 +++
+ target/arm/machine.c        |   7 +-
- hw/block/dataplane/xen-block.c |   1 +
+ target/arm/op_helper.c      |   3 +-
- hw/block/fdc.c                 |   1 +
+ target/arm/translate-a64.c  |  18 ++-
- hw/ide/core.c                  |   1 +
+ target/arm/translate.c      |  14 +-
- hw/intc/arm_gicv3.c            |   8 +++
+files changed, 648 insertions(+), 157 deletions(-)
- hw/intc/arm_gicv3_cpuif.c      |   3 +-
  hw/intc/arm_gicv3_dist.c       |   4 +-
  hw/intc/arm_gicv3_its.c        |  69 +++++++++++++++++++++----
  hw/ppc/spapr.c                 |   1 +
  hw/ppc/spapr_softmmu.c         |   1 +
  hw/scsi/scsi-disk.c            |   1 +
  hw/tpm/tpm_ppi.c               |   2 +-
  nbd/server.c                   |   1 +
  net/l2tpv3.c                   |   2 +-
  plugins/loader.c               |   1 +
  qemu-img.c                     |   1 +
  qemu-io-cmds.c                 |   1 +
  qom/object.c                   |   1 +
  softmmu/physmem.c              |   1 +
  target/arm/cpu.c               |   6 +++
  target/arm/cpu64.c             |  24 +++++++++
  target/arm/translate-neon.c    |  13 +++--
  target/i386/hvf/hvf.c          |   1 +
  target/i386/kvm/kvm.c          |   1 +
  tcg/region.c                   |   1 +
  tests/bench/atomic_add-bench.c |   1 +
  tests/bench/qht-bench.c        |   1 +
  util/atomic64.c                |   1 +
  util/memalign.c                |  92 +++++++++++++++++++++++++++++++++
  util/oslib-posix.c             |  46 -----------------
  util/oslib-win32.c             |  35 -------------
  util/qht.c                     |   1 +
  hw/intc/trace-events           |  21 ++++++++
  tests/avocado/boot_linux.py    |   2 +
  ui/cocoa.m                     | 112 +++++++++--------------------------------
  util/meson.build               |   1 +
 files changed, 377 insertions(+), 212 deletions(-)
  create mode 100644 include/qemu/memalign.h
  create mode 100644 util/memalign.c

-[PULL 01/18] util: Make qemu_oom_check() a static function
+Deleted patch
-The qemu_oom_check() function, which we define in both oslib-posix.c
-and oslib-win32.c, is now used only locally in that file; make it
-static.
-Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
-Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
-Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
-Message-id: 20220226180723.1706285-3-peter.maydell@linaro.org
----
- include/qemu-common.h | 2 --
- util/oslib-posix.c    | 2 +-
- util/oslib-win32.c    | 2 +-
-files changed, 2 insertions(+), 4 deletions(-)
-diff --git a/include/qemu-common.h b/include/qemu-common.h
-index XXXXXXX..XXXXXXX 100644
---- a/include/qemu-common.h
-+++ b/include/qemu-common.h
-@@ -XXX,XX +XXX,XX @@
- int qemu_main(int argc, char **argv, char **envp);
- #endif
--void *qemu_oom_check(void *ptr);
--
- ssize_t qemu_write_full(int fd, const void *buf, size_t count)
-     QEMU_WARN_UNUSED_RESULT;
-diff --git a/util/oslib-posix.c b/util/oslib-posix.c
-index XXXXXXX..XXXXXXX 100644
---- a/util/oslib-posix.c
-+++ b/util/oslib-posix.c
-@@ -XXX,XX +XXX,XX @@ fail_close:
-     return false;
- }
--void *qemu_oom_check(void *ptr)
-+static void *qemu_oom_check(void *ptr)
- {
-     if (ptr == NULL) {
-         fprintf(stderr, "Failed to allocate memory: %s\n", strerror(errno));
-diff --git a/util/oslib-win32.c b/util/oslib-win32.c
-index XXXXXXX..XXXXXXX 100644
---- a/util/oslib-win32.c
-+++ b/util/oslib-win32.c
-@@ -XXX,XX +XXX,XX @@
- /* this must come after including "trace.h" */
- #include <shlobj.h>
--void *qemu_oom_check(void *ptr)
-+static void *qemu_oom_check(void *ptr)
- {
-     if (ptr == NULL) {
-         fprintf(stderr, "Failed to allocate memory: %lu\n", GetLastError());
---
-.25.1

-[PULL 02/18] util: Unify implementations of qemu_memalign()
+Deleted patch
-We implement qemu_memalign() in both oslib-posix.c and oslib-win32.c,
-but the two versions are essentially the same: they call
-qemu_try_memalign(), and abort() after printing an error message if
-it fails.  The only difference is that the win32 version prints the
-GetLastError() value whereas the POSIX version prints
-strerror(errno).  However, this is a bug in the win32 version: in
-commit dfbd0b873a85021 in 2020 we changed the implementation of
-qemu_try_memalign() from using VirtualAlloc() (which sets the
-GetLastError() value) to using _aligned_malloc() (which sets errno),
-but didn't update the error message to match.
-Replace the two separate functions with a single version in a
-new memalign.c file, which drops the unnecessary extra qemu_oom_check()
-function and instead prints a more useful message including the
-requested size and alignment as well as the errno string.
-Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
-Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
-Message-id: 20220226180723.1706285-4-peter.maydell@linaro.org
-Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
----
- util/memalign.c    | 39 +++++++++++++++++++++++++++++++++++++++
- util/oslib-posix.c | 14 --------------
- util/oslib-win32.c | 14 --------------
- util/meson.build   |  1 +
-files changed, 40 insertions(+), 28 deletions(-)
- create mode 100644 util/memalign.c
-diff --git a/util/memalign.c b/util/memalign.c
-new file mode 100644
-index XXXXXXX..XXXXXXX
---- /dev/null
-+++ b/util/memalign.c
-@@ -XXX,XX +XXX,XX @@
-+/*
-+ * memalign.c: Allocate an aligned memory region
-+ *
-+ * Copyright (c) 2003-2008 Fabrice Bellard
-+ * Copyright (c) 2010-2016 Red Hat, Inc.
-+ * Copyright (c) 2022 Linaro Ltd
-+ *
-+ * Permission is hereby granted, free of charge, to any person obtaining a copy
-+ * of this software and associated documentation files (the "Software"), to deal
-+ * in the Software without restriction, including without limitation the rights
-+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-+ * copies of the Software, and to permit persons to whom the Software is
-+ * furnished to do so, subject to the following conditions:
-+ *
-+ * The above copyright notice and this permission notice shall be included in
-+ * all copies or substantial portions of the Software.
-+ *
-+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
-+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
-+ * THE SOFTWARE.
-+ */
-+
-+#include "qemu/osdep.h"
-+
-+void *qemu_memalign(size_t alignment, size_t size)
-+{
-+    void *p = qemu_try_memalign(alignment, size);
-+    if (p) {
-+        return p;
-+    }
-+    fprintf(stderr,
-+            "qemu_memalign: failed to allocate %zu bytes at alignment %zu: %s\n",
-+            size, alignment, strerror(errno));
-+    abort();
-+}
-diff --git a/util/oslib-posix.c b/util/oslib-posix.c
-index XXXXXXX..XXXXXXX 100644
---- a/util/oslib-posix.c
-+++ b/util/oslib-posix.c
-@@ -XXX,XX +XXX,XX @@ fail_close:
-     return false;
- }
--static void *qemu_oom_check(void *ptr)
--{
--    if (ptr == NULL) {
--        fprintf(stderr, "Failed to allocate memory: %s\n", strerror(errno));
--        abort();
--    }
--    return ptr;
--}
--
- void *qemu_try_memalign(size_t alignment, size_t size)
- {
-     void *ptr;
-@@ -XXX,XX +XXX,XX @@ void *qemu_try_memalign(size_t alignment, size_t size)
-     return ptr;
- }
--void *qemu_memalign(size_t alignment, size_t size)
--{
--    return qemu_oom_check(qemu_try_memalign(alignment, size));
--}
--
- /* alloc shared memory pages */
- void *qemu_anon_ram_alloc(size_t size, uint64_t *alignment, bool shared,
-                           bool noreserve)
-diff --git a/util/oslib-win32.c b/util/oslib-win32.c
-index XXXXXXX..XXXXXXX 100644
---- a/util/oslib-win32.c
-+++ b/util/oslib-win32.c
-@@ -XXX,XX +XXX,XX @@
- /* this must come after including "trace.h" */
- #include <shlobj.h>
--static void *qemu_oom_check(void *ptr)
--{
--    if (ptr == NULL) {
--        fprintf(stderr, "Failed to allocate memory: %lu\n", GetLastError());
--        abort();
--    }
--    return ptr;
--}
--
- void *qemu_try_memalign(size_t alignment, size_t size)
- {
-     void *ptr;
-@@ -XXX,XX +XXX,XX @@ void *qemu_try_memalign(size_t alignment, size_t size)
-     return ptr;
- }
--void *qemu_memalign(size_t alignment, size_t size)
--{
--    return qemu_oom_check(qemu_try_memalign(alignment, size));
--}
--
- static int get_allocation_granularity(void)
- {
-     SYSTEM_INFO system_info;
-diff --git a/util/meson.build b/util/meson.build
-index XXXXXXX..XXXXXXX 100644
---- a/util/meson.build
-+++ b/util/meson.build
-@@ -XXX,XX +XXX,XX @@ util_ss.add(when: 'CONFIG_POSIX', if_true: files('drm.c'))
- util_ss.add(files('guest-random.c'))
- util_ss.add(files('yank.c'))
- util_ss.add(files('int128.c'))
-+util_ss.add(files('memalign.c'))
- if have_user
-   util_ss.add(files('selfmap.c'))
---
-.25.1

-[PULL 03/18] util: Return valid allocation for qemu_try_memalign() with zero size
+Deleted patch
-Currently qemu_try_memalign()'s behaviour if asked to allocate
-bytes is rather variable:
- * on Windows, we will assert
- * on POSIX platforms, we get the underlying behaviour of
-   the posix_memalign() or equivalent function, which may be
-   either "return a valid non-NULL pointer" or "return NULL"
-Explictly check for 0 byte allocations, so we get consistent
-behaviour across platforms.  We handle them by incrementing the size
-so that we return a valid non-NULL pointer that can later be passed
-to qemu_vfree().  This is permitted behaviour for the
-posix_memalign() API and is the most usual way that underlying
-malloc() etc implementations handle a zero-sized allocation request,
-because it won't trip up calling code that assumes NULL means an
-error.  (This includes our own qemu_memalign(), which will abort on
-NULL.)
-This change is a preparation for sharing the qemu_try_memalign() code
-between Windows and POSIX.
-Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
-Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
-Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
----
- util/oslib-posix.c | 3 +++
- util/oslib-win32.c | 4 +++-
-files changed, 6 insertions(+), 1 deletion(-)
-diff --git a/util/oslib-posix.c b/util/oslib-posix.c
-index XXXXXXX..XXXXXXX 100644
---- a/util/oslib-posix.c
-+++ b/util/oslib-posix.c
-@@ -XXX,XX +XXX,XX @@ void *qemu_try_memalign(size_t alignment, size_t size)
-         g_assert(is_power_of_2(alignment));
-     }
-+    if (size == 0) {
-+        size++;
-+    }
- #if defined(CONFIG_POSIX_MEMALIGN)
-     int ret;
-     ret = posix_memalign(&ptr, alignment, size);
-diff --git a/util/oslib-win32.c b/util/oslib-win32.c
-index XXXXXXX..XXXXXXX 100644
---- a/util/oslib-win32.c
-+++ b/util/oslib-win32.c
-@@ -XXX,XX +XXX,XX @@ void *qemu_try_memalign(size_t alignment, size_t size)
- {
-     void *ptr;
--    g_assert(size != 0);
-     if (alignment < sizeof(void *)) {
-         alignment = sizeof(void *);
-     } else {
-         g_assert(is_power_of_2(alignment));
-     }
-+    if (size == 0) {
-+        size++;
-+    }
-     ptr = _aligned_malloc(size, alignment);
-     trace_qemu_memalign(alignment, size, ptr);
-     return ptr;
---
-.25.1

-[PULL 04/18] meson.build: Don't misdetect posix_memalign() on Windows
+Deleted patch
-Currently we incorrectly think that posix_memalign() exists on
-Windows.  This is because of a combination of:
- * the msys2/mingw toolchain/libc claim to have a
-   __builtin_posix_memalign when there isn't a builtin of that name
- * meson will assume that if you have a __builtin_foo that
-   counts for has_function('foo')
-Specifying a specific include file via prefix: causes meson to not
-treat builtins as sufficient and actually look for the function
-itself; see this meson pull request which added that as the official
-way to get the right answer:
-  https://github.com/mesonbuild/meson/pull/1150
-Currently this misdectection doesn't cause problems because we only
-use CONFIG_POSIX_MEMALIGN in oslib-posix.c; however that will change
-in a following commit.
-Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
-Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
-Message-id: 20220226180723.1706285-6-peter.maydell@linaro.org
-Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
----
- meson.build | 4 +++-
-file changed, 3 insertions(+), 1 deletion(-)
-diff --git a/meson.build b/meson.build
-index XXXXXXX..XXXXXXX 100644
---- a/meson.build
-+++ b/meson.build
-@@ -XXX,XX +XXX,XX @@ config_host_data.set('CONFIG_CLOCK_ADJTIME', cc.has_function('clock_adjtime'))
- config_host_data.set('CONFIG_DUP3', cc.has_function('dup3'))
- config_host_data.set('CONFIG_FALLOCATE', cc.has_function('fallocate'))
- config_host_data.set('CONFIG_POSIX_FALLOCATE', cc.has_function('posix_fallocate'))
--config_host_data.set('CONFIG_POSIX_MEMALIGN', cc.has_function('posix_memalign'))
-+# Note that we need to specify prefix: here to avoid incorrectly
-+# thinking that Windows has posix_memalign()
-+config_host_data.set('CONFIG_POSIX_MEMALIGN', cc.has_function('posix_memalign', prefix: '#include <stdlib.h>'))
- config_host_data.set('CONFIG_PPOLL', cc.has_function('ppoll'))
- config_host_data.set('CONFIG_PREADV', cc.has_function('preadv', prefix: '#include <sys/uio.h>'))
- config_host_data.set('CONFIG_SEM_TIMEDWAIT', cc.has_function('sem_timedwait', dependencies: threads))
---
-.25.1

-[PULL 05/18] util: Share qemu_try_memalign() implementation between POSIX and Windows
+Deleted patch
-The qemu_try_memalign() functions for POSIX and Windows used to be
-significantly different, but these days they are identical except for
-the actual allocation function called, and the POSIX version already
-has to have ifdeffery for different allocation functions.
-Move to a single implementation in memalign.c, which uses the Windows
-_aligned_malloc if we detect that function in meson.
-Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
-Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
-Message-id: 20220226180723.1706285-7-peter.maydell@linaro.org
-Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
----
- meson.build        |  1 +
- util/memalign.c    | 39 +++++++++++++++++++++++++++++++++++++++
- util/oslib-posix.c | 29 -----------------------------
- util/oslib-win32.c | 17 -----------------
-files changed, 40 insertions(+), 46 deletions(-)
-diff --git a/meson.build b/meson.build
-index XXXXXXX..XXXXXXX 100644
---- a/meson.build
-+++ b/meson.build
-@@ -XXX,XX +XXX,XX @@ config_host_data.set('CONFIG_POSIX_FALLOCATE', cc.has_function('posix_fallocate'
- # Note that we need to specify prefix: here to avoid incorrectly
- # thinking that Windows has posix_memalign()
- config_host_data.set('CONFIG_POSIX_MEMALIGN', cc.has_function('posix_memalign', prefix: '#include <stdlib.h>'))
-+config_host_data.set('CONFIG_ALIGNED_MALLOC', cc.has_function('_aligned_malloc'))
- config_host_data.set('CONFIG_PPOLL', cc.has_function('ppoll'))
- config_host_data.set('CONFIG_PREADV', cc.has_function('preadv', prefix: '#include <sys/uio.h>'))
- config_host_data.set('CONFIG_SEM_TIMEDWAIT', cc.has_function('sem_timedwait', dependencies: threads))
-diff --git a/util/memalign.c b/util/memalign.c
-index XXXXXXX..XXXXXXX 100644
---- a/util/memalign.c
-+++ b/util/memalign.c
-@@ -XXX,XX +XXX,XX @@
-  */
- #include "qemu/osdep.h"
-+#include "qemu/host-utils.h"
-+#include "trace.h"
-+
-+void *qemu_try_memalign(size_t alignment, size_t size)
-+{
-+    void *ptr;
-+
-+    if (alignment < sizeof(void*)) {
-+        alignment = sizeof(void*);
-+    } else {
-+        g_assert(is_power_of_2(alignment));
-+    }
-+
-+    /*
-+     * Handling of 0 allocations varies among the different
-+     * platform APIs (for instance _aligned_malloc() will
-+     * fail) -- ensure that we always return a valid non-NULL
-+     * pointer that can be freed by qemu_vfree().
-+     */
-+    if (size == 0) {
-+        size++;
-+    }
-+#if defined(CONFIG_POSIX_MEMALIGN)
-+    int ret;
-+    ret = posix_memalign(&ptr, alignment, size);
-+    if (ret != 0) {
-+        errno = ret;
-+        ptr = NULL;
-+    }
-+#elif defined(CONFIG_ALIGNED_MALLOC)
-+    ptr = _aligned_malloc(size, alignment);
-+#elif defined(CONFIG_BSD)
-+    ptr = valloc(size);
-+#else
-+    ptr = memalign(alignment, size);
-+#endif
-+    trace_qemu_memalign(alignment, size, ptr);
-+    return ptr;
-+}
- void *qemu_memalign(size_t alignment, size_t size)
- {
-diff --git a/util/oslib-posix.c b/util/oslib-posix.c
-index XXXXXXX..XXXXXXX 100644
---- a/util/oslib-posix.c
-+++ b/util/oslib-posix.c
-@@ -XXX,XX +XXX,XX @@ fail_close:
-     return false;
- }
--void *qemu_try_memalign(size_t alignment, size_t size)
--{
--    void *ptr;
--
--    if (alignment < sizeof(void*)) {
--        alignment = sizeof(void*);
--    } else {
--        g_assert(is_power_of_2(alignment));
--    }
--
--    if (size == 0) {
--        size++;
--    }
--#if defined(CONFIG_POSIX_MEMALIGN)
--    int ret;
--    ret = posix_memalign(&ptr, alignment, size);
--    if (ret != 0) {
--        errno = ret;
--        ptr = NULL;
--    }
--#elif defined(CONFIG_BSD)
--    ptr = valloc(size);
--#else
--    ptr = memalign(alignment, size);
--#endif
--    trace_qemu_memalign(alignment, size, ptr);
--    return ptr;
--}
--
- /* alloc shared memory pages */
- void *qemu_anon_ram_alloc(size_t size, uint64_t *alignment, bool shared,
-                           bool noreserve)
-diff --git a/util/oslib-win32.c b/util/oslib-win32.c
-index XXXXXXX..XXXXXXX 100644
---- a/util/oslib-win32.c
-+++ b/util/oslib-win32.c
-@@ -XXX,XX +XXX,XX @@
- /* this must come after including "trace.h" */
- #include <shlobj.h>
--void *qemu_try_memalign(size_t alignment, size_t size)
--{
--    void *ptr;
--
--    if (alignment < sizeof(void *)) {
--        alignment = sizeof(void *);
--    } else {
--        g_assert(is_power_of_2(alignment));
--    }
--    if (size == 0) {
--        size++;
--    }
--    ptr = _aligned_malloc(size, alignment);
--    trace_qemu_memalign(alignment, size, ptr);
--    return ptr;
--}
--
- static int get_allocation_granularity(void)
- {
-     SYSTEM_INFO system_info;
---
-.25.1

-[PULL 06/18] util: Use meson checks for valloc() and memalign() presence
+Deleted patch
-Instead of assuming that all CONFIG_BSD have valloc() and anything
-else is memalign(), explicitly check for those functions in
-meson.build and use the "is the function present" define.  Tests for
-specific functionality are better than which-OS checks; this also
-lets us give a helpful error message if somehow there's no usable
-function present.
-Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
-Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
-Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
-Message-id: 20220226180723.1706285-8-peter.maydell@linaro.org
----
- meson.build     | 2 ++
- util/memalign.c | 6 ++++--
-files changed, 6 insertions(+), 2 deletions(-)
-diff --git a/meson.build b/meson.build
-index XXXXXXX..XXXXXXX 100644
---- a/meson.build
-+++ b/meson.build
-@@ -XXX,XX +XXX,XX @@ config_host_data.set('CONFIG_POSIX_FALLOCATE', cc.has_function('posix_fallocate'
- # thinking that Windows has posix_memalign()
- config_host_data.set('CONFIG_POSIX_MEMALIGN', cc.has_function('posix_memalign', prefix: '#include <stdlib.h>'))
- config_host_data.set('CONFIG_ALIGNED_MALLOC', cc.has_function('_aligned_malloc'))
-+config_host_data.set('CONFIG_VALLOC', cc.has_function('valloc'))
-+config_host_data.set('CONFIG_MEMALIGN', cc.has_function('memalign'))
- config_host_data.set('CONFIG_PPOLL', cc.has_function('ppoll'))
- config_host_data.set('CONFIG_PREADV', cc.has_function('preadv', prefix: '#include <sys/uio.h>'))
- config_host_data.set('CONFIG_SEM_TIMEDWAIT', cc.has_function('sem_timedwait', dependencies: threads))
-diff --git a/util/memalign.c b/util/memalign.c
-index XXXXXXX..XXXXXXX 100644
---- a/util/memalign.c
-+++ b/util/memalign.c
-@@ -XXX,XX +XXX,XX @@ void *qemu_try_memalign(size_t alignment, size_t size)
-     }
- #elif defined(CONFIG_ALIGNED_MALLOC)
-     ptr = _aligned_malloc(size, alignment);
--#elif defined(CONFIG_BSD)
-+#elif defined(CONFIG_VALLOC)
-     ptr = valloc(size);
--#else
-+#elif defined(CONFIG_MEMALIGN)
-     ptr = memalign(alignment, size);
-+#else
-+    #error No function to allocate aligned memory available
- #endif
-     trace_qemu_memalign(alignment, size, ptr);
-     return ptr;
---
-.25.1

-[PULL 07/18] util: Put qemu_vfree() in memalign.c
+Deleted patch
-qemu_vfree() is the companion free function to qemu_memalign(); put
-it in memalign.c so the allocation and free functions are together.
-Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
-Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
-Message-id: 20220226180723.1706285-9-peter.maydell@linaro.org
-Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
----
- util/memalign.c    | 11 +++++++++++
- util/oslib-posix.c |  6 ------
- util/oslib-win32.c |  6 ------
-files changed, 11 insertions(+), 12 deletions(-)
-diff --git a/util/memalign.c b/util/memalign.c
-index XXXXXXX..XXXXXXX 100644
---- a/util/memalign.c
-+++ b/util/memalign.c
-@@ -XXX,XX +XXX,XX @@ void *qemu_memalign(size_t alignment, size_t size)
-             size, alignment, strerror(errno));
-     abort();
- }
-+
-+void qemu_vfree(void *ptr)
-+{
-+    trace_qemu_vfree(ptr);
-+#if !defined(CONFIG_POSIX_MEMALIGN) && defined(CONFIG_ALIGNED_MALLOC)
-+    /* Only Windows _aligned_malloc needs a special free function */
-+    _aligned_free(ptr);
-+#else
-+    free(ptr);
-+#endif
-+}
-diff --git a/util/oslib-posix.c b/util/oslib-posix.c
-index XXXXXXX..XXXXXXX 100644
---- a/util/oslib-posix.c
-+++ b/util/oslib-posix.c
-@@ -XXX,XX +XXX,XX @@ void *qemu_anon_ram_alloc(size_t size, uint64_t *alignment, bool shared,
-     return ptr;
- }
--void qemu_vfree(void *ptr)
--{
--    trace_qemu_vfree(ptr);
--    free(ptr);
--}
--
- void qemu_anon_ram_free(void *ptr, size_t size)
- {
-     trace_qemu_anon_ram_free(ptr, size);
-diff --git a/util/oslib-win32.c b/util/oslib-win32.c
-index XXXXXXX..XXXXXXX 100644
---- a/util/oslib-win32.c
-+++ b/util/oslib-win32.c
-@@ -XXX,XX +XXX,XX @@ void *qemu_anon_ram_alloc(size_t size, uint64_t *align, bool shared,
-     return ptr;
- }
--void qemu_vfree(void *ptr)
--{
--    trace_qemu_vfree(ptr);
--    _aligned_free(ptr);
--}
--
- void qemu_anon_ram_free(void *ptr, size_t size)
- {
-     trace_qemu_anon_ram_free(ptr, size);
---
-.25.1

-[PULL 08/18] osdep: Move memalign-related functions to their own header
+Deleted patch
-Move the various memalign-related functions out of osdep.h and into
-their own header, which we include only where they are used.
-While we're doing this, add some brief documentation comments.
-Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
-Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
-Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
-Message-id: 20220226180723.1706285-10-peter.maydell@linaro.org
----
- include/qemu/memalign.h        | 61 ++++++++++++++++++++++++++++++++++
- include/qemu/osdep.h           | 18 ----------
- block/blkverify.c              |  1 +
- block/block-copy.c             |  1 +
- block/commit.c                 |  1 +
- block/crypto.c                 |  1 +
- block/dmg.c                    |  1 +
- block/export/fuse.c            |  1 +
- block/file-posix.c             |  1 +
- block/io.c                     |  1 +
- block/mirror.c                 |  1 +
- block/nvme.c                   |  1 +
- block/parallels-ext.c          |  1 +
- block/parallels.c              |  1 +
- block/qcow.c                   |  1 +
- block/qcow2-cache.c            |  1 +
- block/qcow2-cluster.c          |  1 +
- block/qcow2-refcount.c         |  1 +
- block/qcow2-snapshot.c         |  1 +
- block/qcow2.c                  |  1 +
- block/qed-l2-cache.c           |  1 +
- block/qed-table.c              |  1 +
- block/qed.c                    |  1 +
- block/quorum.c                 |  1 +
- block/raw-format.c             |  1 +
- block/vdi.c                    |  1 +
- block/vhdx-log.c               |  1 +
- block/vhdx.c                   |  1 +
- block/vmdk.c                   |  1 +
- block/vpc.c                    |  1 +
- block/win32-aio.c              |  1 +
- hw/block/dataplane/xen-block.c |  1 +
- hw/block/fdc.c                 |  1 +
- hw/ide/core.c                  |  1 +
- hw/ppc/spapr.c                 |  1 +
- hw/ppc/spapr_softmmu.c         |  1 +
- hw/scsi/scsi-disk.c            |  1 +
- hw/tpm/tpm_ppi.c               |  2 +-
- nbd/server.c                   |  1 +
- net/l2tpv3.c                   |  2 +-
- plugins/loader.c               |  1 +
- qemu-img.c                     |  1 +
- qemu-io-cmds.c                 |  1 +
- qom/object.c                   |  1 +
- softmmu/physmem.c              |  1 +
- target/i386/hvf/hvf.c          |  1 +
- target/i386/kvm/kvm.c          |  1 +
- tcg/region.c                   |  1 +
- tests/bench/atomic_add-bench.c |  1 +
- tests/bench/qht-bench.c        |  1 +
- util/atomic64.c                |  1 +
- util/memalign.c                |  1 +
- util/qht.c                     |  1 +
-files changed, 112 insertions(+), 20 deletions(-)
- create mode 100644 include/qemu/memalign.h
-diff --git a/include/qemu/memalign.h b/include/qemu/memalign.h
-new file mode 100644
-index XXXXXXX..XXXXXXX
---- /dev/null
-+++ b/include/qemu/memalign.h
-@@ -XXX,XX +XXX,XX @@
-+/*
-+ * Allocation and free functions for aligned memory
-+ *
-+ * This work is licensed under the terms of the GNU GPL, version 2 or later.
-+ * See the COPYING file in the top-level directory.
-+ */
-+
-+#ifndef QEMU_MEMALIGN_H
-+#define QEMU_MEMALIGN_H
-+
-+/**
-+ * qemu_try_memalign: Allocate aligned memory
-+ * @alignment: required alignment, in bytes
-+ * @size: size of allocation, in bytes
-+ *
-+ * Allocate memory on an aligned boundary (i.e. the returned
-+ * address will be an exact multiple of @alignment).
-+ * @alignment must be a power of 2, or the function will assert().
-+ * On success, returns allocated memory; on failure, returns NULL.
-+ *
-+ * The memory allocated through this function must be freed via
-+ * qemu_vfree() (and not via free()).
-+ */
-+void *qemu_try_memalign(size_t alignment, size_t size);
-+/**
-+ * qemu_memalign: Allocate aligned memory, without failing
-+ * @alignment: required alignment, in bytes
-+ * @size: size of allocation, in bytes
-+ *
-+ * Allocate memory in the same way as qemu_try_memalign(), but
-+ * abort() with an error message if the memory allocation fails.
-+ *
-+ * The memory allocated through this function must be freed via
-+ * qemu_vfree() (and not via free()).
-+ */
-+void *qemu_memalign(size_t alignment, size_t size);
-+/**
-+ * qemu_vfree: Free memory allocated through qemu_memalign
-+ * @ptr: memory to free
-+ *
-+ * This function must be used to free memory allocated via qemu_memalign()
-+ * or qemu_try_memalign(). (Using the wrong free function will cause
-+ * subtle bugs on Windows hosts.)
-+ */
-+void qemu_vfree(void *ptr);
-+/*
-+ * It's an analog of GLIB's g_autoptr_cleanup_generic_gfree(), used to define
-+ * g_autofree macro.
-+ */
-+static inline void qemu_cleanup_generic_vfree(void *p)
-+{
-+  void **pp = (void **)p;
-+  qemu_vfree(*pp);
-+}
-+
-+/*
-+ * Analog of g_autofree, but qemu_vfree is called on cleanup instead of g_free.
-+ */
-+#define QEMU_AUTO_VFREE __attribute__((cleanup(qemu_cleanup_generic_vfree)))
-+
-+#endif
-diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h
-index XXXXXXX..XXXXXXX 100644
---- a/include/qemu/osdep.h
-+++ b/include/qemu/osdep.h
-@@ -XXX,XX +XXX,XX @@ extern "C" {
- #endif
- int qemu_daemon(int nochdir, int noclose);
--void *qemu_try_memalign(size_t alignment, size_t size);
--void *qemu_memalign(size_t alignment, size_t size);
- void *qemu_anon_ram_alloc(size_t size, uint64_t *align, bool shared,
-                           bool noreserve);
--void qemu_vfree(void *ptr);
- void qemu_anon_ram_free(void *ptr, size_t size);
--/*
-- * It's an analog of GLIB's g_autoptr_cleanup_generic_gfree(), used to define
-- * g_autofree macro.
-- */
--static inline void qemu_cleanup_generic_vfree(void *p)
--{
--  void **pp = (void **)p;
--  qemu_vfree(*pp);
--}
--
--/*
-- * Analog of g_autofree, but qemu_vfree is called on cleanup instead of g_free.
-- */
--#define QEMU_AUTO_VFREE __attribute__((cleanup(qemu_cleanup_generic_vfree)))
--
- #ifdef _WIN32
- #define HAVE_CHARDEV_SERIAL 1
- #elif defined(__linux__) || defined(__sun__) || defined(__FreeBSD__)    \
-diff --git a/block/blkverify.c b/block/blkverify.c
-index XXXXXXX..XXXXXXX 100644
---- a/block/blkverify.c
-+++ b/block/blkverify.c
-@@ -XXX,XX +XXX,XX @@
- #include "qemu/cutils.h"
- #include "qemu/module.h"
- #include "qemu/option.h"
-+#include "qemu/memalign.h"
- typedef struct {
-     BdrvChild *test_file;
-diff --git a/block/block-copy.c b/block/block-copy.c
-index XXXXXXX..XXXXXXX 100644
---- a/block/block-copy.c
-+++ b/block/block-copy.c
-@@ -XXX,XX +XXX,XX @@
- #include "qemu/coroutine.h"
- #include "block/aio_task.h"
- #include "qemu/error-report.h"
-+#include "qemu/memalign.h"
- #define BLOCK_COPY_MAX_COPY_RANGE (16 * MiB)
- #define BLOCK_COPY_MAX_BUFFER (1 * MiB)
-diff --git a/block/commit.c b/block/commit.c
-index XXXXXXX..XXXXXXX 100644
---- a/block/commit.c
-+++ b/block/commit.c
-@@ -XXX,XX +XXX,XX @@
- #include "qapi/error.h"
- #include "qapi/qmp/qerror.h"
- #include "qemu/ratelimit.h"
-+#include "qemu/memalign.h"
- #include "sysemu/block-backend.h"
- enum {
-diff --git a/block/crypto.c b/block/crypto.c
-index XXXXXXX..XXXXXXX 100644
---- a/block/crypto.c
-+++ b/block/crypto.c
-@@ -XXX,XX +XXX,XX @@
- #include "qemu/module.h"
- #include "qemu/option.h"
- #include "qemu/cutils.h"
-+#include "qemu/memalign.h"
- #include "crypto.h"
- typedef struct BlockCrypto BlockCrypto;
-diff --git a/block/dmg.c b/block/dmg.c
-index XXXXXXX..XXXXXXX 100644
---- a/block/dmg.c
-+++ b/block/dmg.c
-@@ -XXX,XX +XXX,XX @@
- #include "qemu/bswap.h"
- #include "qemu/error-report.h"
- #include "qemu/module.h"
-+#include "qemu/memalign.h"
- #include "dmg.h"
- int (*dmg_uncompress_bz2)(char *next_in, unsigned int avail_in,
-diff --git a/block/export/fuse.c b/block/export/fuse.c
-index XXXXXXX..XXXXXXX 100644
---- a/block/export/fuse.c
-+++ b/block/export/fuse.c
-@@ -XXX,XX +XXX,XX @@
- #define FUSE_USE_VERSION 31
- #include "qemu/osdep.h"
-+#include "qemu/memalign.h"
- #include "block/aio.h"
- #include "block/block.h"
- #include "block/export.h"
-diff --git a/block/file-posix.c b/block/file-posix.c
-index XXXXXXX..XXXXXXX 100644
---- a/block/file-posix.c
-+++ b/block/file-posix.c
-@@ -XXX,XX +XXX,XX @@
- #include "qemu/module.h"
- #include "qemu/option.h"
- #include "qemu/units.h"
-+#include "qemu/memalign.h"
- #include "trace.h"
- #include "block/thread-pool.h"
- #include "qemu/iov.h"
-diff --git a/block/io.c b/block/io.c
-index XXXXXXX..XXXXXXX 100644
---- a/block/io.c
-+++ b/block/io.c
-@@ -XXX,XX +XXX,XX @@
- #include "block/coroutines.h"
- #include "block/write-threshold.h"
- #include "qemu/cutils.h"
-+#include "qemu/memalign.h"
- #include "qapi/error.h"
- #include "qemu/error-report.h"
- #include "qemu/main-loop.h"
-diff --git a/block/mirror.c b/block/mirror.c
-index XXXXXXX..XXXXXXX 100644
---- a/block/mirror.c
-+++ b/block/mirror.c
-@@ -XXX,XX +XXX,XX @@
- #include "qapi/qmp/qerror.h"
- #include "qemu/ratelimit.h"
- #include "qemu/bitmap.h"
-+#include "qemu/memalign.h"
- #define MAX_IN_FLIGHT 16
- #define MAX_IO_BYTES (1 << 20) /* 1 Mb */
-diff --git a/block/nvme.c b/block/nvme.c
-index XXXXXXX..XXXXXXX 100644
---- a/block/nvme.c
-+++ b/block/nvme.c
-@@ -XXX,XX +XXX,XX @@
- #include "qemu/module.h"
- #include "qemu/cutils.h"
- #include "qemu/option.h"
-+#include "qemu/memalign.h"
- #include "qemu/vfio-helpers.h"
- #include "block/block_int.h"
- #include "sysemu/replay.h"
-diff --git a/block/parallels-ext.c b/block/parallels-ext.c
-index XXXXXXX..XXXXXXX 100644
---- a/block/parallels-ext.c
-+++ b/block/parallels-ext.c
-@@ -XXX,XX +XXX,XX @@
- #include "parallels.h"
- #include "crypto/hash.h"
- #include "qemu/uuid.h"
-+#include "qemu/memalign.h"
- #define PARALLELS_FORMAT_EXTENSION_MAGIC 0xAB234CEF23DCEA87ULL
-diff --git a/block/parallels.c b/block/parallels.c
-index XXXXXXX..XXXXXXX 100644
---- a/block/parallels.c
-+++ b/block/parallels.c
-@@ -XXX,XX +XXX,XX @@
- #include "qapi/qapi-visit-block-core.h"
- #include "qemu/bswap.h"
- #include "qemu/bitmap.h"
-+#include "qemu/memalign.h"
- #include "migration/blocker.h"
- #include "parallels.h"
-diff --git a/block/qcow.c b/block/qcow.c
-index XXXXXXX..XXXXXXX 100644
---- a/block/qcow.c
-+++ b/block/qcow.c
-@@ -XXX,XX +XXX,XX @@
- #include "qemu/option.h"
- #include "qemu/bswap.h"
- #include "qemu/cutils.h"
-+#include "qemu/memalign.h"
- #include <zlib.h>
- #include "qapi/qmp/qdict.h"
- #include "qapi/qmp/qstring.h"
-diff --git a/block/qcow2-cache.c b/block/qcow2-cache.c
-index XXXXXXX..XXXXXXX 100644
---- a/block/qcow2-cache.c
-+++ b/block/qcow2-cache.c
-@@ -XXX,XX +XXX,XX @@
-  */
- #include "qemu/osdep.h"
-+#include "qemu/memalign.h"
- #include "qcow2.h"
- #include "trace.h"
-diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
-index XXXXXXX..XXXXXXX 100644
---- a/block/qcow2-cluster.c
-+++ b/block/qcow2-cluster.c
-@@ -XXX,XX +XXX,XX @@
- #include "qapi/error.h"
- #include "qcow2.h"
- #include "qemu/bswap.h"
-+#include "qemu/memalign.h"
- #include "trace.h"
- int qcow2_shrink_l1_table(BlockDriverState *bs, uint64_t exact_size)
-diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
-index XXXXXXX..XXXXXXX 100644
---- a/block/qcow2-refcount.c
-+++ b/block/qcow2-refcount.c
-@@ -XXX,XX +XXX,XX @@
- #include "qemu/range.h"
- #include "qemu/bswap.h"
- #include "qemu/cutils.h"
-+#include "qemu/memalign.h"
- #include "trace.h"
- static int64_t alloc_clusters_noref(BlockDriverState *bs, uint64_t size,
-diff --git a/block/qcow2-snapshot.c b/block/qcow2-snapshot.c
-index XXXXXXX..XXXXXXX 100644
---- a/block/qcow2-snapshot.c
-+++ b/block/qcow2-snapshot.c
-@@ -XXX,XX +XXX,XX @@
- #include "qemu/bswap.h"
- #include "qemu/error-report.h"
- #include "qemu/cutils.h"
-+#include "qemu/memalign.h"
- static void qcow2_free_single_snapshot(BlockDriverState *bs, int i)
- {
-diff --git a/block/qcow2.c b/block/qcow2.c
-index XXXXXXX..XXXXXXX 100644
---- a/block/qcow2.c
-+++ b/block/qcow2.c
-@@ -XXX,XX +XXX,XX @@
- #include "qemu/option_int.h"
- #include "qemu/cutils.h"
- #include "qemu/bswap.h"
-+#include "qemu/memalign.h"
- #include "qapi/qobject-input-visitor.h"
- #include "qapi/qapi-visit-block-core.h"
- #include "crypto.h"
-diff --git a/block/qed-l2-cache.c b/block/qed-l2-cache.c
-index XXXXXXX..XXXXXXX 100644
---- a/block/qed-l2-cache.c
-+++ b/block/qed-l2-cache.c
-@@ -XXX,XX +XXX,XX @@
-  */
- #include "qemu/osdep.h"
-+#include "qemu/memalign.h"
- #include "trace.h"
- #include "qed.h"
-diff --git a/block/qed-table.c b/block/qed-table.c
-index XXXXXXX..XXXXXXX 100644
---- a/block/qed-table.c
-+++ b/block/qed-table.c
-@@ -XXX,XX +XXX,XX @@
- #include "qemu/sockets.h" /* for EINPROGRESS on Windows */
- #include "qed.h"
- #include "qemu/bswap.h"
-+#include "qemu/memalign.h"
- /* Called with table_lock held.  */
- static int coroutine_fn qed_read_table(BDRVQEDState *s, uint64_t offset,
-diff --git a/block/qed.c b/block/qed.c
-index XXXXXXX..XXXXXXX 100644
---- a/block/qed.c
-+++ b/block/qed.c
-@@ -XXX,XX +XXX,XX @@
- #include "qemu/main-loop.h"
- #include "qemu/module.h"
- #include "qemu/option.h"
-+#include "qemu/memalign.h"
- #include "trace.h"
- #include "qed.h"
- #include "sysemu/block-backend.h"
-diff --git a/block/quorum.c b/block/quorum.c
-index XXXXXXX..XXXXXXX 100644
---- a/block/quorum.c
-+++ b/block/quorum.c
-@@ -XXX,XX +XXX,XX @@
- #include "qemu/cutils.h"
- #include "qemu/module.h"
- #include "qemu/option.h"
-+#include "qemu/memalign.h"
- #include "block/block_int.h"
- #include "block/coroutines.h"
- #include "block/qdict.h"
-diff --git a/block/raw-format.c b/block/raw-format.c
-index XXXXXXX..XXXXXXX 100644
---- a/block/raw-format.c
-+++ b/block/raw-format.c
-@@ -XXX,XX +XXX,XX @@
- #include "qapi/error.h"
- #include "qemu/module.h"
- #include "qemu/option.h"
-+#include "qemu/memalign.h"
- typedef struct BDRVRawState {
-     uint64_t offset;
-diff --git a/block/vdi.c b/block/vdi.c
-index XXXXXXX..XXXXXXX 100644
---- a/block/vdi.c
-+++ b/block/vdi.c
-@@ -XXX,XX +XXX,XX @@
- #include "qemu/coroutine.h"
- #include "qemu/cutils.h"
- #include "qemu/uuid.h"
-+#include "qemu/memalign.h"
- /* Code configuration options. */
-diff --git a/block/vhdx-log.c b/block/vhdx-log.c
-index XXXXXXX..XXXXXXX 100644
---- a/block/vhdx-log.c
-+++ b/block/vhdx-log.c
-@@ -XXX,XX +XXX,XX @@
- #include "block/block_int.h"
- #include "qemu/error-report.h"
- #include "qemu/bswap.h"
-+#include "qemu/memalign.h"
- #include "vhdx.h"
-diff --git a/block/vhdx.c b/block/vhdx.c
-index XXXXXXX..XXXXXXX 100644
---- a/block/vhdx.c
-+++ b/block/vhdx.c
-@@ -XXX,XX +XXX,XX @@
- #include "qemu/crc32c.h"
- #include "qemu/bswap.h"
- #include "qemu/error-report.h"
-+#include "qemu/memalign.h"
- #include "vhdx.h"
- #include "migration/blocker.h"
- #include "qemu/uuid.h"
-diff --git a/block/vmdk.c b/block/vmdk.c
-index XXXXXXX..XXXXXXX 100644
---- a/block/vmdk.c
-+++ b/block/vmdk.c
-@@ -XXX,XX +XXX,XX @@
- #include "qemu/module.h"
- #include "qemu/option.h"
- #include "qemu/bswap.h"
-+#include "qemu/memalign.h"
- #include "migration/blocker.h"
- #include "qemu/cutils.h"
- #include <zlib.h>
-diff --git a/block/vpc.c b/block/vpc.c
-index XXXXXXX..XXXXXXX 100644
---- a/block/vpc.c
-+++ b/block/vpc.c
-@@ -XXX,XX +XXX,XX @@
- #include "migration/blocker.h"
- #include "qemu/bswap.h"
- #include "qemu/uuid.h"
-+#include "qemu/memalign.h"
- #include "qapi/qmp/qdict.h"
- #include "qapi/qobject-input-visitor.h"
- #include "qapi/qapi-visit-block-core.h"
-diff --git a/block/win32-aio.c b/block/win32-aio.c
-index XXXXXXX..XXXXXXX 100644
---- a/block/win32-aio.c
-+++ b/block/win32-aio.c
-@@ -XXX,XX +XXX,XX @@
- #include "block/raw-aio.h"
- #include "qemu/event_notifier.h"
- #include "qemu/iov.h"
-+#include "qemu/memalign.h"
- #include <windows.h>
- #include <winioctl.h>
-diff --git a/hw/block/dataplane/xen-block.c b/hw/block/dataplane/xen-block.c
-index XXXXXXX..XXXXXXX 100644
---- a/hw/block/dataplane/xen-block.c
-+++ b/hw/block/dataplane/xen-block.c
-@@ -XXX,XX +XXX,XX @@
- #include "qemu/osdep.h"
- #include "qemu/error-report.h"
- #include "qemu/main-loop.h"
-+#include "qemu/memalign.h"
- #include "qapi/error.h"
- #include "hw/xen/xen_common.h"
- #include "hw/block/xen_blkif.h"
-diff --git a/hw/block/fdc.c b/hw/block/fdc.c
-index XXXXXXX..XXXXXXX 100644
---- a/hw/block/fdc.c
-+++ b/hw/block/fdc.c
-@@ -XXX,XX +XXX,XX @@
- #include "qapi/error.h"
- #include "qemu/error-report.h"
- #include "qemu/timer.h"
-+#include "qemu/memalign.h"
- #include "hw/irq.h"
- #include "hw/isa/isa.h"
- #include "hw/qdev-properties.h"
-diff --git a/hw/ide/core.c b/hw/ide/core.c
-index XXXXXXX..XXXXXXX 100644
---- a/hw/ide/core.c
-+++ b/hw/ide/core.c
-@@ -XXX,XX +XXX,XX @@
- #include "qemu/main-loop.h"
- #include "qemu/timer.h"
- #include "qemu/hw-version.h"
-+#include "qemu/memalign.h"
- #include "sysemu/sysemu.h"
- #include "sysemu/blockdev.h"
- #include "sysemu/dma.h"
-diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
-index XXXXXXX..XXXXXXX 100644
---- a/hw/ppc/spapr.c
-+++ b/hw/ppc/spapr.c
-@@ -XXX,XX +XXX,XX @@
- #include "qemu/osdep.h"
- #include "qemu-common.h"
- #include "qemu/datadir.h"
-+#include "qemu/memalign.h"
- #include "qapi/error.h"
- #include "qapi/qapi-events-machine.h"
- #include "qapi/qapi-events-qdev.h"
-diff --git a/hw/ppc/spapr_softmmu.c b/hw/ppc/spapr_softmmu.c
-index XXXXXXX..XXXXXXX 100644
---- a/hw/ppc/spapr_softmmu.c
-+++ b/hw/ppc/spapr_softmmu.c
-@@ -XXX,XX +XXX,XX @@
- #include "qemu/osdep.h"
- #include "qemu/cutils.h"
-+#include "qemu/memalign.h"
- #include "cpu.h"
- #include "helper_regs.h"
- #include "hw/ppc/spapr.h"
-diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
-index XXXXXXX..XXXXXXX 100644
---- a/hw/scsi/scsi-disk.c
-+++ b/hw/scsi/scsi-disk.c
-@@ -XXX,XX +XXX,XX @@
- #include "qemu/main-loop.h"
- #include "qemu/module.h"
- #include "qemu/hw-version.h"
-+#include "qemu/memalign.h"
- #include "hw/scsi/scsi.h"
- #include "migration/qemu-file-types.h"
- #include "migration/vmstate.h"
-diff --git a/hw/tpm/tpm_ppi.c b/hw/tpm/tpm_ppi.c
-index XXXXXXX..XXXXXXX 100644
---- a/hw/tpm/tpm_ppi.c
-+++ b/hw/tpm/tpm_ppi.c
-@@ -XXX,XX +XXX,XX @@
-  */
- #include "qemu/osdep.h"
--
-+#include "qemu/memalign.h"
- #include "qapi/error.h"
- #include "sysemu/memory_mapping.h"
- #include "migration/vmstate.h"
-diff --git a/nbd/server.c b/nbd/server.c
-index XXXXXXX..XXXXXXX 100644
---- a/nbd/server.c
-+++ b/nbd/server.c
-@@ -XXX,XX +XXX,XX @@
- #include "trace.h"
- #include "nbd-internal.h"
- #include "qemu/units.h"
-+#include "qemu/memalign.h"
- #define NBD_META_ID_BASE_ALLOCATION 0
- #define NBD_META_ID_ALLOCATION_DEPTH 1
-diff --git a/net/l2tpv3.c b/net/l2tpv3.c
-index XXXXXXX..XXXXXXX 100644
---- a/net/l2tpv3.c
-+++ b/net/l2tpv3.c
-@@ -XXX,XX +XXX,XX @@
- #include "qemu/sockets.h"
- #include "qemu/iov.h"
- #include "qemu/main-loop.h"
--
-+#include "qemu/memalign.h"
- /* The buffer size needs to be investigated for optimum numbers and
-  * optimum means of paging in on different systems. This size is
-diff --git a/plugins/loader.c b/plugins/loader.c
-index XXXXXXX..XXXXXXX 100644
---- a/plugins/loader.c
-+++ b/plugins/loader.c
-@@ -XXX,XX +XXX,XX @@
- #include "qemu/cacheinfo.h"
- #include "qemu/xxhash.h"
- #include "qemu/plugin.h"
-+#include "qemu/memalign.h"
- #include "hw/core/cpu.h"
- #include "exec/exec-all.h"
- #ifndef CONFIG_USER_ONLY
-diff --git a/qemu-img.c b/qemu-img.c
-index XXXXXXX..XXXXXXX 100644
---- a/qemu-img.c
-+++ b/qemu-img.c
-@@ -XXX,XX +XXX,XX @@
- #include "qemu/module.h"
- #include "qemu/sockets.h"
- #include "qemu/units.h"
-+#include "qemu/memalign.h"
- #include "qom/object_interfaces.h"
- #include "sysemu/block-backend.h"
- #include "block/block_int.h"
-diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c
-index XXXXXXX..XXXXXXX 100644
---- a/qemu-io-cmds.c
-+++ b/qemu-io-cmds.c
-@@ -XXX,XX +XXX,XX @@
- #include "qemu/option.h"
- #include "qemu/timer.h"
- #include "qemu/cutils.h"
-+#include "qemu/memalign.h"
- #define CMD_NOFILE_OK   0x01
-diff --git a/qom/object.c b/qom/object.c
-index XXXXXXX..XXXXXXX 100644
---- a/qom/object.c
-+++ b/qom/object.c
-@@ -XXX,XX +XXX,XX @@
- #include "qom/object.h"
- #include "qom/object_interfaces.h"
- #include "qemu/cutils.h"
-+#include "qemu/memalign.h"
- #include "qapi/visitor.h"
- #include "qapi/string-input-visitor.h"
- #include "qapi/string-output-visitor.h"
-diff --git a/softmmu/physmem.c b/softmmu/physmem.c
-index XXXXXXX..XXXXXXX 100644
---- a/softmmu/physmem.c
-+++ b/softmmu/physmem.c
-@@ -XXX,XX +XXX,XX @@
- #include "qemu/config-file.h"
- #include "qemu/error-report.h"
- #include "qemu/qemu-print.h"
-+#include "qemu/memalign.h"
- #include "exec/memory.h"
- #include "exec/ioport.h"
- #include "sysemu/dma.h"
-diff --git a/target/i386/hvf/hvf.c b/target/i386/hvf/hvf.c
-index XXXXXXX..XXXXXXX 100644
---- a/target/i386/hvf/hvf.c
-+++ b/target/i386/hvf/hvf.c
-@@ -XXX,XX +XXX,XX @@
- #include "qemu/osdep.h"
- #include "qemu-common.h"
- #include "qemu/error-report.h"
-+#include "qemu/memalign.h"
- #include "sysemu/hvf.h"
- #include "sysemu/hvf_int.h"
-diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c
-index XXXXXXX..XXXXXXX 100644
---- a/target/i386/kvm/kvm.c
-+++ b/target/i386/kvm/kvm.c
-@@ -XXX,XX +XXX,XX @@
- #include "qemu/main-loop.h"
- #include "qemu/config-file.h"
- #include "qemu/error-report.h"
-+#include "qemu/memalign.h"
- #include "hw/i386/x86.h"
- #include "hw/i386/apic.h"
- #include "hw/i386/apic_internal.h"
-diff --git a/tcg/region.c b/tcg/region.c
-index XXXXXXX..XXXXXXX 100644
---- a/tcg/region.c
-+++ b/tcg/region.c
-@@ -XXX,XX +XXX,XX @@
- #include "qemu/units.h"
- #include "qemu/madvise.h"
- #include "qemu/mprotect.h"
-+#include "qemu/memalign.h"
- #include "qemu/cacheinfo.h"
- #include "qapi/error.h"
- #include "exec/exec-all.h"
-diff --git a/tests/bench/atomic_add-bench.c b/tests/bench/atomic_add-bench.c
-index XXXXXXX..XXXXXXX 100644
---- a/tests/bench/atomic_add-bench.c
-+++ b/tests/bench/atomic_add-bench.c
-@@ -XXX,XX +XXX,XX @@
- #include "qemu/thread.h"
- #include "qemu/host-utils.h"
- #include "qemu/processor.h"
-+#include "qemu/memalign.h"
- struct thread_info {
-     uint64_t r;
-diff --git a/tests/bench/qht-bench.c b/tests/bench/qht-bench.c
-index XXXXXXX..XXXXXXX 100644
---- a/tests/bench/qht-bench.c
-+++ b/tests/bench/qht-bench.c
-@@ -XXX,XX +XXX,XX @@
- #include "qemu/qht.h"
- #include "qemu/rcu.h"
- #include "qemu/xxhash.h"
-+#include "qemu/memalign.h"
- struct thread_stats {
-     size_t rd;
-diff --git a/util/atomic64.c b/util/atomic64.c
-index XXXXXXX..XXXXXXX 100644
---- a/util/atomic64.c
-+++ b/util/atomic64.c
-@@ -XXX,XX +XXX,XX @@
- #include "qemu/atomic.h"
- #include "qemu/thread.h"
- #include "qemu/cacheinfo.h"
-+#include "qemu/memalign.h"
- #ifdef CONFIG_ATOMIC64
- #error This file must only be compiled if !CONFIG_ATOMIC64
-diff --git a/util/memalign.c b/util/memalign.c
-index XXXXXXX..XXXXXXX 100644
---- a/util/memalign.c
-+++ b/util/memalign.c
-@@ -XXX,XX +XXX,XX @@
- #include "qemu/osdep.h"
- #include "qemu/host-utils.h"
-+#include "qemu/memalign.h"
- #include "trace.h"
- void *qemu_try_memalign(size_t alignment, size_t size)
-diff --git a/util/qht.c b/util/qht.c
-index XXXXXXX..XXXXXXX 100644
---- a/util/qht.c
-+++ b/util/qht.c
-@@ -XXX,XX +XXX,XX @@
- #include "qemu/qht.h"
- #include "qemu/atomic.h"
- #include "qemu/rcu.h"
-+#include "qemu/memalign.h"
- //#define QHT_DEBUG
---
-.25.1

-[PULL 09/18] target/arm/translate-neon: UNDEF if VLD1/VST1 stride bits are non-zero
+Deleted patch
-For VLD1/VST1 (single element to one lane) we are only accessing one
-register, and so the 'stride' is meaningless.  The bits that would
-specify stride (insn bit [4] for size=1, bit [6] for size=2) are
-specified to be zero in the encoding (which would correspond to a
-stride of 1 for VLD2/VLD3/VLD4 etc), and we must UNDEF if they are
-not.
-We failed to make this check, which meant that we would incorrectly
-handle some instruction patterns as loads or stores instead of
-UNDEFing them. Enforce that stride == 1 for the nregs == 1 case.
-Resolves: https://gitlab.com/qemu-project/qemu/-/issues/890
-Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
-Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
-Tested-by: Richard Henderson <richard.henderson@linaro.org>
-Message-id: 20220303113741.2156877-2-peter.maydell@linaro.org
----
- target/arm/translate-neon.c | 3 +++
-file changed, 3 insertions(+)
-diff --git a/target/arm/translate-neon.c b/target/arm/translate-neon.c
-index XXXXXXX..XXXXXXX 100644
---- a/target/arm/translate-neon.c
-+++ b/target/arm/translate-neon.c
-@@ -XXX,XX +XXX,XX @@ static bool trans_VLDST_single(DisasContext *s, arg_VLDST_single *a)
-     /* Catch the UNDEF cases. This is unavoidably a bit messy. */
-     switch (nregs) {
-     case 1:
-+        if (a->stride != 1) {
-+            return false;
-+        }
-         if (((a->align & (1 << a->size)) != 0) ||
-             (a->size == 2 && (a->align == 1 || a->align == 2))) {
-             return false;
---
-.25.1

-[PULL 10/18] target/arm/translate-neon: Simplify align field check for VLD3
+Deleted patch
-For VLD3 (single 3-element structure to one lane), there is no
-alignment specification and the alignment bits in the instruction
-must be zero.  This is bit [4] for the size=0 and size=1 cases, and
-bits [5:4] for the size=2 case.  We do this check correctly in
-VLDST_single(), but we write it a bit oddly: in the 'case 3' code we
-check for bit 0 of a->align (bit [4] of the insn), and then we fall
-through to the 'case 2' code which checks bit 1 of a->align (bit [5]
-of the insn) in the size 2 case.  Replace this with just checking "is
-a->align non-zero" for VLD3, which lets us drop the fall-through and
-put the cases in this switch in numerical order.
-Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
-Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
-Tested-by: Richard Henderson <richard.henderson@linaro.org>
-Message-id: 20220303113741.2156877-3-peter.maydell@linaro.org
----
- target/arm/translate-neon.c | 10 +++++-----
-file changed, 5 insertions(+), 5 deletions(-)
-diff --git a/target/arm/translate-neon.c b/target/arm/translate-neon.c
-index XXXXXXX..XXXXXXX 100644
---- a/target/arm/translate-neon.c
-+++ b/target/arm/translate-neon.c
-@@ -XXX,XX +XXX,XX @@ static bool trans_VLDST_single(DisasContext *s, arg_VLDST_single *a)
-             return false;
-         }
-         break;
--    case 3:
--        if ((a->align & 1) != 0) {
--            return false;
--        }
--        /* fall through */
-     case 2:
-         if (a->size == 2 && (a->align & 2) != 0) {
-             return false;
-         }
-         break;
-+    case 3:
-+        if (a->align != 0) {
-+            return false;
-+        }
-+        break;
-     case 4:
-         if (a->size == 2 && a->align == 3) {
-             return false;
---
-.25.1

-[PULL 11/18] hw/intc/arm_gicv3_its: Add trace events for commands
+Deleted patch
-When debugging code that's using the ITS, it's helpful to
-see tracing of the ITS commands that the guest executes. Add
-suitable trace events.
-Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
-Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
-Message-id: 20220303202341.2232284-2-peter.maydell@linaro.org
----
- hw/intc/arm_gicv3_its.c | 28 ++++++++++++++++++++++++++--
- hw/intc/trace-events    | 12 ++++++++++++
-files changed, 38 insertions(+), 2 deletions(-)
-diff --git a/hw/intc/arm_gicv3_its.c b/hw/intc/arm_gicv3_its.c
-index XXXXXXX..XXXXXXX 100644
---- a/hw/intc/arm_gicv3_its.c
-+++ b/hw/intc/arm_gicv3_its.c
-@@ -XXX,XX +XXX,XX @@ static ItsCmdResult process_its_cmd(GICv3ITSState *s, const uint64_t *cmdpkt,
-     devid = (cmdpkt[0] & DEVID_MASK) >> DEVID_SHIFT;
-     eventid = cmdpkt[1] & EVENTID_MASK;
-+    switch (cmd) {
-+    case INTERRUPT:
-+        trace_gicv3_its_cmd_int(devid, eventid);
-+        break;
-+    case CLEAR:
-+        trace_gicv3_its_cmd_clear(devid, eventid);
-+        break;
-+    case DISCARD:
-+        trace_gicv3_its_cmd_discard(devid, eventid);
-+        break;
-+    default:
-+        g_assert_not_reached();
-+    }
-     return do_process_its_cmd(s, devid, eventid, cmd);
- }
-@@ -XXX,XX +XXX,XX @@ static ItsCmdResult process_mapti(GICv3ITSState *s, const uint64_t *cmdpkt,
-     devid = (cmdpkt[0] & DEVID_MASK) >> DEVID_SHIFT;
-     eventid = cmdpkt[1] & EVENTID_MASK;
-+    icid = cmdpkt[2] & ICID_MASK;
-     if (ignore_pInt) {
-         pIntid = eventid;
-+        trace_gicv3_its_cmd_mapi(devid, eventid, icid);
-     } else {
-         pIntid = (cmdpkt[1] & pINTID_MASK) >> pINTID_SHIFT;
-+        trace_gicv3_its_cmd_mapti(devid, eventid, icid, pIntid);
-     }
--    icid = cmdpkt[2] & ICID_MASK;
--
-     if (devid >= s->dt.num_entries) {
-         qemu_log_mask(LOG_GUEST_ERROR,
-                       "%s: invalid command attributes: devid %d>=%d",
-@@ -XXX,XX +XXX,XX @@ static ItsCmdResult process_mapc(GICv3ITSState *s, const uint64_t *cmdpkt)
-     } else {
-         cte.rdbase = 0;
-     }
-+    trace_gicv3_its_cmd_mapc(icid, cte.rdbase, cte.valid);
-     if (icid >= s->ct.num_entries) {
-         qemu_log_mask(LOG_GUEST_ERROR, "ITS MAPC: invalid ICID 0x%d", icid);
-@@ -XXX,XX +XXX,XX @@ static ItsCmdResult process_mapd(GICv3ITSState *s, const uint64_t *cmdpkt)
-     dte.ittaddr = (cmdpkt[2] & ITTADDR_MASK) >> ITTADDR_SHIFT;
-     dte.valid = cmdpkt[2] & CMD_FIELD_VALID_MASK;
-+    trace_gicv3_its_cmd_mapd(devid, dte.size, dte.ittaddr, dte.valid);
-+
-     if (devid >= s->dt.num_entries) {
-         qemu_log_mask(LOG_GUEST_ERROR,
-                       "ITS MAPD: invalid device ID field 0x%x >= 0x%x\n",
-@@ -XXX,XX +XXX,XX @@ static ItsCmdResult process_movall(GICv3ITSState *s, const uint64_t *cmdpkt)
-     rd1 = FIELD_EX64(cmdpkt[2], MOVALL_2, RDBASE1);
-     rd2 = FIELD_EX64(cmdpkt[3], MOVALL_3, RDBASE2);
-+    trace_gicv3_its_cmd_movall(rd1, rd2);
-+
-     if (rd1 >= s->gicv3->num_cpu) {
-         qemu_log_mask(LOG_GUEST_ERROR,
-                       "%s: RDBASE1 %" PRId64
-@@ -XXX,XX +XXX,XX @@ static ItsCmdResult process_movi(GICv3ITSState *s, const uint64_t *cmdpkt)
-     eventid = FIELD_EX64(cmdpkt[1], MOVI_1, EVENTID);
-     new_icid = FIELD_EX64(cmdpkt[2], MOVI_2, ICID);
-+    trace_gicv3_its_cmd_movi(devid, eventid, new_icid);
-+
-     if (devid >= s->dt.num_entries) {
-         qemu_log_mask(LOG_GUEST_ERROR,
-                       "%s: invalid command attributes: devid %d>=%d",
-@@ -XXX,XX +XXX,XX @@ static void process_cmdq(GICv3ITSState *s)
-              * is already consistent by the time SYNC command is executed.
-              * Hence no further processing is required for SYNC command.
-              */
-+            trace_gicv3_its_cmd_sync();
-             break;
-         case GITS_CMD_MAPD:
-             result = process_mapd(s, cmdpkt);
-@@ -XXX,XX +XXX,XX @@ static void process_cmdq(GICv3ITSState *s)
-              * need to trigger lpi priority re-calculation to be in
-              * sync with LPI config table or pending table changes.
-              */
-+            trace_gicv3_its_cmd_inv();
-             for (i = 0; i < s->gicv3->num_cpu; i++) {
-                 gicv3_redist_update_lpi(&s->gicv3->cpu[i]);
-             }
-@@ -XXX,XX +XXX,XX @@ static void process_cmdq(GICv3ITSState *s)
-             result = process_movall(s, cmdpkt);
-             break;
-         default:
-+            trace_gicv3_its_cmd_unknown(cmd);
-             break;
-         }
-         if (result == CMD_CONTINUE) {
-diff --git a/hw/intc/trace-events b/hw/intc/trace-events
-index XXXXXXX..XXXXXXX 100644
---- a/hw/intc/trace-events
-+++ b/hw/intc/trace-events
-@@ -XXX,XX +XXX,XX @@ gicv3_its_write(uint64_t offset, uint64_t data, unsigned size) "GICv3 ITS write:
- gicv3_its_badwrite(uint64_t offset, uint64_t data, unsigned size) "GICv3 ITS write: offset 0x%" PRIx64 " data 0x%" PRIx64 " size %u: error"
- gicv3_its_translation_write(uint64_t offset, uint64_t data, unsigned size, uint32_t requester_id) "GICv3 ITS TRANSLATER write: offset 0x%" PRIx64 " data 0x%" PRIx64 " size %u requester_id 0x%x"
- gicv3_its_process_command(uint32_t rd_offset, uint8_t cmd) "GICv3 ITS: processing command at offset 0x%x: 0x%x"
-+gicv3_its_cmd_int(uint32_t devid, uint32_t eventid) "GICv3 ITS: command INT DeviceID 0x%x EventID 0x%x"
-+gicv3_its_cmd_clear(uint32_t devid, uint32_t eventid) "GICv3 ITS: command CLEAR DeviceID 0x%x EventID 0x%x"
-+gicv3_its_cmd_discard(uint32_t devid, uint32_t eventid) "GICv3 ITS: command DISCARD DeviceID 0x%x EventID 0x%x"
-+gicv3_its_cmd_sync(void) "GICv3 ITS: command SYNC"
-+gicv3_its_cmd_mapd(uint32_t devid, uint32_t size, uint64_t ittaddr, int valid) "GICv3 ITS: command MAPD DeviceID 0x%x Size 0x%x ITT_addr 0x%" PRIx64 " V %d"
-+gicv3_its_cmd_mapc(uint32_t icid, uint64_t rdbase, int valid) "GICv3 ITS: command MAPC ICID 0x%x RDbase 0x%" PRIx64 " V %d"
-+gicv3_its_cmd_mapi(uint32_t devid, uint32_t eventid, uint32_t icid) "GICv3 ITS: command MAPI DeviceID 0x%x EventID 0x%x ICID 0x%x"
-+gicv3_its_cmd_mapti(uint32_t devid, uint32_t eventid, uint32_t icid, uint32_t intid) "GICv3 ITS: command MAPTI DeviceID 0x%x EventID 0x%x ICID 0x%x pINTID 0x%x"
-+gicv3_its_cmd_inv(void) "GICv3 ITS: command INV or INVALL"
-+gicv3_its_cmd_movall(uint64_t rd1, uint64_t rd2) "GICv3 ITS: command MOVALL RDbase1 0x%" PRIx64 " RDbase2 0x%" PRIx64
-+gicv3_its_cmd_movi(uint32_t devid, uint32_t eventid, uint32_t icid) "GICv3 ITS: command MOVI DeviceID 0x%x EventID 0x%x ICID 0x%x"
-+gicv3_its_cmd_unknown(unsigned cmd) "GICv3 ITS: unknown command 0x%x"
- # armv7m_nvic.c
- nvic_recompute_state(int vectpending, int vectpending_prio, int exception_prio) "NVIC state recomputed: vectpending %d vectpending_prio %d exception_prio %d"
---
-.25.1

-[PULL 12/18] hw/intc/arm_gicv3_its: Add trace events for table reads and writes
+Deleted patch
-For debugging guest use of the ITS, it can be helpful to trace
-when the ITS reads and writes the in-memory tables.
-Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
-Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
-Message-id: 20220303202341.2232284-3-peter.maydell@linaro.org
----
- hw/intc/arm_gicv3_its.c | 37 +++++++++++++++++++++++++++++++------
- hw/intc/trace-events    |  9 +++++++++
-files changed, 40 insertions(+), 6 deletions(-)
-diff --git a/hw/intc/arm_gicv3_its.c b/hw/intc/arm_gicv3_its.c
-index XXXXXXX..XXXXXXX 100644
---- a/hw/intc/arm_gicv3_its.c
-+++ b/hw/intc/arm_gicv3_its.c
-@@ -XXX,XX +XXX,XX @@ static MemTxResult get_cte(GICv3ITSState *s, uint16_t icid, CTEntry *cte)
-     if (entry_addr == -1) {
-         /* No L2 table entry, i.e. no valid CTE, or a memory error */
-         cte->valid = false;
--        return res;
-+        goto out;
-     }
-     cteval = address_space_ldq_le(as, entry_addr, MEMTXATTRS_UNSPECIFIED, &res);
-     if (res != MEMTX_OK) {
--        return res;
-+        goto out;
-     }
-     cte->valid = FIELD_EX64(cteval, CTE, VALID);
-     cte->rdbase = FIELD_EX64(cteval, CTE, RDBASE);
--    return MEMTX_OK;
-+out:
-+    if (res != MEMTX_OK) {
-+        trace_gicv3_its_cte_read_fault(icid);
-+    } else {
-+        trace_gicv3_its_cte_read(icid, cte->valid, cte->rdbase);
-+    }
-+    return res;
- }
- /*
-@@ -XXX,XX +XXX,XX @@ static bool update_ite(GICv3ITSState *s, uint32_t eventid, const DTEntry *dte,
-     uint64_t itel = 0;
-     uint32_t iteh = 0;
-+    trace_gicv3_its_ite_write(dte->ittaddr, eventid, ite->valid,
-+                              ite->inttype, ite->intid, ite->icid,
-+                              ite->vpeid, ite->doorbell);
-+
-     if (ite->valid) {
-         itel = FIELD_DP64(itel, ITE_L, VALID, 1);
-         itel = FIELD_DP64(itel, ITE_L, INTTYPE, ite->inttype);
-@@ -XXX,XX +XXX,XX @@ static MemTxResult get_ite(GICv3ITSState *s, uint32_t eventid,
-     itel = address_space_ldq_le(as, iteaddr, MEMTXATTRS_UNSPECIFIED, &res);
-     if (res != MEMTX_OK) {
-+        trace_gicv3_its_ite_read_fault(dte->ittaddr, eventid);
-         return res;
-     }
-     iteh = address_space_ldl_le(as, iteaddr + 8, MEMTXATTRS_UNSPECIFIED, &res);
-     if (res != MEMTX_OK) {
-+        trace_gicv3_its_ite_read_fault(dte->ittaddr, eventid);
-         return res;
-     }
-@@ -XXX,XX +XXX,XX @@ static MemTxResult get_ite(GICv3ITSState *s, uint32_t eventid,
-     ite->icid = FIELD_EX64(itel, ITE_L, ICID);
-     ite->vpeid = FIELD_EX64(itel, ITE_L, VPEID);
-     ite->doorbell = FIELD_EX64(iteh, ITE_H, DOORBELL);
-+    trace_gicv3_its_ite_read(dte->ittaddr, eventid, ite->valid,
-+                             ite->inttype, ite->intid, ite->icid,
-+                             ite->vpeid, ite->doorbell);
-     return MEMTX_OK;
- }
-@@ -XXX,XX +XXX,XX @@ static MemTxResult get_dte(GICv3ITSState *s, uint32_t devid, DTEntry *dte)
-     if (entry_addr == -1) {
-         /* No L2 table entry, i.e. no valid DTE, or a memory error */
-         dte->valid = false;
--        return res;
-+        goto out;
-     }
-     dteval = address_space_ldq_le(as, entry_addr, MEMTXATTRS_UNSPECIFIED, &res);
-     if (res != MEMTX_OK) {
--        return res;
-+        goto out;
-     }
-     dte->valid = FIELD_EX64(dteval, DTE, VALID);
-     dte->size = FIELD_EX64(dteval, DTE, SIZE);
-     /* DTE word field stores bits [51:8] of the ITT address */
-     dte->ittaddr = FIELD_EX64(dteval, DTE, ITTADDR) << ITTADDR_SHIFT;
--    return MEMTX_OK;
-+out:
-+    if (res != MEMTX_OK) {
-+        trace_gicv3_its_dte_read_fault(devid);
-+    } else {
-+        trace_gicv3_its_dte_read(devid, dte->valid, dte->size, dte->ittaddr);
-+    }
-+    return res;
- }
- /*
-@@ -XXX,XX +XXX,XX @@ static bool update_cte(GICv3ITSState *s, uint16_t icid, const CTEntry *cte)
-     uint64_t cteval = 0;
-     MemTxResult res = MEMTX_OK;
-+    trace_gicv3_its_cte_write(icid, cte->valid, cte->rdbase);
-+
-     if (cte->valid) {
-         /* add mapping entry to collection table */
-         cteval = FIELD_DP64(cteval, CTE, VALID, 1);
-@@ -XXX,XX +XXX,XX @@ static bool update_dte(GICv3ITSState *s, uint32_t devid, const DTEntry *dte)
-     uint64_t dteval = 0;
-     MemTxResult res = MEMTX_OK;
-+    trace_gicv3_its_dte_write(devid, dte->valid, dte->size, dte->ittaddr);
-+
-     if (dte->valid) {
-         /* add mapping entry to device table */
-         dteval = FIELD_DP64(dteval, DTE, VALID, 1);
-diff --git a/hw/intc/trace-events b/hw/intc/trace-events
-index XXXXXXX..XXXXXXX 100644
---- a/hw/intc/trace-events
-+++ b/hw/intc/trace-events
-@@ -XXX,XX +XXX,XX @@ gicv3_its_cmd_inv(void) "GICv3 ITS: command INV or INVALL"
- gicv3_its_cmd_movall(uint64_t rd1, uint64_t rd2) "GICv3 ITS: command MOVALL RDbase1 0x%" PRIx64 " RDbase2 0x%" PRIx64
- gicv3_its_cmd_movi(uint32_t devid, uint32_t eventid, uint32_t icid) "GICv3 ITS: command MOVI DeviceID 0x%x EventID 0x%x ICID 0x%x"
- gicv3_its_cmd_unknown(unsigned cmd) "GICv3 ITS: unknown command 0x%x"
-+gicv3_its_cte_read(uint32_t icid, int valid, uint32_t rdbase) "GICv3 ITS: Collection Table read for ICID 0x%x: valid %d RDBase 0x%x"
-+gicv3_its_cte_write(uint32_t icid, int valid, uint32_t rdbase) "GICv3 ITS: Collection Table write for ICID 0x%x: valid %d RDBase 0x%x"
-+gicv3_its_cte_read_fault(uint32_t icid) "GICv3 ITS: Collection Table read for ICID 0x%x: faulted"
-+gicv3_its_ite_read(uint64_t ittaddr, uint32_t eventid, int valid, int inttype, uint32_t intid, uint32_t icid, uint32_t vpeid, uint32_t doorbell) "GICv3 ITS: Interrupt Table read for ITTaddr 0x%" PRIx64 " EventID 0x%x: valid %d inttype %d intid 0x%x ICID 0x%x vPEID 0x%x doorbell 0x%x"
-+gicv3_its_ite_read_fault(uint64_t ittaddr, uint32_t eventid) "GICv3 ITS: Interrupt Table read for ITTaddr 0x%" PRIx64 " EventID 0x%x: faulted"
-+gicv3_its_ite_write(uint64_t ittaddr, uint32_t eventid, int valid, int inttype, uint32_t intid, uint32_t icid, uint32_t vpeid, uint32_t doorbell) "GICv3 ITS: Interrupt Table write for ITTaddr 0x%" PRIx64 " EventID 0x%x: valid %d inttype %d intid 0x%x ICID 0x%x vPEID 0x%x doorbell 0x%x"
-+gicv3_its_dte_read(uint32_t devid, int valid, uint32_t size, uint64_t ittaddr) "GICv3 ITS: Device Table read for DeviceID 0x%x: valid %d size 0x%x ITTaddr 0x%" PRIx64
-+gicv3_its_dte_write(uint32_t devid, int valid, uint32_t size, uint64_t ittaddr) "GICv3 ITS: Device Table write for DeviceID 0x%x: valid %d size 0x%x ITTaddr 0x%" PRIx64
-+gicv3_its_dte_read_fault(uint32_t devid) "GICv3 ITS: Device Table read for DeviceID 0x%x: faulted"
- # armv7m_nvic.c
- nvic_recompute_state(int vectpending, int vectpending_prio, int exception_prio) "NVIC state recomputed: vectpending %d vectpending_prio %d exception_prio %d"
---
-.25.1

-[PULL 13/18] hw/intc/arm_gicv3: Specify valid and impl in MemoryRegionOps
+Deleted patch
-The GICv3 has some registers that support byte accesses, and some
-that support 8-byte accesses.  Our TCG implementation implements all
-of this, switching on the 'size' argument and handling the registers
-that must support reads of that size while logging an error for
-attempted accesses to registers that do not support that size access.
-However we forgot to tell the core memory subsystem about this by
-specifying the .impl and .valid fields in the MemoryRegionOps struct,
-so the core was happily simulating 8 byte accesses by combining two 4
-byte accesses.  This doesn't have much guest-visible effect, since
-there aren't many 8 byte registers and they all support being written
-in two 4 byte parts.
-Set the .impl and .valid fields to say that all sizes from 1 to 8
-bytes are both valid and implemented by the device.
-Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
-Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
-Message-id: 20220303202341.2232284-4-peter.maydell@linaro.org
----
- hw/intc/arm_gicv3.c | 8 ++++++++
-file changed, 8 insertions(+)
-diff --git a/hw/intc/arm_gicv3.c b/hw/intc/arm_gicv3.c
-index XXXXXXX..XXXXXXX 100644
---- a/hw/intc/arm_gicv3.c
-+++ b/hw/intc/arm_gicv3.c
-@@ -XXX,XX +XXX,XX @@ static const MemoryRegionOps gic_ops[] = {
-         .read_with_attrs = gicv3_dist_read,
-         .write_with_attrs = gicv3_dist_write,
-         .endianness = DEVICE_NATIVE_ENDIAN,
-+        .valid.min_access_size = 1,
-+        .valid.max_access_size = 8,
-+        .impl.min_access_size = 1,
-+        .impl.max_access_size = 8,
-     },
-     {
-         .read_with_attrs = gicv3_redist_read,
-         .write_with_attrs = gicv3_redist_write,
-         .endianness = DEVICE_NATIVE_ENDIAN,
-+        .valid.min_access_size = 1,
-+        .valid.max_access_size = 8,
-+        .impl.min_access_size = 1,
-+        .impl.max_access_size = 8,
-     }
- };
---
-.25.1

-[PULL 14/18] hw/intc/arm_gicv3: Fix missing spaces in error log messages
+Deleted patch
-We forgot a space in some log messages, so the output ended
-up looking like
-gicv3_dist_write: invalid guest write at offset 0000000000008000size 8
-with a missing space before "size". Add the missing spaces.
-Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
-Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
-Message-id: 20220303202341.2232284-5-peter.maydell@linaro.org
----
- hw/intc/arm_gicv3_dist.c | 4 ++--
- hw/intc/arm_gicv3_its.c  | 4 ++--
-files changed, 4 insertions(+), 4 deletions(-)
-diff --git a/hw/intc/arm_gicv3_dist.c b/hw/intc/arm_gicv3_dist.c
-index XXXXXXX..XXXXXXX 100644
---- a/hw/intc/arm_gicv3_dist.c
-+++ b/hw/intc/arm_gicv3_dist.c
-@@ -XXX,XX +XXX,XX @@ MemTxResult gicv3_dist_read(void *opaque, hwaddr offset, uint64_t *data,
-     if (!r) {
-         qemu_log_mask(LOG_GUEST_ERROR,
-                       "%s: invalid guest read at offset " TARGET_FMT_plx
--                      "size %u\n", __func__, offset, size);
-+                      " size %u\n", __func__, offset, size);
-         trace_gicv3_dist_badread(offset, size, attrs.secure);
-         /* The spec requires that reserved registers are RAZ/WI;
-          * so use MEMTX_ERROR returns from leaf functions as a way to
-@@ -XXX,XX +XXX,XX @@ MemTxResult gicv3_dist_write(void *opaque, hwaddr offset, uint64_t data,
-     if (!r) {
-         qemu_log_mask(LOG_GUEST_ERROR,
-                       "%s: invalid guest write at offset " TARGET_FMT_plx
--                      "size %u\n", __func__, offset, size);
-+                      " size %u\n", __func__, offset, size);
-         trace_gicv3_dist_badwrite(offset, data, size, attrs.secure);
-         /* The spec requires that reserved registers are RAZ/WI;
-          * so use MEMTX_ERROR returns from leaf functions as a way to
-diff --git a/hw/intc/arm_gicv3_its.c b/hw/intc/arm_gicv3_its.c
-index XXXXXXX..XXXXXXX 100644
---- a/hw/intc/arm_gicv3_its.c
-+++ b/hw/intc/arm_gicv3_its.c
-@@ -XXX,XX +XXX,XX @@ static MemTxResult gicv3_its_read(void *opaque, hwaddr offset, uint64_t *data,
-     if (!result) {
-         qemu_log_mask(LOG_GUEST_ERROR,
-                       "%s: invalid guest read at offset " TARGET_FMT_plx
--                      "size %u\n", __func__, offset, size);
-+                      " size %u\n", __func__, offset, size);
-         trace_gicv3_its_badread(offset, size);
-         /*
-          * The spec requires that reserved registers are RAZ/WI;
-@@ -XXX,XX +XXX,XX @@ static MemTxResult gicv3_its_write(void *opaque, hwaddr offset, uint64_t data,
-     if (!result) {
-         qemu_log_mask(LOG_GUEST_ERROR,
-                       "%s: invalid guest write at offset " TARGET_FMT_plx
--                      "size %u\n", __func__, offset, size);
-+                      " size %u\n", __func__, offset, size);
-         trace_gicv3_its_badwrite(offset, data, size);
-         /*
-          * The spec requires that reserved registers are RAZ/WI;
---
-.25.1

-[PULL 15/18] hw/intc/arm_gicv3_cpuif: Fix register names in ICV_HPPIR read trace event
+Deleted patch
-The trace_gicv3_icv_hppir_read trace event takes an integer value
-which it uses to form the register name, which should be either
-ICV_HPPIR0 or ICV_HPPIR1.  We were passing in the 'grp' variable for
-this, but that is either GICV3_G0 or GICV3_G1NS, which happen to be 0
-and 2, which meant that tracing for the ICV_HPPIR1 register was
-incorrectly printed as ICV_HPPIR2.
-Use the same approach we do for all the other similar trace events,
-and pass in 'ri->crm == 8 ?  0 : 1', deriving the index value
-directly from the ARMCPRegInfo struct.
-Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
-Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
-Message-id: 20220303202341.2232284-6-peter.maydell@linaro.org
----
- hw/intc/arm_gicv3_cpuif.c | 3 ++-
-file changed, 2 insertions(+), 1 deletion(-)
-diff --git a/hw/intc/arm_gicv3_cpuif.c b/hw/intc/arm_gicv3_cpuif.c
-index XXXXXXX..XXXXXXX 100644
---- a/hw/intc/arm_gicv3_cpuif.c
-+++ b/hw/intc/arm_gicv3_cpuif.c
-@@ -XXX,XX +XXX,XX @@ static uint64_t icv_hppir_read(CPUARMState *env, const ARMCPRegInfo *ri)
-         }
-     }
--    trace_gicv3_icv_hppir_read(grp, gicv3_redist_affid(cs), value);
-+    trace_gicv3_icv_hppir_read(ri->crm == 8 ? 0 : 1,
-+                               gicv3_redist_affid(cs), value);
-     return value;
- }
---
-.25.1

-[PULL 16/18] ui/cocoa: Use the standard about panel
+Deleted patch
-From: Akihiko Odaki <akihiko.odaki@gmail.com>
-This provides standard look and feel for the about panel and reduces
-code.
-Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
-Message-id: 20220227042241.1543-1-akihiko.odaki@gmail.com
-Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
-Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
----
- ui/cocoa.m | 112 +++++++++++------------------------------------------
-file changed, 23 insertions(+), 89 deletions(-)
-diff --git a/ui/cocoa.m b/ui/cocoa.m
-index XXXXXXX..XXXXXXX 100644
---- a/ui/cocoa.m
-+++ b/ui/cocoa.m
-@@ -XXX,XX +XXX,XX @@ static void cocoa_switch(DisplayChangeListener *dcl,
- static void cocoa_refresh(DisplayChangeListener *dcl);
--static NSWindow *normalWindow, *about_window;
-+static NSWindow *normalWindow;
- static const DisplayChangeListenerOps dcl_ops = {
-     .dpy_name          = "cocoa",
-     .dpy_gfx_update = cocoa_update,
-@@ -XXX,XX +XXX,XX @@ QemuCocoaView *cocoaView;
- - (BOOL)verifyQuit;
- - (void)openDocumentation:(NSString *)filename;
- - (IBAction) do_about_menu_item: (id) sender;
--- (void)make_about_window;
- - (void)adjustSpeed:(id)sender;
- @end
-@@ -XXX,XX +XXX,XX @@ QemuCocoaView *cocoaView;
-         [pauseLabel setFont: [NSFont fontWithName: @"Helvetica" size: 90]];
-         [pauseLabel setTextColor: [NSColor blackColor]];
-         [pauseLabel sizeToFit];
--
--        [self make_about_window];
-     }
-     return self;
- }
-@@ -XXX,XX +XXX,XX @@ QemuCocoaView *cocoaView;
- /* The action method for the About menu item */
- - (IBAction) do_about_menu_item: (id) sender
- {
--    [about_window makeKeyAndOrderFront: nil];
--}
--
--/* Create and display the about dialog */
--- (void)make_about_window
--{
--    /* Make the window */
--    int x = 0, y = 0, about_width = 400, about_height = 200;
--    NSRect window_rect = NSMakeRect(x, y, about_width, about_height);
--    about_window = [[NSWindow alloc] initWithContentRect:window_rect
--                    styleMask:NSWindowStyleMaskTitled | NSWindowStyleMaskClosable |
--                    NSWindowStyleMaskMiniaturizable
--                    backing:NSBackingStoreBuffered
--                    defer:NO];
--    [about_window setTitle: @"About"];
--    [about_window setReleasedWhenClosed: NO];
--    [about_window center];
--    NSView *superView = [about_window contentView];
--
--    /* Create the dimensions of the picture */
--    int picture_width = 80, picture_height = 80;
--    x = (about_width - picture_width)/2;
--    y = about_height - picture_height - 10;
--    NSRect picture_rect = NSMakeRect(x, y, picture_width, picture_height);
--
--    /* Make the picture of QEMU */
--    NSImageView *picture_view = [[NSImageView alloc] initWithFrame:
--                                                     picture_rect];
--    char *qemu_image_path_c = get_relocated_path(CONFIG_QEMU_ICONDIR "/hicolor/512x512/apps/qemu.png");
--    NSString *qemu_image_path = [NSString stringWithUTF8String:qemu_image_path_c];
--    g_free(qemu_image_path_c);
--    NSImage *qemu_image = [[NSImage alloc] initWithContentsOfFile:qemu_image_path];
--    [picture_view setImage: qemu_image];
--    [picture_view setImageScaling: NSImageScaleProportionallyUpOrDown];
--    [superView addSubview: picture_view];
--
--    /* Make the name label */
--    NSBundle *bundle = [NSBundle mainBundle];
--    if (bundle) {
--        x = 0;
--        y = y - 25;
--        int name_width = about_width, name_height = 20;
--        NSRect name_rect = NSMakeRect(x, y, name_width, name_height);
--        NSTextField *name_label = [[NSTextField alloc] initWithFrame: name_rect];
--        [name_label setEditable: NO];
--        [name_label setBezeled: NO];
--        [name_label setDrawsBackground: NO];
--        [name_label setAlignment: NSTextAlignmentCenter];
--        NSString *qemu_name = [[bundle executablePath] lastPathComponent];
--        [name_label setStringValue: qemu_name];
--        [superView addSubview: name_label];
-+    NSAutoreleasePool *pool = [[NSAutoreleasePool alloc] init];
-+    char *icon_path_c = get_relocated_path(CONFIG_QEMU_ICONDIR "/hicolor/512x512/apps/qemu.png");
-+    NSString *icon_path = [NSString stringWithUTF8String:icon_path_c];
-+    g_free(icon_path_c);
-+    NSImage *icon = [[NSImage alloc] initWithContentsOfFile:icon_path];
-+    NSString *version = @"QEMU emulator version " QEMU_FULL_VERSION;
-+    NSString *copyright = @QEMU_COPYRIGHT;
-+    NSDictionary *options;
-+    if (icon) {
-+        options = @{
-+            NSAboutPanelOptionApplicationIcon : icon,
-+            NSAboutPanelOptionApplicationVersion : version,
-+            @"Copyright" : copyright,
-+        };
-+        [icon release];
-+    } else {
-+        options = @{
-+            NSAboutPanelOptionApplicationVersion : version,
-+            @"Copyright" : copyright,
-+        };
-     }
--
--    /* Set the version label's attributes */
--    x = 0;
--    y = 50;
--    int version_width = about_width, version_height = 20;
--    NSRect version_rect = NSMakeRect(x, y, version_width, version_height);
--    NSTextField *version_label = [[NSTextField alloc] initWithFrame:
--                                                      version_rect];
--    [version_label setEditable: NO];
--    [version_label setBezeled: NO];
--    [version_label setAlignment: NSTextAlignmentCenter];
--    [version_label setDrawsBackground: NO];
--
--    /* Create the version string*/
--    NSString *version_string;
--    version_string = [[NSString alloc] initWithFormat:
--    @"QEMU emulator version %s", QEMU_FULL_VERSION];
--    [version_label setStringValue: version_string];
--    [superView addSubview: version_label];
--
--    /* Make copyright label */
--    x = 0;
--    y = 35;
--    int copyright_width = about_width, copyright_height = 20;
--    NSRect copyright_rect = NSMakeRect(x, y, copyright_width, copyright_height);
--    NSTextField *copyright_label = [[NSTextField alloc] initWithFrame:
--                                                        copyright_rect];
--    [copyright_label setEditable: NO];
--    [copyright_label setBezeled: NO];
--    [copyright_label setDrawsBackground: NO];
--    [copyright_label setAlignment: NSTextAlignmentCenter];
--    [copyright_label setStringValue: [NSString stringWithFormat: @"%s",
--                                     QEMU_COPYRIGHT]];
--    [superView addSubview: copyright_label];
-+    [NSApp orderFrontStandardAboutPanelWithOptions:options];
-+    [pool release];
- }
- /* Used by the Speed menu items */
---
-.25.1

-[PULL 17/18] target/arm: Provide cpu property for controling FEAT_LPA2
+Deleted patch
-From: Richard Henderson <richard.henderson@linaro.org>
-There is a Linux kernel bug present until v5.12 that prevents
-booting with FEAT_LPA2 enabled.  As a workaround for TCG, allow
-the feature to be disabled from -cpu max.
-Since this kernel bug is present in the Fedora 31 image that
-we test in avocado, disable lpa2 on the command-line.
-Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
-Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
-Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
----
- target/arm/cpu.h            |  5 ++++-
- target/arm/cpu.c            |  6 ++++++
- target/arm/cpu64.c          | 24 ++++++++++++++++++++++++
- tests/avocado/boot_linux.py |  2 ++
-files changed, 36 insertions(+), 1 deletion(-)
-diff --git a/target/arm/cpu.h b/target/arm/cpu.h
-index XXXXXXX..XXXXXXX 100644
---- a/target/arm/cpu.h
-+++ b/target/arm/cpu.h
-@@ -XXX,XX +XXX,XX @@ typedef struct {
- # define ARM_MAX_VQ    16
- void arm_cpu_sve_finalize(ARMCPU *cpu, Error **errp);
- void arm_cpu_pauth_finalize(ARMCPU *cpu, Error **errp);
-+void arm_cpu_lpa2_finalize(ARMCPU *cpu, Error **errp);
- #else
- # define ARM_MAX_VQ    1
- static inline void arm_cpu_sve_finalize(ARMCPU *cpu, Error **errp) { }
- static inline void arm_cpu_pauth_finalize(ARMCPU *cpu, Error **errp) { }
-+static inline void arm_cpu_lpa2_finalize(ARMCPU *cpu, Error **errp) { }
- #endif
- typedef struct ARMVectorReg {
-@@ -XXX,XX +XXX,XX @@ struct ARMCPU {
-     /*
-      * Intermediate values used during property parsing.
--     * Once finalized, the values should be read from ID_AA64ISAR1.
-+     * Once finalized, the values should be read from ID_AA64*.
-      */
-     bool prop_pauth;
-     bool prop_pauth_impdef;
-+    bool prop_lpa2;
-     /* DCZ blocksize, in log_2(words), ie low 4 bits of DCZID_EL0 */
-     uint32_t dcz_blocksize;
-diff --git a/target/arm/cpu.c b/target/arm/cpu.c
-index XXXXXXX..XXXXXXX 100644
---- a/target/arm/cpu.c
-+++ b/target/arm/cpu.c
-@@ -XXX,XX +XXX,XX @@ void arm_cpu_finalize_features(ARMCPU *cpu, Error **errp)
-             error_propagate(errp, local_err);
-             return;
-         }
-+
-+        arm_cpu_lpa2_finalize(cpu, &local_err);
-+        if (local_err != NULL) {
-+            error_propagate(errp, local_err);
-+            return;
-+        }
-     }
-     if (kvm_enabled()) {
-diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c
-index XXXXXXX..XXXXXXX 100644
---- a/target/arm/cpu64.c
-+++ b/target/arm/cpu64.c
-@@ -XXX,XX +XXX,XX @@ void aarch64_add_pauth_properties(Object *obj)
-     }
- }
-+static Property arm_cpu_lpa2_property =
-+    DEFINE_PROP_BOOL("lpa2", ARMCPU, prop_lpa2, true);
-+
-+void arm_cpu_lpa2_finalize(ARMCPU *cpu, Error **errp)
-+{
-+    uint64_t t;
-+
-+    /*
-+     * We only install the property for tcg -cpu max; this is the
-+     * only situation in which the cpu field can be true.
-+     */
-+    if (!cpu->prop_lpa2) {
-+        return;
-+    }
-+
-+    t = cpu->isar.id_aa64mmfr0;
-+    t = FIELD_DP64(t, ID_AA64MMFR0, TGRAN16, 2);   /* 16k pages w/ LPA2 */
-+    t = FIELD_DP64(t, ID_AA64MMFR0, TGRAN4, 1);    /*  4k pages w/ LPA2 */
-+    t = FIELD_DP64(t, ID_AA64MMFR0, TGRAN16_2, 3); /* 16k stage2 w/ LPA2 */
-+    t = FIELD_DP64(t, ID_AA64MMFR0, TGRAN4_2, 3);  /*  4k stage2 w/ LPA2 */
-+    cpu->isar.id_aa64mmfr0 = t;
-+}
-+
- static void aarch64_host_initfn(Object *obj)
- {
- #if defined(CONFIG_KVM)
-@@ -XXX,XX +XXX,XX @@ static void aarch64_max_initfn(Object *obj)
-     aarch64_add_sve_properties(obj);
-     object_property_add(obj, "sve-max-vq", "uint32", cpu_max_get_sve_max_vq,
-                         cpu_max_set_sve_max_vq, NULL, NULL);
-+    qdev_property_add_static(DEVICE(obj), &arm_cpu_lpa2_property);
- }
- static void aarch64_a64fx_initfn(Object *obj)
-diff --git a/tests/avocado/boot_linux.py b/tests/avocado/boot_linux.py
-index XXXXXXX..XXXXXXX 100644
---- a/tests/avocado/boot_linux.py
-+++ b/tests/avocado/boot_linux.py
-@@ -XXX,XX +XXX,XX @@ def test_virt_tcg_gicv2(self):
-         """
-         self.require_accelerator("tcg")
-         self.vm.add_args("-accel", "tcg")
-+        self.vm.add_args("-cpu", "max,lpa2=off")
-         self.vm.add_args("-machine", "virt,gic-version=2")
-         self.add_common_args()
-         self.launch_and_wait(set_up_ssh_connection=False)
-@@ -XXX,XX +XXX,XX @@ def test_virt_tcg_gicv3(self):
-         """
-         self.require_accelerator("tcg")
-         self.vm.add_args("-accel", "tcg")
-+        self.vm.add_args("-cpu", "max,lpa2=off")
-         self.vm.add_args("-machine", "virt,gic-version=3")
-         self.add_common_args()
-         self.launch_and_wait(set_up_ssh_connection=False)
---
-.25.1

-[PULL 18/18] hw/arm/virt: Disable LPA2 for -machine virt-6.2
+Deleted patch
-From: Richard Henderson <richard.henderson@linaro.org>
-There is a Linux kernel bug present until v5.12 that prevents
-booting with FEAT_LPA2 enabled.  As a workaround for TCG,
-disable this feature for machine versions prior to 7.0.
-Cc: Daniel P. Berrangé <berrange@redhat.com>
-Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
-Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
-Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
----
- include/hw/arm/virt.h | 1 +
- hw/arm/virt.c         | 7 +++++++
-files changed, 8 insertions(+)
-diff --git a/include/hw/arm/virt.h b/include/hw/arm/virt.h
-index XXXXXXX..XXXXXXX 100644
---- a/include/hw/arm/virt.h
-+++ b/include/hw/arm/virt.h
-@@ -XXX,XX +XXX,XX @@ struct VirtMachineClass {
-     bool no_secure_gpio;
-     /* Machines < 6.2 have no support for describing cpu topology to guest */
-     bool no_cpu_topology;
-+    bool no_tcg_lpa2;
- };
- struct VirtMachineState {
-diff --git a/hw/arm/virt.c b/hw/arm/virt.c
-index XXXXXXX..XXXXXXX 100644
---- a/hw/arm/virt.c
-+++ b/hw/arm/virt.c
-@@ -XXX,XX +XXX,XX @@ static void machvirt_init(MachineState *machine)
-             object_property_set_bool(cpuobj, "pmu", false, NULL);
-         }
-+        if (vmc->no_tcg_lpa2 && object_property_find(cpuobj, "lpa2")) {
-+            object_property_set_bool(cpuobj, "lpa2", false, NULL);
-+        }
-+
-         if (object_property_find(cpuobj, "reset-cbar")) {
-             object_property_set_int(cpuobj, "reset-cbar",
-                                     vms->memmap[VIRT_CPUPERIPHS].base,
-@@ -XXX,XX +XXX,XX @@ DEFINE_VIRT_MACHINE_AS_LATEST(7, 0)
- static void virt_machine_6_2_options(MachineClass *mc)
- {
-+    VirtMachineClass *vmc = VIRT_MACHINE_CLASS(OBJECT_CLASS(mc));
-+
-     virt_machine_7_0_options(mc);
-     compat_props_add(mc->compat_props, hw_compat_6_2, hw_compat_6_2_len);
-+    vmc->no_tcg_lpa2 = true;
- }
- DEFINE_VIRT_MACHINE(6, 2)
---
-.25.1

Last lot of target-arm stuff: cleanups, bug fixes; nothing major here.

-- PMM

The following changes since commit 9d662a6b22a0838a85c5432385f35db2488a33a5:

Merge remote-tracking branch 'remotes/legoater/tags/pull-ppc-20220305' into staging (2022-03-05 18:03:15 +0000)

are available in the Git repository at:

https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20220307

for you to fetch changes up to 0942820408dc788560f6968e9b5f011803b846c2:

hw/arm/virt: Disable LPA2 for -machine virt-6.2 (2022-03-07 14:32:21 +0000)

----------------------------------------------------------------
target-arm queue:
 * cleanups of qemu_oom_check() and qemu_memalign()
 * target/arm/translate-neon: UNDEF if VLD1/VST1 stride bits are non-zero
 * target/arm/translate-neon: Simplify align field check for VLD3
 * GICv3 ITS: add more trace events
 * GICv3 ITS: implement 8-byte accesses properly
 * GICv3: fix minor issues with some trace/log messages
 * ui/cocoa: Use the standard about panel
 * target/arm: Provide cpu property for controling FEAT_LPA2
 * hw/arm/virt: Disable LPA2 for -machine virt-6.2

----------------------------------------------------------------
Akihiko Odaki (1):
      ui/cocoa: Use the standard about panel

Peter Maydell (15):
      util: Make qemu_oom_check() a static function
      util: Unify implementations of qemu_memalign()
      util: Return valid allocation for qemu_try_memalign() with zero size
      meson.build: Don't misdetect posix_memalign() on Windows
      util: Share qemu_try_memalign() implementation between POSIX and Windows
      util: Use meson checks for valloc() and memalign() presence
      util: Put qemu_vfree() in memalign.c
      osdep: Move memalign-related functions to their own header
      target/arm/translate-neon: UNDEF if VLD1/VST1 stride bits are non-zero
      target/arm/translate-neon: Simplify align field check for VLD3
      hw/intc/arm_gicv3_its: Add trace events for commands
      hw/intc/arm_gicv3_its: Add trace events for table reads and writes
      hw/intc/arm_gicv3: Specify valid and impl in MemoryRegionOps
      hw/intc/arm_gicv3: Fix missing spaces in error log messages
      hw/intc/arm_gicv3_cpuif: Fix register names in ICV_HPPIR read trace event

Richard Henderson (2):
      target/arm: Provide cpu property for controling FEAT_LPA2
      hw/arm/virt: Disable LPA2 for -machine virt-6.2

The qemu_oom_check() function, which we define in both oslib-posix.c
and oslib-win32.c, is now used only locally in that file; make it
static.

diff --git a/include/qemu-common.h b/include/qemu-common.h
index XXXXXXX..XXXXXXX 100644
--- a/include/qemu-common.h
+++ b/include/qemu-common.h
@@ -XXX,XX +XXX,XX @@
 int qemu_main(int argc, char **argv, char **envp);
 #endif
 
-void *qemu_oom_check(void *ptr);
-
 ssize_t qemu_write_full(int fd, const void *buf, size_t count)
     QEMU_WARN_UNUSED_RESULT;
 
diff --git a/util/oslib-posix.c b/util/oslib-posix.c
index XXXXXXX..XXXXXXX 100644
--- a/util/oslib-posix.c
+++ b/util/oslib-posix.c
@@ -XXX,XX +XXX,XX @@ fail_close:
     return false;
 }
 
-void *qemu_oom_check(void *ptr)
+static void *qemu_oom_check(void *ptr)
 {
     if (ptr == NULL) {
         fprintf(stderr, "Failed to allocate memory: %s\n", strerror(errno));
diff --git a/util/oslib-win32.c b/util/oslib-win32.c
index XXXXXXX..XXXXXXX 100644
--- a/util/oslib-win32.c
+++ b/util/oslib-win32.c
@@ -XXX,XX +XXX,XX @@
 /* this must come after including "trace.h" */
 #include <shlobj.h>
 
-void *qemu_oom_check(void *ptr)
+static void *qemu_oom_check(void *ptr)
 {
     if (ptr == NULL) {
         fprintf(stderr, "Failed to allocate memory: %lu\n", GetLastError());
-- 
2.25.1

We implement qemu_memalign() in both oslib-posix.c and oslib-win32.c,
but the two versions are essentially the same: they call
qemu_try_memalign(), and abort() after printing an error message if
it fails.  The only difference is that the win32 version prints the
GetLastError() value whereas the POSIX version prints
strerror(errno).  However, this is a bug in the win32 version: in
commit dfbd0b873a85021 in 2020 we changed the implementation of
qemu_try_memalign() from using VirtualAlloc() (which sets the
GetLastError() value) to using _aligned_malloc() (which sets errno),
but didn't update the error message to match.

Replace the two separate functions with a single version in a
new memalign.c file, which drops the unnecessary extra qemu_oom_check()
function and instead prints a more useful message including the
requested size and alignment as well as the errno string.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20220226180723.1706285-4-peter.maydell@linaro.org
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 util/memalign.c    | 39 +++++++++++++++++++++++++++++++++++++++
 util/oslib-posix.c | 14 --------------
 util/oslib-win32.c | 14 --------------
 util/meson.build   |  1 +
 4 files changed, 40 insertions(+), 28 deletions(-)
 create mode 100644 util/memalign.c

diff --git a/util/memalign.c b/util/memalign.c
new file mode 100644
index XXXXXXX..XXXXXXX
--- /dev/null
+++ b/util/memalign.c
@@ -XXX,XX +XXX,XX @@
+/*
+ * memalign.c: Allocate an aligned memory region
+ *
+ * Copyright (c) 2003-2008 Fabrice Bellard
+ * Copyright (c) 2010-2016 Red Hat, Inc.
+ * Copyright (c) 2022 Linaro Ltd
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+ * THE SOFTWARE.
+ */
+
+#include "qemu/osdep.h"
+
+void *qemu_memalign(size_t alignment, size_t size)
+{
+    void *p = qemu_try_memalign(alignment, size);
+    if (p) {
+        return p;
+    }
+    fprintf(stderr,
+            "qemu_memalign: failed to allocate %zu bytes at alignment %zu: %s\n",
+            size, alignment, strerror(errno));
+    abort();
+}
diff --git a/util/oslib-posix.c b/util/oslib-posix.c
index XXXXXXX..XXXXXXX 100644
--- a/util/oslib-posix.c
+++ b/util/oslib-posix.c
@@ -XXX,XX +XXX,XX @@ fail_close:
     return false;
 }
 
-static void *qemu_oom_check(void *ptr)
-{
-    if (ptr == NULL) {
-        fprintf(stderr, "Failed to allocate memory: %s\n", strerror(errno));
-        abort();
-    }
-    return ptr;
-}
-
 void *qemu_try_memalign(size_t alignment, size_t size)
 {
     void *ptr;
@@ -XXX,XX +XXX,XX @@ void *qemu_try_memalign(size_t alignment, size_t size)
     return ptr;
 }
 
-void *qemu_memalign(size_t alignment, size_t size)
-{
-    return qemu_oom_check(qemu_try_memalign(alignment, size));
-}
-
 /* alloc shared memory pages */
 void *qemu_anon_ram_alloc(size_t size, uint64_t *alignment, bool shared,
                           bool noreserve)
diff --git a/util/oslib-win32.c b/util/oslib-win32.c
index XXXXXXX..XXXXXXX 100644
--- a/util/oslib-win32.c
+++ b/util/oslib-win32.c
@@ -XXX,XX +XXX,XX @@
 /* this must come after including "trace.h" */
 #include <shlobj.h>
 
-static void *qemu_oom_check(void *ptr)
-{
-    if (ptr == NULL) {
-        fprintf(stderr, "Failed to allocate memory: %lu\n", GetLastError());
-        abort();
-    }
-    return ptr;
-}
-
 void *qemu_try_memalign(size_t alignment, size_t size)
 {
     void *ptr;
@@ -XXX,XX +XXX,XX @@ void *qemu_try_memalign(size_t alignment, size_t size)
     return ptr;
 }
 
-void *qemu_memalign(size_t alignment, size_t size)
-{
-    return qemu_oom_check(qemu_try_memalign(alignment, size));
-}
-
 static int get_allocation_granularity(void)
 {
     SYSTEM_INFO system_info;
diff --git a/util/meson.build b/util/meson.build
index XXXXXXX..XXXXXXX 100644
--- a/util/meson.build
+++ b/util/meson.build
@@ -XXX,XX +XXX,XX @@ util_ss.add(when: 'CONFIG_POSIX', if_true: files('drm.c'))
 util_ss.add(files('guest-random.c'))
 util_ss.add(files('yank.c'))
 util_ss.add(files('int128.c'))
+util_ss.add(files('memalign.c'))
 
 if have_user
   util_ss.add(files('selfmap.c'))
-- 
2.25.1

Currently qemu_try_memalign()'s behaviour if asked to allocate
0 bytes is rather variable:
 * on Windows, we will assert
 * on POSIX platforms, we get the underlying behaviour of
   the posix_memalign() or equivalent function, which may be
   either "return a valid non-NULL pointer" or "return NULL"

Explictly check for 0 byte allocations, so we get consistent
behaviour across platforms.  We handle them by incrementing the size
so that we return a valid non-NULL pointer that can later be passed
to qemu_vfree().  This is permitted behaviour for the
posix_memalign() API and is the most usual way that underlying
malloc() etc implementations handle a zero-sized allocation request,
because it won't trip up calling code that assumes NULL means an
error.  (This includes our own qemu_memalign(), which will abort on
NULL.)

This change is a preparation for sharing the qemu_try_memalign() code
between Windows and POSIX.

diff --git a/util/oslib-posix.c b/util/oslib-posix.c
index XXXXXXX..XXXXXXX 100644
--- a/util/oslib-posix.c
+++ b/util/oslib-posix.c
@@ -XXX,XX +XXX,XX @@ void *qemu_try_memalign(size_t alignment, size_t size)
         g_assert(is_power_of_2(alignment));
     }
 
+    if (size == 0) {
+        size++;
+    }
 #if defined(CONFIG_POSIX_MEMALIGN)
     int ret;
     ret = posix_memalign(&ptr, alignment, size);
diff --git a/util/oslib-win32.c b/util/oslib-win32.c
index XXXXXXX..XXXXXXX 100644
--- a/util/oslib-win32.c
+++ b/util/oslib-win32.c
@@ -XXX,XX +XXX,XX @@ void *qemu_try_memalign(size_t alignment, size_t size)
 {
     void *ptr;
 
-    g_assert(size != 0);
     if (alignment < sizeof(void *)) {
         alignment = sizeof(void *);
     } else {
         g_assert(is_power_of_2(alignment));
     }
+    if (size == 0) {
+        size++;
+    }
     ptr = _aligned_malloc(size, alignment);
     trace_qemu_memalign(alignment, size, ptr);
     return ptr;
-- 
2.25.1

Currently we incorrectly think that posix_memalign() exists on
Windows.  This is because of a combination of:

* the msys2/mingw toolchain/libc claim to have a
   __builtin_posix_memalign when there isn't a builtin of that name
 * meson will assume that if you have a __builtin_foo that
   counts for has_function('foo')

Specifying a specific include file via prefix: causes meson to not
treat builtins as sufficient and actually look for the function
itself; see this meson pull request which added that as the official
way to get the right answer:
  https://github.com/mesonbuild/meson/pull/1150

Currently this misdectection doesn't cause problems because we only
use CONFIG_POSIX_MEMALIGN in oslib-posix.c; however that will change
in a following commit.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20220226180723.1706285-6-peter.maydell@linaro.org
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 meson.build | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/meson.build b/meson.build
index XXXXXXX..XXXXXXX 100644
--- a/meson.build
+++ b/meson.build
@@ -XXX,XX +XXX,XX @@ config_host_data.set('CONFIG_CLOCK_ADJTIME', cc.has_function('clock_adjtime'))
 config_host_data.set('CONFIG_DUP3', cc.has_function('dup3'))
 config_host_data.set('CONFIG_FALLOCATE', cc.has_function('fallocate'))
 config_host_data.set('CONFIG_POSIX_FALLOCATE', cc.has_function('posix_fallocate'))
-config_host_data.set('CONFIG_POSIX_MEMALIGN', cc.has_function('posix_memalign'))
+# Note that we need to specify prefix: here to avoid incorrectly
+# thinking that Windows has posix_memalign()
+config_host_data.set('CONFIG_POSIX_MEMALIGN', cc.has_function('posix_memalign', prefix: '#include <stdlib.h>'))
 config_host_data.set('CONFIG_PPOLL', cc.has_function('ppoll'))
 config_host_data.set('CONFIG_PREADV', cc.has_function('preadv', prefix: '#include <sys/uio.h>'))
 config_host_data.set('CONFIG_SEM_TIMEDWAIT', cc.has_function('sem_timedwait', dependencies: threads))
-- 
2.25.1

The qemu_try_memalign() functions for POSIX and Windows used to be
significantly different, but these days they are identical except for
the actual allocation function called, and the POSIX version already
has to have ifdeffery for different allocation functions.

Move to a single implementation in memalign.c, which uses the Windows
_aligned_malloc if we detect that function in meson.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20220226180723.1706285-7-peter.maydell@linaro.org
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 meson.build        |  1 +
 util/memalign.c    | 39 +++++++++++++++++++++++++++++++++++++++
 util/oslib-posix.c | 29 -----------------------------
 util/oslib-win32.c | 17 -----------------
 4 files changed, 40 insertions(+), 46 deletions(-)

diff --git a/meson.build b/meson.build
index XXXXXXX..XXXXXXX 100644
--- a/meson.build
+++ b/meson.build
@@ -XXX,XX +XXX,XX @@ config_host_data.set('CONFIG_POSIX_FALLOCATE', cc.has_function('posix_fallocate'
 # Note that we need to specify prefix: here to avoid incorrectly
 # thinking that Windows has posix_memalign()
 config_host_data.set('CONFIG_POSIX_MEMALIGN', cc.has_function('posix_memalign', prefix: '#include <stdlib.h>'))
+config_host_data.set('CONFIG_ALIGNED_MALLOC', cc.has_function('_aligned_malloc'))
 config_host_data.set('CONFIG_PPOLL', cc.has_function('ppoll'))
 config_host_data.set('CONFIG_PREADV', cc.has_function('preadv', prefix: '#include <sys/uio.h>'))
 config_host_data.set('CONFIG_SEM_TIMEDWAIT', cc.has_function('sem_timedwait', dependencies: threads))
diff --git a/util/memalign.c b/util/memalign.c
index XXXXXXX..XXXXXXX 100644
--- a/util/memalign.c
+++ b/util/memalign.c
@@ -XXX,XX +XXX,XX @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu/host-utils.h"
+#include "trace.h"
+
+void *qemu_try_memalign(size_t alignment, size_t size)
+{
+    void *ptr;
+
+    if (alignment < sizeof(void*)) {
+        alignment = sizeof(void*);
+    } else {
+        g_assert(is_power_of_2(alignment));
+    }
+
+    /*
+     * Handling of 0 allocations varies among the different
+     * platform APIs (for instance _aligned_malloc() will
+     * fail) -- ensure that we always return a valid non-NULL
+     * pointer that can be freed by qemu_vfree().
+     */
+    if (size == 0) {
+        size++;
+    }
+#if defined(CONFIG_POSIX_MEMALIGN)
+    int ret;
+    ret = posix_memalign(&ptr, alignment, size);
+    if (ret != 0) {
+        errno = ret;
+        ptr = NULL;
+    }
+#elif defined(CONFIG_ALIGNED_MALLOC)
+    ptr = _aligned_malloc(size, alignment);
+#elif defined(CONFIG_BSD)
+    ptr = valloc(size);
+#else
+    ptr = memalign(alignment, size);
+#endif
+    trace_qemu_memalign(alignment, size, ptr);
+    return ptr;
+}
 
 void *qemu_memalign(size_t alignment, size_t size)
 {
diff --git a/util/oslib-posix.c b/util/oslib-posix.c
index XXXXXXX..XXXXXXX 100644
--- a/util/oslib-posix.c
+++ b/util/oslib-posix.c
@@ -XXX,XX +XXX,XX @@ fail_close:
     return false;
 }
 
-void *qemu_try_memalign(size_t alignment, size_t size)
-{
-    void *ptr;
-
-    if (alignment < sizeof(void*)) {
-        alignment = sizeof(void*);
-    } else {
-        g_assert(is_power_of_2(alignment));
-    }
-
-    if (size == 0) {
-        size++;
-    }
-#if defined(CONFIG_POSIX_MEMALIGN)
-    int ret;
-    ret = posix_memalign(&ptr, alignment, size);
-    if (ret != 0) {
-        errno = ret;
-        ptr = NULL;
-    }
-#elif defined(CONFIG_BSD)
-    ptr = valloc(size);
-#else
-    ptr = memalign(alignment, size);
-#endif
-    trace_qemu_memalign(alignment, size, ptr);
-    return ptr;
-}
-
 /* alloc shared memory pages */
 void *qemu_anon_ram_alloc(size_t size, uint64_t *alignment, bool shared,
                           bool noreserve)
diff --git a/util/oslib-win32.c b/util/oslib-win32.c
index XXXXXXX..XXXXXXX 100644
--- a/util/oslib-win32.c
+++ b/util/oslib-win32.c
@@ -XXX,XX +XXX,XX @@
 /* this must come after including "trace.h" */
 #include <shlobj.h>
 
-void *qemu_try_memalign(size_t alignment, size_t size)
-{
-    void *ptr;
-
-    if (alignment < sizeof(void *)) {
-        alignment = sizeof(void *);
-    } else {
-        g_assert(is_power_of_2(alignment));
-    }
-    if (size == 0) {
-        size++;
-    }
-    ptr = _aligned_malloc(size, alignment);
-    trace_qemu_memalign(alignment, size, ptr);
-    return ptr;
-}
-
 static int get_allocation_granularity(void)
 {
     SYSTEM_INFO system_info;
-- 
2.25.1

Instead of assuming that all CONFIG_BSD have valloc() and anything
else is memalign(), explicitly check for those functions in
meson.build and use the "is the function present" define.  Tests for
specific functionality are better than which-OS checks; this also
lets us give a helpful error message if somehow there's no usable
function present.

diff --git a/meson.build b/meson.build
index XXXXXXX..XXXXXXX 100644
--- a/meson.build
+++ b/meson.build
@@ -XXX,XX +XXX,XX @@ config_host_data.set('CONFIG_POSIX_FALLOCATE', cc.has_function('posix_fallocate'
 # thinking that Windows has posix_memalign()
 config_host_data.set('CONFIG_POSIX_MEMALIGN', cc.has_function('posix_memalign', prefix: '#include <stdlib.h>'))
 config_host_data.set('CONFIG_ALIGNED_MALLOC', cc.has_function('_aligned_malloc'))
+config_host_data.set('CONFIG_VALLOC', cc.has_function('valloc'))
+config_host_data.set('CONFIG_MEMALIGN', cc.has_function('memalign'))
 config_host_data.set('CONFIG_PPOLL', cc.has_function('ppoll'))
 config_host_data.set('CONFIG_PREADV', cc.has_function('preadv', prefix: '#include <sys/uio.h>'))
 config_host_data.set('CONFIG_SEM_TIMEDWAIT', cc.has_function('sem_timedwait', dependencies: threads))
diff --git a/util/memalign.c b/util/memalign.c
index XXXXXXX..XXXXXXX 100644
--- a/util/memalign.c
+++ b/util/memalign.c
@@ -XXX,XX +XXX,XX @@ void *qemu_try_memalign(size_t alignment, size_t size)
     }
 #elif defined(CONFIG_ALIGNED_MALLOC)
     ptr = _aligned_malloc(size, alignment);
-#elif defined(CONFIG_BSD)
+#elif defined(CONFIG_VALLOC)
     ptr = valloc(size);
-#else
+#elif defined(CONFIG_MEMALIGN)
     ptr = memalign(alignment, size);
+#else
+    #error No function to allocate aligned memory available
 #endif
     trace_qemu_memalign(alignment, size, ptr);
     return ptr;
-- 
2.25.1

qemu_vfree() is the companion free function to qemu_memalign(); put
it in memalign.c so the allocation and free functions are together.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20220226180723.1706285-9-peter.maydell@linaro.org
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 util/memalign.c    | 11 +++++++++++
 util/oslib-posix.c |  6 ------
 util/oslib-win32.c |  6 ------
 3 files changed, 11 insertions(+), 12 deletions(-)

diff --git a/util/memalign.c b/util/memalign.c
index XXXXXXX..XXXXXXX 100644
--- a/util/memalign.c
+++ b/util/memalign.c
@@ -XXX,XX +XXX,XX @@ void *qemu_memalign(size_t alignment, size_t size)
             size, alignment, strerror(errno));
     abort();
 }
+
+void qemu_vfree(void *ptr)
+{
+    trace_qemu_vfree(ptr);
+#if !defined(CONFIG_POSIX_MEMALIGN) && defined(CONFIG_ALIGNED_MALLOC)
+    /* Only Windows _aligned_malloc needs a special free function */
+    _aligned_free(ptr);
+#else
+    free(ptr);
+#endif
+}
diff --git a/util/oslib-posix.c b/util/oslib-posix.c
index XXXXXXX..XXXXXXX 100644
--- a/util/oslib-posix.c
+++ b/util/oslib-posix.c
@@ -XXX,XX +XXX,XX @@ void *qemu_anon_ram_alloc(size_t size, uint64_t *alignment, bool shared,
     return ptr;
 }
 
-void qemu_vfree(void *ptr)
-{
-    trace_qemu_vfree(ptr);
-    free(ptr);
-}
-
 void qemu_anon_ram_free(void *ptr, size_t size)
 {
     trace_qemu_anon_ram_free(ptr, size);
diff --git a/util/oslib-win32.c b/util/oslib-win32.c
index XXXXXXX..XXXXXXX 100644
--- a/util/oslib-win32.c
+++ b/util/oslib-win32.c
@@ -XXX,XX +XXX,XX @@ void *qemu_anon_ram_alloc(size_t size, uint64_t *align, bool shared,
     return ptr;
 }
 
-void qemu_vfree(void *ptr)
-{
-    trace_qemu_vfree(ptr);
-    _aligned_free(ptr);
-}
-
 void qemu_anon_ram_free(void *ptr, size_t size)
 {
     trace_qemu_anon_ram_free(ptr, size);
-- 
2.25.1

Move the various memalign-related functions out of osdep.h and into
their own header, which we include only where they are used.
While we're doing this, add some brief documentation comments.

diff --git a/include/qemu/memalign.h b/include/qemu/memalign.h
new file mode 100644
index XXXXXXX..XXXXXXX
--- /dev/null
+++ b/include/qemu/memalign.h
@@ -XXX,XX +XXX,XX @@
+/*
+ * Allocation and free functions for aligned memory
+ *
+ * This work is licensed under the terms of the GNU GPL, version 2 or later.
+ * See the COPYING file in the top-level directory.
+ */
+
+#ifndef QEMU_MEMALIGN_H
+#define QEMU_MEMALIGN_H
+
+/**
+ * qemu_try_memalign: Allocate aligned memory
+ * @alignment: required alignment, in bytes
+ * @size: size of allocation, in bytes
+ *
+ * Allocate memory on an aligned boundary (i.e. the returned
+ * address will be an exact multiple of @alignment).
+ * @alignment must be a power of 2, or the function will assert().
+ * On success, returns allocated memory; on failure, returns NULL.
+ *
+ * The memory allocated through this function must be freed via
+ * qemu_vfree() (and not via free()).
+ */
+void *qemu_try_memalign(size_t alignment, size_t size);
+/**
+ * qemu_memalign: Allocate aligned memory, without failing
+ * @alignment: required alignment, in bytes
+ * @size: size of allocation, in bytes
+ *
+ * Allocate memory in the same way as qemu_try_memalign(), but
+ * abort() with an error message if the memory allocation fails.
+ *
+ * The memory allocated through this function must be freed via
+ * qemu_vfree() (and not via free()).
+ */
+void *qemu_memalign(size_t alignment, size_t size);
+/**
+ * qemu_vfree: Free memory allocated through qemu_memalign
+ * @ptr: memory to free
+ *
+ * This function must be used to free memory allocated via qemu_memalign()
+ * or qemu_try_memalign(). (Using the wrong free function will cause
+ * subtle bugs on Windows hosts.)
+ */
+void qemu_vfree(void *ptr);
+/*
+ * It's an analog of GLIB's g_autoptr_cleanup_generic_gfree(), used to define
+ * g_autofree macro.
+ */
+static inline void qemu_cleanup_generic_vfree(void *p)
+{
+  void **pp = (void **)p;
+  qemu_vfree(*pp);
+}
+
+/*
+ * Analog of g_autofree, but qemu_vfree is called on cleanup instead of g_free.
+ */
+#define QEMU_AUTO_VFREE __attribute__((cleanup(qemu_cleanup_generic_vfree)))
+
+#endif
diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h
index XXXXXXX..XXXXXXX 100644
--- a/include/qemu/osdep.h
+++ b/include/qemu/osdep.h
@@ -XXX,XX +XXX,XX @@ extern "C" {
 #endif
 
 int qemu_daemon(int nochdir, int noclose);
-void *qemu_try_memalign(size_t alignment, size_t size);
-void *qemu_memalign(size_t alignment, size_t size);
 void *qemu_anon_ram_alloc(size_t size, uint64_t *align, bool shared,
                           bool noreserve);
-void qemu_vfree(void *ptr);
 void qemu_anon_ram_free(void *ptr, size_t size);
 
-/*
- * It's an analog of GLIB's g_autoptr_cleanup_generic_gfree(), used to define
- * g_autofree macro.
- */
-static inline void qemu_cleanup_generic_vfree(void *p)
-{
-  void **pp = (void **)p;
-  qemu_vfree(*pp);
-}
-
-/*
- * Analog of g_autofree, but qemu_vfree is called on cleanup instead of g_free.
- */
-#define QEMU_AUTO_VFREE __attribute__((cleanup(qemu_cleanup_generic_vfree)))
-
 #ifdef _WIN32
 #define HAVE_CHARDEV_SERIAL 1
 #elif defined(__linux__) || defined(__sun__) || defined(__FreeBSD__)    \
diff --git a/block/blkverify.c b/block/blkverify.c
index XXXXXXX..XXXXXXX 100644
--- a/block/blkverify.c
+++ b/block/blkverify.c
@@ -XXX,XX +XXX,XX @@
 #include "qemu/cutils.h"
 #include "qemu/module.h"
 #include "qemu/option.h"
+#include "qemu/memalign.h"
 
 typedef struct {
     BdrvChild *test_file;
diff --git a/block/block-copy.c b/block/block-copy.c
index XXXXXXX..XXXXXXX 100644
--- a/block/block-copy.c
+++ b/block/block-copy.c
@@ -XXX,XX +XXX,XX @@
 #include "qemu/coroutine.h"
 #include "block/aio_task.h"
 #include "qemu/error-report.h"
+#include "qemu/memalign.h"
 
 #define BLOCK_COPY_MAX_COPY_RANGE (16 * MiB)
 #define BLOCK_COPY_MAX_BUFFER (1 * MiB)
diff --git a/block/commit.c b/block/commit.c
index XXXXXXX..XXXXXXX 100644
--- a/block/commit.c
+++ b/block/commit.c
@@ -XXX,XX +XXX,XX @@
 #include "qapi/error.h"
 #include "qapi/qmp/qerror.h"
 #include "qemu/ratelimit.h"
+#include "qemu/memalign.h"
 #include "sysemu/block-backend.h"
 
 enum {
diff --git a/block/crypto.c b/block/crypto.c
index XXXXXXX..XXXXXXX 100644
--- a/block/crypto.c
+++ b/block/crypto.c
@@ -XXX,XX +XXX,XX @@
 #include "qemu/module.h"
 #include "qemu/option.h"
 #include "qemu/cutils.h"
+#include "qemu/memalign.h"
 #include "crypto.h"
 
 typedef struct BlockCrypto BlockCrypto;
diff --git a/block/dmg.c b/block/dmg.c
index XXXXXXX..XXXXXXX 100644
--- a/block/dmg.c
+++ b/block/dmg.c
@@ -XXX,XX +XXX,XX @@
 #include "qemu/bswap.h"
 #include "qemu/error-report.h"
 #include "qemu/module.h"
+#include "qemu/memalign.h"
 #include "dmg.h"
 
 int (*dmg_uncompress_bz2)(char *next_in, unsigned int avail_in,
diff --git a/block/export/fuse.c b/block/export/fuse.c
index XXXXXXX..XXXXXXX 100644
--- a/block/export/fuse.c
+++ b/block/export/fuse.c
@@ -XXX,XX +XXX,XX @@
 #define FUSE_USE_VERSION 31
 
 #include "qemu/osdep.h"
+#include "qemu/memalign.h"
 #include "block/aio.h"
 #include "block/block.h"
 #include "block/export.h"
diff --git a/block/file-posix.c b/block/file-posix.c
index XXXXXXX..XXXXXXX 100644
--- a/block/file-posix.c
+++ b/block/file-posix.c
@@ -XXX,XX +XXX,XX @@
 #include "qemu/module.h"
 #include "qemu/option.h"
 #include "qemu/units.h"
+#include "qemu/memalign.h"
 #include "trace.h"
 #include "block/thread-pool.h"
 #include "qemu/iov.h"
diff --git a/block/io.c b/block/io.c
index XXXXXXX..XXXXXXX 100644
--- a/block/io.c
+++ b/block/io.c
@@ -XXX,XX +XXX,XX @@
 #include "block/coroutines.h"
 #include "block/write-threshold.h"
 #include "qemu/cutils.h"
+#include "qemu/memalign.h"
 #include "qapi/error.h"
 #include "qemu/error-report.h"
 #include "qemu/main-loop.h"
diff --git a/block/mirror.c b/block/mirror.c
index XXXXXXX..XXXXXXX 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -XXX,XX +XXX,XX @@
 #include "qapi/qmp/qerror.h"
 #include "qemu/ratelimit.h"
 #include "qemu/bitmap.h"
+#include "qemu/memalign.h"
 
 #define MAX_IN_FLIGHT 16
 #define MAX_IO_BYTES (1 << 20) /* 1 Mb */
diff --git a/block/nvme.c b/block/nvme.c
index XXXXXXX..XXXXXXX 100644
--- a/block/nvme.c
+++ b/block/nvme.c
@@ -XXX,XX +XXX,XX @@
 #include "qemu/module.h"
 #include "qemu/cutils.h"
 #include "qemu/option.h"
+#include "qemu/memalign.h"
 #include "qemu/vfio-helpers.h"
 #include "block/block_int.h"
 #include "sysemu/replay.h"
diff --git a/block/parallels-ext.c b/block/parallels-ext.c
index XXXXXXX..XXXXXXX 100644
--- a/block/parallels-ext.c
+++ b/block/parallels-ext.c
@@ -XXX,XX +XXX,XX @@
 #include "parallels.h"
 #include "crypto/hash.h"
 #include "qemu/uuid.h"
+#include "qemu/memalign.h"
 
 #define PARALLELS_FORMAT_EXTENSION_MAGIC 0xAB234CEF23DCEA87ULL
 
diff --git a/block/parallels.c b/block/parallels.c
index XXXXXXX..XXXXXXX 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -XXX,XX +XXX,XX @@
 #include "qapi/qapi-visit-block-core.h"
 #include "qemu/bswap.h"
 #include "qemu/bitmap.h"
+#include "qemu/memalign.h"
 #include "migration/blocker.h"
 #include "parallels.h"
 
diff --git a/block/qcow.c b/block/qcow.c
index XXXXXXX..XXXXXXX 100644
--- a/block/qcow.c
+++ b/block/qcow.c
@@ -XXX,XX +XXX,XX @@
 #include "qemu/option.h"
 #include "qemu/bswap.h"
 #include "qemu/cutils.h"
+#include "qemu/memalign.h"
 #include <zlib.h>
 #include "qapi/qmp/qdict.h"
 #include "qapi/qmp/qstring.h"
diff --git a/block/qcow2-cache.c b/block/qcow2-cache.c
index XXXXXXX..XXXXXXX 100644
--- a/block/qcow2-cache.c
+++ b/block/qcow2-cache.c
@@ -XXX,XX +XXX,XX @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu/memalign.h"
 #include "qcow2.h"
 #include "trace.h"
 
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index XXXXXXX..XXXXXXX 100644
--- a/block/qcow2-cluster.c
+++ b/block/qcow2-cluster.c
@@ -XXX,XX +XXX,XX @@
 #include "qapi/error.h"
 #include "qcow2.h"
 #include "qemu/bswap.h"
+#include "qemu/memalign.h"
 #include "trace.h"
 
 int qcow2_shrink_l1_table(BlockDriverState *bs, uint64_t exact_size)
diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
index XXXXXXX..XXXXXXX 100644
--- a/block/qcow2-refcount.c
+++ b/block/qcow2-refcount.c
@@ -XXX,XX +XXX,XX @@
 #include "qemu/range.h"
 #include "qemu/bswap.h"
 #include "qemu/cutils.h"
+#include "qemu/memalign.h"
 #include "trace.h"
 
 static int64_t alloc_clusters_noref(BlockDriverState *bs, uint64_t size,
diff --git a/block/qcow2-snapshot.c b/block/qcow2-snapshot.c
index XXXXXXX..XXXXXXX 100644
--- a/block/qcow2-snapshot.c
+++ b/block/qcow2-snapshot.c
@@ -XXX,XX +XXX,XX @@
 #include "qemu/bswap.h"
 #include "qemu/error-report.h"
 #include "qemu/cutils.h"
+#include "qemu/memalign.h"
 
 static void qcow2_free_single_snapshot(BlockDriverState *bs, int i)
 {
diff --git a/block/qcow2.c b/block/qcow2.c
index XXXXXXX..XXXXXXX 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -XXX,XX +XXX,XX @@
 #include "qemu/option_int.h"
 #include "qemu/cutils.h"
 #include "qemu/bswap.h"
+#include "qemu/memalign.h"
 #include "qapi/qobject-input-visitor.h"
 #include "qapi/qapi-visit-block-core.h"
 #include "crypto.h"
diff --git a/block/qed-l2-cache.c b/block/qed-l2-cache.c
index XXXXXXX..XXXXXXX 100644
--- a/block/qed-l2-cache.c
+++ b/block/qed-l2-cache.c
@@ -XXX,XX +XXX,XX @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu/memalign.h"
 #include "trace.h"
 #include "qed.h"
 
diff --git a/block/qed-table.c b/block/qed-table.c
index XXXXXXX..XXXXXXX 100644
--- a/block/qed-table.c
+++ b/block/qed-table.c
@@ -XXX,XX +XXX,XX @@
 #include "qemu/sockets.h" /* for EINPROGRESS on Windows */
 #include "qed.h"
 #include "qemu/bswap.h"
+#include "qemu/memalign.h"
 
 /* Called with table_lock held.  */
 static int coroutine_fn qed_read_table(BDRVQEDState *s, uint64_t offset,
diff --git a/block/qed.c b/block/qed.c
index XXXXXXX..XXXXXXX 100644
--- a/block/qed.c
+++ b/block/qed.c
@@ -XXX,XX +XXX,XX @@
 #include "qemu/main-loop.h"
 #include "qemu/module.h"
 #include "qemu/option.h"
+#include "qemu/memalign.h"
 #include "trace.h"
 #include "qed.h"
 #include "sysemu/block-backend.h"
diff --git a/block/quorum.c b/block/quorum.c
index XXXXXXX..XXXXXXX 100644
--- a/block/quorum.c
+++ b/block/quorum.c
@@ -XXX,XX +XXX,XX @@
 #include "qemu/cutils.h"
 #include "qemu/module.h"
 #include "qemu/option.h"
+#include "qemu/memalign.h"
 #include "block/block_int.h"
 #include "block/coroutines.h"
 #include "block/qdict.h"
diff --git a/block/raw-format.c b/block/raw-format.c
index XXXXXXX..XXXXXXX 100644
--- a/block/raw-format.c
+++ b/block/raw-format.c
@@ -XXX,XX +XXX,XX @@
 #include "qapi/error.h"
 #include "qemu/module.h"
 #include "qemu/option.h"
+#include "qemu/memalign.h"
 
 typedef struct BDRVRawState {
     uint64_t offset;
diff --git a/block/vdi.c b/block/vdi.c
index XXXXXXX..XXXXXXX 100644
--- a/block/vdi.c
+++ b/block/vdi.c
@@ -XXX,XX +XXX,XX @@
 #include "qemu/coroutine.h"
 #include "qemu/cutils.h"
 #include "qemu/uuid.h"
+#include "qemu/memalign.h"
 
 /* Code configuration options. */
 
diff --git a/block/vhdx-log.c b/block/vhdx-log.c
index XXXXXXX..XXXXXXX 100644
--- a/block/vhdx-log.c
+++ b/block/vhdx-log.c
@@ -XXX,XX +XXX,XX @@
 #include "block/block_int.h"
 #include "qemu/error-report.h"
 #include "qemu/bswap.h"
+#include "qemu/memalign.h"
 #include "vhdx.h"
 
 
diff --git a/block/vhdx.c b/block/vhdx.c
index XXXXXXX..XXXXXXX 100644
--- a/block/vhdx.c
+++ b/block/vhdx.c
@@ -XXX,XX +XXX,XX @@
 #include "qemu/crc32c.h"
 #include "qemu/bswap.h"
 #include "qemu/error-report.h"
+#include "qemu/memalign.h"
 #include "vhdx.h"
 #include "migration/blocker.h"
 #include "qemu/uuid.h"
diff --git a/block/vmdk.c b/block/vmdk.c
index XXXXXXX..XXXXXXX 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -XXX,XX +XXX,XX @@
 #include "qemu/module.h"
 #include "qemu/option.h"
 #include "qemu/bswap.h"
+#include "qemu/memalign.h"
 #include "migration/blocker.h"
 #include "qemu/cutils.h"
 #include <zlib.h>
diff --git a/block/vpc.c b/block/vpc.c
index XXXXXXX..XXXXXXX 100644
--- a/block/vpc.c
+++ b/block/vpc.c
@@ -XXX,XX +XXX,XX @@
 #include "migration/blocker.h"
 #include "qemu/bswap.h"
 #include "qemu/uuid.h"
+#include "qemu/memalign.h"
 #include "qapi/qmp/qdict.h"
 #include "qapi/qobject-input-visitor.h"
 #include "qapi/qapi-visit-block-core.h"
diff --git a/block/win32-aio.c b/block/win32-aio.c
index XXXXXXX..XXXXXXX 100644
--- a/block/win32-aio.c
+++ b/block/win32-aio.c
@@ -XXX,XX +XXX,XX @@
 #include "block/raw-aio.h"
 #include "qemu/event_notifier.h"
 #include "qemu/iov.h"
+#include "qemu/memalign.h"
 #include <windows.h>
 #include <winioctl.h>
 
diff --git a/hw/block/dataplane/xen-block.c b/hw/block/dataplane/xen-block.c
index XXXXXXX..XXXXXXX 100644
--- a/hw/block/dataplane/xen-block.c
+++ b/hw/block/dataplane/xen-block.c
@@ -XXX,XX +XXX,XX @@
 #include "qemu/osdep.h"
 #include "qemu/error-report.h"
 #include "qemu/main-loop.h"
+#include "qemu/memalign.h"
 #include "qapi/error.h"
 #include "hw/xen/xen_common.h"
 #include "hw/block/xen_blkif.h"
diff --git a/hw/block/fdc.c b/hw/block/fdc.c
index XXXXXXX..XXXXXXX 100644
--- a/hw/block/fdc.c
+++ b/hw/block/fdc.c
@@ -XXX,XX +XXX,XX @@
 #include "qapi/error.h"
 #include "qemu/error-report.h"
 #include "qemu/timer.h"
+#include "qemu/memalign.h"
 #include "hw/irq.h"
 #include "hw/isa/isa.h"
 #include "hw/qdev-properties.h"
diff --git a/hw/ide/core.c b/hw/ide/core.c
index XXXXXXX..XXXXXXX 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -XXX,XX +XXX,XX @@
 #include "qemu/main-loop.h"
 #include "qemu/timer.h"
 #include "qemu/hw-version.h"
+#include "qemu/memalign.h"
 #include "sysemu/sysemu.h"
 #include "sysemu/blockdev.h"
 #include "sysemu/dma.h"
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index XXXXXXX..XXXXXXX 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -XXX,XX +XXX,XX @@
 #include "qemu/osdep.h"
 #include "qemu-common.h"
 #include "qemu/datadir.h"
+#include "qemu/memalign.h"
 #include "qapi/error.h"
 #include "qapi/qapi-events-machine.h"
 #include "qapi/qapi-events-qdev.h"
diff --git a/hw/ppc/spapr_softmmu.c b/hw/ppc/spapr_softmmu.c
index XXXXXXX..XXXXXXX 100644
--- a/hw/ppc/spapr_softmmu.c
+++ b/hw/ppc/spapr_softmmu.c
@@ -XXX,XX +XXX,XX @@
 #include "qemu/osdep.h"
 #include "qemu/cutils.h"
+#include "qemu/memalign.h"
 #include "cpu.h"
 #include "helper_regs.h"
 #include "hw/ppc/spapr.h"
diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
index XXXXXXX..XXXXXXX 100644
--- a/hw/scsi/scsi-disk.c
+++ b/hw/scsi/scsi-disk.c
@@ -XXX,XX +XXX,XX @@
 #include "qemu/main-loop.h"
 #include "qemu/module.h"
 #include "qemu/hw-version.h"
+#include "qemu/memalign.h"
 #include "hw/scsi/scsi.h"
 #include "migration/qemu-file-types.h"
 #include "migration/vmstate.h"
diff --git a/hw/tpm/tpm_ppi.c b/hw/tpm/tpm_ppi.c
index XXXXXXX..XXXXXXX 100644
--- a/hw/tpm/tpm_ppi.c
+++ b/hw/tpm/tpm_ppi.c
@@ -XXX,XX +XXX,XX @@
  */
 
 #include "qemu/osdep.h"
-
+#include "qemu/memalign.h"
 #include "qapi/error.h"
 #include "sysemu/memory_mapping.h"
 #include "migration/vmstate.h"
diff --git a/nbd/server.c b/nbd/server.c
index XXXXXXX..XXXXXXX 100644
--- a/nbd/server.c
+++ b/nbd/server.c
@@ -XXX,XX +XXX,XX @@
 #include "trace.h"
 #include "nbd-internal.h"
 #include "qemu/units.h"
+#include "qemu/memalign.h"
 
 #define NBD_META_ID_BASE_ALLOCATION 0
 #define NBD_META_ID_ALLOCATION_DEPTH 1
diff --git a/net/l2tpv3.c b/net/l2tpv3.c
index XXXXXXX..XXXXXXX 100644
--- a/net/l2tpv3.c
+++ b/net/l2tpv3.c
@@ -XXX,XX +XXX,XX @@
 #include "qemu/sockets.h"
 #include "qemu/iov.h"
 #include "qemu/main-loop.h"
-
+#include "qemu/memalign.h"
 
 /* The buffer size needs to be investigated for optimum numbers and
  * optimum means of paging in on different systems. This size is
diff --git a/plugins/loader.c b/plugins/loader.c
index XXXXXXX..XXXXXXX 100644
--- a/plugins/loader.c
+++ b/plugins/loader.c
@@ -XXX,XX +XXX,XX @@
 #include "qemu/cacheinfo.h"
 #include "qemu/xxhash.h"
 #include "qemu/plugin.h"
+#include "qemu/memalign.h"
 #include "hw/core/cpu.h"
 #include "exec/exec-all.h"
 #ifndef CONFIG_USER_ONLY
diff --git a/qemu-img.c b/qemu-img.c
index XXXXXXX..XXXXXXX 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -XXX,XX +XXX,XX @@
 #include "qemu/module.h"
 #include "qemu/sockets.h"
 #include "qemu/units.h"
+#include "qemu/memalign.h"
 #include "qom/object_interfaces.h"
 #include "sysemu/block-backend.h"
 #include "block/block_int.h"
diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c
index XXXXXXX..XXXXXXX 100644
--- a/qemu-io-cmds.c
+++ b/qemu-io-cmds.c
@@ -XXX,XX +XXX,XX @@
 #include "qemu/option.h"
 #include "qemu/timer.h"
 #include "qemu/cutils.h"
+#include "qemu/memalign.h"
 
 #define CMD_NOFILE_OK   0x01
 
diff --git a/qom/object.c b/qom/object.c
index XXXXXXX..XXXXXXX 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -XXX,XX +XXX,XX @@
 #include "qom/object.h"
 #include "qom/object_interfaces.h"
 #include "qemu/cutils.h"
+#include "qemu/memalign.h"
 #include "qapi/visitor.h"
 #include "qapi/string-input-visitor.h"
 #include "qapi/string-output-visitor.h"
diff --git a/softmmu/physmem.c b/softmmu/physmem.c
index XXXXXXX..XXXXXXX 100644
--- a/softmmu/physmem.c
+++ b/softmmu/physmem.c
@@ -XXX,XX +XXX,XX @@
 #include "qemu/config-file.h"
 #include "qemu/error-report.h"
 #include "qemu/qemu-print.h"
+#include "qemu/memalign.h"
 #include "exec/memory.h"
 #include "exec/ioport.h"
 #include "sysemu/dma.h"
diff --git a/target/i386/hvf/hvf.c b/target/i386/hvf/hvf.c
index XXXXXXX..XXXXXXX 100644
--- a/target/i386/hvf/hvf.c
+++ b/target/i386/hvf/hvf.c
@@ -XXX,XX +XXX,XX @@
 #include "qemu/osdep.h"
 #include "qemu-common.h"
 #include "qemu/error-report.h"
+#include "qemu/memalign.h"
 
 #include "sysemu/hvf.h"
 #include "sysemu/hvf_int.h"
diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c
index XXXXXXX..XXXXXXX 100644
--- a/target/i386/kvm/kvm.c
+++ b/target/i386/kvm/kvm.c
@@ -XXX,XX +XXX,XX @@
 #include "qemu/main-loop.h"
 #include "qemu/config-file.h"
 #include "qemu/error-report.h"
+#include "qemu/memalign.h"
 #include "hw/i386/x86.h"
 #include "hw/i386/apic.h"
 #include "hw/i386/apic_internal.h"
diff --git a/tcg/region.c b/tcg/region.c
index XXXXXXX..XXXXXXX 100644
--- a/tcg/region.c
+++ b/tcg/region.c
@@ -XXX,XX +XXX,XX @@
 #include "qemu/units.h"
 #include "qemu/madvise.h"
 #include "qemu/mprotect.h"
+#include "qemu/memalign.h"
 #include "qemu/cacheinfo.h"
 #include "qapi/error.h"
 #include "exec/exec-all.h"
diff --git a/tests/bench/atomic_add-bench.c b/tests/bench/atomic_add-bench.c
index XXXXXXX..XXXXXXX 100644
--- a/tests/bench/atomic_add-bench.c
+++ b/tests/bench/atomic_add-bench.c
@@ -XXX,XX +XXX,XX @@
 #include "qemu/thread.h"
 #include "qemu/host-utils.h"
 #include "qemu/processor.h"
+#include "qemu/memalign.h"
 
 struct thread_info {
     uint64_t r;
diff --git a/tests/bench/qht-bench.c b/tests/bench/qht-bench.c
index XXXXXXX..XXXXXXX 100644
--- a/tests/bench/qht-bench.c
+++ b/tests/bench/qht-bench.c
@@ -XXX,XX +XXX,XX @@
 #include "qemu/qht.h"
 #include "qemu/rcu.h"
 #include "qemu/xxhash.h"
+#include "qemu/memalign.h"
 
 struct thread_stats {
     size_t rd;
diff --git a/util/atomic64.c b/util/atomic64.c
index XXXXXXX..XXXXXXX 100644
--- a/util/atomic64.c
+++ b/util/atomic64.c
@@ -XXX,XX +XXX,XX @@
 #include "qemu/atomic.h"
 #include "qemu/thread.h"
 #include "qemu/cacheinfo.h"
+#include "qemu/memalign.h"
 
 #ifdef CONFIG_ATOMIC64
 #error This file must only be compiled if !CONFIG_ATOMIC64
diff --git a/util/memalign.c b/util/memalign.c
index XXXXXXX..XXXXXXX 100644
--- a/util/memalign.c
+++ b/util/memalign.c
@@ -XXX,XX +XXX,XX @@
 
 #include "qemu/osdep.h"
 #include "qemu/host-utils.h"
+#include "qemu/memalign.h"
 #include "trace.h"
 
 void *qemu_try_memalign(size_t alignment, size_t size)
diff --git a/util/qht.c b/util/qht.c
index XXXXXXX..XXXXXXX 100644
--- a/util/qht.c
+++ b/util/qht.c
@@ -XXX,XX +XXX,XX @@
 #include "qemu/qht.h"
 #include "qemu/atomic.h"
 #include "qemu/rcu.h"
+#include "qemu/memalign.h"
 
 //#define QHT_DEBUG
 
-- 
2.25.1

For VLD1/VST1 (single element to one lane) we are only accessing one
register, and so the 'stride' is meaningless.  The bits that would
specify stride (insn bit [4] for size=1, bit [6] for size=2) are
specified to be zero in the encoding (which would correspond to a
stride of 1 for VLD2/VLD3/VLD4 etc), and we must UNDEF if they are
not.

We failed to make this check, which meant that we would incorrectly
handle some instruction patterns as loads or stores instead of
UNDEFing them. Enforce that stride == 1 for the nregs == 1 case.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/890
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Tested-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20220303113741.2156877-2-peter.maydell@linaro.org
---
 target/arm/translate-neon.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/target/arm/translate-neon.c b/target/arm/translate-neon.c
index XXXXXXX..XXXXXXX 100644
--- a/target/arm/translate-neon.c
+++ b/target/arm/translate-neon.c
@@ -XXX,XX +XXX,XX @@ static bool trans_VLDST_single(DisasContext *s, arg_VLDST_single *a)
     /* Catch the UNDEF cases. This is unavoidably a bit messy. */
     switch (nregs) {
     case 1:
+        if (a->stride != 1) {
+            return false;
+        }
         if (((a->align & (1 << a->size)) != 0) ||
             (a->size == 2 && (a->align == 1 || a->align == 2))) {
             return false;
-- 
2.25.1

For VLD3 (single 3-element structure to one lane), there is no
alignment specification and the alignment bits in the instruction
must be zero.  This is bit [4] for the size=0 and size=1 cases, and
bits [5:4] for the size=2 case.  We do this check correctly in
VLDST_single(), but we write it a bit oddly: in the 'case 3' code we
check for bit 0 of a->align (bit [4] of the insn), and then we fall
through to the 'case 2' code which checks bit 1 of a->align (bit [5]
of the insn) in the size 2 case.  Replace this with just checking "is
a->align non-zero" for VLD3, which lets us drop the fall-through and
put the cases in this switch in numerical order.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Tested-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20220303113741.2156877-3-peter.maydell@linaro.org
---
 target/arm/translate-neon.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/target/arm/translate-neon.c b/target/arm/translate-neon.c
index XXXXXXX..XXXXXXX 100644
--- a/target/arm/translate-neon.c
+++ b/target/arm/translate-neon.c
@@ -XXX,XX +XXX,XX @@ static bool trans_VLDST_single(DisasContext *s, arg_VLDST_single *a)
             return false;
         }
         break;
-    case 3:
-        if ((a->align & 1) != 0) {
-            return false;
-        }
-        /* fall through */
     case 2:
         if (a->size == 2 && (a->align & 2) != 0) {
             return false;
         }
         break;
+    case 3:
+        if (a->align != 0) {
+            return false;
+        }
+        break;
     case 4:
         if (a->size == 2 && a->align == 3) {
             return false;
-- 
2.25.1

When debugging code that's using the ITS, it's helpful to
see tracing of the ITS commands that the guest executes. Add
suitable trace events.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20220303202341.2232284-2-peter.maydell@linaro.org
---
 hw/intc/arm_gicv3_its.c | 28 ++++++++++++++++++++++++++--
 hw/intc/trace-events    | 12 ++++++++++++
 2 files changed, 38 insertions(+), 2 deletions(-)

diff --git a/hw/intc/arm_gicv3_its.c b/hw/intc/arm_gicv3_its.c
index XXXXXXX..XXXXXXX 100644
--- a/hw/intc/arm_gicv3_its.c
+++ b/hw/intc/arm_gicv3_its.c
@@ -XXX,XX +XXX,XX @@ static ItsCmdResult process_its_cmd(GICv3ITSState *s, const uint64_t *cmdpkt,
 
     devid = (cmdpkt[0] & DEVID_MASK) >> DEVID_SHIFT;
     eventid = cmdpkt[1] & EVENTID_MASK;
+    switch (cmd) {
+    case INTERRUPT:
+        trace_gicv3_its_cmd_int(devid, eventid);
+        break;
+    case CLEAR:
+        trace_gicv3_its_cmd_clear(devid, eventid);
+        break;
+    case DISCARD:
+        trace_gicv3_its_cmd_discard(devid, eventid);
+        break;
+    default:
+        g_assert_not_reached();
+    }
     return do_process_its_cmd(s, devid, eventid, cmd);
 }
 
@@ -XXX,XX +XXX,XX @@ static ItsCmdResult process_mapti(GICv3ITSState *s, const uint64_t *cmdpkt,
 
     devid = (cmdpkt[0] & DEVID_MASK) >> DEVID_SHIFT;
     eventid = cmdpkt[1] & EVENTID_MASK;
+    icid = cmdpkt[2] & ICID_MASK;
 
     if (ignore_pInt) {
         pIntid = eventid;
+        trace_gicv3_its_cmd_mapi(devid, eventid, icid);
     } else {
         pIntid = (cmdpkt[1] & pINTID_MASK) >> pINTID_SHIFT;
+        trace_gicv3_its_cmd_mapti(devid, eventid, icid, pIntid);
     }
 
-    icid = cmdpkt[2] & ICID_MASK;
-
     if (devid >= s->dt.num_entries) {
         qemu_log_mask(LOG_GUEST_ERROR,
                       "%s: invalid command attributes: devid %d>=%d",
@@ -XXX,XX +XXX,XX @@ static ItsCmdResult process_mapc(GICv3ITSState *s, const uint64_t *cmdpkt)
     } else {
         cte.rdbase = 0;
     }
+    trace_gicv3_its_cmd_mapc(icid, cte.rdbase, cte.valid);
 
     if (icid >= s->ct.num_entries) {
         qemu_log_mask(LOG_GUEST_ERROR, "ITS MAPC: invalid ICID 0x%d", icid);
@@ -XXX,XX +XXX,XX @@ static ItsCmdResult process_mapd(GICv3ITSState *s, const uint64_t *cmdpkt)
     dte.ittaddr = (cmdpkt[2] & ITTADDR_MASK) >> ITTADDR_SHIFT;
     dte.valid = cmdpkt[2] & CMD_FIELD_VALID_MASK;
 
+    trace_gicv3_its_cmd_mapd(devid, dte.size, dte.ittaddr, dte.valid);
+
     if (devid >= s->dt.num_entries) {
         qemu_log_mask(LOG_GUEST_ERROR,
                       "ITS MAPD: invalid device ID field 0x%x >= 0x%x\n",
@@ -XXX,XX +XXX,XX @@ static ItsCmdResult process_movall(GICv3ITSState *s, const uint64_t *cmdpkt)
     rd1 = FIELD_EX64(cmdpkt[2], MOVALL_2, RDBASE1);
     rd2 = FIELD_EX64(cmdpkt[3], MOVALL_3, RDBASE2);
 
+    trace_gicv3_its_cmd_movall(rd1, rd2);
+
     if (rd1 >= s->gicv3->num_cpu) {
         qemu_log_mask(LOG_GUEST_ERROR,
                       "%s: RDBASE1 %" PRId64
@@ -XXX,XX +XXX,XX @@ static ItsCmdResult process_movi(GICv3ITSState *s, const uint64_t *cmdpkt)
     eventid = FIELD_EX64(cmdpkt[1], MOVI_1, EVENTID);
     new_icid = FIELD_EX64(cmdpkt[2], MOVI_2, ICID);
 
+    trace_gicv3_its_cmd_movi(devid, eventid, new_icid);
+
     if (devid >= s->dt.num_entries) {
         qemu_log_mask(LOG_GUEST_ERROR,
                       "%s: invalid command attributes: devid %d>=%d",
@@ -XXX,XX +XXX,XX @@ static void process_cmdq(GICv3ITSState *s)
              * is already consistent by the time SYNC command is executed.
              * Hence no further processing is required for SYNC command.
              */
+            trace_gicv3_its_cmd_sync();
             break;
         case GITS_CMD_MAPD:
             result = process_mapd(s, cmdpkt);
@@ -XXX,XX +XXX,XX @@ static void process_cmdq(GICv3ITSState *s)
              * need to trigger lpi priority re-calculation to be in
              * sync with LPI config table or pending table changes.
              */
+            trace_gicv3_its_cmd_inv();
             for (i = 0; i < s->gicv3->num_cpu; i++) {
                 gicv3_redist_update_lpi(&s->gicv3->cpu[i]);
             }
@@ -XXX,XX +XXX,XX @@ static void process_cmdq(GICv3ITSState *s)
             result = process_movall(s, cmdpkt);
             break;
         default:
+            trace_gicv3_its_cmd_unknown(cmd);
             break;
         }
         if (result == CMD_CONTINUE) {
diff --git a/hw/intc/trace-events b/hw/intc/trace-events
index XXXXXXX..XXXXXXX 100644
--- a/hw/intc/trace-events
+++ b/hw/intc/trace-events
@@ -XXX,XX +XXX,XX @@ gicv3_its_write(uint64_t offset, uint64_t data, unsigned size) "GICv3 ITS write:
 gicv3_its_badwrite(uint64_t offset, uint64_t data, unsigned size) "GICv3 ITS write: offset 0x%" PRIx64 " data 0x%" PRIx64 " size %u: error"
 gicv3_its_translation_write(uint64_t offset, uint64_t data, unsigned size, uint32_t requester_id) "GICv3 ITS TRANSLATER write: offset 0x%" PRIx64 " data 0x%" PRIx64 " size %u requester_id 0x%x"
 gicv3_its_process_command(uint32_t rd_offset, uint8_t cmd) "GICv3 ITS: processing command at offset 0x%x: 0x%x"
+gicv3_its_cmd_int(uint32_t devid, uint32_t eventid) "GICv3 ITS: command INT DeviceID 0x%x EventID 0x%x"
+gicv3_its_cmd_clear(uint32_t devid, uint32_t eventid) "GICv3 ITS: command CLEAR DeviceID 0x%x EventID 0x%x"
+gicv3_its_cmd_discard(uint32_t devid, uint32_t eventid) "GICv3 ITS: command DISCARD DeviceID 0x%x EventID 0x%x"
+gicv3_its_cmd_sync(void) "GICv3 ITS: command SYNC"
+gicv3_its_cmd_mapd(uint32_t devid, uint32_t size, uint64_t ittaddr, int valid) "GICv3 ITS: command MAPD DeviceID 0x%x Size 0x%x ITT_addr 0x%" PRIx64 " V %d"
+gicv3_its_cmd_mapc(uint32_t icid, uint64_t rdbase, int valid) "GICv3 ITS: command MAPC ICID 0x%x RDbase 0x%" PRIx64 " V %d"
+gicv3_its_cmd_mapi(uint32_t devid, uint32_t eventid, uint32_t icid) "GICv3 ITS: command MAPI DeviceID 0x%x EventID 0x%x ICID 0x%x"
+gicv3_its_cmd_mapti(uint32_t devid, uint32_t eventid, uint32_t icid, uint32_t intid) "GICv3 ITS: command MAPTI DeviceID 0x%x EventID 0x%x ICID 0x%x pINTID 0x%x"
+gicv3_its_cmd_inv(void) "GICv3 ITS: command INV or INVALL"
+gicv3_its_cmd_movall(uint64_t rd1, uint64_t rd2) "GICv3 ITS: command MOVALL RDbase1 0x%" PRIx64 " RDbase2 0x%" PRIx64
+gicv3_its_cmd_movi(uint32_t devid, uint32_t eventid, uint32_t icid) "GICv3 ITS: command MOVI DeviceID 0x%x EventID 0x%x ICID 0x%x"
+gicv3_its_cmd_unknown(unsigned cmd) "GICv3 ITS: unknown command 0x%x"
 
 # armv7m_nvic.c
 nvic_recompute_state(int vectpending, int vectpending_prio, int exception_prio) "NVIC state recomputed: vectpending %d vectpending_prio %d exception_prio %d"
-- 
2.25.1

For debugging guest use of the ITS, it can be helpful to trace
when the ITS reads and writes the in-memory tables.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20220303202341.2232284-3-peter.maydell@linaro.org
---
 hw/intc/arm_gicv3_its.c | 37 +++++++++++++++++++++++++++++++------
 hw/intc/trace-events    |  9 +++++++++
 2 files changed, 40 insertions(+), 6 deletions(-)

diff --git a/hw/intc/arm_gicv3_its.c b/hw/intc/arm_gicv3_its.c
index XXXXXXX..XXXXXXX 100644
--- a/hw/intc/arm_gicv3_its.c
+++ b/hw/intc/arm_gicv3_its.c
@@ -XXX,XX +XXX,XX @@ static MemTxResult get_cte(GICv3ITSState *s, uint16_t icid, CTEntry *cte)
     if (entry_addr == -1) {
         /* No L2 table entry, i.e. no valid CTE, or a memory error */
         cte->valid = false;
-        return res;
+        goto out;
     }
 
     cteval = address_space_ldq_le(as, entry_addr, MEMTXATTRS_UNSPECIFIED, &res);
     if (res != MEMTX_OK) {
-        return res;
+        goto out;
     }
     cte->valid = FIELD_EX64(cteval, CTE, VALID);
     cte->rdbase = FIELD_EX64(cteval, CTE, RDBASE);
-    return MEMTX_OK;
+out:
+    if (res != MEMTX_OK) {
+        trace_gicv3_its_cte_read_fault(icid);
+    } else {
+        trace_gicv3_its_cte_read(icid, cte->valid, cte->rdbase);
+    }
+    return res;
 }
 
 /*
@@ -XXX,XX +XXX,XX @@ static bool update_ite(GICv3ITSState *s, uint32_t eventid, const DTEntry *dte,
     uint64_t itel = 0;
     uint32_t iteh = 0;
 
+    trace_gicv3_its_ite_write(dte->ittaddr, eventid, ite->valid,
+                              ite->inttype, ite->intid, ite->icid,
+                              ite->vpeid, ite->doorbell);
+
     if (ite->valid) {
         itel = FIELD_DP64(itel, ITE_L, VALID, 1);
         itel = FIELD_DP64(itel, ITE_L, INTTYPE, ite->inttype);
@@ -XXX,XX +XXX,XX @@ static MemTxResult get_ite(GICv3ITSState *s, uint32_t eventid,
 
     itel = address_space_ldq_le(as, iteaddr, MEMTXATTRS_UNSPECIFIED, &res);
     if (res != MEMTX_OK) {
+        trace_gicv3_its_ite_read_fault(dte->ittaddr, eventid);
         return res;
     }
 
     iteh = address_space_ldl_le(as, iteaddr + 8, MEMTXATTRS_UNSPECIFIED, &res);
     if (res != MEMTX_OK) {
+        trace_gicv3_its_ite_read_fault(dte->ittaddr, eventid);
         return res;
     }
 
@@ -XXX,XX +XXX,XX @@ static MemTxResult get_ite(GICv3ITSState *s, uint32_t eventid,
     ite->icid = FIELD_EX64(itel, ITE_L, ICID);
     ite->vpeid = FIELD_EX64(itel, ITE_L, VPEID);
     ite->doorbell = FIELD_EX64(iteh, ITE_H, DOORBELL);
+    trace_gicv3_its_ite_read(dte->ittaddr, eventid, ite->valid,
+                             ite->inttype, ite->intid, ite->icid,
+                             ite->vpeid, ite->doorbell);
     return MEMTX_OK;
 }
 
@@ -XXX,XX +XXX,XX @@ static MemTxResult get_dte(GICv3ITSState *s, uint32_t devid, DTEntry *dte)
     if (entry_addr == -1) {
         /* No L2 table entry, i.e. no valid DTE, or a memory error */
         dte->valid = false;
-        return res;
+        goto out;
     }
     dteval = address_space_ldq_le(as, entry_addr, MEMTXATTRS_UNSPECIFIED, &res);
     if (res != MEMTX_OK) {
-        return res;
+        goto out;
     }
     dte->valid = FIELD_EX64(dteval, DTE, VALID);
     dte->size = FIELD_EX64(dteval, DTE, SIZE);
     /* DTE word field stores bits [51:8] of the ITT address */
     dte->ittaddr = FIELD_EX64(dteval, DTE, ITTADDR) << ITTADDR_SHIFT;
-    return MEMTX_OK;
+out:
+    if (res != MEMTX_OK) {
+        trace_gicv3_its_dte_read_fault(devid);
+    } else {
+        trace_gicv3_its_dte_read(devid, dte->valid, dte->size, dte->ittaddr);
+    }
+    return res;
 }
 
 /*
@@ -XXX,XX +XXX,XX @@ static bool update_cte(GICv3ITSState *s, uint16_t icid, const CTEntry *cte)
     uint64_t cteval = 0;
     MemTxResult res = MEMTX_OK;
 
+    trace_gicv3_its_cte_write(icid, cte->valid, cte->rdbase);
+
     if (cte->valid) {
         /* add mapping entry to collection table */
         cteval = FIELD_DP64(cteval, CTE, VALID, 1);
@@ -XXX,XX +XXX,XX @@ static bool update_dte(GICv3ITSState *s, uint32_t devid, const DTEntry *dte)
     uint64_t dteval = 0;
     MemTxResult res = MEMTX_OK;
 
+    trace_gicv3_its_dte_write(devid, dte->valid, dte->size, dte->ittaddr);
+
     if (dte->valid) {
         /* add mapping entry to device table */
         dteval = FIELD_DP64(dteval, DTE, VALID, 1);
diff --git a/hw/intc/trace-events b/hw/intc/trace-events
index XXXXXXX..XXXXXXX 100644
--- a/hw/intc/trace-events
+++ b/hw/intc/trace-events
@@ -XXX,XX +XXX,XX @@ gicv3_its_cmd_inv(void) "GICv3 ITS: command INV or INVALL"
 gicv3_its_cmd_movall(uint64_t rd1, uint64_t rd2) "GICv3 ITS: command MOVALL RDbase1 0x%" PRIx64 " RDbase2 0x%" PRIx64
 gicv3_its_cmd_movi(uint32_t devid, uint32_t eventid, uint32_t icid) "GICv3 ITS: command MOVI DeviceID 0x%x EventID 0x%x ICID 0x%x"
 gicv3_its_cmd_unknown(unsigned cmd) "GICv3 ITS: unknown command 0x%x"
+gicv3_its_cte_read(uint32_t icid, int valid, uint32_t rdbase) "GICv3 ITS: Collection Table read for ICID 0x%x: valid %d RDBase 0x%x"
+gicv3_its_cte_write(uint32_t icid, int valid, uint32_t rdbase) "GICv3 ITS: Collection Table write for ICID 0x%x: valid %d RDBase 0x%x"
+gicv3_its_cte_read_fault(uint32_t icid) "GICv3 ITS: Collection Table read for ICID 0x%x: faulted"
+gicv3_its_ite_read(uint64_t ittaddr, uint32_t eventid, int valid, int inttype, uint32_t intid, uint32_t icid, uint32_t vpeid, uint32_t doorbell) "GICv3 ITS: Interrupt Table read for ITTaddr 0x%" PRIx64 " EventID 0x%x: valid %d inttype %d intid 0x%x ICID 0x%x vPEID 0x%x doorbell 0x%x"
+gicv3_its_ite_read_fault(uint64_t ittaddr, uint32_t eventid) "GICv3 ITS: Interrupt Table read for ITTaddr 0x%" PRIx64 " EventID 0x%x: faulted"
+gicv3_its_ite_write(uint64_t ittaddr, uint32_t eventid, int valid, int inttype, uint32_t intid, uint32_t icid, uint32_t vpeid, uint32_t doorbell) "GICv3 ITS: Interrupt Table write for ITTaddr 0x%" PRIx64 " EventID 0x%x: valid %d inttype %d intid 0x%x ICID 0x%x vPEID 0x%x doorbell 0x%x"
+gicv3_its_dte_read(uint32_t devid, int valid, uint32_t size, uint64_t ittaddr) "GICv3 ITS: Device Table read for DeviceID 0x%x: valid %d size 0x%x ITTaddr 0x%" PRIx64
+gicv3_its_dte_write(uint32_t devid, int valid, uint32_t size, uint64_t ittaddr) "GICv3 ITS: Device Table write for DeviceID 0x%x: valid %d size 0x%x ITTaddr 0x%" PRIx64
+gicv3_its_dte_read_fault(uint32_t devid) "GICv3 ITS: Device Table read for DeviceID 0x%x: faulted"
 
 # armv7m_nvic.c
 nvic_recompute_state(int vectpending, int vectpending_prio, int exception_prio) "NVIC state recomputed: vectpending %d vectpending_prio %d exception_prio %d"
-- 
2.25.1

The GICv3 has some registers that support byte accesses, and some
that support 8-byte accesses.  Our TCG implementation implements all
of this, switching on the 'size' argument and handling the registers
that must support reads of that size while logging an error for
attempted accesses to registers that do not support that size access.
However we forgot to tell the core memory subsystem about this by
specifying the .impl and .valid fields in the MemoryRegionOps struct,
so the core was happily simulating 8 byte accesses by combining two 4
byte accesses.  This doesn't have much guest-visible effect, since
there aren't many 8 byte registers and they all support being written
in two 4 byte parts.

Set the .impl and .valid fields to say that all sizes from 1 to 8
bytes are both valid and implemented by the device.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20220303202341.2232284-4-peter.maydell@linaro.org
---
 hw/intc/arm_gicv3.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/hw/intc/arm_gicv3.c b/hw/intc/arm_gicv3.c
index XXXXXXX..XXXXXXX 100644
--- a/hw/intc/arm_gicv3.c
+++ b/hw/intc/arm_gicv3.c
@@ -XXX,XX +XXX,XX @@ static const MemoryRegionOps gic_ops[] = {
         .read_with_attrs = gicv3_dist_read,
         .write_with_attrs = gicv3_dist_write,
         .endianness = DEVICE_NATIVE_ENDIAN,
+        .valid.min_access_size = 1,
+        .valid.max_access_size = 8,
+        .impl.min_access_size = 1,
+        .impl.max_access_size = 8,
     },
     {
         .read_with_attrs = gicv3_redist_read,
         .write_with_attrs = gicv3_redist_write,
         .endianness = DEVICE_NATIVE_ENDIAN,
+        .valid.min_access_size = 1,
+        .valid.max_access_size = 8,
+        .impl.min_access_size = 1,
+        .impl.max_access_size = 8,
     }
 };
 
-- 
2.25.1

We forgot a space in some log messages, so the output ended
up looking like
gicv3_dist_write: invalid guest write at offset 0000000000008000size 8

with a missing space before "size". Add the missing spaces.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20220303202341.2232284-5-peter.maydell@linaro.org
---
 hw/intc/arm_gicv3_dist.c | 4 ++--
 hw/intc/arm_gicv3_its.c  | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/hw/intc/arm_gicv3_dist.c b/hw/intc/arm_gicv3_dist.c
index XXXXXXX..XXXXXXX 100644
--- a/hw/intc/arm_gicv3_dist.c
+++ b/hw/intc/arm_gicv3_dist.c
@@ -XXX,XX +XXX,XX @@ MemTxResult gicv3_dist_read(void *opaque, hwaddr offset, uint64_t *data,
     if (!r) {
         qemu_log_mask(LOG_GUEST_ERROR,
                       "%s: invalid guest read at offset " TARGET_FMT_plx
-                      "size %u\n", __func__, offset, size);
+                      " size %u\n", __func__, offset, size);
         trace_gicv3_dist_badread(offset, size, attrs.secure);
         /* The spec requires that reserved registers are RAZ/WI;
          * so use MEMTX_ERROR returns from leaf functions as a way to
@@ -XXX,XX +XXX,XX @@ MemTxResult gicv3_dist_write(void *opaque, hwaddr offset, uint64_t data,
     if (!r) {
         qemu_log_mask(LOG_GUEST_ERROR,
                       "%s: invalid guest write at offset " TARGET_FMT_plx
-                      "size %u\n", __func__, offset, size);
+                      " size %u\n", __func__, offset, size);
         trace_gicv3_dist_badwrite(offset, data, size, attrs.secure);
         /* The spec requires that reserved registers are RAZ/WI;
          * so use MEMTX_ERROR returns from leaf functions as a way to
diff --git a/hw/intc/arm_gicv3_its.c b/hw/intc/arm_gicv3_its.c
index XXXXXXX..XXXXXXX 100644
--- a/hw/intc/arm_gicv3_its.c
+++ b/hw/intc/arm_gicv3_its.c
@@ -XXX,XX +XXX,XX @@ static MemTxResult gicv3_its_read(void *opaque, hwaddr offset, uint64_t *data,
     if (!result) {
         qemu_log_mask(LOG_GUEST_ERROR,
                       "%s: invalid guest read at offset " TARGET_FMT_plx
-                      "size %u\n", __func__, offset, size);
+                      " size %u\n", __func__, offset, size);
         trace_gicv3_its_badread(offset, size);
         /*
          * The spec requires that reserved registers are RAZ/WI;
@@ -XXX,XX +XXX,XX @@ static MemTxResult gicv3_its_write(void *opaque, hwaddr offset, uint64_t data,
     if (!result) {
         qemu_log_mask(LOG_GUEST_ERROR,
                       "%s: invalid guest write at offset " TARGET_FMT_plx
-                      "size %u\n", __func__, offset, size);
+                      " size %u\n", __func__, offset, size);
         trace_gicv3_its_badwrite(offset, data, size);
         /*
          * The spec requires that reserved registers are RAZ/WI;
-- 
2.25.1

The trace_gicv3_icv_hppir_read trace event takes an integer value
which it uses to form the register name, which should be either
ICV_HPPIR0 or ICV_HPPIR1.  We were passing in the 'grp' variable for
this, but that is either GICV3_G0 or GICV3_G1NS, which happen to be 0
and 2, which meant that tracing for the ICV_HPPIR1 register was
incorrectly printed as ICV_HPPIR2.

Use the same approach we do for all the other similar trace events,
and pass in 'ri->crm == 8 ?  0 : 1', deriving the index value
directly from the ARMCPRegInfo struct.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20220303202341.2232284-6-peter.maydell@linaro.org
---
 hw/intc/arm_gicv3_cpuif.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/intc/arm_gicv3_cpuif.c b/hw/intc/arm_gicv3_cpuif.c
index XXXXXXX..XXXXXXX 100644
--- a/hw/intc/arm_gicv3_cpuif.c
+++ b/hw/intc/arm_gicv3_cpuif.c
@@ -XXX,XX +XXX,XX @@ static uint64_t icv_hppir_read(CPUARMState *env, const ARMCPRegInfo *ri)
         }
     }
 
-    trace_gicv3_icv_hppir_read(grp, gicv3_redist_affid(cs), value);
+    trace_gicv3_icv_hppir_read(ri->crm == 8 ? 0 : 1,
+                               gicv3_redist_affid(cs), value);
     return value;
 }
 
-- 
2.25.1

From: Akihiko Odaki <akihiko.odaki@gmail.com>

This provides standard look and feel for the about panel and reduces
code.

Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
Message-id: 20220227042241.1543-1-akihiko.odaki@gmail.com
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 ui/cocoa.m | 112 +++++++++++------------------------------------------
 1 file changed, 23 insertions(+), 89 deletions(-)

diff --git a/ui/cocoa.m b/ui/cocoa.m
index XXXXXXX..XXXXXXX 100644
--- a/ui/cocoa.m
+++ b/ui/cocoa.m
@@ -XXX,XX +XXX,XX @@ static void cocoa_switch(DisplayChangeListener *dcl,
 
 static void cocoa_refresh(DisplayChangeListener *dcl);
 
-static NSWindow *normalWindow, *about_window;
+static NSWindow *normalWindow;
 static const DisplayChangeListenerOps dcl_ops = {
     .dpy_name          = "cocoa",
     .dpy_gfx_update = cocoa_update,
@@ -XXX,XX +XXX,XX @@ QemuCocoaView *cocoaView;
 - (BOOL)verifyQuit;
 - (void)openDocumentation:(NSString *)filename;
 - (IBAction) do_about_menu_item: (id) sender;
-- (void)make_about_window;
 - (void)adjustSpeed:(id)sender;
 @end
 
@@ -XXX,XX +XXX,XX @@ QemuCocoaView *cocoaView;
         [pauseLabel setFont: [NSFont fontWithName: @"Helvetica" size: 90]];
         [pauseLabel setTextColor: [NSColor blackColor]];
         [pauseLabel sizeToFit];
-
-        [self make_about_window];
     }
     return self;
 }
@@ -XXX,XX +XXX,XX @@ QemuCocoaView *cocoaView;
 /* The action method for the About menu item */
 - (IBAction) do_about_menu_item: (id) sender
 {
-    [about_window makeKeyAndOrderFront: nil];
-}
-
-/* Create and display the about dialog */
-- (void)make_about_window
-{
-    /* Make the window */
-    int x = 0, y = 0, about_width = 400, about_height = 200;
-    NSRect window_rect = NSMakeRect(x, y, about_width, about_height);
-    about_window = [[NSWindow alloc] initWithContentRect:window_rect
-                    styleMask:NSWindowStyleMaskTitled | NSWindowStyleMaskClosable |
-                    NSWindowStyleMaskMiniaturizable
-                    backing:NSBackingStoreBuffered
-                    defer:NO];
-    [about_window setTitle: @"About"];
-    [about_window setReleasedWhenClosed: NO];
-    [about_window center];
-    NSView *superView = [about_window contentView];
-
-    /* Create the dimensions of the picture */
-    int picture_width = 80, picture_height = 80;
-    x = (about_width - picture_width)/2;
-    y = about_height - picture_height - 10;
-    NSRect picture_rect = NSMakeRect(x, y, picture_width, picture_height);
-
-    /* Make the picture of QEMU */
-    NSImageView *picture_view = [[NSImageView alloc] initWithFrame:
-                                                     picture_rect];
-    char *qemu_image_path_c = get_relocated_path(CONFIG_QEMU_ICONDIR "/hicolor/512x512/apps/qemu.png");
-    NSString *qemu_image_path = [NSString stringWithUTF8String:qemu_image_path_c];
-    g_free(qemu_image_path_c);
-    NSImage *qemu_image = [[NSImage alloc] initWithContentsOfFile:qemu_image_path];
-    [picture_view setImage: qemu_image];
-    [picture_view setImageScaling: NSImageScaleProportionallyUpOrDown];
-    [superView addSubview: picture_view];
-
-    /* Make the name label */
-    NSBundle *bundle = [NSBundle mainBundle];
-    if (bundle) {
-        x = 0;
-        y = y - 25;
-        int name_width = about_width, name_height = 20;
-        NSRect name_rect = NSMakeRect(x, y, name_width, name_height);
-        NSTextField *name_label = [[NSTextField alloc] initWithFrame: name_rect];
-        [name_label setEditable: NO];
-        [name_label setBezeled: NO];
-        [name_label setDrawsBackground: NO];
-        [name_label setAlignment: NSTextAlignmentCenter];
-        NSString *qemu_name = [[bundle executablePath] lastPathComponent];
-        [name_label setStringValue: qemu_name];
-        [superView addSubview: name_label];
+    NSAutoreleasePool *pool = [[NSAutoreleasePool alloc] init];
+    char *icon_path_c = get_relocated_path(CONFIG_QEMU_ICONDIR "/hicolor/512x512/apps/qemu.png");
+    NSString *icon_path = [NSString stringWithUTF8String:icon_path_c];
+    g_free(icon_path_c);
+    NSImage *icon = [[NSImage alloc] initWithContentsOfFile:icon_path];
+    NSString *version = @"QEMU emulator version " QEMU_FULL_VERSION;
+    NSString *copyright = @QEMU_COPYRIGHT;
+    NSDictionary *options;
+    if (icon) {
+        options = @{
+            NSAboutPanelOptionApplicationIcon : icon,
+            NSAboutPanelOptionApplicationVersion : version,
+            @"Copyright" : copyright,
+        };
+        [icon release];
+    } else {
+        options = @{
+            NSAboutPanelOptionApplicationVersion : version,
+            @"Copyright" : copyright,
+        };
     }
-
-    /* Set the version label's attributes */
-    x = 0;
-    y = 50;
-    int version_width = about_width, version_height = 20;
-    NSRect version_rect = NSMakeRect(x, y, version_width, version_height);
-    NSTextField *version_label = [[NSTextField alloc] initWithFrame:
-                                                      version_rect];
-    [version_label setEditable: NO];
-    [version_label setBezeled: NO];
-    [version_label setAlignment: NSTextAlignmentCenter];
-    [version_label setDrawsBackground: NO];
-
-    /* Create the version string*/
-    NSString *version_string;
-    version_string = [[NSString alloc] initWithFormat:
-    @"QEMU emulator version %s", QEMU_FULL_VERSION];
-    [version_label setStringValue: version_string];
-    [superView addSubview: version_label];
-
-    /* Make copyright label */
-    x = 0;
-    y = 35;
-    int copyright_width = about_width, copyright_height = 20;
-    NSRect copyright_rect = NSMakeRect(x, y, copyright_width, copyright_height);
-    NSTextField *copyright_label = [[NSTextField alloc] initWithFrame:
-                                                        copyright_rect];
-    [copyright_label setEditable: NO];
-    [copyright_label setBezeled: NO];
-    [copyright_label setDrawsBackground: NO];
-    [copyright_label setAlignment: NSTextAlignmentCenter];
-    [copyright_label setStringValue: [NSString stringWithFormat: @"%s",
-                                     QEMU_COPYRIGHT]];
-    [superView addSubview: copyright_label];
+    [NSApp orderFrontStandardAboutPanelWithOptions:options];
+    [pool release];
 }
 
 /* Used by the Speed menu items */
-- 
2.25.1

From: Richard Henderson <richard.henderson@linaro.org>

There is a Linux kernel bug present until v5.12 that prevents
booting with FEAT_LPA2 enabled.  As a workaround for TCG, allow
the feature to be disabled from -cpu max.

Since this kernel bug is present in the Fedora 31 image that
we test in avocado, disable lpa2 on the command-line.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 target/arm/cpu.h            |  5 ++++-
 target/arm/cpu.c            |  6 ++++++
 target/arm/cpu64.c          | 24 ++++++++++++++++++++++++
 tests/avocado/boot_linux.py |  2 ++
 4 files changed, 36 insertions(+), 1 deletion(-)

diff --git a/target/arm/cpu.h b/target/arm/cpu.h
index XXXXXXX..XXXXXXX 100644
--- a/target/arm/cpu.h
+++ b/target/arm/cpu.h
@@ -XXX,XX +XXX,XX @@ typedef struct {
 # define ARM_MAX_VQ    16
 void arm_cpu_sve_finalize(ARMCPU *cpu, Error **errp);
 void arm_cpu_pauth_finalize(ARMCPU *cpu, Error **errp);
+void arm_cpu_lpa2_finalize(ARMCPU *cpu, Error **errp);
 #else
 # define ARM_MAX_VQ    1
 static inline void arm_cpu_sve_finalize(ARMCPU *cpu, Error **errp) { }
 static inline void arm_cpu_pauth_finalize(ARMCPU *cpu, Error **errp) { }
+static inline void arm_cpu_lpa2_finalize(ARMCPU *cpu, Error **errp) { }
 #endif
 
 typedef struct ARMVectorReg {
@@ -XXX,XX +XXX,XX @@ struct ARMCPU {
 
     /*
      * Intermediate values used during property parsing.
-     * Once finalized, the values should be read from ID_AA64ISAR1.
+     * Once finalized, the values should be read from ID_AA64*.
      */
     bool prop_pauth;
     bool prop_pauth_impdef;
+    bool prop_lpa2;
 
     /* DCZ blocksize, in log_2(words), ie low 4 bits of DCZID_EL0 */
     uint32_t dcz_blocksize;
diff --git a/target/arm/cpu.c b/target/arm/cpu.c
index XXXXXXX..XXXXXXX 100644
--- a/target/arm/cpu.c
+++ b/target/arm/cpu.c
@@ -XXX,XX +XXX,XX @@ void arm_cpu_finalize_features(ARMCPU *cpu, Error **errp)
             error_propagate(errp, local_err);
             return;
         }
+
+        arm_cpu_lpa2_finalize(cpu, &local_err);
+        if (local_err != NULL) {
+            error_propagate(errp, local_err);
+            return;
+        }
     }
 
     if (kvm_enabled()) {
diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c
index XXXXXXX..XXXXXXX 100644
--- a/target/arm/cpu64.c
+++ b/target/arm/cpu64.c
@@ -XXX,XX +XXX,XX @@ void aarch64_add_pauth_properties(Object *obj)
     }
 }
 
+static Property arm_cpu_lpa2_property =
+    DEFINE_PROP_BOOL("lpa2", ARMCPU, prop_lpa2, true);
+
+void arm_cpu_lpa2_finalize(ARMCPU *cpu, Error **errp)
+{
+    uint64_t t;
+
+    /*
+     * We only install the property for tcg -cpu max; this is the
+     * only situation in which the cpu field can be true.
+     */
+    if (!cpu->prop_lpa2) {
+        return;
+    }
+
+    t = cpu->isar.id_aa64mmfr0;
+    t = FIELD_DP64(t, ID_AA64MMFR0, TGRAN16, 2);   /* 16k pages w/ LPA2 */
+    t = FIELD_DP64(t, ID_AA64MMFR0, TGRAN4, 1);    /*  4k pages w/ LPA2 */
+    t = FIELD_DP64(t, ID_AA64MMFR0, TGRAN16_2, 3); /* 16k stage2 w/ LPA2 */
+    t = FIELD_DP64(t, ID_AA64MMFR0, TGRAN4_2, 3);  /*  4k stage2 w/ LPA2 */
+    cpu->isar.id_aa64mmfr0 = t;
+}
+
 static void aarch64_host_initfn(Object *obj)
 {
 #if defined(CONFIG_KVM)
@@ -XXX,XX +XXX,XX @@ static void aarch64_max_initfn(Object *obj)
     aarch64_add_sve_properties(obj);
     object_property_add(obj, "sve-max-vq", "uint32", cpu_max_get_sve_max_vq,
                         cpu_max_set_sve_max_vq, NULL, NULL);
+    qdev_property_add_static(DEVICE(obj), &arm_cpu_lpa2_property);
 }
 
 static void aarch64_a64fx_initfn(Object *obj)
diff --git a/tests/avocado/boot_linux.py b/tests/avocado/boot_linux.py
index XXXXXXX..XXXXXXX 100644
--- a/tests/avocado/boot_linux.py
+++ b/tests/avocado/boot_linux.py
@@ -XXX,XX +XXX,XX @@ def test_virt_tcg_gicv2(self):
         """
         self.require_accelerator("tcg")
         self.vm.add_args("-accel", "tcg")
+        self.vm.add_args("-cpu", "max,lpa2=off")
         self.vm.add_args("-machine", "virt,gic-version=2")
         self.add_common_args()
         self.launch_and_wait(set_up_ssh_connection=False)
@@ -XXX,XX +XXX,XX @@ def test_virt_tcg_gicv3(self):
         """
         self.require_accelerator("tcg")
         self.vm.add_args("-accel", "tcg")
+        self.vm.add_args("-cpu", "max,lpa2=off")
         self.vm.add_args("-machine", "virt,gic-version=3")
         self.add_common_args()
         self.launch_and_wait(set_up_ssh_connection=False)
-- 
2.25.1

From: Richard Henderson <richard.henderson@linaro.org>

There is a Linux kernel bug present until v5.12 that prevents
booting with FEAT_LPA2 enabled.  As a workaround for TCG,
disable this feature for machine versions prior to 7.0.

Cc: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
---
 include/hw/arm/virt.h | 1 +
 hw/arm/virt.c         | 7 +++++++
 2 files changed, 8 insertions(+)

diff --git a/include/hw/arm/virt.h b/include/hw/arm/virt.h
index XXXXXXX..XXXXXXX 100644
--- a/include/hw/arm/virt.h
+++ b/include/hw/arm/virt.h
@@ -XXX,XX +XXX,XX @@ struct VirtMachineClass {
     bool no_secure_gpio;
     /* Machines < 6.2 have no support for describing cpu topology to guest */
     bool no_cpu_topology;
+    bool no_tcg_lpa2;
 };
 
 struct VirtMachineState {
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index XXXXXXX..XXXXXXX 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -XXX,XX +XXX,XX @@ static void machvirt_init(MachineState *machine)
             object_property_set_bool(cpuobj, "pmu", false, NULL);
         }
 
+        if (vmc->no_tcg_lpa2 && object_property_find(cpuobj, "lpa2")) {
+            object_property_set_bool(cpuobj, "lpa2", false, NULL);
+        }
+
         if (object_property_find(cpuobj, "reset-cbar")) {
             object_property_set_int(cpuobj, "reset-cbar",
                                     vms->memmap[VIRT_CPUPERIPHS].base,
@@ -XXX,XX +XXX,XX @@ DEFINE_VIRT_MACHINE_AS_LATEST(7, 0)
 
 static void virt_machine_6_2_options(MachineClass *mc)
 {
+    VirtMachineClass *vmc = VIRT_MACHINE_CLASS(OBJECT_CLASS(mc));
+
     virt_machine_7_0_options(mc);
     compat_props_add(mc->compat_props, hw_compat_6_2, hw_compat_6_2_len);
+    vmc->no_tcg_lpa2 = true;
 }
 DEFINE_VIRT_MACHINE(6, 2)
 
-- 
2.25.1

Dropped the tmp421 patch and the following patch that
depended on it; no other changes.

thanks
-- PMM

The following changes since commit 43771d5d92312504305c19abe29ec5bfabd55f01:

Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2017-05-31' into staging (2017-06-01 16:39:16 +0100)

are available in the git repository at:

git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20170602

for you to fetch changes up to c7637c04be257968e6df30de961a6a23a0ac3dd8:

hw/arm/virt: fdt: generate distance-map when needed (2017-06-02 11:51:49 +0100)

----------------------------------------------------------------
target-arm queue:
 * virt: numa: provide ACPI distance info when needed
 * aspeed: fix i2c controller bugs
 * M profile: support MPU
 * gicv3: fix mishandling of BPR1, VBPR1
 * load_uboot_image: don't assume a full header read
 * libvixl: Correct build failures on NetBSD

----------------------------------------------------------------
Andrew Jones (3):
      load_uboot_image: don't assume a full header read
      hw/arm/virt-acpi-build: build SLIT when needed
      hw/arm/virt: fdt: generate distance-map when needed

Cédric Le Goater (4):
      aspeed/i2c: improve command handling
      aspeed/i2c: handle LAST command under the RX command
      aspeed/i2c: introduce a state machine
      aspeed: add some I2C devices to the Aspeed machines

Kamil Rytarowski (1):
      libvixl: Correct build failures on NetBSD

Michael Davidsaver (4):
      armv7m: Improve "-d mmu" tracing for PMSAv7 MPU
      armv7m: Implement M profile default memory map
      armv7m: Classify faults as MemManage or BusFault
      arm: add MPU support to M profile CPUs

Peter Maydell (12):
      hw/intc/arm_gicv3_cpuif: Fix reset value for VMCR_EL2.VBPR1
      hw/intc/arm_gicv3_cpuif: Don't let BPR be set below its minimum
      hw/intc/arm_gicv3_cpuif: Fix priority masking for NS BPR1
      arm: Use the mmu_idx we're passed in arm_cpu_do_unaligned_access()
      arm: Add support for M profile CPUs having different MMU index semantics
      arm: Use different ARMMMUIdx values for M profile
      arm: Clean up handling of no-MPU PMSA CPUs
      arm: Don't clear ARM_FEATURE_PMSA for no-mpu configs
      arm: Don't let no-MPU PMSA cores write to SCTLR.M
      arm: Remove unnecessary check on cpu->pmsav7_dregion
      arm: All M profile cores are PMSA
      arm: Implement HFNMIENA support for M profile MPU

Wei Huang (1):
      target/arm: clear PMUVER field of AA64DFR0 when vPMU=off