[PATCH 0/5] --disable-tcg qtest/avocado fixes for ppc64

Daniel Henrique Barboza posted 5 patches 2 years, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220303153517.168943-1-danielhb413@gmail.com
Test checkpatch passed
Maintainers: Cleber Rosa <crosa@redhat.com>, "Philippe Mathieu-Daudé" <f4bug@amsat.org>, Wainer dos Santos Moschetta <wainersm@redhat.com>, Beraldo Leal <bleal@redhat.com>, Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>, Paolo Bonzini <pbonzini@redhat.com>, Thomas Huth <thuth@redhat.com>, Laurent Vivier <lvivier@redhat.com>
tests/avocado/boot_linux_console.py | 5 +++++
tests/avocado/replay_kernel.py      | 4 ++++
tests/qtest/meson.build             | 4 +++-
3 files changed, 12 insertions(+), 1 deletion(-)
[PATCH 0/5] --disable-tcg qtest/avocado fixes for ppc64
Posted by Daniel Henrique Barboza 2 years, 1 month ago
Hi,

'make check' and 'make check-avocado' in a ppc64 host, using a QEMU
built with --disable-tcg, fails in a handful of tests/files due to the
lack of TCG support not being accounted for. The tests usually fall back
to KVM acceleration, and when running in an IBM POWER server this accel
type isn't able to run any other machine but 'pseries'. 

This series aims to fix it by checking for CONFIG_TCG in
qtest/meson.build, and using require_accelerator('tcg') in avocado
tests. I avoided changing the behavior when running the tests in other
host architectures because I can't assert about how KVM behaves in x86 and
aarch64. Patches 1, 2 and 4 were limited to ppc/ppc64 tests only because
of that.

Patch 5 is something that I am fairly confident that affects all archs
so the change is made in the common code for everyone.


Daniel Henrique Barboza (5):
  qtest/meson.build: check CONFIG_TCG for prom-env-test in qtests_ppc
  qtest/meson.build: check CONFIG_TCG for boot-serial-test in qtests_ppc
  avocado/boot_linux_console.py: check for tcg in test_ppc_powernv8/9
  avocado/boot_linux_console.py: check tcg accel in test_ppc64_e500
  avocado/replay_kernel.py: make tcg-icount check in run_vm()

 tests/avocado/boot_linux_console.py | 5 +++++
 tests/avocado/replay_kernel.py      | 4 ++++
 tests/qtest/meson.build             | 4 +++-
 3 files changed, 12 insertions(+), 1 deletion(-)

-- 
2.35.1
Re: [PATCH 0/5] --disable-tcg qtest/avocado fixes for ppc64
Posted by Cédric Le Goater 2 years, 1 month ago
On 3/3/22 16:35, Daniel Henrique Barboza wrote:
> Hi,
> 
> 'make check' and 'make check-avocado' in a ppc64 host, using a QEMU
> built with --disable-tcg, fails in a handful of tests/files due to the
> lack of TCG support not being accounted for. The tests usually fall back
> to KVM acceleration, and when running in an IBM POWER server this accel
> type isn't able to run any other machine but 'pseries'.
> 
> This series aims to fix it by checking for CONFIG_TCG in
> qtest/meson.build, and using require_accelerator('tcg') in avocado
> tests. I avoided changing the behavior when running the tests in other
> host architectures because I can't assert about how KVM behaves in x86 and
> aarch64. Patches 1, 2 and 4 were limited to ppc/ppc64 tests only because
> of that.
> 
> Patch 5 is something that I am fairly confident that affects all archs
> so the change is made in the common code for everyone.
> 
> 
> Daniel Henrique Barboza (5):
>    qtest/meson.build: check CONFIG_TCG for prom-env-test in qtests_ppc
>    qtest/meson.build: check CONFIG_TCG for boot-serial-test in qtests_ppc
>    avocado/boot_linux_console.py: check for tcg in test_ppc_powernv8/9
>    avocado/boot_linux_console.py: check tcg accel in test_ppc64_e500
>    avocado/replay_kernel.py: make tcg-icount check in run_vm()
> 
>   tests/avocado/boot_linux_console.py | 5 +++++
>   tests/avocado/replay_kernel.py      | 4 ++++
>   tests/qtest/meson.build             | 4 +++-
>   3 files changed, 12 insertions(+), 1 deletion(-)
> 


Queued for 7.0

Thanks,

C.