This patch series contains updates to PMBus in QEMU along with some PMBus device models for Renesas regulators. I have also added myself to MAINTAINERS as this code is in use daily, where I am responsible for it. | Patchew

[PATCH v3 0/9] This patch series contains updates to PMBus in QEMU along with some PMBus device models for Renesas regulators. I have also added myself to MAINTAINERS as this code is in use daily, where I am responsible for it.

Titus Rwantare posted 9 patches 2 years, 2 months ago

Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220302015053.1984165-1-titusr@google.com

Maintainers: Peter Maydell <peter.maydell@linaro.org>, Titus Rwantare <titusr@google.com>, Thomas Huth <thuth@redhat.com>, Laurent Vivier <lvivier@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

MAINTAINERS                      |  13 +
hw/arm/Kconfig                   |   1 +
hw/i2c/pmbus_device.c            | 106 ++++++-
hw/sensor/Kconfig                |   5 +
hw/sensor/isl_pmbus_vr.c         | 279 ++++++++++++++++++
hw/sensor/meson.build            |   1 +
include/hw/i2c/pmbus_device.h    |  23 +-
include/hw/sensor/isl_pmbus_vr.h |  52 ++++
tests/qtest/isl_pmbus_vr-test.c  | 474 +++++++++++++++++++++++++++++++
tests/qtest/meson.build          |   1 +
10 files changed, 944 insertions(+), 11 deletions(-)
create mode 100644 hw/sensor/isl_pmbus_vr.c
create mode 100644 include/hw/sensor/isl_pmbus_vr.h
create mode 100644 tests/qtest/isl_pmbus_vr-test.c

Expand all Fold all

[PATCH v3 0/9] This patch series contains updates to PMBus in QEMU along with some PMBus device models for Renesas regulators. I have also added myself to MAINTAINERS as this code is in use daily, where I am responsible for it.

Posted by Titus Rwantare 2 years, 2 months ago

v2:
  - split PMBus commit with updates into individual fixes
  - renamed isl_pmbus[.ch] adding _vr for voltage regulators

v3:
  - split uint refactor commit and removed commit renaming files
  - rename rolled into preceding commits
  - update commit description for uint refactoring change

Shengtan Mao (1):
  hw/i2c: Added linear mode translation for pmbus devices

Titus Rwantare (8):
  hw/i2c: pmbus: add registers
  hw/i2c: pmbus: guard against out of range accesses
  hw/i2c: pmbus: add PEC unsupported warning
  hw/i2c: pmbus: refactor uint handling
  hw/i2c: pmbus: update MAINTAINERS
  hw/sensor: add Intersil ISL69260 device model
  hw/sensor: add Renesas raa229004 PMBus device
  hw/sensor: add Renesas raa228000 device

 MAINTAINERS                      |  13 +
 hw/arm/Kconfig                   |   1 +
 hw/i2c/pmbus_device.c            | 106 ++++++-
 hw/sensor/Kconfig                |   5 +
 hw/sensor/isl_pmbus_vr.c         | 279 ++++++++++++++++++
 hw/sensor/meson.build            |   1 +
 include/hw/i2c/pmbus_device.h    |  23 +-
 include/hw/sensor/isl_pmbus_vr.h |  52 ++++
 tests/qtest/isl_pmbus_vr-test.c  | 474 +++++++++++++++++++++++++++++++
 tests/qtest/meson.build          |   1 +
 10 files changed, 944 insertions(+), 11 deletions(-)
 create mode 100644 hw/sensor/isl_pmbus_vr.c
 create mode 100644 include/hw/sensor/isl_pmbus_vr.h
 create mode 100644 tests/qtest/isl_pmbus_vr-test.c

-- 
2.35.1.616.g0bdcbb4464-goog

Re: [PATCH v3 0/9] This patch series contains updates to PMBus in QEMU along with some PMBus device models for Renesas regulators. I have also added myself to MAINTAINERS as this code is in use daily, where I am responsible for it.

Posted by Corey Minyard 2 years, 2 months ago

On Tue, Mar 01, 2022 at 05:50:44PM -0800, Titus Rwantare wrote:
> v2:
>   - split PMBus commit with updates into individual fixes
>   - renamed isl_pmbus[.ch] adding _vr for voltage regulators
> 
> v3:
>   - split uint refactor commit and removed commit renaming files
>   - rename rolled into preceding commits
>   - update commit description for uint refactoring change

This all looks good to me:

Acked-by: Corey Minyard <cminyard@mvista.com>

Do you have a plan for getting this in to qemu?  Like through the ARM
tree?  I could take it into an I2C tree, but there's really not much
activity or work there.

-corey

> 
> Shengtan Mao (1):
>   hw/i2c: Added linear mode translation for pmbus devices
> 
> Titus Rwantare (8):
>   hw/i2c: pmbus: add registers
>   hw/i2c: pmbus: guard against out of range accesses
>   hw/i2c: pmbus: add PEC unsupported warning
>   hw/i2c: pmbus: refactor uint handling
>   hw/i2c: pmbus: update MAINTAINERS
>   hw/sensor: add Intersil ISL69260 device model
>   hw/sensor: add Renesas raa229004 PMBus device
>   hw/sensor: add Renesas raa228000 device
> 
>  MAINTAINERS                      |  13 +
>  hw/arm/Kconfig                   |   1 +
>  hw/i2c/pmbus_device.c            | 106 ++++++-
>  hw/sensor/Kconfig                |   5 +
>  hw/sensor/isl_pmbus_vr.c         | 279 ++++++++++++++++++
>  hw/sensor/meson.build            |   1 +
>  include/hw/i2c/pmbus_device.h    |  23 +-
>  include/hw/sensor/isl_pmbus_vr.h |  52 ++++
>  tests/qtest/isl_pmbus_vr-test.c  | 474 +++++++++++++++++++++++++++++++
>  tests/qtest/meson.build          |   1 +
>  10 files changed, 944 insertions(+), 11 deletions(-)
>  create mode 100644 hw/sensor/isl_pmbus_vr.c
>  create mode 100644 include/hw/sensor/isl_pmbus_vr.h
>  create mode 100644 tests/qtest/isl_pmbus_vr-test.c
> 
> -- 
> 2.35.1.616.g0bdcbb4464-goog
>

Re: [PATCH v3 0/9] This patch series contains updates to PMBus in QEMU along with some PMBus device models for Renesas regulators. I have also added myself to MAINTAINERS as this code is in use daily, where I am responsible for it.

Posted by Titus Rwantare 2 years, 2 months ago

On Fri, 4 Mar 2022 at 13:43, Corey Minyard <minyard@acm.org> wrote:
>
> On Tue, Mar 01, 2022 at 05:50:44PM -0800, Titus Rwantare wrote:
> > v2:
> >   - split PMBus commit with updates into individual fixes
> >   - renamed isl_pmbus[.ch] adding _vr for voltage regulators
> >
> > v3:
> >   - split uint refactor commit and removed commit renaming files
> >   - rename rolled into preceding commits
> >   - update commit description for uint refactoring change
>
> This all looks good to me:
>
> Acked-by: Corey Minyard <cminyard@mvista.com>
>
> Do you have a plan for getting this in to qemu?  Like through the ARM
> tree?  I could take it into an I2C tree, but there's really not much
> activity or work there.
>
> -corey

In general PMBus is more specific to i2c than ARM, but I'm not sure of
the QEMU implications.

Titus

Re: [PATCH v3 0/9] This patch series contains updates to PMBus in QEMU along with some PMBus device models for Renesas regulators. I have also added myself to MAINTAINERS as this code is in use daily, where I am responsible for it.

Posted by Philippe Mathieu-Daudé 2 years, 1 month ago

On 5/3/22 00:42, Titus Rwantare wrote:
> On Fri, 4 Mar 2022 at 13:43, Corey Minyard <minyard@acm.org> wrote:
>>
>> On Tue, Mar 01, 2022 at 05:50:44PM -0800, Titus Rwantare wrote:
>>> v2:
>>>    - split PMBus commit with updates into individual fixes
>>>    - renamed isl_pmbus[.ch] adding _vr for voltage regulators
>>>
>>> v3:
>>>    - split uint refactor commit and removed commit renaming files
>>>    - rename rolled into preceding commits
>>>    - update commit description for uint refactoring change
>>
>> This all looks good to me:
>>
>> Acked-by: Corey Minyard <cminyard@mvista.com>
>>
>> Do you have a plan for getting this in to qemu?  Like through the ARM
>> tree?  I could take it into an I2C tree, but there's really not much
>> activity or work there.
>>
>> -corey
> 
> In general PMBus is more specific to i2c than ARM, but I'm not sure of
> the QEMU implications.

Titus, could you address my comments?

Corey, if you are busy, I can take care of this series.

Regards,

Phil.

Re: [PATCH v3 0/9] This patch series contains updates to PMBus in QEMU along with some PMBus device models for Renesas regulators. I have also added myself to MAINTAINERS as this code is in use daily, where I am responsible for it.

Posted by Corey Minyard 2 years, 1 month ago

On Mon, Mar 07, 2022 at 01:00:02AM +0100, Philippe Mathieu-Daudé wrote:
> On 5/3/22 00:42, Titus Rwantare wrote:
> > On Fri, 4 Mar 2022 at 13:43, Corey Minyard <minyard@acm.org> wrote:
> > > 
> > > On Tue, Mar 01, 2022 at 05:50:44PM -0800, Titus Rwantare wrote:
> > > > v2:
> > > >    - split PMBus commit with updates into individual fixes
> > > >    - renamed isl_pmbus[.ch] adding _vr for voltage regulators
> > > > 
> > > > v3:
> > > >    - split uint refactor commit and removed commit renaming files
> > > >    - rename rolled into preceding commits
> > > >    - update commit description for uint refactoring change
> > > 
> > > This all looks good to me:
> > > 
> > > Acked-by: Corey Minyard <cminyard@mvista.com>
> > > 
> > > Do you have a plan for getting this in to qemu?  Like through the ARM
> > > tree?  I could take it into an I2C tree, but there's really not much
> > > activity or work there.
> > > 
> > > -corey
> > 
> > In general PMBus is more specific to i2c than ARM, but I'm not sure of
> > the QEMU implications.
> 
> Titus, could you address my comments?
> 
> Corey, if you are busy, I can take care of this series.

It's not a "too busy" sort of thing, the i2c tree doesn't get much
traffic.  I can take it, but it's not much different than just pulling
it directly.

So it's probably best if you take it.

Thanks,

-corey

> 
> Regards,
> 
> Phil.
>

Re: [PATCH v3 0/9] This patch series contains updates to PMBus in QEMU along with some PMBus device models for Renesas regulators. I have also added myself to MAINTAINERS as this code is in use daily, where I am responsible for it.

Posted by Philippe Mathieu-Daudé 2 years, 1 month ago

On 8/3/22 14:53, Corey Minyard wrote:
> On Mon, Mar 07, 2022 at 01:00:02AM +0100, Philippe Mathieu-Daudé wrote:
>> On 5/3/22 00:42, Titus Rwantare wrote:
>>> On Fri, 4 Mar 2022 at 13:43, Corey Minyard <minyard@acm.org> wrote:
>>>>
>>>> On Tue, Mar 01, 2022 at 05:50:44PM -0800, Titus Rwantare wrote:
>>>>> v2:
>>>>>     - split PMBus commit with updates into individual fixes
>>>>>     - renamed isl_pmbus[.ch] adding _vr for voltage regulators
>>>>>
>>>>> v3:
>>>>>     - split uint refactor commit and removed commit renaming files
>>>>>     - rename rolled into preceding commits
>>>>>     - update commit description for uint refactoring change
>>>>
>>>> This all looks good to me:
>>>>
>>>> Acked-by: Corey Minyard <cminyard@mvista.com>
>>>>
>>>> Do you have a plan for getting this in to qemu?  Like through the ARM
>>>> tree?  I could take it into an I2C tree, but there's really not much
>>>> activity or work there.
>>>>
>>>> -corey
>>>
>>> In general PMBus is more specific to i2c than ARM, but I'm not sure of
>>> the QEMU implications.
>>
>> Titus, could you address my comments?
>>
>> Corey, if you are busy, I can take care of this series.
> 
> It's not a "too busy" sort of thing, the i2c tree doesn't get much
> traffic.  I can take it, but it's not much different than just pulling
> it directly.
> 
> So it's probably best if you take it.

OK. I'll send a pullreq shortly.

Regards,

Phil.