[PATCH v2 0/4] cutils: Introduce bundle mechanism

Akihiko Odaki posted 4 patches 2 years, 2 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220226124535.76885-1-akihiko.odaki@gmail.com
Maintainers: Jason Wang <jasowang@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Akihiko Odaki <akihiko.odaki@gmail.com>, Gerd Hoffmann <kraxel@redhat.com>
There is a newer version of this series
configure             | 13 +++++++++++++
include/net/net.h     |  2 +-
include/qemu/cutils.h | 19 +++++++++++++++++++
meson.build           |  6 +++---
net/tap.c             |  6 +++++-
qemu-options.hx       |  4 ++--
softmmu/datadir.c     | 35 ++++++++++++-----------------------
ui/cocoa.m            | 20 +++++++++++---------
ui/gtk.c              |  8 +++++---
ui/sdl2.c             | 18 +++++++++++-------
util/cutils.c         | 33 +++++++++++++++++++++++++++++++++
11 files changed, 115 insertions(+), 49 deletions(-)
[PATCH v2 0/4] cutils: Introduce bundle mechanism
Posted by Akihiko Odaki 2 years, 2 months ago
Developers often run QEMU without installing. The bundle mechanism
allows to look up files which should be present in installation even in
such a situation.

v2: Rebased to the latest QEMU.

Akihiko Odaki (4):
  cutils: Introduce bundle mechanism
  datadir: Use bundle mechanism
  ui/icons: Use bundle mechanism
  net: Use bundle mechanism

 configure             | 13 +++++++++++++
 include/net/net.h     |  2 +-
 include/qemu/cutils.h | 19 +++++++++++++++++++
 meson.build           |  6 +++---
 net/tap.c             |  6 +++++-
 qemu-options.hx       |  4 ++--
 softmmu/datadir.c     | 35 ++++++++++++-----------------------
 ui/cocoa.m            | 20 +++++++++++---------
 ui/gtk.c              |  8 +++++---
 ui/sdl2.c             | 18 +++++++++++-------
 util/cutils.c         | 33 +++++++++++++++++++++++++++++++++
 11 files changed, 115 insertions(+), 49 deletions(-)

-- 
2.32.0 (Apple Git-132)
Re: [PATCH v2 0/4] cutils: Introduce bundle mechanism
Posted by Peter Maydell 2 years, 2 months ago
On Sat, 26 Feb 2022 at 12:45, Akihiko Odaki <akihiko.odaki@gmail.com> wrote:
>
> Developers often run QEMU without installing. The bundle mechanism
> allows to look up files which should be present in installation even in
> such a situation.

This is supposed to work already -- it is why find_datadir() looks
at a path based on qemu_get_exec_dir() as well as at the
CONFIG_QEMU_DATADIR.

If you want to replace that mechanism, you need to explain:
 * under what circumstances it isn't working correctly
 * why we should replace it with a different design rather
   than attempting to fix its bugs
 * why the design you're proposing is the right way to do that

The cover letter is a good place to explain that sort of
thing, so people understand why the patchset is doing what
it is before they dive into the detail.

thanks
-- PMM
Re: [PATCH v2 0/4] cutils: Introduce bundle mechanism
Posted by Akihiko Odaki 2 years, 2 months ago
On 2022/02/26 22:02, Peter Maydell wrote:
> On Sat, 26 Feb 2022 at 12:45, Akihiko Odaki <akihiko.odaki@gmail.com> wrote:
>>
>> Developers often run QEMU without installing. The bundle mechanism
>> allows to look up files which should be present in installation even in
>> such a situation.
> 
> This is supposed to work already -- it is why find_datadir() looks
> at a path based on qemu_get_exec_dir() as well as at the
> CONFIG_QEMU_DATADIR.
> 
> If you want to replace that mechanism, you need to explain:
>   * under what circumstances it isn't working correctly
>   * why we should replace it with a different design rather
>     than attempting to fix its bugs
>   * why the design you're proposing is the right way to do that
> 
> The cover letter is a good place to explain that sort of
> thing, so people understand why the patchset is doing what
> it is before they dive into the detail.
> 
> thanks
> -- PMM

datadir is only for pc-bios and does not include icons and 
qemu-bridge-helper. find_bundle is a general mechanism which can be used 
for any files to be installed.

Regards,
Akihiko Odaki