tcg/tci: Use tcg_out_ldst in tcg_out_st

[PATCH] tcg/tci: Use tcg_out_ldst in tcg_out_st

Richard Henderson posted 1 patch 3 years, 11 months ago

Download mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220226015502.534801-1-richard.henderson@linaro.org

Maintainers: Stefan Weil <sw@weilnetz.de>, Richard Henderson <richard.henderson@linaro.org>

tcg/tci/tcg-target.c.inc | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

Expand all Fold all

[PATCH] tcg/tci: Use tcg_out_ldst in tcg_out_st

Posted by Richard Henderson 3 years, 11 months ago

The tcg_out_ldst helper will handle out-of-range offsets.
We haven't actually encountered any, since we haven't run
across the assert within tcg_out_op_rrs, but an out-of-range
offset would not be impossible in future.

Fixes: 65089889183 ("tcg/tci: Change encoding to uint32_t units")
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 tcg/tci/tcg-target.c.inc | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/tcg/tci/tcg-target.c.inc b/tcg/tci/tcg-target.c.inc
index 0cb16aaa81..9ff1fa0832 100644
--- a/tcg/tci/tcg-target.c.inc
+++ b/tcg/tci/tcg-target.c.inc
@@ -790,14 +790,13 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc,
 static void tcg_out_st(TCGContext *s, TCGType type, TCGReg val, TCGReg base,
                        intptr_t offset)
 {
-    stack_bounds_check(base, offset);
     switch (type) {
     case TCG_TYPE_I32:
-        tcg_out_op_rrs(s, INDEX_op_st_i32, val, base, offset);
+        tcg_out_ldst(s, INDEX_op_st_i32, val, base, offset);
         break;
 #if TCG_TARGET_REG_BITS == 64
     case TCG_TYPE_I64:
-        tcg_out_op_rrs(s, INDEX_op_st_i64, val, base, offset);
+        tcg_out_ldst(s, INDEX_op_st_i64, val, base, offset);
         break;
 #endif
     default:
-- 
2.25.1

Re: [PATCH] tcg/tci: Use tcg_out_ldst in tcg_out_st

Posted by Philippe Mathieu-Daudé 3 years, 11 months ago

On 26/2/22 02:55, Richard Henderson wrote:
> The tcg_out_ldst helper will handle out-of-range offsets.
> We haven't actually encountered any, since we haven't run
> across the assert within tcg_out_op_rrs, but an out-of-range
> offset would not be impossible in future.
> 
> Fixes: 65089889183 ("tcg/tci: Change encoding to uint32_t units")
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   tcg/tci/tcg-target.c.inc | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>