Python: Fix qmp race condition on accept()

[PATCH 05/10] python/aqmp: squelch pylint warning for too many lines

Posted by John Snow 3 years, 11 months ago

I would really like to keep this under 1000 lines, I promise. Doesn't
look like it's gonna happen.

Signed-off-by: John Snow <jsnow@redhat.com>
---
 python/qemu/aqmp/protocol.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/python/qemu/aqmp/protocol.py b/python/qemu/aqmp/protocol.py
index 56f05b9030..631bcdaa55 100644
--- a/python/qemu/aqmp/protocol.py
+++ b/python/qemu/aqmp/protocol.py
@@ -10,6 +10,9 @@
 class.
 """
 
+# It's all the docstrings ... ! It's long for a good reason ^_^;
+# pylint: disable=too-many-lines
+
 import asyncio
 from asyncio import StreamReader, StreamWriter
 from enum import Enum
-- 
2.34.1

Re: [PATCH 05/10] python/aqmp: squelch pylint warning for too many lines

Posted by Daniel P. Berrangé 3 years, 11 months ago

On Fri, Feb 25, 2022 at 03:59:43PM -0500, John Snow wrote:
> I would really like to keep this under 1000 lines, I promise. Doesn't
> look like it's gonna happen.
> 
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  python/qemu/aqmp/protocol.py | 3 +++
>  1 file changed, 3 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

> 
> diff --git a/python/qemu/aqmp/protocol.py b/python/qemu/aqmp/protocol.py
> index 56f05b9030..631bcdaa55 100644
> --- a/python/qemu/aqmp/protocol.py
> +++ b/python/qemu/aqmp/protocol.py
> @@ -10,6 +10,9 @@
>  class.
>  """
>  
> +# It's all the docstrings ... ! It's long for a good reason ^_^;
> +# pylint: disable=too-many-lines

Indeed that is a crazy check if it can't be made to only consider
non-comment lines in its metric.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|