[PATCH] qapi: Belatedly adjust limitations documentation

Markus Armbruster posted 1 patch 3 years, 11 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220225084538.218876-1-armbru@redhat.com
Test checkpatch passed
Maintainers: Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>
qapi/compat.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] qapi: Belatedly adjust limitations documentation
Posted by Markus Armbruster 3 years, 11 months ago
Commit 57df0dff1a "qapi: Extend -compat to set policy for unstable
interfaces" (v6.2.0) took care of covering experimental features, but
neglected to adjust a comment suggesting to cover it.  Adjust it now.

Fixes: 57df0dff1a1f4c846aa74a082bfd595a8a990015
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 qapi/compat.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qapi/compat.json b/qapi/compat.json
index c53b69fe3f..39b52872d5 100644
--- a/qapi/compat.json
+++ b/qapi/compat.json
@@ -41,7 +41,7 @@
 #
 # Limitation: covers only syntactic aspects of QMP, i.e. stuff tagged
 # with feature 'deprecated'.  We may want to extend it to cover
-# semantic aspects, CLI, and experimental features.
+# semantic aspects and CLI.
 #
 # Limitation: deprecated-output policy @hide is not implemented for
 # enumeration values.  They behave the same as with policy @accept.
-- 
2.35.1


Re: [PATCH] qapi: Belatedly adjust limitations documentation
Posted by Philippe Mathieu-Daudé 3 years, 11 months ago
On 25/2/22 09:45, Markus Armbruster wrote:
> Commit 57df0dff1a "qapi: Extend -compat to set policy for unstable
> interfaces" (v6.2.0) took care of covering experimental features, but
> neglected to adjust a comment suggesting to cover it.  Adjust it now.
> 
> Fixes: 57df0dff1a1f4c846aa74a082bfd595a8a990015
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>   qapi/compat.json | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)


Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>



Re: [PATCH] qapi: Belatedly adjust limitations documentation
Posted by Eric Blake 3 years, 11 months ago
On Fri, Feb 25, 2022 at 09:45:38AM +0100, Markus Armbruster wrote:
> Commit 57df0dff1a "qapi: Extend -compat to set policy for unstable
> interfaces" (v6.2.0) took care of covering experimental features, but
> neglected to adjust a comment suggesting to cover it.  Adjust it now.
> 
> Fixes: 57df0dff1a1f4c846aa74a082bfd595a8a990015
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  qapi/compat.json | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/qapi/compat.json b/qapi/compat.json
> index c53b69fe3f..39b52872d5 100644
> --- a/qapi/compat.json
> +++ b/qapi/compat.json
> @@ -41,7 +41,7 @@
>  #
>  # Limitation: covers only syntactic aspects of QMP, i.e. stuff tagged
>  # with feature 'deprecated'.  We may want to extend it to cover
> -# semantic aspects, CLI, and experimental features.
> +# semantic aspects and CLI.
>  #
>  # Limitation: deprecated-output policy @hide is not implemented for
>  # enumeration values.  They behave the same as with policy @accept.
> -- 
> 2.35.1
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org