tests/qemu-iotests/040: Skip TestCommitWithFilters without 'throttle'

[PATCH] tests/qemu-iotests/040: Skip TestCommitWithFilters without 'throttle'

Thomas Huth posted 1 patch 2 years, 2 months ago

Download mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220223123127.3206042-1-thuth@redhat.com

Maintainers: Hanna Reitz <hreitz@redhat.com>, Kevin Wolf <kwolf@redhat.com>

tests/qemu-iotests/040 | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH] tests/qemu-iotests/040: Skip TestCommitWithFilters without 'throttle'

Posted by Thomas Huth 2 years, 2 months ago

iotest 040 already has some checks for the availability of the 'throttle'
driver, but some new code has been added in the course of time that
depends on 'throttle' but does not check for its availability. Add
a check to the TestCommitWithFilters class so that this iotest now
also passes again if 'throttle' has not been enabled in the QEMU
binaries.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/qemu-iotests/040 | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/qemu-iotests/040 b/tests/qemu-iotests/040
index 6af5ab9e76..0e1cfd7e49 100755
--- a/tests/qemu-iotests/040
+++ b/tests/qemu-iotests/040
@@ -744,6 +744,7 @@ class TestCommitWithFilters(iotests.QMPTestCase):
                              pattern_file)
             self.assertFalse('Pattern verification failed' in result)
 
+    @iotests.skip_if_unsupported(['throttle'])
     def setUp(self):
         qemu_img('create', '-f', iotests.imgfmt, self.img0, '64M')
         qemu_img('create', '-f', iotests.imgfmt, self.img1, '64M')
-- 
2.27.0

Re: [PATCH] tests/qemu-iotests/040: Skip TestCommitWithFilters without 'throttle'

Posted by Hanna Reitz 2 years, 2 months ago

On 23.02.22 13:31, Thomas Huth wrote:
> iotest 040 already has some checks for the availability of the 'throttle'
> driver, but some new code has been added in the course of time that
> depends on 'throttle' but does not check for its availability. Add
> a check to the TestCommitWithFilters class so that this iotest now
> also passes again if 'throttle' has not been enabled in the QEMU
> binaries.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   tests/qemu-iotests/040 | 1 +
>   1 file changed, 1 insertion(+)

Thanks, applied to my block branch:

https://gitlab.com/hreitz/qemu/-/commits/block

Hanna