[PATCH 0/8] Misc build fixes and cleanups

marcandre.lureau@redhat.com posted 8 patches 2 years, 2 months ago
Test checkpatch failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220222194008.610377-1-marcandre.lureau@redhat.com
docs/devel/build-system.rst             |   5 -
meson.build                             |  25 ++---
audio/audio.h                           |   4 +-
block/qcow2.h                           |   2 +-
bsd-user/qemu.h                         |   2 +-
hw/display/qxl.h                        |   2 +-
hw/net/rocker/rocker.h                  |   2 +-
hw/xen/xen_pt.h                         |   2 +-
include/chardev/char-fe.h               |   2 +-
include/disas/dis-asm.h                 |   2 +-
include/hw/acpi/aml-build.h             |  12 +-
include/hw/core/cpu.h                   |   2 +-
include/hw/hw.h                         |   2 +-
include/hw/virtio/virtio.h              |   2 +-
include/hw/xen/xen-bus-helper.h         |   4 +-
include/hw/xen/xen-bus.h                |   4 +-
include/hw/xen/xen_common.h             |   2 +-
include/hw/xen/xen_pvdev.h              |   2 +-
include/monitor/monitor.h               |   4 +-
include/qapi/error.h                    |  20 ++--
include/qapi/qmp/qjson.h                |   8 +-
include/qemu-common.h                   |  21 ----
include/qemu/buffer.h                   |   2 +-
include/qemu/compiler.h                 |  11 +-
include/qemu/error-report.h             |  24 ++--
include/qemu/log-for-trace.h            |   2 +-
include/qemu/log.h                      |   2 +-
include/qemu/qemu-print.h               |   8 +-
include/qemu/readline.h                 |   2 +-
qga/guest-agent-core.h                  |   2 +-
qga/vss-win32/requester.h               |   2 +-
qga/vss-win32/vss-common.h              |   3 +-
scripts/cocci-macro-file.h              |   2 +-
tests/qtest/libqos/libqtest.h           |  42 +++----
tests/qtest/libqtest-single.h           |   2 +-
tests/qtest/migration-helpers.h         |   6 +-
audio/alsaaudio.c                       |   4 +-
audio/coreaudio.c                       |   4 +-
audio/dsoundaudio.c                     |   4 +-
audio/ossaudio.c                        |   4 +-
audio/paaudio.c                         |   2 +-
audio/sdlaudio.c                        |   2 +-
block/blkverify.c                       |   2 +-
block/ssh.c                             |   4 +-
chardev/char-pty.c                      | 104 ++++++++++++++++++
crypto/cipher-afalg.c                   |   4 +-
crypto/hash-afalg.c                     |   4 +-
fsdev/9p-marshal.c                      |   2 +-
fsdev/virtfs-proxy-helper.c             |   2 +-
gdbstub.c                               |   2 +-
hw/9pfs/9p.c                            |   2 +-
hw/acpi/aml-build.c                     |   4 +-
hw/mips/fuloong2e.c                     |   2 +-
hw/mips/malta.c                         |   2 +-
hw/net/rtl8139.c                        |   2 +-
hw/virtio/virtio.c                      |   2 +-
io/channel-socket.c                     |   6 +-
io/channel-websock.c                    |   2 +-
monitor/hmp.c                           |   4 +-
nbd/server.c                            |  10 +-
net/socket.c                            |  24 ++--
qemu-img.c                              |   4 +-
qemu-io.c                               |   2 +-
qobject/json-parser.c                   |   2 +-
softmmu/qtest.c                         |   4 +-
tests/qtest/e1000e-test.c               |   4 +-
tests/qtest/libqtest.c                  |   6 +-
tests/qtest/npcm7xx_emc-test.c          |   4 +-
tests/qtest/test-filter-mirror.c        |   4 +-
tests/qtest/test-filter-redirector.c    |   8 +-
tests/qtest/virtio-net-test.c           |  10 +-
tests/unit/socket-helpers.c             |   2 +-
tests/unit/test-qobject-input-visitor.c |   4 +-
util/osdep.c                            |   4 +-
util/qemu-openpty.c                     | 139 ------------------------
util/qemu-sockets.c                     |  10 +-
chardev/meson.build                     |   4 +-
qga/meson.build                         |   2 +-
qga/vss-win32/install.cpp               |   4 +
qga/vss-win32/provider.cpp              |   4 +
scripts/checkpatch.pl                   |   2 +-
tests/qtest/libqos/meson.build          |   1 -
util/meson.build                        |   1 -
83 files changed, 300 insertions(+), 370 deletions(-)
delete mode 100644 util/qemu-openpty.c
[PATCH 0/8] Misc build fixes and cleanups
Posted by marcandre.lureau@redhat.com 2 years, 2 months ago
From: Marc-André Lureau <marcandre.lureau@redhat.com>

Hi,

A small collection of patches gleaned while working on different things.

Marc-André Lureau (8):
  meson: fix generic location of vss headers
  qga/vss-win32: check old VSS SDK headers
  qga/vss: update informative message about MinGW
  meson: drop the .fa library suffix
  meson: use chardev_ss dependencies
  char: move qemu_openpty_raw from util/ to char/
  Drop qemu_foo() socket API wrapper
  Replace GCC_FMT_ATTR with G_GNUC_PRINTF

 docs/devel/build-system.rst             |   5 -
 meson.build                             |  25 ++---
 audio/audio.h                           |   4 +-
 block/qcow2.h                           |   2 +-
 bsd-user/qemu.h                         |   2 +-
 hw/display/qxl.h                        |   2 +-
 hw/net/rocker/rocker.h                  |   2 +-
 hw/xen/xen_pt.h                         |   2 +-
 include/chardev/char-fe.h               |   2 +-
 include/disas/dis-asm.h                 |   2 +-
 include/hw/acpi/aml-build.h             |  12 +-
 include/hw/core/cpu.h                   |   2 +-
 include/hw/hw.h                         |   2 +-
 include/hw/virtio/virtio.h              |   2 +-
 include/hw/xen/xen-bus-helper.h         |   4 +-
 include/hw/xen/xen-bus.h                |   4 +-
 include/hw/xen/xen_common.h             |   2 +-
 include/hw/xen/xen_pvdev.h              |   2 +-
 include/monitor/monitor.h               |   4 +-
 include/qapi/error.h                    |  20 ++--
 include/qapi/qmp/qjson.h                |   8 +-
 include/qemu-common.h                   |  21 ----
 include/qemu/buffer.h                   |   2 +-
 include/qemu/compiler.h                 |  11 +-
 include/qemu/error-report.h             |  24 ++--
 include/qemu/log-for-trace.h            |   2 +-
 include/qemu/log.h                      |   2 +-
 include/qemu/qemu-print.h               |   8 +-
 include/qemu/readline.h                 |   2 +-
 qga/guest-agent-core.h                  |   2 +-
 qga/vss-win32/requester.h               |   2 +-
 qga/vss-win32/vss-common.h              |   3 +-
 scripts/cocci-macro-file.h              |   2 +-
 tests/qtest/libqos/libqtest.h           |  42 +++----
 tests/qtest/libqtest-single.h           |   2 +-
 tests/qtest/migration-helpers.h         |   6 +-
 audio/alsaaudio.c                       |   4 +-
 audio/coreaudio.c                       |   4 +-
 audio/dsoundaudio.c                     |   4 +-
 audio/ossaudio.c                        |   4 +-
 audio/paaudio.c                         |   2 +-
 audio/sdlaudio.c                        |   2 +-
 block/blkverify.c                       |   2 +-
 block/ssh.c                             |   4 +-
 chardev/char-pty.c                      | 104 ++++++++++++++++++
 crypto/cipher-afalg.c                   |   4 +-
 crypto/hash-afalg.c                     |   4 +-
 fsdev/9p-marshal.c                      |   2 +-
 fsdev/virtfs-proxy-helper.c             |   2 +-
 gdbstub.c                               |   2 +-
 hw/9pfs/9p.c                            |   2 +-
 hw/acpi/aml-build.c                     |   4 +-
 hw/mips/fuloong2e.c                     |   2 +-
 hw/mips/malta.c                         |   2 +-
 hw/net/rtl8139.c                        |   2 +-
 hw/virtio/virtio.c                      |   2 +-
 io/channel-socket.c                     |   6 +-
 io/channel-websock.c                    |   2 +-
 monitor/hmp.c                           |   4 +-
 nbd/server.c                            |  10 +-
 net/socket.c                            |  24 ++--
 qemu-img.c                              |   4 +-
 qemu-io.c                               |   2 +-
 qobject/json-parser.c                   |   2 +-
 softmmu/qtest.c                         |   4 +-
 tests/qtest/e1000e-test.c               |   4 +-
 tests/qtest/libqtest.c                  |   6 +-
 tests/qtest/npcm7xx_emc-test.c          |   4 +-
 tests/qtest/test-filter-mirror.c        |   4 +-
 tests/qtest/test-filter-redirector.c    |   8 +-
 tests/qtest/virtio-net-test.c           |  10 +-
 tests/unit/socket-helpers.c             |   2 +-
 tests/unit/test-qobject-input-visitor.c |   4 +-
 util/osdep.c                            |   4 +-
 util/qemu-openpty.c                     | 139 ------------------------
 util/qemu-sockets.c                     |  10 +-
 chardev/meson.build                     |   4 +-
 qga/meson.build                         |   2 +-
 qga/vss-win32/install.cpp               |   4 +
 qga/vss-win32/provider.cpp              |   4 +
 scripts/checkpatch.pl                   |   2 +-
 tests/qtest/libqos/meson.build          |   1 -
 util/meson.build                        |   1 -
 83 files changed, 300 insertions(+), 370 deletions(-)
 delete mode 100644 util/qemu-openpty.c

-- 
2.35.1.273.ge6ebfd0e8cbb



Re: [PATCH 0/8] Misc build fixes and cleanups
Posted by Paolo Bonzini 2 years, 2 months ago
On 2/22/22 20:40, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> Hi,
> 
> A small collection of patches gleaned while working on different things.

Queued all except patch 4.

Paolo

> Marc-André Lureau (8):
>    meson: fix generic location of vss headers
>    qga/vss-win32: check old VSS SDK headers
>    qga/vss: update informative message about MinGW
>    meson: drop the .fa library suffix
>    meson: use chardev_ss dependencies
>    char: move qemu_openpty_raw from util/ to char/
>    Drop qemu_foo() socket API wrapper
>    Replace GCC_FMT_ATTR with G_GNUC_PRINTF
> 
>   docs/devel/build-system.rst             |   5 -
>   meson.build                             |  25 ++---
>   audio/audio.h                           |   4 +-
>   block/qcow2.h                           |   2 +-
>   bsd-user/qemu.h                         |   2 +-
>   hw/display/qxl.h                        |   2 +-
>   hw/net/rocker/rocker.h                  |   2 +-
>   hw/xen/xen_pt.h                         |   2 +-
>   include/chardev/char-fe.h               |   2 +-
>   include/disas/dis-asm.h                 |   2 +-
>   include/hw/acpi/aml-build.h             |  12 +-
>   include/hw/core/cpu.h                   |   2 +-
>   include/hw/hw.h                         |   2 +-
>   include/hw/virtio/virtio.h              |   2 +-
>   include/hw/xen/xen-bus-helper.h         |   4 +-
>   include/hw/xen/xen-bus.h                |   4 +-
>   include/hw/xen/xen_common.h             |   2 +-
>   include/hw/xen/xen_pvdev.h              |   2 +-
>   include/monitor/monitor.h               |   4 +-
>   include/qapi/error.h                    |  20 ++--
>   include/qapi/qmp/qjson.h                |   8 +-
>   include/qemu-common.h                   |  21 ----
>   include/qemu/buffer.h                   |   2 +-
>   include/qemu/compiler.h                 |  11 +-
>   include/qemu/error-report.h             |  24 ++--
>   include/qemu/log-for-trace.h            |   2 +-
>   include/qemu/log.h                      |   2 +-
>   include/qemu/qemu-print.h               |   8 +-
>   include/qemu/readline.h                 |   2 +-
>   qga/guest-agent-core.h                  |   2 +-
>   qga/vss-win32/requester.h               |   2 +-
>   qga/vss-win32/vss-common.h              |   3 +-
>   scripts/cocci-macro-file.h              |   2 +-
>   tests/qtest/libqos/libqtest.h           |  42 +++----
>   tests/qtest/libqtest-single.h           |   2 +-
>   tests/qtest/migration-helpers.h         |   6 +-
>   audio/alsaaudio.c                       |   4 +-
>   audio/coreaudio.c                       |   4 +-
>   audio/dsoundaudio.c                     |   4 +-
>   audio/ossaudio.c                        |   4 +-
>   audio/paaudio.c                         |   2 +-
>   audio/sdlaudio.c                        |   2 +-
>   block/blkverify.c                       |   2 +-
>   block/ssh.c                             |   4 +-
>   chardev/char-pty.c                      | 104 ++++++++++++++++++
>   crypto/cipher-afalg.c                   |   4 +-
>   crypto/hash-afalg.c                     |   4 +-
>   fsdev/9p-marshal.c                      |   2 +-
>   fsdev/virtfs-proxy-helper.c             |   2 +-
>   gdbstub.c                               |   2 +-
>   hw/9pfs/9p.c                            |   2 +-
>   hw/acpi/aml-build.c                     |   4 +-
>   hw/mips/fuloong2e.c                     |   2 +-
>   hw/mips/malta.c                         |   2 +-
>   hw/net/rtl8139.c                        |   2 +-
>   hw/virtio/virtio.c                      |   2 +-
>   io/channel-socket.c                     |   6 +-
>   io/channel-websock.c                    |   2 +-
>   monitor/hmp.c                           |   4 +-
>   nbd/server.c                            |  10 +-
>   net/socket.c                            |  24 ++--
>   qemu-img.c                              |   4 +-
>   qemu-io.c                               |   2 +-
>   qobject/json-parser.c                   |   2 +-
>   softmmu/qtest.c                         |   4 +-
>   tests/qtest/e1000e-test.c               |   4 +-
>   tests/qtest/libqtest.c                  |   6 +-
>   tests/qtest/npcm7xx_emc-test.c          |   4 +-
>   tests/qtest/test-filter-mirror.c        |   4 +-
>   tests/qtest/test-filter-redirector.c    |   8 +-
>   tests/qtest/virtio-net-test.c           |  10 +-
>   tests/unit/socket-helpers.c             |   2 +-
>   tests/unit/test-qobject-input-visitor.c |   4 +-
>   util/osdep.c                            |   4 +-
>   util/qemu-openpty.c                     | 139 ------------------------
>   util/qemu-sockets.c                     |  10 +-
>   chardev/meson.build                     |   4 +-
>   qga/meson.build                         |   2 +-
>   qga/vss-win32/install.cpp               |   4 +
>   qga/vss-win32/provider.cpp              |   4 +
>   scripts/checkpatch.pl                   |   2 +-
>   tests/qtest/libqos/meson.build          |   1 -
>   util/meson.build                        |   1 -
>   83 files changed, 300 insertions(+), 370 deletions(-)
>   delete mode 100644 util/qemu-openpty.c
>