[PATCH 2/2] scripts/qemu-gdb/timers.py: the 'last' attribute is no more

David Edmondson posted 2 patches 3 years, 11 months ago
[PATCH 2/2] scripts/qemu-gdb/timers.py: the 'last' attribute is no more
Posted by David Edmondson 3 years, 11 months ago
The 'last' member of QEMUClock was removed some time ago, but the
python gdb helper did not notice.

Fixes: 3c2d4c8aa6 ("timer: last, remove last bits of last")
Signed-off-by: David Edmondson <david.edmondson@oracle.com>
---
 scripts/qemugdb/timers.py | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/scripts/qemugdb/timers.py b/scripts/qemugdb/timers.py
index 46537b27cf..0538677288 100644
--- a/scripts/qemugdb/timers.py
+++ b/scripts/qemugdb/timers.py
@@ -37,10 +37,9 @@ def dump_timers(self, timer):
 
     def process_timerlist(self, tlist, ttype):
         gdb.write("Processing %s timers\n" % (ttype))
-        gdb.write("  clock %s is enabled:%s, last:%s\n" % (
+        gdb.write("  clock %s is enabled:%s\n" % (
             tlist['clock']['type'],
-            tlist['clock']['enabled'],
-            tlist['clock']['last']))
+            tlist['clock']['enabled']))
         if int(tlist['active_timers']) > 0:
             self.dump_timers(tlist['active_timers'])
 
-- 
2.34.1


Re: [PATCH 2/2] scripts/qemu-gdb/timers.py: the 'last' attribute is no more
Posted by Philippe Mathieu-Daudé 3 years, 11 months ago
On 21/2/22 17:49, David Edmondson wrote:
> The 'last' member of QEMUClock was removed some time ago, but the
> python gdb helper did not notice.
> 
> Fixes: 3c2d4c8aa6 ("timer: last, remove last bits of last")
> Signed-off-by: David Edmondson <david.edmondson@oracle.com>
> ---
>   scripts/qemugdb/timers.py | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)

Ouch, 2+ years.

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>