MAINTAINERS: Add Akihiko Odaki to macOS-relateds

[PATCH] MAINTAINERS: Add Akihiko Odaki to macOS-relateds

Posted by Akihiko Odaki 3 years, 1 month ago

Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 2fd74c46426..5aefb5b431a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2333,6 +2333,7 @@ F: audio/alsaaudio.c
 Core Audio framework backend
 M: Gerd Hoffmann <kraxel@redhat.com>
 R: Christian Schoenebeck <qemu_oss@crudebyte.com>
+R: Akihiko Odaki <akihiko.odaki@gmail.com>
 S: Odd Fixes
 F: audio/coreaudio.c
 
@@ -2585,6 +2586,7 @@ F: util/drm.c
 
 Cocoa graphics
 M: Peter Maydell <peter.maydell@linaro.org>
+R: Akihiko Odaki <akihiko.odaki@gmail.com>
 S: Odd Fixes
 F: ui/cocoa.m
 
-- 
2.32.0 (Apple Git-132)

Re: [PATCH] MAINTAINERS: Add Akihiko Odaki to macOS-relateds

Posted by Christian Schoenebeck 3 years, 1 month ago

On Sonntag, 13. Februar 2022 03:12:15 CET Akihiko Odaki wrote:
> Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
> ---
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2fd74c46426..5aefb5b431a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2333,6 +2333,7 @@ F: audio/alsaaudio.c
>  Core Audio framework backend
>  M: Gerd Hoffmann <kraxel@redhat.com>
>  R: Christian Schoenebeck <qemu_oss@crudebyte.com>
> +R: Akihiko Odaki <akihiko.odaki@gmail.com>
>  S: Odd Fixes
>  F: audio/coreaudio.c
> 
> @@ -2585,6 +2586,7 @@ F: util/drm.c
> 
>  Cocoa graphics
>  M: Peter Maydell <peter.maydell@linaro.org>
> +R: Akihiko Odaki <akihiko.odaki@gmail.com>
>  S: Odd Fixes
>  F: ui/cocoa.m

Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>

Re: [PATCH] MAINTAINERS: Add Akihiko Odaki to macOS-relateds

Posted by Philippe Mathieu-Daudé via 3 years, 1 month ago

On 13/2/22 03:12, Akihiko Odaki wrote:
> Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
> ---
>   MAINTAINERS | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2fd74c46426..5aefb5b431a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2333,6 +2333,7 @@ F: audio/alsaaudio.c
>   Core Audio framework backend
>   M: Gerd Hoffmann <kraxel@redhat.com>
>   R: Christian Schoenebeck <qemu_oss@crudebyte.com>
> +R: Akihiko Odaki <akihiko.odaki@gmail.com>
>   S: Odd Fixes
>   F: audio/coreaudio.c
>   
> @@ -2585,6 +2586,7 @@ F: util/drm.c
>   
>   Cocoa graphics
>   M: Peter Maydell <peter.maydell@linaro.org>
> +R: Akihiko Odaki <akihiko.odaki@gmail.com>
>   S: Odd Fixes
>   F: ui/cocoa.m
>   

Thanks!

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Re: [PATCH] MAINTAINERS: Add Akihiko Odaki to macOS-relateds

Posted by Peter Maydell 3 years, 1 month ago

On Sun, 13 Feb 2022 at 02:12, Akihiko Odaki <akihiko.odaki@gmail.com> wrote:
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
> ---
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)

Thanks for volunteering to review cocoa-related patches!
Would you mind having a look at these couple of patches
from early January?
https://patchew.org/QEMU/20220102174153.70043-1-carwynellis@gmail.com/
("ui/cocoa: Add option to disable left command and hide cursor on click")
https://patchew.org/QEMU/20220103114515.24020-1-carwynellis@gmail.com/
("Show/hide the menu bar in fullscreen on mouse")

They need review both from the pov of "is this a sensible UI change
for the cococa frontend" and also the usual code-level review.
They've been on my "I should look at this" list for weeks now
but I don't really feel very confident to review on either front...

I'll take this patch via target-arm.next, since I'm making a pullreq
anyway.

thanks
-- PMM