malta: Fix PCI IRQ levels to be preserved during migration

[PATCH v2 0/5] malta: Fix PCI IRQ levels to be preserved during migration

Bernhard Beschow posted 5 patches 3 years, 11 months ago

Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220212113519.69527-1-shentey@gmail.com

Maintainers: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, "Hervé Poussineau" <hpoussin@reactos.org>, Aurelien Jarno <aurelien@aurel32.net>

hw/isa/piix4.c                | 61 +++++++++++++++++++++++++++++++---
hw/mips/gt64xxx_pci.c         | 62 +++--------------------------------
hw/mips/malta.c               |  6 +---
hw/pci-host/sh_pci.c          |  6 ++--
hw/pci-host/versatile.c       |  6 ++--
hw/ppc/ppc440_pcix.c          |  6 ++--
hw/ppc/ppc4xx_pci.c           |  6 ++--
include/hw/mips/mips.h        |  2 +-
include/hw/southbridge/piix.h |  2 --
9 files changed, 75 insertions(+), 82 deletions(-)

Expand all Fold all

[PATCH v2 0/5] malta: Fix PCI IRQ levels to be preserved during migration

Posted by Bernhard Beschow 3 years, 11 months ago

The intention behind v1 [1] was just to remove some global variables from
gt64xxx and piix4. During review it was noticed that the Malta board misses to
preserve the PCI IRQ levels during migration. Since the patch series offered an
easy fix v2 was born.

Furthermore, i8259[] was moved to PIIX4State in patch 1. This attribute seems
quite redundant to *isa to me. I therefore attempt to resolve it.

Tested with [2]:

  qemu-system-mips64 -M malta -kernel vmlinux-3.2.0-4-5kc-malta -hda \
  debian_wheezy_mips_standard.qcow2 -append "root=/dev/sda1 console=tty0"

It was possible to log in as root and `poweroff` the machine.
  
[1] https://lists.nongnu.org/archive/html/qemu-devel/2022-01/msg02786.html
[2] https://people.debian.org/~aurel32/qemu/mips/
  
v2:
  isa/piix4: Fix PCI IRQ levels to be preserved in VMState
  isa/piix4: Resolve redundant i8259[] attribute

Bernhard Beschow (5):
  malta: Move PCI interrupt handling from gt64xxx to piix4
  pci: Always pass own DeviceState to pci_map_irq_fn's
  isa/piix4: Resolve global variables
  isa/piix4: Fix PCI IRQ levels to be preserved in VMState
  isa/piix4: Resolve redundant i8259[] attribute

 hw/isa/piix4.c                | 61 +++++++++++++++++++++++++++++++---
 hw/mips/gt64xxx_pci.c         | 62 +++--------------------------------
 hw/mips/malta.c               |  6 +---
 hw/pci-host/sh_pci.c          |  6 ++--
 hw/pci-host/versatile.c       |  6 ++--
 hw/ppc/ppc440_pcix.c          |  6 ++--
 hw/ppc/ppc4xx_pci.c           |  6 ++--
 include/hw/mips/mips.h        |  2 +-
 include/hw/southbridge/piix.h |  2 --
 9 files changed, 75 insertions(+), 82 deletions(-)

-- 
2.35.1