The following changes since commit 6dffbe36af79e26a4d23f94a9a1c1201de99c261:

Merge tag 'migration-20230215-pull-request' of https://gitlab.com/juan.quintela/qemu into staging (2023-02-16 13:09:51 +0000)

https://repo.or.cz/qemu/kevin.git tags/for-upstream

for you to fetch changes up to a4d5224c2cb650b5a401d626d3f36e42e6987aa7:

hbitmap: fix hbitmap_status() return value for first dirty bit case (2023-02-17 14:34:24 +0100)

- configure: Enable -Wthread-safety if present

- no_co_wrapper to fix bdrv_open*() calls from coroutine context

- curl fixes, including enablement of newer libcurl versions

- MAINTAINERS: drop Vladimir from parallels block driver

- hbitmap: fix hbitmap_status() return value for first dirty bit case

- file-posix: Fix assertion failure in write_zeroes after moving

bdrv_getlength() to co_wrapper

Andrey Zhadchenko (1):

hbitmap: fix hbitmap_status() return value for first dirty bit case

Anton Johansson (1):

block: Handle curl 7.55.0, 7.85.0 version changes

Emanuele Giuseppe Esposito (3):

util/qemu-thread-posix: use TSA_NO_TSA to suppress clang TSA warnings in FreeBSD

bsd-user/mmap: use TSA_NO_TSA to suppress clang TSA warnings in FreeBSD

block/file-posix: don't use functions calling AIO_WAIT_WHILE in worker threads

From: Emanuele Giuseppe Esposito <eesposit@redhat.com>

FreeBSD implements pthread headers using TSA (thread safety analysis)

annotations, therefore when an application is compiled with

-Wthread-safety there are some locking/annotation requirements that the

user of the pthread API has to follow.

This will also be the case in QEMU, since util/qemu-thread-posix.c uses

the pthread API. Therefore when building it with -Wthread-safety, the

compiler will throw warnings because the functions are not properly

annotated. We need TSA to be enabled because it ensures that the

critical sections of an annotated variable are properly locked.

In order to make the compiler happy and avoid adding all the necessary

macros to all callers (lock functions should use TSA_ACQUIRE, while

unlock TSA_RELEASE, and this applies to all users of pthread_mutex_lock

and pthread_mutex_unlock), simply use TSA_NO_TSA to supppress such

warnings.

Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>

Message-Id: <20230117135203.3049709-2-eesposit@redhat.com>

Reviewed-by: Kevin Wolf <kwolf@redhat.com>

include/qemu/thread.h | 14 +++++++++-----

util/qemu-thread-posix.c | 2 +-

2 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/include/qemu/thread.h b/include/qemu/thread.h

--- a/include/qemu/thread.h

+++ b/include/qemu/thread.h

@@ -XXX,XX +XXX,XX @@

#include "qemu/processor.h"

#include "qemu/atomic.h"

+#include "qemu/clang-tsa.h"

typedef struct QemuCond QemuCond;

typedef struct QemuSemaphore QemuSemaphore;

@@ -XXX,XX +XXX,XX @@ typedef struct QemuThread QemuThread;

void qemu_mutex_init(QemuMutex *mutex);

void qemu_mutex_destroy(QemuMutex *mutex);

-int qemu_mutex_trylock_impl(QemuMutex *mutex, const char *file, const int line);

-void qemu_mutex_lock_impl(QemuMutex *mutex, const char *file, const int line);

-void qemu_mutex_unlock_impl(QemuMutex *mutex, const char *file, const int line);

+int TSA_NO_TSA qemu_mutex_trylock_impl(QemuMutex *mutex, const char *file,

+ const int line);

+void TSA_NO_TSA qemu_mutex_lock_impl(QemuMutex *mutex, const char *file,

+ const int line);

+void TSA_NO_TSA qemu_mutex_unlock_impl(QemuMutex *mutex, const char *file,

+ const int line);

void qemu_rec_mutex_init(QemuRecMutex *mutex);

void qemu_rec_mutex_destroy(QemuRecMutex *mutex);

@@ -XXX,XX +XXX,XX @@ void qemu_cond_destroy(QemuCond *cond);

*/

void qemu_cond_signal(QemuCond *cond);

void qemu_cond_broadcast(QemuCond *cond);

-void qemu_cond_wait_impl(QemuCond *cond, QemuMutex *mutex,

- const char *file, const int line);

+void TSA_NO_TSA qemu_cond_wait_impl(QemuCond *cond, QemuMutex *mutex,

+ const char *file, const int line);

bool qemu_cond_timedwait_impl(QemuCond *cond, QemuMutex *mutex, int ms,

const char *file, const int line);

diff --git a/util/qemu-thread-posix.c b/util/qemu-thread-posix.c

index XXXXXXX..XXXXXXX 100644

--- a/util/qemu-thread-posix.c

+++ b/util/qemu-thread-posix.c

@@ -XXX,XX +XXX,XX @@ void qemu_cond_wait_impl(QemuCond *cond, QemuMutex *mutex, const char *file, con

error_exit(err, __func__);

}

-static bool

+static bool TSA_NO_TSA

qemu_cond_timedwait_ts(QemuCond *cond, QemuMutex *mutex, struct timespec *ts,

const char *file, const int line)

2.39.2