[PATCH v4 0/3] qapi/ui: change vnc addresses

Vladimir Sementsov-Ogievskiy posted 3 patches 3 years, 12 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220210141457.539582-1-vsementsov@virtuozzo.com
Maintainers: Gerd Hoffmann <kraxel@redhat.com>, Wainer dos Santos Moschetta <wainersm@redhat.com>, Cleber Rosa <crosa@redhat.com>, "Philippe Mathieu-Daudé" <f4bug@amsat.org>, Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>, Beraldo Leal <bleal@redhat.com>
There is a newer version of this series
docs/about/removed-features.rst |   3 +-
qapi/ui.json                    |  65 ++++++++++++++
include/ui/console.h            |   1 +
monitor/qmp-cmds.c              |  15 ++++
ui/vnc.c                        | 152 ++++++++++++++++----------------
tests/avocado/vnc.py            |  63 +++++++++++++
6 files changed, 220 insertions(+), 79 deletions(-)
[PATCH v4 0/3] qapi/ui: change vnc addresses
Posted by Vladimir Sementsov-Ogievskiy 3 years, 12 months ago
Hi all!

v4:
01: add Daniel's r-b
02: refactor to add new display-update command instead
03: rebase on 02
    search for free ports, using same range as in tests/qemu-iotests/147
    check connection on ports

Recently our customer requested a possibility to change VNC listen port
dynamically.

Happily in Rhel7-based Qemu we already have this possibility: through
deprecated "change" qmp command.

But since 6.0 "change" qmp command was removed, with recommendation to
use change-vnc-password or blockdev-change-medium instead. Of course,
neither of them allow change VNC listen port.

So, let's reimplement the possibility.

Vladimir Sementsov-Ogievskiy (3):
  ui/vnc: refactor arrays of addresses to SocketAddressList
  qapi/ui: display-update: add possibility to change listen address
  avocado/vnc: add test_change_listen

 docs/about/removed-features.rst |   3 +-
 qapi/ui.json                    |  65 ++++++++++++++
 include/ui/console.h            |   1 +
 monitor/qmp-cmds.c              |  15 ++++
 ui/vnc.c                        | 152 ++++++++++++++++----------------
 tests/avocado/vnc.py            |  63 +++++++++++++
 6 files changed, 220 insertions(+), 79 deletions(-)

-- 
2.31.1


Re: [PATCH v4 0/3] qapi/ui: change vnc addresses
Posted by Markus Armbruster 3 years, 12 months ago
I figure there's no real need for more review from me.  But if you'd
like me to review, let me know.

Gerd, should this go through your tree?