exec: Split some user-mode specific declarations from 'exec/exec-all.h'

[PATCH 2/9] coverity-scan: Cover common-user/

Posted by Philippe Mathieu-Daudé via 4 years ago

common-user/ has been added in commit bbf15aaf7c
("common-user: Move safe-syscall.* from linux-user").

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 scripts/coverity-scan/COMPONENTS.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/coverity-scan/COMPONENTS.md b/scripts/coverity-scan/COMPONENTS.md
index 183f26a32c..cea6695ecd 100644
--- a/scripts/coverity-scan/COMPONENTS.md
+++ b/scripts/coverity-scan/COMPONENTS.md
@@ -127,7 +127,7 @@ usb
   ~ (/qemu)?(/hw/usb/.*|/include/hw/usb/.*)
 
 user
-  ~ (/qemu)?(/linux-user/.*|/bsd-user/.*|/user-exec\.c|/thunk\.c|/include/exec/user/.*)
+  ~ (/qemu)?(/common-user/.*|/linux-user/.*|/bsd-user/.*|/user-exec\.c|/thunk\.c|/include/exec/user/.*)
 
 util
   ~ (/qemu)?(/util/.*|/include/qemu/.*)
-- 
2.34.1

Re: [PATCH 2/9] coverity-scan: Cover common-user/

Posted by Richard Henderson 3 years, 12 months ago

On 2/10/22 10:00, Philippe Mathieu-Daudé wrote:
> common-user/ has been added in commit bbf15aaf7c
> ("common-user: Move safe-syscall.* from linux-user").
> 
> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
> ---
>   scripts/coverity-scan/COMPONENTS.md | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

Re: [PATCH 2/9] coverity-scan: Cover common-user/

Posted by Peter Maydell 3 years, 12 months ago

On Wed, 9 Feb 2022 at 23:12, Philippe Mathieu-Daudé via
<qemu-devel@nongnu.org> wrote:
>
> common-user/ has been added in commit bbf15aaf7c
> ("common-user: Move safe-syscall.* from linux-user").
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  scripts/coverity-scan/COMPONENTS.md | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/coverity-scan/COMPONENTS.md b/scripts/coverity-scan/COMPONENTS.md
> index 183f26a32c..cea6695ecd 100644
> --- a/scripts/coverity-scan/COMPONENTS.md
> +++ b/scripts/coverity-scan/COMPONENTS.md
> @@ -127,7 +127,7 @@ usb
>    ~ (/qemu)?(/hw/usb/.*|/include/hw/usb/.*)
>
>  user
> -  ~ (/qemu)?(/linux-user/.*|/bsd-user/.*|/user-exec\.c|/thunk\.c|/include/exec/user/.*)
> +  ~ (/qemu)?(/common-user/.*|/linux-user/.*|/bsd-user/.*|/user-exec\.c|/thunk\.c|/include/exec/user/.*)
>
>  util
>    ~ (/qemu)?(/util/.*|/include/qemu/.*)

Note that there is no automatic process by which changes to this
file get applied to the coverity scan config, so hiding changes
to it inside a larger patchset increases the chance they get
overlooked (by Paolo, who gets to do the manual config update)...

-- PMM

Re: [PATCH 2/9] coverity-scan: Cover common-user/

Posted by Philippe Mathieu-Daudé via 3 years, 12 months ago

On 11/2/22 12:56, Peter Maydell wrote:
> On Wed, 9 Feb 2022 at 23:12, Philippe Mathieu-Daudé via
> <qemu-devel@nongnu.org> wrote:
>>
>> common-user/ has been added in commit bbf15aaf7c
>> ("common-user: Move safe-syscall.* from linux-user").
>>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>>   scripts/coverity-scan/COMPONENTS.md | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/coverity-scan/COMPONENTS.md b/scripts/coverity-scan/COMPONENTS.md
>> index 183f26a32c..cea6695ecd 100644
>> --- a/scripts/coverity-scan/COMPONENTS.md
>> +++ b/scripts/coverity-scan/COMPONENTS.md
>> @@ -127,7 +127,7 @@ usb
>>     ~ (/qemu)?(/hw/usb/.*|/include/hw/usb/.*)
>>
>>   user
>> -  ~ (/qemu)?(/linux-user/.*|/bsd-user/.*|/user-exec\.c|/thunk\.c|/include/exec/user/.*)
>> +  ~ (/qemu)?(/common-user/.*|/linux-user/.*|/bsd-user/.*|/user-exec\.c|/thunk\.c|/include/exec/user/.*)
>>
>>   util
>>     ~ (/qemu)?(/util/.*|/include/qemu/.*)
> 
> Note that there is no automatic process by which changes to this
> file get applied to the coverity scan config, so hiding changes
> to it inside a larger patchset increases the chance they get
> overlooked (by Paolo, who gets to do the manual config update)...

Oh OK, I thought this was consumed by a script.

Re: [PATCH 2/9] coverity-scan: Cover common-user/

Posted by Peter Maydell 3 years, 12 months ago

On Fri, 11 Feb 2022 at 12:38, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> On 11/2/22 12:56, Peter Maydell wrote:
> > On Wed, 9 Feb 2022 at 23:12, Philippe Mathieu-Daudé via
> > <qemu-devel@nongnu.org> wrote:
> >>
> >> common-user/ has been added in commit bbf15aaf7c
> >> ("common-user: Move safe-syscall.* from linux-user").
> >>
> >> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> >> ---
> >>   scripts/coverity-scan/COMPONENTS.md | 2 +-
> >>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/scripts/coverity-scan/COMPONENTS.md b/scripts/coverity-scan/COMPONENTS.md
> >> index 183f26a32c..cea6695ecd 100644
> >> --- a/scripts/coverity-scan/COMPONENTS.md
> >> +++ b/scripts/coverity-scan/COMPONENTS.md
> >> @@ -127,7 +127,7 @@ usb
> >>     ~ (/qemu)?(/hw/usb/.*|/include/hw/usb/.*)
> >>
> >>   user
> >> -  ~ (/qemu)?(/linux-user/.*|/bsd-user/.*|/user-exec\.c|/thunk\.c|/include/exec/user/.*)
> >> +  ~ (/qemu)?(/common-user/.*|/linux-user/.*|/bsd-user/.*|/user-exec\.c|/thunk\.c|/include/exec/user/.*)
> >>
> >>   util
> >>     ~ (/qemu)?(/util/.*|/include/qemu/.*)
> >
> > Note that there is no automatic process by which changes to this
> > file get applied to the coverity scan config, so hiding changes
> > to it inside a larger patchset increases the chance they get
> > overlooked (by Paolo, who gets to do the manual config update)...
>
> Oh OK, I thought this was consumed by a script.

Unfortunately Coverity don't provide an API for configuring
components, so it all has to be done via their webpage GUI :-(

-- PMM