[v3] TPM-CRB: Remove spurious error report when used with VFIO

[PATCH v3 0/2] TPM-CRB: Remove spurious error report when used with VFIO

Eric Auger posted 2 patches 3 years, 12 months ago

Diff against v1 v2 v4
Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220208133117.111833-1-eric.auger@redhat.com

There is a newer version of this series

hw/tpm/tpm_crb.c     | 23 +++++++++++++++++++++--
hw/vfio/common.c     | 15 ++++++++++++++-
hw/vfio/trace-events |  1 +
3 files changed, 36 insertions(+), 3 deletions(-)

Expand all Fold all

[PATCH v3 0/2] TPM-CRB: Remove spurious error report when used with VFIO

Posted by Eric Auger 3 years, 12 months ago

This series aims at removing a spurious error message we get when
launching a guest with a TPM-CRB device and VFIO-PCI devices.

The CRB command buffer currently is a RAM MemoryRegion and given
its base address alignment, it causes an error report on
vfio_listener_region_add(). This series proposes to use a ram-device
region instead which helps in better assessing the dma map error
failure on VFIO side.

Best Regards

Eric

This series can be found at:
https://github.com/eauger/qemu/tree/tpm-crb-ram-device-v3

History:
v2 -> v3:
- Use PRIxPTR
- call vmstate_unregister_ram

v1 -> v2:
- added tpm_crb_unrealize (dared to keep Stefan's T-b though)

Eric Auger (2):
  tpm: CRB: Use ram_device for "tpm-crb-cmd" region
  hw/vfio/common: Silence ram device offset alignment error traces

 hw/tpm/tpm_crb.c     | 23 +++++++++++++++++++++--
 hw/vfio/common.c     | 15 ++++++++++++++-
 hw/vfio/trace-events |  1 +
 3 files changed, 36 insertions(+), 3 deletions(-)

-- 
2.26.3

Re: [PATCH v3 0/2] TPM-CRB: Remove spurious error report when used with VFIO

Posted by Eric Auger 3 years, 12 months ago

Hi,

On 2/8/22 2:31 PM, Eric Auger wrote:
> This series aims at removing a spurious error message we get when
> launching a guest with a TPM-CRB device and VFIO-PCI devices.
>
> The CRB command buffer currently is a RAM MemoryRegion and given
> its base address alignment, it causes an error report on
> vfio_listener_region_add(). This series proposes to use a ram-device
> region instead which helps in better assessing the dma map error
> failure on VFIO side.
>
> Best Regards
>
> Eric
>
> This series can be found at:
> https://github.com/eauger/qemu/tree/tpm-crb-ram-device-v3
oups sorry. As philippe sent the v3, I forgot to double increment :-/ I
will resend a v4. Sorry for the noise

Thanks

Eric
>
> History:
> v2 -> v3:
> - Use PRIxPTR
> - call vmstate_unregister_ram
>
> v1 -> v2:
> - added tpm_crb_unrealize (dared to keep Stefan's T-b though)
>
> Eric Auger (2):
>   tpm: CRB: Use ram_device for "tpm-crb-cmd" region
>   hw/vfio/common: Silence ram device offset alignment error traces
>
>  hw/tpm/tpm_crb.c     | 23 +++++++++++++++++++++--
>  hw/vfio/common.c     | 15 ++++++++++++++-
>  hw/vfio/trace-events |  1 +
>  3 files changed, 36 insertions(+), 3 deletions(-)
>