erst: drop cast to long long

[PATCH] erst: drop cast to long long

Michael S. Tsirkin posted 1 patch 4 years ago

Download mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220206093547.1282513-1-mst@redhat.com

Maintainers: Laurent Vivier <lvivier@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Thomas Huth <thuth@redhat.com>

tests/qtest/erst-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] erst: drop cast to long long

Posted by Michael S. Tsirkin 4 years ago

The way to print uint64_t is with PRIx64, not with
a cast to long long.

Cc: Eric DeVolder <eric.devolder@oracle.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 tests/qtest/erst-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/qtest/erst-test.c b/tests/qtest/erst-test.c
index c6a0ae4013..f94cd8dd8e 100644
--- a/tests/qtest/erst-test.c
+++ b/tests/qtest/erst-test.c
@@ -75,7 +75,7 @@ static inline uint64_t in_reg64(ERSTState *s, unsigned reg)
     uint64_t res;
 
     res = qpci_io_readq(s->dev, s->reg_bar, reg);
-    g_test_message("*%s -> %016llx", name, (unsigned long long)res);
+    g_test_message("*%s -> %016" PRIx64, name, res);
 
     return res;
 }
-- 
MST

Re: [PATCH] erst: drop cast to long long

Posted by Philippe Mathieu-Daudé via 4 years ago

On 6/2/22 10:35, Michael S. Tsirkin wrote:
> The way to print uint64_t is with PRIx64, not with
> a cast to long long.
> 
> Cc: Eric DeVolder <eric.devolder@oracle.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>   tests/qtest/erst-test.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Re: [PATCH] erst: drop cast to long long

Posted by Thomas Huth 4 years ago

On 06/02/2022 10.35, Michael S. Tsirkin wrote:
> The way to print uint64_t is with PRIx64, not with
> a cast to long long.
> 
> Cc: Eric DeVolder <eric.devolder@oracle.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>   tests/qtest/erst-test.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/qtest/erst-test.c b/tests/qtest/erst-test.c
> index c6a0ae4013..f94cd8dd8e 100644
> --- a/tests/qtest/erst-test.c
> +++ b/tests/qtest/erst-test.c
> @@ -75,7 +75,7 @@ static inline uint64_t in_reg64(ERSTState *s, unsigned reg)
>       uint64_t res;
>   
>       res = qpci_io_readq(s->dev, s->reg_bar, reg);
> -    g_test_message("*%s -> %016llx", name, (unsigned long long)res);
> +    g_test_message("*%s -> %016" PRIx64, name, res);
>   
>       return res;
>   }

Reviewed-by: Thomas Huth <thuth@redhat.com>