[PATCH v2 0/2] Python: setuptools v60+ workaround

John Snow posted 2 patches 2 years, 3 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220204221804.2047468-1-jsnow@redhat.com
Maintainers: John Snow <jsnow@redhat.com>, Cleber Rosa <crosa@redhat.com>, Eduardo Habkost <eduardo@habkost.net>
python/Makefile                | 2 --
python/setup.cfg               | 1 -
python/tests/iotests-pylint.sh | 3 ++-
python/tests/pylint.sh         | 3 ++-
4 files changed, 4 insertions(+), 5 deletions(-)
[PATCH v2 0/2] Python: setuptools v60+ workaround
Posted by John Snow 2 years, 3 months ago
Long story short: Python 3.7/3.8 on Fedora with setuptools v60.0.0+
together create a bug that ultimately causes pylint to fail. See the
first commit message for more detail.

I sent out a hotfix two weeks ago to fix this behavior on our CI, but
there's a better workaround. This adds the better workaround and reverts
the hotfix.

John Snow (2):
  Python: add setuptools v60.0 workaround
  Revert "python: pin setuptools below v60.0.0"

 python/Makefile                | 2 --
 python/setup.cfg               | 1 -
 python/tests/iotests-pylint.sh | 3 ++-
 python/tests/pylint.sh         | 3 ++-
 4 files changed, 4 insertions(+), 5 deletions(-)

-- 
2.34.1



Re: [PATCH v2 0/2] Python: setuptools v60+ workaround
Posted by John Snow 2 years, 2 months ago
On Fri, Feb 4, 2022 at 5:18 PM John Snow <jsnow@redhat.com> wrote:
>
> Long story short: Python 3.7/3.8 on Fedora with setuptools v60.0.0+
> together create a bug that ultimately causes pylint to fail. See the
> first commit message for more detail.
>
> I sent out a hotfix two weeks ago to fix this behavior on our CI, but
> there's a better workaround. This adds the better workaround and reverts
> the hotfix.
>
> John Snow (2):
>   Python: add setuptools v60.0 workaround
>   Revert "python: pin setuptools below v60.0.0"
>
>  python/Makefile                | 2 --
>  python/setup.cfg               | 1 -
>  python/tests/iotests-pylint.sh | 3 ++-
>  python/tests/pylint.sh         | 3 ++-
>  4 files changed, 4 insertions(+), 5 deletions(-)
>
> --
> 2.34.1
>

Assuming no news is good news. I'm staging this to my Python branch,
and intend to send a PR after I get an ACK on '[PATCH 0/4] iotests:
finalize switch to async QMP' -- so there's time to veto this if you
have concerns.

--js