target/ppc: Fix radix logging

[PATCH] target/ppc: Fix radix logging

Posted by Cédric Le Goater 4 years ago

ppc_radix64_partition_scoped_xlate() logs the host page protection
bits variable but it is uninitialized since it is set later in
ppc_radix64_check_prot(). Remove the

Fixes: Coverity CID 1468942
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 target/ppc/mmu-radix64.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/target/ppc/mmu-radix64.c b/target/ppc/mmu-radix64.c
index 040c055bff65..d4e16bd7db50 100644
--- a/target/ppc/mmu-radix64.c
+++ b/target/ppc/mmu-radix64.c
@@ -327,13 +327,9 @@ static int ppc_radix64_partition_scoped_xlate(PowerPCCPU *cpu,
     uint64_t pte;
 
     qemu_log_mask(CPU_LOG_MMU, "%s for %s @0x%"VADDR_PRIx
-                  " mmu_idx %u (prot %c%c%c) 0x%"HWADDR_PRIx"\n",
+                  " mmu_idx %u 0x%"HWADDR_PRIx"\n",
                   __func__, access_str(access_type),
-                  eaddr, mmu_idx,
-                  *h_prot & PAGE_READ ? 'r' : '-',
-                  *h_prot & PAGE_WRITE ? 'w' : '-',
-                  *h_prot & PAGE_EXEC ? 'x' : '-',
-                  g_raddr);
+                  eaddr, mmu_idx, g_raddr);
 
     *h_page_size = PRTBE_R_GET_RTS(pate.dw0);
     /* No valid pte or access denied due to protection */
-- 
2.34.1

Re: [PATCH] target/ppc: Fix radix logging

Posted by Greg Kurz 4 years ago

On Thu, 3 Feb 2022 15:21:45 +0100
Cédric Le Goater <clg@kaod.org> wrote:

> ppc_radix64_partition_scoped_xlate() logs the host page protection
> bits variable but it is uninitialized since it is set later in
> ppc_radix64_check_prot(). Remove the
> 

Remove the what ?

> Fixes: Coverity CID 1468942
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---

LGTM apart from that.

Reviewed-by: Greg Kurz <groug@kaod.org>

>  target/ppc/mmu-radix64.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/target/ppc/mmu-radix64.c b/target/ppc/mmu-radix64.c
> index 040c055bff65..d4e16bd7db50 100644
> --- a/target/ppc/mmu-radix64.c
> +++ b/target/ppc/mmu-radix64.c
> @@ -327,13 +327,9 @@ static int ppc_radix64_partition_scoped_xlate(PowerPCCPU *cpu,
>      uint64_t pte;
>  
>      qemu_log_mask(CPU_LOG_MMU, "%s for %s @0x%"VADDR_PRIx
> -                  " mmu_idx %u (prot %c%c%c) 0x%"HWADDR_PRIx"\n",
> +                  " mmu_idx %u 0x%"HWADDR_PRIx"\n",
>                    __func__, access_str(access_type),
> -                  eaddr, mmu_idx,
> -                  *h_prot & PAGE_READ ? 'r' : '-',
> -                  *h_prot & PAGE_WRITE ? 'w' : '-',
> -                  *h_prot & PAGE_EXEC ? 'x' : '-',
> -                  g_raddr);
> +                  eaddr, mmu_idx, g_raddr);
>  
>      *h_page_size = PRTBE_R_GET_RTS(pate.dw0);
>      /* No valid pte or access denied due to protection */

Re: [PATCH] target/ppc: Fix radix logging

Posted by Cédric Le Goater 4 years ago

On 2/3/22 15:39, Greg Kurz wrote:
> On Thu, 3 Feb 2022 15:21:45 +0100
> Cédric Le Goater <clg@kaod.org> wrote:
> 
>> ppc_radix64_partition_scoped_xlate() logs the host page protection
>> bits variable but it is uninitialized since it is set later in
>> ppc_radix64_check_prot(). Remove the
>>
> 
> Remove the what ?

Arg ...

Changed to :

   ppc_radix64_partition_scoped_xlate() logs the host page protection
   bits variable but it is uninitialized. The value is set later on in
   ppc_radix64_check_prot(). Remove the output.


Thanks,

C.


> 
>> Fixes: Coverity CID 1468942
>> Signed-off-by: Cédric Le Goater <clg@kaod.org>
>> ---
> 
> LGTM apart from that.
> 
> Reviewed-by: Greg Kurz <groug@kaod.org>
> 
>>   target/ppc/mmu-radix64.c | 8 ++------
>>   1 file changed, 2 insertions(+), 6 deletions(-)
>>
>> diff --git a/target/ppc/mmu-radix64.c b/target/ppc/mmu-radix64.c
>> index 040c055bff65..d4e16bd7db50 100644
>> --- a/target/ppc/mmu-radix64.c
>> +++ b/target/ppc/mmu-radix64.c
>> @@ -327,13 +327,9 @@ static int ppc_radix64_partition_scoped_xlate(PowerPCCPU *cpu,
>>       uint64_t pte;
>>   
>>       qemu_log_mask(CPU_LOG_MMU, "%s for %s @0x%"VADDR_PRIx
>> -                  " mmu_idx %u (prot %c%c%c) 0x%"HWADDR_PRIx"\n",
>> +                  " mmu_idx %u 0x%"HWADDR_PRIx"\n",
>>                     __func__, access_str(access_type),
>> -                  eaddr, mmu_idx,
>> -                  *h_prot & PAGE_READ ? 'r' : '-',
>> -                  *h_prot & PAGE_WRITE ? 'w' : '-',
>> -                  *h_prot & PAGE_EXEC ? 'x' : '-',
>> -                  g_raddr);
>> +                  eaddr, mmu_idx, g_raddr);
>>   
>>       *h_page_size = PRTBE_R_GET_RTS(pate.dw0);
>>       /* No valid pte or access denied due to protection */
>

Re: [PATCH] target/ppc: Fix radix logging

Posted by Cédric Le Goater 3 years, 12 months ago

On 2/3/22 15:21, Cédric Le Goater wrote:
> ppc_radix64_partition_scoped_xlate() logs the host page protection
> bits variable but it is uninitialized since it is set later in
> ppc_radix64_check_prot(). Remove the
> 
> Fixes: Coverity CID 1468942
> Signed-off-by: Cédric Le Goater <clg@kaod.org>


Applied to ppc-7.0 (with a commit log update)

Thanks,

C.