[PATCH 01/22] bsd-user/main.c: Drop syscall flavor arg -bsd

Warner Losh posted 22 patches 4 years ago
Maintainers: Kyle Evans <kevans@freebsd.org>, Warner Losh <imp@bsdimp.com>, Brad Smith <brad@comstyle.com>
There is a newer version of this series
[PATCH 01/22] bsd-user/main.c: Drop syscall flavor arg -bsd
Posted by Warner Losh 4 years ago
We've not realistically been able to actually run any bsd program on any
other bsd program. They are too diverged to do this easily. The current
code is setup to do it, but implementing it is hard. Stop pretending
that we can do this.

Signed-off-by: Warner Losh <imp@bsdimp.com>
---
 bsd-user/main.c | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/bsd-user/main.c b/bsd-user/main.c
index f1d58e905e7..bddb830e99b 100644
--- a/bsd-user/main.c
+++ b/bsd-user/main.c
@@ -164,7 +164,6 @@ static void usage(void)
            "-E var=value      sets/modifies targets environment variable(s)\n"
            "-U var            unsets targets environment variable(s)\n"
            "-B address        set guest_base address to address\n"
-           "-bsd type         select emulated BSD type FreeBSD/NetBSD/OpenBSD (default)\n"
            "\n"
            "Debug options:\n"
            "-d item1[,...]    enable logging of specified items\n"
@@ -392,17 +391,6 @@ int main(int argc, char **argv)
             have_guest_base = true;
         } else if (!strcmp(r, "drop-ld-preload")) {
             (void) envlist_unsetenv(envlist, "LD_PRELOAD");
-        } else if (!strcmp(r, "bsd")) {
-            if (!strcasecmp(argv[optind], "freebsd")) {
-                bsd_type = target_freebsd;
-            } else if (!strcasecmp(argv[optind], "netbsd")) {
-                bsd_type = target_netbsd;
-            } else if (!strcasecmp(argv[optind], "openbsd")) {
-                bsd_type = target_openbsd;
-            } else {
-                usage();
-            }
-            optind++;
         } else if (!strcmp(r, "seed")) {
             seed_optarg = optarg;
         } else if (!strcmp(r, "singlestep")) {
-- 
2.33.1


Re: [PATCH 01/22] bsd-user/main.c: Drop syscall flavor arg -bsd
Posted by Richard Henderson 4 years ago
On 2/1/22 22:14, Warner Losh wrote:
> We've not realistically been able to actually run any bsd program on any
> other bsd program. They are too diverged to do this easily. The current
> code is setup to do it, but implementing it is hard. Stop pretending
> that we can do this.
> 
> Signed-off-by: Warner Losh<imp@bsdimp.com>
> ---
>   bsd-user/main.c | 12 ------------
>   1 file changed, 12 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~