[PATCH 00/11] target/ppc: powerpc_excp improvements [BookE] (6/n)

Fabiano Rosas posted 11 patches 2 years, 3 months ago
Failed in applying to current master (apply log)
target/ppc/excp_helper.c | 228 +++++++++++++++++++++++++++++++++++++++
1 file changed, 228 insertions(+)
[PATCH 00/11] target/ppc: powerpc_excp improvements [BookE] (6/n)
Posted by Fabiano Rosas 2 years, 3 months ago
This series handles the BookE exception code.

Tested the following machines/CPUs:

== bamboo ==
440ep, 460ex, 440-xilinx-w-dfpu

== sam460ex ==
440ep, 460ex, 440-xilinx-w-dfpu

== mpc8544ds ==
e500v1, e500v2

== ppce500 ==
e500mc, e5500, e6500

About the remaining CPUs:

- The 440x4 have been partially removed in the past. I sent a separate
  patch removing what's left of it.

- The 440x5 (440-xilinx) boots with the bamboo machine but it
  segfaults in userspace (also in master).

- The e200 is broken in master due to an assert in _spr_register (the
  DSRR0/1 registers are being registered twice). After fixing that
  QEMU crashes due to lack of IRQ controller (there's a TODO in the
  init_proc_e200).

Fabiano Rosas (11):
  target/ppc: Introduce powerpc_excp_booke
  target/ppc: Simplify powerpc_excp_booke
  target/ppc: booke: Critical exception cleanup
  target/ppc: booke: Machine Check cleanups
  target/ppc: booke: Data Storage exception cleanup
  target/ppc: booke: Instruction storage exception cleanup
  target/ppc: booke: External interrupt cleanup
  target/ppc: booke: Alignment interrupt cleanup
  target/ppc: booke: System Call exception cleanup
  target/ppc: booke: Watchdog Timer interrupt
  target/ppc: booke: System Reset exception cleanup

 target/ppc/excp_helper.c | 228 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 228 insertions(+)

-- 
2.34.1


Re: [PATCH 00/11] target/ppc: powerpc_excp improvements [BookE] (6/n)
Posted by Cédric Le Goater 2 years, 2 months ago
On 1/28/22 23:40, Fabiano Rosas wrote:
> This series handles the BookE exception code.
> 
> Tested the following machines/CPUs:
> 
> == bamboo ==
> 440ep, 460ex, 440-xilinx-w-dfpu
> 
> == sam460ex ==
> 440ep, 460ex, 440-xilinx-w-dfpu
> 
> == mpc8544ds ==
> e500v1, e500v2
> 
> == ppce500 ==
> e500mc, e5500, e6500
> 
> About the remaining CPUs:
> 
> - The 440x4 have been partially removed in the past. I sent a separate
>    patch removing what's left of it.
> 
> - The 440x5 (440-xilinx) boots with the bamboo machine but it
>    segfaults in userspace (also in master).
> 
> - The e200 is broken in master due to an assert in _spr_register (the
>    DSRR0/1 registers are being registered twice). After fixing that
>    QEMU crashes due to lack of IRQ controller (there's a TODO in the
>    init_proc_e200).
> 
> Fabiano Rosas (11):
>    target/ppc: Introduce powerpc_excp_booke
>    target/ppc: Simplify powerpc_excp_booke
>    target/ppc: booke: Critical exception cleanup
>    target/ppc: booke: Machine Check cleanups
>    target/ppc: booke: Data Storage exception cleanup
>    target/ppc: booke: Instruction storage exception cleanup
>    target/ppc: booke: External interrupt cleanup
>    target/ppc: booke: Alignment interrupt cleanup
>    target/ppc: booke: System Call exception cleanup
>    target/ppc: booke: Watchdog Timer interrupt
>    target/ppc: booke: System Reset exception cleanup
> 
>   target/ppc/excp_helper.c | 228 +++++++++++++++++++++++++++++++++++++++
>   1 file changed, 228 insertions(+)
> 
Applied to ppc-7.0.

Thanks,

C.



Re: [PATCH 00/11] target/ppc: powerpc_excp improvements [BookE] (6/n)
Posted by BALATON Zoltan 2 years, 3 months ago
On Fri, 28 Jan 2022, Fabiano Rosas wrote:
> This series handles the BookE exception code.
>
> Tested the following machines/CPUs:
>
> == bamboo ==
> 440ep, 460ex, 440-xilinx-w-dfpu
>
> == sam460ex ==
> 440ep, 460ex, 440-xilinx-w-dfpu

What OS did you test with? Other than the 460ex may not make much sense 
on this board but checking it never hurts. If you only tried Linux kernel 
then something else to give more coverage could be the same MorphOS iso 
that used for pegasos2 which should also boot on sam460ex as shown here:

http://zero.eik.bme.hu/~balaton/qemu/amiga/#morphos

or the AROS iso further up that page that should also boot on sam460ex.

Regards,
BALATON Zoltan

> == mpc8544ds ==
> e500v1, e500v2
>
> == ppce500 ==
> e500mc, e5500, e6500
>
> About the remaining CPUs:
>
> - The 440x4 have been partially removed in the past. I sent a separate
>  patch removing what's left of it.
>
> - The 440x5 (440-xilinx) boots with the bamboo machine but it
>  segfaults in userspace (also in master).
>
> - The e200 is broken in master due to an assert in _spr_register (the
>  DSRR0/1 registers are being registered twice). After fixing that
>  QEMU crashes due to lack of IRQ controller (there's a TODO in the
>  init_proc_e200).
>
> Fabiano Rosas (11):
>  target/ppc: Introduce powerpc_excp_booke
>  target/ppc: Simplify powerpc_excp_booke
>  target/ppc: booke: Critical exception cleanup
>  target/ppc: booke: Machine Check cleanups
>  target/ppc: booke: Data Storage exception cleanup
>  target/ppc: booke: Instruction storage exception cleanup
>  target/ppc: booke: External interrupt cleanup
>  target/ppc: booke: Alignment interrupt cleanup
>  target/ppc: booke: System Call exception cleanup
>  target/ppc: booke: Watchdog Timer interrupt
>  target/ppc: booke: System Reset exception cleanup
>
> target/ppc/excp_helper.c | 228 +++++++++++++++++++++++++++++++++++++++
> 1 file changed, 228 insertions(+)
>
>

Re: [PATCH 00/11] target/ppc: powerpc_excp improvements [BookE] (6/n)
Posted by Cédric Le Goater 2 years, 3 months ago
Hello Zoltan,

On 1/29/22 01:07, BALATON Zoltan wrote:
> On Fri, 28 Jan 2022, Fabiano Rosas wrote:
>> This series handles the BookE exception code.
>>
>> Tested the following machines/CPUs:
>>
>> == bamboo ==
>> 440ep, 460ex, 440-xilinx-w-dfpu
>>
>> == sam460ex ==
>> 440ep, 460ex, 440-xilinx-w-dfpu
> 
> What OS did you test with? Other than the 460ex may not make much sense on this board but checking it never hurts. If you only tried Linux kernel then something else to give more coverage could be the same MorphOS iso that used for pegasos2 which should also boot on sam460ex as shown here:
> 
> http://zero.eik.bme.hu/~balaton/qemu/amiga/#morphos
> 
> or the AROS iso further up that page that should also boot on sam460ex.
> 

I didn't see any issue.

Could you please give a try to this branch :

   https://gitlab.com/legoater/qemu/-/tree/ppc-7.0

Thanks,

C.

Re: [PATCH 00/11] target/ppc: powerpc_excp improvements [BookE] (6/n)
Posted by BALATON Zoltan 2 years, 3 months ago
On Tue, 1 Feb 2022, Cédric Le Goater wrote:
> On 1/29/22 01:07, BALATON Zoltan wrote:
>> On Fri, 28 Jan 2022, Fabiano Rosas wrote:
>>> This series handles the BookE exception code.
>>> 
>>> Tested the following machines/CPUs:
>>> 
>>> == bamboo ==
>>> 440ep, 460ex, 440-xilinx-w-dfpu
>>> 
>>> == sam460ex ==
>>> 440ep, 460ex, 440-xilinx-w-dfpu
>> 
>> What OS did you test with? Other than the 460ex may not make much sense on 
>> this board but checking it never hurts. If you only tried Linux kernel then 
>> something else to give more coverage could be the same MorphOS iso that 
>> used for pegasos2 which should also boot on sam460ex as shown here:
>> 
>> http://zero.eik.bme.hu/~balaton/qemu/amiga/#morphos
>> 
>> or the AROS iso further up that page that should also boot on sam460ex.
>
> I didn't see any issue.
>
> Could you please give a try to this branch :
>
>  https://gitlab.com/legoater/qemu/-/tree/ppc-7.0

Thanks for testing. It should be fine if it still boots so just go ahead 
and put the series in the next pull request. If I find anything I'll 
report when it's in master, I don't have the resources to follow branches 
but we have a long freeze time to find any bugs so ir should be OK.

Regards,
BALATON Zoltan
Re: [PATCH 00/11] target/ppc: powerpc_excp improvements [BookE] (6/n)
Posted by Fabiano Rosas 2 years, 3 months ago
BALATON Zoltan <balaton@eik.bme.hu> writes:

> On Tue, 1 Feb 2022, Cédric Le Goater wrote:
>> On 1/29/22 01:07, BALATON Zoltan wrote:
>>> On Fri, 28 Jan 2022, Fabiano Rosas wrote:
>>>> This series handles the BookE exception code.
>>>> 
>>>> Tested the following machines/CPUs:
>>>> 
>>>> == bamboo ==
>>>> 440ep, 460ex, 440-xilinx-w-dfpu
>>>> 
>>>> == sam460ex ==
>>>> 440ep, 460ex, 440-xilinx-w-dfpu
>>> 
>>> What OS did you test with? Other than the 460ex may not make much sense on 
>>> this board but checking it never hurts. If you only tried Linux kernel then 
>>> something else to give more coverage could be the same MorphOS iso that 
>>> used for pegasos2 which should also boot on sam460ex as shown here:
>>> 
>>> http://zero.eik.bme.hu/~balaton/qemu/amiga/#morphos
>>> 
>>> or the AROS iso further up that page that should also boot on sam460ex.
>>
>> I didn't see any issue.
>>
>> Could you please give a try to this branch :
>>
>>  https://gitlab.com/legoater/qemu/-/tree/ppc-7.0
>
> Thanks for testing. It should be fine if it still boots so just go ahead 
> and put the series in the next pull request. If I find anything I'll 
> report when it's in master, I don't have the resources to follow branches 
> but we have a long freeze time to find any bugs so ir should be OK.

I tested it but forgot to post here. It boots fine until the little
ballons screen and I can click around. So I'd say were good. =)