[v5] trace qmp commands

[PATCH v5 0/7] trace qmp commands

Vladimir Sementsov-Ogievskiy posted 7 patches 2 years, 3 months ago

Diff against v1 v1 v2 v3 v4 v6
Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220125215655.3111881-1-vsementsov@virtuozzo.com

Maintainers: Stefan Hajnoczi <stefanha@redhat.com>, Markus Armbruster <armbru@redhat.com>, Michael Roth <michael.roth@amd.com>

There is a newer version of this series

docs/devel/qapi-code-gen.rst |  23 +++++++-
meson.build                  |   3 ++
qapi/meson.build             |   7 +++
qga/meson.build              |  11 +++-
scripts/qapi/commands.py     | 101 ++++++++++++++++++++++++++++++-----
scripts/qapi/gen.py          |  33 ++++++++++--
scripts/qapi/main.py         |  10 ++--
tests/meson.build            |  11 +++-
trace/meson.build            |  11 ++--
9 files changed, 182 insertions(+), 28 deletions(-)

Expand all Fold all

[PATCH v5 0/7] trace qmp commands

Posted by Vladimir Sementsov-Ogievskiy 2 years, 3 months ago

This series aims to add trace points for each qmp command with help of
qapi code generator.

v5: small fixes and rewordings, + reshuffle patches so that main meson change now is like in v3 and Paolo's a-b make sense again.

01: - fix/reword commit message
    - fix typing in qapi/gen.py
    - rename add_trace_events to gen_trace_events, and to _gen_trace_event for private attribute
02: - split from 03, to make 03 a bit simpler
03: - reword commit message
    - rename add_trace_events to gen_trace_events, and to _gen_trace_event for private attribute
    - rebase on 02
    - merge here main.py changes, with new option: --gen-trace
04: - move some parts to other commits, so now it looks like 03 patch of v3, so add back a-b mark by Paolo
05: - split doc change from 04
06: - split new comments from 04
07: new

Vladimir Sementsov-Ogievskiy (7):
  scripts/qapi/gen.py: add FOO.trace-events output module
  qapi/commands: refactor error handling code
  qapi/commands: Optionally generate trace for QMP commands
  meson: generate trace events for qmp commands
  docs/qapi-code-gen: update to cover trace events code generation
  meson: document, why we don't generate trace events for tests/ and
    qga/
  qapi: generate trace events by default

 docs/devel/qapi-code-gen.rst |  23 +++++++-
 meson.build                  |   3 ++
 qapi/meson.build             |   7 +++
 qga/meson.build              |  11 +++-
 scripts/qapi/commands.py     | 101 ++++++++++++++++++++++++++++++-----
 scripts/qapi/gen.py          |  33 ++++++++++--
 scripts/qapi/main.py         |  10 ++--
 tests/meson.build            |  11 +++-
 trace/meson.build            |  11 ++--
 9 files changed, 182 insertions(+), 28 deletions(-)

-- 
2.31.1

Re: [PATCH v5 0/7] trace qmp commands

Posted by Markus Armbruster 2 years, 2 months ago

Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes:

> This series aims to add trace points for each qmp command with help of
> qapi code generator.

I found only really minor things.  A quick respin should get us to the
finish line.  Thanks!

Re: [PATCH v5 0/7] trace qmp commands

Posted by Stefan Hajnoczi 2 years, 2 months ago

On Tue, Jan 25, 2022 at 10:56:48PM +0100, Vladimir Sementsov-Ogievskiy wrote:
> This series aims to add trace points for each qmp command with help of
> qapi code generator.
> 
> v5: small fixes and rewordings, + reshuffle patches so that main meson change now is like in v3 and Paolo's a-b make sense again.
> 
> 01: - fix/reword commit message
>     - fix typing in qapi/gen.py
>     - rename add_trace_events to gen_trace_events, and to _gen_trace_event for private attribute
> 02: - split from 03, to make 03 a bit simpler
> 03: - reword commit message
>     - rename add_trace_events to gen_trace_events, and to _gen_trace_event for private attribute
>     - rebase on 02
>     - merge here main.py changes, with new option: --gen-trace
> 04: - move some parts to other commits, so now it looks like 03 patch of v3, so add back a-b mark by Paolo
> 05: - split doc change from 04
> 06: - split new comments from 04
> 07: new
> 
> Vladimir Sementsov-Ogievskiy (7):
>   scripts/qapi/gen.py: add FOO.trace-events output module
>   qapi/commands: refactor error handling code
>   qapi/commands: Optionally generate trace for QMP commands
>   meson: generate trace events for qmp commands
>   docs/qapi-code-gen: update to cover trace events code generation
>   meson: document, why we don't generate trace events for tests/ and
>     qga/
>   qapi: generate trace events by default
> 
>  docs/devel/qapi-code-gen.rst |  23 +++++++-
>  meson.build                  |   3 ++
>  qapi/meson.build             |   7 +++
>  qga/meson.build              |  11 +++-
>  scripts/qapi/commands.py     | 101 ++++++++++++++++++++++++++++++-----
>  scripts/qapi/gen.py          |  33 ++++++++++--
>  scripts/qapi/main.py         |  10 ++--
>  tests/meson.build            |  11 +++-
>  trace/meson.build            |  11 ++--
>  9 files changed, 182 insertions(+), 28 deletions(-)
> 
> -- 
> 2.31.1
> 

Thanks, Vladimir. This looks great!

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>