cpuid: use unsigned for max cpuid

[PATCH] cpuid: use unsigned for max cpuid

Michael S. Tsirkin posted 1 patch 2 years, 2 months ago

Download mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220125192232.99101-1-mst@redhat.com

Maintainers: Richard Henderson <richard.henderson@linaro.org>

configure                 | 2 +-
util/bufferiszero.c       | 2 +-
tcg/i386/tcg-target.c.inc | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)

Expand all Fold all

[PATCH] cpuid: use unsigned for max cpuid

Posted by Michael S. Tsirkin 2 years, 2 months ago

__get_cpuid_max returns an unsigned value.
For consistency, store the result in an unsigned variable.

Found by running ./configure --extra-cflags=-Wconversion

Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Richard Henderson <rth@twiddle.net>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---

Richard, if appropriate pls queue this.
Thanks!

 configure                 | 2 +-
 util/bufferiszero.c       | 2 +-
 tcg/i386/tcg-target.c.inc | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/configure b/configure
index e1a31fb332..938f43a59a 100755
--- a/configure
+++ b/configure
@@ -2768,7 +2768,7 @@ cat > $TMPC << EOF
 #include <cpuid.h>
 int main(void) {
     unsigned a, b, c, d;
-    int max = __get_cpuid_max(0, 0);
+    unsigned max = __get_cpuid_max(0, 0);
 
     if (max >= 1) {
         __cpuid(1, a, b, c, d);
diff --git a/util/bufferiszero.c b/util/bufferiszero.c
index 695bb4ce28..ec3cd4ca15 100644
--- a/util/bufferiszero.c
+++ b/util/bufferiszero.c
@@ -272,7 +272,7 @@ static void init_accel(unsigned cache)
 
 static void __attribute__((constructor)) init_cpuid_cache(void)
 {
-    int max = __get_cpuid_max(0, NULL);
+    unsigned max = __get_cpuid_max(0, NULL);
     int a, b, c, d;
     unsigned cache = 0;
 
diff --git a/tcg/i386/tcg-target.c.inc b/tcg/i386/tcg-target.c.inc
index 875311f795..4dab09f265 100644
--- a/tcg/i386/tcg-target.c.inc
+++ b/tcg/i386/tcg-target.c.inc
@@ -3747,7 +3747,7 @@ static void tcg_target_init(TCGContext *s)
 {
 #ifdef CONFIG_CPUID_H
     unsigned a, b, c, d, b7 = 0;
-    int max = __get_cpuid_max(0, 0);
+    unsigned max = __get_cpuid_max(0, 0);
 
     if (max >= 7) {
         /* BMI1 is available on AMD Piledriver and Intel Haswell CPUs.  */
-- 
MST

Re: [PATCH] cpuid: use unsigned for max cpuid

Posted by Philippe Mathieu-Daudé via 2 years, 2 months ago

On 25/1/22 20:24, Michael S. Tsirkin wrote:
> __get_cpuid_max returns an unsigned value.
> For consistency, store the result in an unsigned variable.
> 
> Found by running ./configure --extra-cflags=-Wconversion
> 
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Richard Henderson <rth@twiddle.net>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> 
> Richard, if appropriate pls queue this.
> Thanks!
> 
>   configure                 | 2 +-
>   util/bufferiszero.c       | 2 +-
>   tcg/i386/tcg-target.c.inc | 2 +-
>   3 files changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>