[PATCH] qemu-storage-daemon: Fix typo in vhost-user-blk help

Kevin Wolf posted 1 patch 2 years, 2 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220125151514.49035-1-kwolf@redhat.com
Maintainers: Kevin Wolf <kwolf@redhat.com>
storage-daemon/qemu-storage-daemon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] qemu-storage-daemon: Fix typo in vhost-user-blk help
Posted by Kevin Wolf 2 years, 2 months ago
The syntax of the fd passing case misses the "addr.type=" key. Add it.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 storage-daemon/qemu-storage-daemon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/storage-daemon/qemu-storage-daemon.c b/storage-daemon/qemu-storage-daemon.c
index 9d76d1114d..ec9aa79b55 100644
--- a/storage-daemon/qemu-storage-daemon.c
+++ b/storage-daemon/qemu-storage-daemon.c
@@ -111,7 +111,7 @@ static void help(void)
 "                         export the specified block node as a\n"
 "                         vhost-user-blk device over UNIX domain socket\n"
 "  --export [type=]vhost-user-blk,id=<id>,node-name=<node-name>,\n"
-"           fd,addr.str=<fd>[,writable=on|off]\n"
+"           addr.type=fd,addr.str=<fd>[,writable=on|off]\n"
 "           [,logical-block-size=<block-size>][,num-queues=<num-queues>]\n"
 "                         export the specified block node as a\n"
 "                         vhost-user-blk device over file descriptor\n"
-- 
2.31.1


Re: [PATCH] qemu-storage-daemon: Fix typo in vhost-user-blk help
Posted by Hanna Reitz 2 years, 2 months ago
On 25.01.22 16:15, Kevin Wolf wrote:
> The syntax of the fd passing case misses the "addr.type=" key. Add it.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>   storage-daemon/qemu-storage-daemon.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Hanna Reitz <hreitz@redhat.com>