[v4] CXl 2.0 emulation Support

[PATCH v4 14/42] tests/acpi: allow DSDT.viot table changes.

Posted by Jonathan Cameron via 4 years ago

From: Jonathan Cameron <jonathan.cameron@huawei.com>

The next patch unifies some of the PCI host bridge DSDT
generation code and results in some minor changes to this file.

Signed-off-by: Jonathan Cameron <jonathan.cameron@huawei.com>
---
 tests/qtest/bios-tables-test-allowed-diff.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index dfb8523c8b..08a8095432 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1 +1,2 @@
 /* List of comma-separated changed AML files to ignore */
+"tests/data/acpi/q35/DSDT.viot",
-- 
2.32.0

Re: [PATCH v4 14/42] tests/acpi: allow DSDT.viot table changes.

Posted by Alex Bennée 4 years ago

Jonathan Cameron <Jonathan.Cameron@huawei.com> writes:

> From: Jonathan Cameron <jonathan.cameron@huawei.com>
>
> The next patch unifies some of the PCI host bridge DSDT
> generation code and results in some minor changes to this file.

I'd just squash this in with the patch that makes the change...
otherwise you risk breaking bisectablility.

>
> Signed-off-by: Jonathan Cameron <jonathan.cameron@huawei.com>
> ---
>  tests/qtest/bios-tables-test-allowed-diff.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
> index dfb8523c8b..08a8095432 100644
> --- a/tests/qtest/bios-tables-test-allowed-diff.h
> +++ b/tests/qtest/bios-tables-test-allowed-diff.h
> @@ -1 +1,2 @@
>  /* List of comma-separated changed AML files to ignore */
> +"tests/data/acpi/q35/DSDT.viot",


-- 
Alex Bennée

Re: [PATCH v4 14/42] tests/acpi: allow DSDT.viot table changes.

Posted by Jonathan Cameron via 4 years ago

On Thu, 27 Jan 2022 14:06:42 +0000
Alex Bennée <alex.bennee@linaro.org> wrote:

> Jonathan Cameron <Jonathan.Cameron@huawei.com> writes:
> 
> > From: Jonathan Cameron <jonathan.cameron@huawei.com>
> >
> > The next patch unifies some of the PCI host bridge DSDT
> > generation code and results in some minor changes to this file.  
> 
> I'd just squash this in with the patch that makes the change...
> otherwise you risk breaking bisectablility.
Hi Alex,

This sequence of 3 patches is as described in
tests/qtest/bios-tables-test.c

According to description there the point is to allow
whoever picks these patches up to just change the 3rd patch
if the tables need updating to reflect some other change.

It would be a lot easier obviously to just squash it, but
given the process is laid out in that file, I'd rather
leave it like this.

Or am I missing a reason this particular one is better
squashed? 

Thanks,

Jonathan


> 
> >
> > Signed-off-by: Jonathan Cameron <jonathan.cameron@huawei.com>
> > ---
> >  tests/qtest/bios-tables-test-allowed-diff.h | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
> > index dfb8523c8b..08a8095432 100644
> > --- a/tests/qtest/bios-tables-test-allowed-diff.h
> > +++ b/tests/qtest/bios-tables-test-allowed-diff.h
> > @@ -1 +1,2 @@
> >  /* List of comma-separated changed AML files to ignore */
> > +"tests/data/acpi/q35/DSDT.viot",  
> 
>

Re: [PATCH v4 14/42] tests/acpi: allow DSDT.viot table changes.

Posted by Alex Bennée 4 years ago

Jonathan Cameron <Jonathan.Cameron@huawei.com> writes:

> On Thu, 27 Jan 2022 14:06:42 +0000
> Alex Bennée <alex.bennee@linaro.org> wrote:
>
>> Jonathan Cameron <Jonathan.Cameron@huawei.com> writes:
>> 
>> > From: Jonathan Cameron <jonathan.cameron@huawei.com>
>> >
>> > The next patch unifies some of the PCI host bridge DSDT
>> > generation code and results in some minor changes to this file.  
>> 
>> I'd just squash this in with the patch that makes the change...
>> otherwise you risk breaking bisectablility.
> Hi Alex,
>
> This sequence of 3 patches is as described in
> tests/qtest/bios-tables-test.c
>
> According to description there the point is to allow
> whoever picks these patches up to just change the 3rd patch
> if the tables need updating to reflect some other change.
>
> It would be a lot easier obviously to just squash it, but
> given the process is laid out in that file, I'd rather
> leave it like this.

Hmm I shall defer to the maintainer here. I assume this process is to
deal with complex changes over several commits. So ignore that comment
for now.

>
> Or am I missing a reason this particular one is better
> squashed? 
>
> Thanks,
>
> Jonathan
>
>
>> 
>> >
>> > Signed-off-by: Jonathan Cameron <jonathan.cameron@huawei.com>
>> > ---
>> >  tests/qtest/bios-tables-test-allowed-diff.h | 1 +
>> >  1 file changed, 1 insertion(+)
>> >
>> > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
>> > index dfb8523c8b..08a8095432 100644
>> > --- a/tests/qtest/bios-tables-test-allowed-diff.h
>> > +++ b/tests/qtest/bios-tables-test-allowed-diff.h
>> > @@ -1 +1,2 @@
>> >  /* List of comma-separated changed AML files to ignore */
>> > +"tests/data/acpi/q35/DSDT.viot",  
>> 
>> 


-- 
Alex Bennée