[PATCH] target/avr: Correct AVRCPUClass docstring

Philippe Mathieu-Daudé via posted 1 patch 2 years, 3 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220122001036.83267-1-f4bug@amsat.org
Test checkpatch failed
target/avr/cpu-qom.h | 1 -
1 file changed, 1 deletion(-)
[PATCH] target/avr: Correct AVRCPUClass docstring
Posted by Philippe Mathieu-Daudé via 2 years, 3 months ago
There is no 'vr' field in AVRCPUClass.

Likely a copy/paste typo from CRISCPUClass ;)

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 target/avr/cpu-qom.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/target/avr/cpu-qom.h b/target/avr/cpu-qom.h
index 9fa6989c18..14e5b3ce72 100644
--- a/target/avr/cpu-qom.h
+++ b/target/avr/cpu-qom.h
@@ -33,7 +33,6 @@ OBJECT_DECLARE_TYPE(AVRCPU, AVRCPUClass,
  *  AVRCPUClass:
  *  @parent_realize: The parent class' realize handler.
  *  @parent_reset: The parent class' reset handler.
- *  @vr: Version Register value.
  *
  *  A AVR CPU model.
  */
-- 
2.34.1


Re: [PATCH] target/avr: Correct AVRCPUClass docstring
Posted by Laurent Vivier 2 years, 2 months ago
Le 22/01/2022 à 01:10, Philippe Mathieu-Daudé via a écrit :
> There is no 'vr' field in AVRCPUClass.
> 
> Likely a copy/paste typo from CRISCPUClass ;)
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>   target/avr/cpu-qom.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/target/avr/cpu-qom.h b/target/avr/cpu-qom.h
> index 9fa6989c18..14e5b3ce72 100644
> --- a/target/avr/cpu-qom.h
> +++ b/target/avr/cpu-qom.h
> @@ -33,7 +33,6 @@ OBJECT_DECLARE_TYPE(AVRCPU, AVRCPUClass,
>    *  AVRCPUClass:
>    *  @parent_realize: The parent class' realize handler.
>    *  @parent_reset: The parent class' reset handler.
> - *  @vr: Version Register value.
>    *
>    *  A AVR CPU model.
>    */

Applied to my trivial-patches branch.

Thanks,
Laurent


Re: [PATCH] target/avr: Correct AVRCPUClass docstring
Posted by Richard Henderson 2 years, 3 months ago
On 1/22/22 11:10 AM, Philippe Mathieu-Daudé via wrote:
> There is no 'vr' field in AVRCPUClass.
> 
> Likely a copy/paste typo from CRISCPUClass ;)
> 
> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
> ---
>   target/avr/cpu-qom.h | 1 -
>   1 file changed, 1 deletion(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~