This is my last respin on this series which is fully reviewed.

Refresh lcitool to latest and remove libxml2 (mjt).

v6:
- update libvirt-ci submodule to remove lttng-ust from FreeBSD runners

v5:
- update scripts/meson-buildoptions.sh (thuth)
- squash libvirt-ci updates (thuth)

v4:
- Fixed typos and cleaned checkpatch.pl (thuth)
- Corrected libvirt-ci submodule URL

v3:
- fix 'refresh' helper to update cirrus-ci files (danpb)

v2:
- rebased (testing/next)
- include mjt's libxml2 removal patch

Michael Tokarev (1):
  drop libxml2 checks since libxml is not actually used (for parallels)

Philippe Mathieu-Daudé (6):
  MAINTAINERS: Cover lcitool submodule with build test / automation
  gitmodules: Correct libvirt-ci submodule URL
  tests/lcitool: Include local qemu.yml when refreshing cirrus-ci files
  tests/lcitool: Refresh submodule and remove libxml2
  tests: Manually remove libxml2 on MSYS2 runners
  tests/lcitool: Install libibumad to cover RDMA on Debian based distros

 meson.build                                     | 6 ------
 .cirrus.yml                                     | 1 -
 .gitlab-ci.d/cirrus/freebsd-12.vars             | 2 +-
 .gitlab-ci.d/cirrus/freebsd-13.vars             | 2 +-
 .gitlab-ci.d/cirrus/macos-11.vars               | 2 +-
 .gitlab-ci.d/windows.yml                        | 2 --
 .gitmodules                                     | 2 +-
 MAINTAINERS                                     | 1 +
 block/meson.build                               | 3 +--
 meson_options.txt                               | 2 --
 scripts/checkpatch.pl                           | 1 -
 scripts/ci/org.centos/stream/8/x86_64/configure | 1 -
 scripts/coverity-scan/coverity-scan.docker      | 1 -
 scripts/coverity-scan/run-coverity-scan         | 2 +-
 scripts/meson-buildoptions.sh                   | 3 ---
 tests/docker/dockerfiles/alpine.docker          | 4 ++--
 tests/docker/dockerfiles/centos8.docker         | 4 +---
 tests/docker/dockerfiles/fedora.docker          | 4 +---
 tests/docker/dockerfiles/opensuse-leap.docker   | 3 +--
 tests/docker/dockerfiles/ubuntu1804.docker      | 4 ++--
 tests/docker/dockerfiles/ubuntu2004.docker      | 4 ++--
 tests/lcitool/libvirt-ci                        | 2 +-
 tests/lcitool/projects/qemu.yml                 | 2 +-
 tests/lcitool/refresh                           | 2 +-
 24 files changed, 19 insertions(+), 41 deletions(-)

-- 
2.34.1

Philippe Mathieu-Daudé <f4bug@amsat.org> writes:

> This is my last respin on this series which is fully reviewed.
>
> Refresh lcitool to latest and remove libxml2 (mjt).

Queued to testing/next, thanks.

-- 
Alex Bennée

Philippe Mathieu-Daudé <f4bug@amsat.org> writes:

> This is my last respin on this series which is fully reviewed.
>
<snip>

Just to note the "b4" application of this broke the From addresses. If
you see the lore copy:

  https://lore.kernel.org/qemu-devel/20220121154134.315047-1-f4bug@amsat.org/

all your From's are via qemu-devel. Have you changed anything about your
submission process?

-- 
Alex Bennée

On 1/24/22 11:55, Alex Bennée wrote:
> 
> Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
> 
>> This is my last respin on this series which is fully reviewed.
>>
> <snip>
> 
> Just to note the "b4" application of this broke the From addresses. If
> you see the lore copy:
> 
>   https://lore.kernel.org/qemu-devel/20220121154134.315047-1-f4bug@amsat.org/
> 
> all your From's are via qemu-devel. Have you changed anything about your
> submission process?

No. Maybe the list changed something again? Similar problem occurred
18 months ago IIRC. Not sure what I can do, the domain misses SPF/DKIM:
https://toolbox.googleapps.com/apps/checkmx/check?domain=amsat.org

If it helps you can get them on my branch macos12:
https://gitlab.com/philmd/qemu/-/compare/5e9d14f2...36d00943e?from_project_id=6939745

Philippe Mathieu-Daudé <f4bug@amsat.org> writes:

> On 1/24/22 11:55, Alex Bennée wrote:
>> 
>> Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
>> 
>>> This is my last respin on this series which is fully reviewed.
>>>
>> <snip>
>> 
>> Just to note the "b4" application of this broke the From addresses. If
>> you see the lore copy:
>> 
>>   https://lore.kernel.org/qemu-devel/20220121154134.315047-1-f4bug@amsat.org/
>> 
>> all your From's are via qemu-devel. Have you changed anything about your
>> submission process?
>
> No. Maybe the list changed something again? Similar problem occurred
> 18 months ago IIRC. Not sure what I can do, the domain misses SPF/DKIM:
> https://toolbox.googleapps.com/apps/checkmx/check?domain=amsat.org

I thought so but others in the archives are fine. I take it you can't ask
the owners of amsat.org to expand the SPF setting or use the MX server
indicated to send emails?

Otherwise it might be worth either getting your own gmail or domain for
posting.

>
> If it helps you can get them on my branch macos12:
> https://gitlab.com/philmd/qemu/-/compare/5e9d14f2...36d00943e?from_project_id=6939745

I nabbed it with my old-school patch handling which still works but
doesn't auto collect tags for me ;-)

-- 
Alex Bennée

On 1/24/22 20:16, Alex Bennée wrote:
> 
> Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
> 
>> On 1/24/22 11:55, Alex Bennée wrote:
>>>
>>> Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
>>>
>>>> This is my last respin on this series which is fully reviewed.
>>>>
>>> <snip>
>>>
>>> Just to note the "b4" application of this broke the From addresses. If
>>> you see the lore copy:
>>>
>>>   https://lore.kernel.org/qemu-devel/20220121154134.315047-1-f4bug@amsat.org/
>>>
>>> all your From's are via qemu-devel. Have you changed anything about your
>>> submission process?
>>
>> No. Maybe the list changed something again? Similar problem occurred
>> 18 months ago IIRC. Not sure what I can do, the domain misses SPF/DKIM:
>> https://toolbox.googleapps.com/apps/checkmx/check?domain=amsat.org
> 
> I thought so but others in the archives are fine. I take it you can't ask
> the owners of amsat.org to expand the SPF setting or use the MX server
> indicated to send emails?
> 
> Otherwise it might be worth either getting your own gmail or domain for
> posting.

=)

I'm seeing the same with Mark's email: Mark Cave-Ayland via
<openbios-bounces@openbios.org> maybe Google is running a global SMTP purge?

Similar SPF/DKIM errors:
https://toolbox.googleapps.com/apps/checkmx/check?domain=ilande.co.uk

> 
>>
>> If it helps you can get them on my branch macos12:
>> https://gitlab.com/philmd/qemu/-/compare/5e9d14f2...36d00943e?from_project_id=6939745
> 
> I nabbed it with my old-school patch handling which still works but
> doesn't auto collect tags for me ;-)
> 

On 1/24/22 20:33, Philippe Mathieu-Daudé wrote:
> On 1/24/22 20:16, Alex Bennée wrote:
>>
>> Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
>>
>>> On 1/24/22 11:55, Alex Bennée wrote:
>>>>
>>>> Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
>>>>
>>>>> This is my last respin on this series which is fully reviewed.
>>>>>
>>>> <snip>
>>>>
>>>> Just to note the "b4" application of this broke the From addresses. If
>>>> you see the lore copy:
>>>>
>>>>   https://lore.kernel.org/qemu-devel/20220121154134.315047-1-f4bug@amsat.org/
>>>>
>>>> all your From's are via qemu-devel. Have you changed anything about your
>>>> submission process?
>>>
>>> No. Maybe the list changed something again? Similar problem occurred
>>> 18 months ago IIRC. Not sure what I can do, the domain misses SPF/DKIM:
>>> https://toolbox.googleapps.com/apps/checkmx/check?domain=amsat.org
>>
>> I thought so but others in the archives are fine. I take it you can't ask
>> the owners of amsat.org to expand the SPF setting or use the MX server
>> indicated to send emails?
>>
>> Otherwise it might be worth either getting your own gmail or domain for
>> posting.
> 
> =)
> 
> I'm seeing the same with Mark's email: Mark Cave-Ayland via
> <openbios-bounces@openbios.org> maybe Google is running a global SMTP purge?
> 
> Similar SPF/DKIM errors:
> https://toolbox.googleapps.com/apps/checkmx/check?domain=ilande.co.uk
> 
>>
>>>
>>> If it helps you can get them on my branch macos12:
>>> https://gitlab.com/philmd/qemu/-/compare/5e9d14f2...36d00943e?from_project_id=6939745
>>
>> I nabbed it with my old-school patch handling which still works but
>> doesn't auto collect tags for me ;-)

I'm seeing the same issue with these domains since mid december:

- amd.com
- huawei.com
- hisilicon.com
- ilande.co.uk
- amsat.org
- rev.ng

https://lore.kernel.org/qemu-devel/20220124104450.152481-1-ross.lagerwall@citrix.com/
https://lore.kernel.org/qemu-devel/1643102134-15506-1-git-send-email-chenxiang66@hisilicon.com/
https://lore.kernel.org/qemu-devel/20220124105245.00006aa1@Huawei.com/
https://lore.kernel.org/qemu-devel/20220105185720.0d4fc159@orange/
https://lore.kernel.org/qemu-devel/20211220234146.s7pq5gu6yxhtub3r@amd.com/

On Tue, 25 Jan 2022 11:59:38 +0100
Philippe Mathieu-Daudé via <qemu-devel@nongnu.org> wrote:

> I'm seeing the same issue with these domains since mid december:
> 
> ...
> - rev.ng
> 
> ...
> https://lore.kernel.org/qemu-devel/20220105185720.0d4fc159@orange/
> ...

I've tried to look into this and it looks like our set up should be OK.
We enabled SPF (i.e., a rule stating that only our mailserver can send
e-mail with our domain in "From:") and DKIM (i.e., our mailserver signs
certain portions of the e-mail). We also enabled DMARC which
coordinates the two.

Now, as far as I understand, mailing lists can either rewrite the
"From" header (as qemu-devel does) or leave it as it is. In the latter
situation, SPF will fail but DMARC should instruct MTAs to check
DKIM, and that should pass.

    https://begriffs.com/posts/2018-09-18-dmarc-mailing-list.html
    https://dmarc.org/wiki/FAQ#I_operate_a_mailing_list_and_I_want_to_interoperate_with_DMARC.2C_what_should_I_do.3F

DKIM signature can be corrupted in case the mailing list tampers with
the subject or the body of the e-mail, but this doesn't seem to be the
case: I've tried to manually verify the DKIM signature of the same
e-mail that I got both from the mailing list and directly from the
sender (I was in Cc), and they both verify correctly.

tl;dr I *think* rewriting the From header should not be necessary for
our domain.

If you guys think this is not the case and there's something we can do
to improve the situation (other than adding gmail.com to our SPF
record), let me know.

-- 
Alessandro Di Federico
rev.ng Labs

On 24/01/2022 19:33, Philippe Mathieu-Daudé via wrote:

> On 1/24/22 20:16, Alex Bennée wrote:
>>
>> Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
>>
>>> On 1/24/22 11:55, Alex Bennée wrote:
>>>>
>>>> Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
>>>>
>>>>> This is my last respin on this series which is fully reviewed.
>>>>>
>>>> <snip>
>>>>
>>>> Just to note the "b4" application of this broke the From addresses. If
>>>> you see the lore copy:
>>>>
>>>>    https://lore.kernel.org/qemu-devel/20220121154134.315047-1-f4bug@amsat.org/
>>>>
>>>> all your From's are via qemu-devel. Have you changed anything about your
>>>> submission process?
>>>
>>> No. Maybe the list changed something again? Similar problem occurred
>>> 18 months ago IIRC. Not sure what I can do, the domain misses SPF/DKIM:
>>> https://toolbox.googleapps.com/apps/checkmx/check?domain=amsat.org
>>
>> I thought so but others in the archives are fine. I take it you can't ask
>> the owners of amsat.org to expand the SPF setting or use the MX server
>> indicated to send emails?
>>
>> Otherwise it might be worth either getting your own gmail or domain for
>> posting.
> 
> =)
> 
> I'm seeing the same with Mark's email: Mark Cave-Ayland via
> <openbios-bounces@openbios.org> maybe Google is running a global SMTP purge?
> 
> Similar SPF/DKIM errors:
> https://toolbox.googleapps.com/apps/checkmx/check?domain=ilande.co.uk

Is there something that needs to be changed in my email setup? My email isn't managed 
by GMail so I'm lacking a bit of context here.


ATB,

Mark.