The current firmware descriptor schema for flash requires that both the
executable to NVRAM template paths be provided. This is fine for the
most common usage of EDK2 builds in virtualization where the separate
_CODE and _VARS files are provided.

With confidential computing technology like AMD SEV, persistent storage
of variables may be completely disabled because the firmware requires a
known clean state on every cold boot. There is no way to express this
in the firmware descriptor today.

Even with regular EDK2 builds it is possible to create a firmware that
has both executable code and variable persistence in a single file. This
hasn't been commonly used, since it would mean every guest bootup would
need to clone the full firmware file, leading to redundant duplicate
storage of the code portion. In some scenarios this may not matter and
might even be beneficial. For example if a public cloud allows users to
bring their own firmware, such that the user can pre-enroll their own
secure boot keys, you're going to have this copied on disk for each
tenant already. At this point the it can be simpler to just deal with
a single file rather than split builds. The firmware descriptor ought
to be able to express this combined firmware model too.

This all points towards expanding the schema for flash with a 'mode'
concept

 - "split" - the current implicit behaviour with separate files
   for code and variables.

 - "combined" - the alternate behaviour where a single file contains
   both code and variables.

 - "stateless" - the confidential computing use case where storage
   of variables is completely disable, leaving only the code.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 docs/interop/firmware.json | 54 ++++++++++++++++++++++++++++++++------
 1 file changed, 46 insertions(+), 8 deletions(-)

diff --git a/docs/interop/firmware.json b/docs/interop/firmware.json
index 8d8b0be030..884e99864b 100644
--- a/docs/interop/firmware.json
+++ b/docs/interop/firmware.json
@@ -210,24 +210,61 @@
   'data'   : { 'filename' : 'str',
                'format'   : 'BlockdevDriver' } }
 
+
+##
+# @FirmwareFlashType:
+#
+# Describes how the firmware build handles code versus variable
+# persistence.
+#
+# @split: the executable file contains code while the nvram
+#         template provides variable storage. The executable
+#         must be configured read-only and can be shared between
+#         multiple guests. The nvram template must be cloned
+#         for each new guest and configured read-write.
+#
+# @combined: the executable file contains both code and
+#            variable storage. The executable must be cloned
+#            for each new guest and configured read-write.
+#            No nvram template will be specified.
+#
+# @stateless: the executable file contains code and variable
+#             storage is not persisted. The executed must
+#             be configured read-only and can be shared
+#             between multiple guests. No nvram template
+#             willbe specified.
+#
+# Since: 7.0.0
+##
+{ 'enum': 'FirmwareFlashMode',
+  'data': [ 'split', 'combined', 'stateless' ] }
+
 ##
 # @FirmwareMappingFlash:
 #
 # Describes loading and mapping properties for the firmware executable
 # and its accompanying NVRAM file, when @FirmwareDevice is @flash.
 #
-# @executable: Identifies the firmware executable. The firmware
-#              executable may be shared by multiple virtual machine
-#              definitions. The preferred corresponding QEMU command
-#              line options are
+# @mode: describes how the firmware build handles code versus variable
+#        storage. If not present, it must be treated as if it was
+#        configured with value ``split``. Since: 7.0.0
+#
+# @executable: Identifies the firmware executable. The @mode
+#              indicates whether there will be an associated
+#              NVRAM template present. The preferred
+#              corresponding QEMU command line options are
 #                  -drive if=none,id=pflash0,readonly=on,file=@executable.@filename,format=@executable.@format
 #                  -machine pflash0=pflash0
-#              or equivalent -blockdev instead of -drive.
+#              or equivalent -blockdev instead of -drive. When
+#              @mode is ``combined`` the executable must be
+#              cloned before use and configured with readonly=off.
 #              With QEMU versions older than 4.0, you have to use
 #                  -drive if=pflash,unit=0,readonly=on,file=@executable.@filename,format=@executable.@format
 #
 # @nvram-template: Identifies the NVRAM template compatible with
-#                  @executable. Management software instantiates an
+#                  @executable, when @mode is set to ``split``,
+#                  otherwise it should not be present.
+#                  Management software instantiates an
 #                  individual copy -- a specific NVRAM file -- from
 #                  @nvram-template.@filename for each new virtual
 #                  machine definition created. @nvram-template.@filename
@@ -246,8 +283,9 @@
 # Since: 3.0
 ##
 { 'struct' : 'FirmwareMappingFlash',
-  'data'   : { 'executable'     : 'FirmwareFlashFile',
-               'nvram-template' : 'FirmwareFlashFile' } }
+  'data'   : { 'mode': 'FirmwareFlashMode',
+               'executable'     : 'FirmwareFlashFile',
+               '*nvram-template' : 'FirmwareFlashFile' } }
 
 ##
 # @FirmwareMappingKernel:
-- 
2.33.1

+Gerd & David.

On 21/1/22 16:34, Daniel P. Berrangé wrote:
> The current firmware descriptor schema for flash requires that both the
> executable to NVRAM template paths be provided. This is fine for the
> most common usage of EDK2 builds in virtualization where the separate
> _CODE and _VARS files are provided.
> 
> With confidential computing technology like AMD SEV, persistent storage
> of variables may be completely disabled because the firmware requires a
> known clean state on every cold boot. There is no way to express this
> in the firmware descriptor today.
> 
> Even with regular EDK2 builds it is possible to create a firmware that
> has both executable code and variable persistence in a single file. This
> hasn't been commonly used, since it would mean every guest bootup would
> need to clone the full firmware file, leading to redundant duplicate
> storage of the code portion. In some scenarios this may not matter and
> might even be beneficial. For example if a public cloud allows users to
> bring their own firmware, such that the user can pre-enroll their own
> secure boot keys, you're going to have this copied on disk for each
> tenant already. At this point the it can be simpler to just deal with
> a single file rather than split builds. The firmware descriptor ought
> to be able to express this combined firmware model too.
> 
> This all points towards expanding the schema for flash with a 'mode'
> concept

":"?

> 
>   - "split" - the current implicit behaviour with separate files
>     for code and variables.
> 
>   - "combined" - the alternate behaviour where a single file contains
>     both code and variables.
> 
>   - "stateless" - the confidential computing use case where storage
>     of variables is completely disable, leaving only the code.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>   docs/interop/firmware.json | 54 ++++++++++++++++++++++++++++++++------
>   1 file changed, 46 insertions(+), 8 deletions(-)
> 
> diff --git a/docs/interop/firmware.json b/docs/interop/firmware.json
> index 8d8b0be030..884e99864b 100644
> --- a/docs/interop/firmware.json
> +++ b/docs/interop/firmware.json
> @@ -210,24 +210,61 @@
>     'data'   : { 'filename' : 'str',
>                  'format'   : 'BlockdevDriver' } }
>   
> +
> +##
> +# @FirmwareFlashType:
> +#
> +# Describes how the firmware build handles code versus variable
> +# persistence.
> +#
> +# @split: the executable file contains code while the nvram
> +#         template provides variable storage. The executable
> +#         must be configured read-only and can be shared between
> +#         multiple guests. The nvram template must be cloned
> +#         for each new guest and configured read-write.
> +#
> +# @combined: the executable file contains both code and
> +#            variable storage. The executable must be cloned
> +#            for each new guest and configured read-write.
> +#            No nvram template will be specified.
> +#
> +# @stateless: the executable file contains code and variable
> +#             storage is not persisted. The executed must
> +#             be configured read-only and can be shared
> +#             between multiple guests. No nvram template
> +#             willbe specified.

"NVRAM"? (multiple times), "will be"

> +#
> +# Since: 7.0.0
> +##
> +{ 'enum': 'FirmwareFlashMode',
> +  'data': [ 'split', 'combined', 'stateless' ] }
> +
>   ##
>   # @FirmwareMappingFlash:
>   #
>   # Describes loading and mapping properties for the firmware executable
>   # and its accompanying NVRAM file, when @FirmwareDevice is @flash.
>   #
> -# @executable: Identifies the firmware executable. The firmware
> -#              executable may be shared by multiple virtual machine
> -#              definitions. The preferred corresponding QEMU command
> -#              line options are
> +# @mode: describes how the firmware build handles code versus variable
> +#        storage. If not present, it must be treated as if it was
> +#        configured with value ``split``. Since: 7.0.0
> +#
> +# @executable: Identifies the firmware executable. The @mode
> +#              indicates whether there will be an associated
> +#              NVRAM template present. The preferred
> +#              corresponding QEMU command line options are
>   #                  -drive if=none,id=pflash0,readonly=on,file=@executable.@filename,format=@executable.@format
>   #                  -machine pflash0=pflash0
> -#              or equivalent -blockdev instead of -drive.
> +#              or equivalent -blockdev instead of -drive. When
> +#              @mode is ``combined`` the executable must be
> +#              cloned before use and configured with readonly=off.
>   #              With QEMU versions older than 4.0, you have to use
>   #                  -drive if=pflash,unit=0,readonly=on,file=@executable.@filename,format=@executable.@format
>   #
>   # @nvram-template: Identifies the NVRAM template compatible with
> -#                  @executable. Management software instantiates an
> +#                  @executable, when @mode is set to ``split``,
> +#                  otherwise it should not be present.
> +#                  Management software instantiates an
>   #                  individual copy -- a specific NVRAM file -- from
>   #                  @nvram-template.@filename for each new virtual
>   #                  machine definition created. @nvram-template.@filename
> @@ -246,8 +283,9 @@
>   # Since: 3.0
>   ##
>   { 'struct' : 'FirmwareMappingFlash',
> -  'data'   : { 'executable'     : 'FirmwareFlashFile',
> -               'nvram-template' : 'FirmwareFlashFile' } }
> +  'data'   : { 'mode': 'FirmwareFlashMode',
> +               'executable'     : 'FirmwareFlashFile',
> +               '*nvram-template' : 'FirmwareFlashFile' } }
>   
>   ##
>   # @FirmwareMappingKernel:

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

  Hi,

> >   { 'struct' : 'FirmwareMappingFlash',
> > -  'data'   : { 'executable'     : 'FirmwareFlashFile',
> > -               'nvram-template' : 'FirmwareFlashFile' } }
> > +  'data'   : { 'mode': 'FirmwareFlashMode',
> > +               'executable'     : 'FirmwareFlashFile',
> > +               '*nvram-template' : 'FirmwareFlashFile' } }

I think for backward compatibility reasons we want 'mode' be optional,
with 'mode' = 'split' being assumed in case it is not present.

otherwise looks sane to me.

take care,
  Gerd